diff --git a/lib/config.py b/lib/config.py index 0c769d2bce7e9fefaac48778b900d665a90ed9b5..50fc784dc7f016b1692c9188fad86b58677e8892 100644 --- a/lib/config.py +++ b/lib/config.py @@ -133,7 +133,7 @@ class ConfigWriter: existing.update(exceptions) retries = 64 while retries > 0: - unique_id = utils.GetUUID() + unique_id = utils.NewUUID() if unique_id not in existing and unique_id is not None: break else: diff --git a/lib/utils.py b/lib/utils.py index d5d604b2f7d64506b4fdd9001e083e392690ea1d..f22537917efa99dcfaff498e4b719e0c1cf1efc7 100644 --- a/lib/utils.py +++ b/lib/utils.py @@ -847,7 +847,7 @@ def GetHomeDir(user, default=None): return result.pw_dir -def GetUUID(): +def NewUUID(): """Returns a random UUID. """ diff --git a/qa/qa_cluster.py b/qa/qa_cluster.py index 2995885dce47e8538be5c777e6a40b3ea7bc6234..8b3d3eb29c125dd3a888dfed3fb434c4d766cd9e 100644 --- a/qa/qa_cluster.py +++ b/qa/qa_cluster.py @@ -164,7 +164,7 @@ def TestClusterCopyfile(): """gnt-cluster copyfile""" master = qa_config.GetMasterNode() - uniqueid = utils.GetUUID() + uniqueid = utils.NewUUID() # Create temporary file f = tempfile.NamedTemporaryFile() @@ -188,8 +188,8 @@ def TestClusterCommand(): """gnt-cluster command""" master = qa_config.GetMasterNode() - uniqueid = utils.GetUUID() - rfile = "/tmp/gnt%s" % utils.GetUUID() + uniqueid = utils.NewUUID() + rfile = "/tmp/gnt%s" % utils.NewUUID() rcmd = utils.ShellQuoteArgs(['echo', '-n', uniqueid]) cmd = utils.ShellQuoteArgs(['gnt-cluster', 'command', "%s >%s" % (rcmd, rfile)]) diff --git a/test/ganeti.utils_unittest.py b/test/ganeti.utils_unittest.py index 4de493a32a0a183259b0d7422e1a1ced230c3d99..22c0cc40b9a2483425883ba6201683a95b035131 100755 --- a/test/ganeti.utils_unittest.py +++ b/test/ganeti.utils_unittest.py @@ -541,14 +541,14 @@ class TestListVisibleFiles(unittest.TestCase): self._test(files, expected) -class TestGetUUID(unittest.TestCase): - """Test case for GetUUID""" +class TestNewUUID(unittest.TestCase): + """Test case for NewUUID""" _re_uuid = re.compile('^[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-' '[a-f0-9]{4}-[a-f0-9]{12}$') def runTest(self): - self.failUnless(self._re_uuid.match(utils.GetUUID())) + self.failUnless(self._re_uuid.match(utils.NewUUID())) if __name__ == '__main__':