From 10cd4a294eef4fae49d8321465261629a20650e2 Mon Sep 17 00:00:00 2001
From: Guido Trotter <ultrotter@google.com>
Date: Wed, 30 Apr 2008 09:29:30 +0000
Subject: [PATCH] Remove NoHooksLU.BuildHooksEnv
Since NoHooksLU defines HPATH as None, BuildHooksEnv will never be called (as
the LogicalUnit.BuildHooksEnv docstring correctly states). Removing the
function altogether, to avoid having dead code lying around, and to make sure
the non-implemented one in LogicalUnit will be called if someone mistakenly
tries to call it, so it's immediately clear that something is wrong.
Reviewed-by: iustinp
---
lib/cmdlib.py | 8 --------
1 file changed, 8 deletions(-)
diff --git a/lib/cmdlib.py b/lib/cmdlib.py
index 760f7d70d..1b569857a 100644
--- a/lib/cmdlib.py
+++ b/lib/cmdlib.py
@@ -164,14 +164,6 @@ class NoHooksLU(LogicalUnit):
HPATH = None
HTYPE = None
- def BuildHooksEnv(self):
- """Build hooks env.
-
- This is a no-op, since we don't run hooks.
-
- """
- return {}, [], []
-
def _AddHostToEtcHosts(hostname):
"""Wrapper around utils.SetEtcHostsEntry.
--
GitLab