From 0b1c7a55e1415cb93a8a6ba452a67e7283929cdc Mon Sep 17 00:00:00 2001 From: Iustin Pop <iustin@google.com> Date: Thu, 21 Feb 2013 17:41:34 +0100 Subject: [PATCH] Fix exports query with failed RPCs When the RPC to a node has failed (for whatever reason), we currently return _FS_UNAVAIL, which means "this node doesn't support exports". However, that is misleading: all nodes support exports, but we failed to list them at the moment, so _FS_NODATA (temporary failure) is more appropriate here. Signed-off-by: Iustin Pop <iustin@google.com> Reviewed-by: Michael Hanselmann <hansmi@google.com> --- lib/query.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/query.py b/lib/query.py index a9e027456..37bf11438 100644 --- a/lib/query.py +++ b/lib/query.py @@ -1,7 +1,7 @@ # # -# Copyright (C) 2010, 2011, 2012 Google Inc. +# Copyright (C) 2010, 2011, 2012, 2013 Google Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -2428,7 +2428,7 @@ def _GetExportName(_, (node_name, expname)): # pylint: disable=W0613 """ if expname is None: - return _FS_UNAVAIL + return _FS_NODATA else: return expname -- GitLab