From 01b6558a8bf85c189b28050a2f3b1aaa579dc0db Mon Sep 17 00:00:00 2001
From: Iustin Pop <iustin@google.com>
Date: Mon, 15 Mar 2010 17:14:25 +0100
Subject: [PATCH] Clarify the error message for ':' in PV names
As described in issue 93, just saying ':' is not a valid char can be
confusing.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
---
lib/bdev.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/bdev.py b/lib/bdev.py
index bdfbec7aa..721f3a6ec 100644
--- a/lib/bdev.py
+++ b/lib/bdev.py
@@ -389,8 +389,9 @@ class LogicalVolume(BlockDev):
pvlist = [ pv[1] for pv in pvs_info ]
if utils.any(pvlist, lambda v: ":" in v):
- _ThrowError("Some of your PVs have invalid character ':'"
- " in their name")
+ _ThrowError("Some of your PVs have the invalid character ':' in their"
+ " name, this is not supported - please filter them out"
+ " in lvm.conf using either 'filter' or 'preferred_names'")
free_size = sum([ pv[0] for pv in pvs_info ])
current_pvs = len(pvlist)
stripes = min(current_pvs, constants.LVM_STRIPECOUNT)
--
GitLab