• Iustin Pop's avatar
    Fix bug introduced by f5677ab3 · ff6082e4
    Iustin Pop authored
    Commit f5677ab3
     added the _VerifyOob functionality, but there are two
    issues with this function:
    - a real bug, as objects.Node doesn't have a 'master' attribute
    - a design bug, as we need to verify the OOB programs not only on
      current masters, but on all nodes that can become masters via the
      auto-promote functionality; otherwise, an automated cluster operation
      could cause the cluster to become inconsistent (error in verify)
    The Node.master bug didn't appear in QA because it is triggered only
    with non-master-candidate nodes, and our QA doesn't test this
    combination (and neither other node flags combination).
    Signed-off-by: default avatarIustin Pop <iustin@google.com>
    Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
cmdlib.py 392 KB