• Guido Trotter's avatar
    ConfigWriter.AddInstance check instance mac · e4640214
    Guido Trotter authored
    There is a race condition in CreateInstance, since the mac address is
    generated early and only added to the config (and thus really assured to
    be unique) only at this point. Since it's possible that another instance
    gets the same mac address in the meantime with this check we'll make the
    instance creation fail before modifying the config data and thus having
    a wrong in-memory config (which is bad!!).
    Note that the same race condition exists, for example, in
    SetInstanceParams, and should be fully addressed by a way to revert
    config changes if writing them fails!
    Reviewed-by: iustin
config.py 40.1 KB