• Iustin Pop's avatar
    Fix a type issue and bad logic in cluster verification · e375fb61
    Iustin Pop authored
    Commit 2e04d454
    
     introduced the new offline state for the instance
    state, but being a big monolithic patch it sneaked in something that
    doesn't make sense.
    
    The checks for extra instances (either wrongly up or just unknown) are
    done purely on a name-basis, not on objects, so the types there are
    wrong. Furthermore, they have no relation to the admin state of the
    instance, so we just drop the entire if block. We keep the increment
    of the offline instance count, but move it to a different loop over
    instances.
    Signed-off-by: default avatarIustin Pop <iustin@google.com>
    Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
    e375fb61
cmdlib.py 543 KB