-
Niklas Hambuechen authored
The example filter did not actually do what was written in its description. For `reason` predicates, the spec says "This predicate is true, if one of the entries of one of the opcodes in this job satisfies the expression." The existing ["reason", ["!", ["=~", "reason", "maintenance pink bunny"]]] would therefore match on pretty much all jobs submitted, as even jobs with `--reason="maintenance pink bunny"` have other reason trail entries that are not "maintenance pink bunny", and one such entry suffices to satisfy the expression. Consequenlty, the given example would in practice pause all new jobs. The correct way to do this is a filter chain: prio 0 ["reason", ["=~", "reason", "maintenance pink bunny"]] PASS prio 1 ["jobid", [">", "id", "watermark"]] PAUSE Signed-off-by: Niklas Hambuechen <niklash@google.com> Signed-off-by: Klaus Aehlig <aehlig@google.com> Reviewed-by: Klaus Aehlig <aehlig@google.com>
06710954