Skip to content
  • Iustin Pop's avatar
    Treat virtual LVs as inexistent · 33f2a81a
    Iustin Pop authored
    
    
    Currently, “gnt-cluster verify” and “gnt-cluster verify-disks” use the
    list of LVs as returned by backend.GetVolumeList to determine whether an
    LV exists or not. However, LVs can also be ‘virtual’, which is handled
    correctly (i.e. as missing) by the bdev code, but not by this function.
    
    This patch changed GetVolumeList to simply skip virtual LVs; this makes
    cluster verify and verify-disks report these correctly as missing. The
    only downside is that an user could get confused (lvs reports the volume
    as existing, but ganeti as missing). However, this is better than simply
    considering virtual LVs as “good”.
    
    No other code beside these two gnt-cluster operations uses the
    GetVolumeList function, so we don't change the behaviour of the rest of
    the code (e.g. replace-disks, instance info, etc.).
    
    Signed-off-by: default avatarIustin Pop <iustin@google.com>
    Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
    33f2a81a