QC.hs 40.2 KB
Newer Older
1
2
{-# LANGUAGE TemplateHaskell #-}

3
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
4
5
6
7
8

-}

{-

9
Copyright (C) 2009, 2010, 2011 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

28
module Ganeti.HTools.QC
29
30
    ( testUtils
    , testPeerMap
31
32
33
34
    , testContainer
    , testInstance
    , testNode
    , testText
Iustin Pop's avatar
Iustin Pop committed
35
    , testOpCodes
36
    , testJobs
37
    , testCluster
Iustin Pop's avatar
Iustin Pop committed
38
    , testLoader
39
    , testTypes
40
    ) where
41
42

import Test.QuickCheck
Iustin Pop's avatar
Iustin Pop committed
43
import Data.List (findIndex, intercalate, nub, isPrefixOf)
44
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
45
46
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
47
import qualified Data.Map
48
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
49
import qualified Ganeti.OpCodes as OpCodes
50
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
51
import qualified Ganeti.Luxi
52
53
54
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
55
import qualified Ganeti.HTools.ExtLoader
56
57
58
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
59
import qualified Ganeti.HTools.Luxi
60
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
61
import qualified Ganeti.HTools.Group as Group
62
import qualified Ganeti.HTools.PeerMap as PeerMap
63
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
64
import qualified Ganeti.HTools.Simu
65
66
67
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
68
import qualified Ganeti.HTools.Version
69
import qualified Ganeti.Constants as C
70

71
72
73
74
75
import qualified Ganeti.HTools.Program.Hail
import qualified Ganeti.HTools.Program.Hbal
import qualified Ganeti.HTools.Program.Hscan
import qualified Ganeti.HTools.Program.Hspace

76
import Ganeti.HTools.QCHelper (testSuite)
Iustin Pop's avatar
Iustin Pop committed
77

78
79
-- * Constants

80
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
81
82
83
maxMem :: Int
maxMem = 1024 * 1024

84
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
85
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
86
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
87

88
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
89
90
91
maxCpu :: Int
maxCpu = 1024

Iustin Pop's avatar
Iustin Pop committed
92
93
94
95
96
97
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
               Group.create "default" Utils.defaultGroupID
                    Types.AllocPreferred

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
98
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
99
100
101
102

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

103
104
-- * Helper functions

105
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
106
107
108
109
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

Iustin Pop's avatar
Iustin Pop committed
110
111
112
113
114
115
116
-- | Checks for equality with proper annotation.
(==?) :: (Show a, Eq a) => a -> a -> Property
(==?) x y = printTestCase
            ("Expected equality, but '" ++
             show x ++ "' /= '" ++ show y ++ "'") (x == y)
infix 3 ==?

117
-- | Update an instance to be smaller than a node.
118
setInstanceSmallerThanNode node inst =
119
120
121
    inst { Instance.mem = Node.availMem node `div` 2
         , Instance.dsk = Node.availDisk node `div` 2
         , Instance.vcpus = Node.availCpu node `div` 2
122
123
         }

124
-- | Create an instance given its spec.
125
createInstance mem dsk vcpus =
126
    Instance.create "inst-unnamed" mem dsk vcpus Types.Running [] True (-1) (-1)
127
                    Types.DTDrbd8
128

129
-- | Create a small cluster by repeating a node spec.
130
131
132
133
134
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
    let fn = Node.buildPeers node Container.empty
        namelst = map (\n -> (Node.name n, n)) (replicate count fn)
        (_, nlst) = Loader.assignIndices namelst
135
    in nlst
136

137
-- | Checks if a node is "big" enough.
138
139
140
141
142
isNodeBig :: Node.Node -> Int -> Bool
isNodeBig node size = Node.availDisk node > size * Types.unitDsk
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

143
144
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
145

146
-- | Assigns a new fresh instance to a cluster; this is not
147
-- allocation, so no resource checks are done.
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
                then 0
                else fst (Container.findMax il) + 1
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

165
166
-- * Arbitrary instances

167
-- | Defines a DNS name.
168
newtype DNSChar = DNSChar { dnsGetChar::Char }
169

170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
instance Arbitrary DNSChar where
    arbitrary = do
      x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
      return (DNSChar x)

getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)


getFQDN :: Gen String
getFQDN = do
  felem <- getName
  ncomps <- choose (1, 4)
  frest <- vector ncomps::Gen [[DNSChar]]
  let frest' = map (map dnsGetChar) frest
  return (felem ++ "." ++ intercalate "." frest')

190
instance Arbitrary Types.InstanceStatus where
191
    arbitrary = elements [minBound..maxBound]
192

193
194
195
-- let's generate a random instance
instance Arbitrary Instance.Instance where
    arbitrary = do
196
      name <- getFQDN
Iustin Pop's avatar
Iustin Pop committed
197
198
      mem <- choose (0, maxMem)
      dsk <- choose (0, maxDsk)
199
      run_st <- arbitrary
200
201
      pn <- arbitrary
      sn <- arbitrary
Iustin Pop's avatar
Iustin Pop committed
202
      vcpus <- choose (0, maxCpu)
203
      return $ Instance.create name mem dsk vcpus run_st [] True pn sn
204
                               Types.DTDrbd8
205

206
207
208
209
210
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
          case min_multiplier of
            Just mm -> (mm * Types.unitMem,
                        mm * Types.unitDsk,
                        mm * Types.unitCpu)
            Nothing -> (0, 0, 0)
      (top_mem, top_dsk, top_cpu)  =
          case max_multiplier of
            Just mm -> (mm * Types.unitMem,
                        mm * Types.unitDsk,
                        mm * Types.unitCpu)
            Nothing -> (maxMem, maxDsk, maxCpu)
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
  return $ Node.buildPeers n Container.empty

236
237
-- and a random node
instance Arbitrary Node.Node where
238
    arbitrary = genNode Nothing Nothing
239

Iustin Pop's avatar
Iustin Pop committed
240
241
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
242
  arbitrary = elements [minBound..maxBound]
Iustin Pop's avatar
Iustin Pop committed
243
244
245
246
247
248
249
250
251
252
253
254

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
    (case op_id of
        "OP_TEST_DELAY" ->
          liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
        "OP_INSTANCE_REPLACE_DISKS" ->
255
          liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
Iustin Pop's avatar
Iustin Pop committed
256
257
          arbitrary arbitrary arbitrary
        "OP_INSTANCE_FAILOVER" ->
258
259
          liftM3 OpCodes.OpInstanceFailover arbitrary arbitrary
                 arbitrary
Iustin Pop's avatar
Iustin Pop committed
260
        "OP_INSTANCE_MIGRATE" ->
261
262
          liftM5 OpCodes.OpInstanceMigrate arbitrary arbitrary
                 arbitrary arbitrary
263
          arbitrary
Iustin Pop's avatar
Iustin Pop committed
264
265
        _ -> fail "Wrong opcode")

266
267
268
269
270
271
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

272
273
274
275
276
277
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
    arbitrary = do
      v <- choose (0, 1)
      return $ SmallRatio v

278
279
280
281
282
283
instance Arbitrary Types.AllocPolicy where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Types.DiskTemplate where
  arbitrary = elements [minBound..maxBound]

284
285
286
287
288
289
290
291
292
instance Arbitrary Types.FailMode where
    arbitrary = elements [minBound..maxBound]

instance Arbitrary a => Arbitrary (Types.OpResult a) where
    arbitrary = arbitrary >>= \c ->
                case c of
                  False -> liftM Types.OpFail arbitrary
                  True -> liftM Types.OpGood arbitrary

293
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
294

295
296
297
298
-- ** Utils tests

-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
299
300
301
prop_Utils_commaJoinSplit =
    forAll (arbitrary `suchThat`
            (\l -> l /= [""] && all (not . elem ',') l )) $ \lst ->
Iustin Pop's avatar
Iustin Pop committed
302
    Utils.sepSplit ',' (Utils.commaJoin lst) ==? lst
Iustin Pop's avatar
Iustin Pop committed
303

304
-- | Split and join should always be idempotent.
Iustin Pop's avatar
Iustin Pop committed
305
306
prop_Utils_commaSplitJoin s =
    Utils.commaJoin (Utils.sepSplit ',' s) ==? s
307

308
-- | fromObjWithDefault, we test using the Maybe monad and an integer
309
-- value.
310
311
312
313
314
315
prop_Utils_fromObjWithDefault def_value random_key =
    -- a missing key will be returned with the default
    Utils.fromObjWithDefault [] random_key def_value == Just def_value &&
    -- a found key will be returned as is, not with default
    Utils.fromObjWithDefault [(random_key, J.showJSON def_value)]
         random_key (def_value+1) == Just def_value
Iustin Pop's avatar
Iustin Pop committed
316
        where _types = def_value :: Integer
317

318
-- | Test that functional if' behaves like the syntactic sugar if.
Iustin Pop's avatar
Iustin Pop committed
319
320
321
prop_Utils_if'if :: Bool -> Int -> Int -> Gen Prop
prop_Utils_if'if cnd a b =
    Utils.if' cnd a b ==? if cnd then a else b
322

Guido Trotter's avatar
Guido Trotter committed
323
-- | Test basic select functionality
Iustin Pop's avatar
Iustin Pop committed
324
325
326
327
prop_Utils_select :: Int      -- ^ Default result
                  -> [Int]    -- ^ List of False values
                  -> [Int]    -- ^ List of True values
                  -> Gen Prop -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
328
prop_Utils_select def lst1 lst2 =
Iustin Pop's avatar
Iustin Pop committed
329
  Utils.select def cndlist ==? expectedresult
Guido Trotter's avatar
Guido Trotter committed
330
  where expectedresult = Utils.if' (null lst2) def (head lst2)
331
332
        flist = map (\e -> (False, e)) lst1
        tlist = map (\e -> (True, e)) lst2
Guido Trotter's avatar
Guido Trotter committed
333
334
335
        cndlist = flist ++ tlist

-- | Test basic select functionality with undefined default
Iustin Pop's avatar
Iustin Pop committed
336
prop_Utils_select_undefd :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
337
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
338
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
339
prop_Utils_select_undefd lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
340
  Utils.select undefined cndlist ==? head lst2
Guido Trotter's avatar
Guido Trotter committed
341
342
343
344
345
  where flist = map (\e -> (False, e)) lst1
        tlist = map (\e -> (True, e)) lst2
        cndlist = flist ++ tlist

-- | Test basic select functionality with undefined list values
Iustin Pop's avatar
Iustin Pop committed
346
prop_Utils_select_undefv :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
347
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
348
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
349
prop_Utils_select_undefv lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
350
  Utils.select undefined cndlist ==? head lst2
Guido Trotter's avatar
Guido Trotter committed
351
352
353
  where flist = map (\e -> (False, e)) lst1
        tlist = map (\e -> (True, e)) lst2
        cndlist = flist ++ tlist ++ [undefined]
354

Iustin Pop's avatar
Iustin Pop committed
355
356
357
358
359
360
361
362
363
364
365
prop_Utils_parseUnit (NonNegative n) =
    Utils.parseUnit (show n) == Types.Ok n &&
    Utils.parseUnit (show n ++ "m") == Types.Ok n &&
    (case Utils.parseUnit (show n ++ "M") of
      Types.Ok m -> if n > 0
                    then m < n  -- for positive values, X MB is less than X MiB
                    else m == 0 -- but for 0, 0 MB == 0 MiB
      Types.Bad _ -> False) &&
    Utils.parseUnit (show n ++ "g") == Types.Ok (n*1024) &&
    Utils.parseUnit (show n ++ "t") == Types.Ok (n*1048576) &&
    Types.isBad (Utils.parseUnit (show n ++ "x")::Types.Result Int)
Iustin Pop's avatar
Iustin Pop committed
366
    where _types = n::Int
Iustin Pop's avatar
Iustin Pop committed
367

368
-- | Test list for the Utils module.
369
370
371
372
373
374
375
376
377
378
testSuite "Utils"
              [ 'prop_Utils_commaJoinSplit
              , 'prop_Utils_commaSplitJoin
              , 'prop_Utils_fromObjWithDefault
              , 'prop_Utils_if'if
              , 'prop_Utils_select
              , 'prop_Utils_select_undefd
              , 'prop_Utils_select_undefv
              , 'prop_Utils_parseUnit
              ]
379

380
381
382
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
383
prop_PeerMap_addIdempotent pmap key em =
Iustin Pop's avatar
Iustin Pop committed
384
    fn puniq ==? fn (fn puniq)
385
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
386
387
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
388
          puniq = PeerMap.accumArray const pmap
389

390
-- | Make sure remove is idempotent.
391
prop_PeerMap_removeIdempotent pmap key =
Iustin Pop's avatar
Iustin Pop committed
392
    fn puniq ==? fn (fn puniq)
393
394
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
395
396
          puniq = PeerMap.accumArray const pmap

397
-- | Make sure a missing item returns 0.
398
prop_PeerMap_findMissing pmap key =
Iustin Pop's avatar
Iustin Pop committed
399
    PeerMap.find key (PeerMap.remove key puniq) ==? 0
400
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
401
402
          puniq = PeerMap.accumArray const pmap

403
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
404
prop_PeerMap_addFind pmap key em =
Iustin Pop's avatar
Iustin Pop committed
405
    PeerMap.find key (PeerMap.add key em puniq) ==? em
406
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
407
                    key::PeerMap.Key, em::PeerMap.Elem)
408
          puniq = PeerMap.accumArray const pmap
409

410
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
411
prop_PeerMap_maxElem pmap =
Iustin Pop's avatar
Iustin Pop committed
412
413
    PeerMap.maxElem puniq ==? if null puniq then 0
                              else (maximum . snd . unzip) puniq
414
    where _types = pmap::PeerMap.PeerMap
415
416
          puniq = PeerMap.accumArray const pmap

417
-- | List of tests for the PeerMap module.
418
419
420
421
422
423
424
testSuite "PeerMap"
              [ 'prop_PeerMap_addIdempotent
              , 'prop_PeerMap_removeIdempotent
              , 'prop_PeerMap_maxElem
              , 'prop_PeerMap_addFind
              , 'prop_PeerMap_findMissing
              ]
425

426
-- ** Container tests
427
428
429
430
431
432
433
434
435

prop_Container_addTwo cdata i1 i2 =
    fn i1 i2 cont == fn i2 i1 cont &&
       fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

436
437
438
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
Iustin Pop's avatar
Iustin Pop committed
439
  in Container.nameOf nl (Node.idx fnode) ==? Node.name fnode
440

441
-- | We test that in a cluster, given a random node, we can find it by
442
-- its name and alias, as long as all names and aliases are unique,
443
-- and that we fail to find a non-existing name.
444
445
446
447
448
449
450
451
452
453
454
455
456
prop_Container_findByName node othername =
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
  forAll (vector cnt) $ \ names ->
  (length . nub) (map fst names ++ map snd names) ==
  length names * 2 &&
  not (othername `elem` (map fst names ++ map snd names)) ==>
  let nl = makeSmallCluster node cnt
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
457
      nl' = Container.fromList nodes'
458
459
460
461
462
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
     Container.findByName nl' othername == Nothing

463
464
465
466
467
testSuite "Container"
              [ 'prop_Container_addTwo
              , 'prop_Container_nameOf
              , 'prop_Container_findByName
              ]
468

469
470
-- ** Instance tests

471
472
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
473
prop_Instance_creat inst =
Iustin Pop's avatar
Iustin Pop committed
474
    Instance.name inst ==? Instance.alias inst
Iustin Pop's avatar
Iustin Pop committed
475

476
prop_Instance_setIdx inst idx =
Iustin Pop's avatar
Iustin Pop committed
477
    Instance.idx (Instance.setIdx inst idx) ==? idx
478
479
480
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
481
482
483
484
485
486
487
488
    Instance.name newinst == name &&
    Instance.alias newinst == name
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
    Instance.name newinst == Instance.name inst &&
    Instance.alias newinst == name
489
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
490
          newinst = Instance.setAlias inst name
491
492

prop_Instance_setPri inst pdx =
Iustin Pop's avatar
Iustin Pop committed
493
    Instance.pNode (Instance.setPri inst pdx) ==? pdx
494
495
496
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
Iustin Pop's avatar
Iustin Pop committed
497
    Instance.sNode (Instance.setSec inst sdx) ==? sdx
498
499
500
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
501
    Instance.pNode si == pdx && Instance.sNode si == sdx
502
503
504
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
505
506
507
508
509
510
511
512
prop_Instance_shrinkMG inst =
    Instance.mem inst >= 2 * Types.unitMem ==>
        case Instance.shrinkByType inst Types.FailMem of
          Types.Ok inst' ->
              Instance.mem inst' == Instance.mem inst - Types.unitMem
          _ -> False

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
513
514
515
    forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
516
517
518
519
520
521
522
523
524

prop_Instance_shrinkCG inst =
    Instance.vcpus inst >= 2 * Types.unitCpu ==>
        case Instance.shrinkByType inst Types.FailCPU of
          Types.Ok inst' ->
              Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
          _ -> False

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
525
526
527
    forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
528
529
530
531
532
533
534
535
536

prop_Instance_shrinkDG inst =
    Instance.dsk inst >= 2 * Types.unitDsk ==>
        case Instance.shrinkByType inst Types.FailDisk of
          Types.Ok inst' ->
              Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
          _ -> False

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
537
538
539
    forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
540
541

prop_Instance_setMovable inst m =
Iustin Pop's avatar
Iustin Pop committed
542
    Instance.movable inst' ==? m
543
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
544

545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
testSuite "Instance"
              [ 'prop_Instance_creat
              , 'prop_Instance_setIdx
              , 'prop_Instance_setName
              , 'prop_Instance_setAlias
              , 'prop_Instance_setPri
              , 'prop_Instance_setSec
              , 'prop_Instance_setBoth
              , 'prop_Instance_shrinkMG
              , 'prop_Instance_shrinkMF
              , 'prop_Instance_shrinkCG
              , 'prop_Instance_shrinkCF
              , 'prop_Instance_shrinkDG
              , 'prop_Instance_shrinkDF
              , 'prop_Instance_setMovable
              ]
Iustin Pop's avatar
Iustin Pop committed
561

562
563
-- ** Text backend tests

Iustin Pop's avatar
Iustin Pop committed
564
565
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
566
567
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
568
                        (NonNegative pdx) (NonNegative sdx) autobal dt =
569
    pnode /= snode && pdx /= sdx ==>
Iustin Pop's avatar
Iustin Pop committed
570
571
572
    let vcpus_s = show vcpus
        dsk_s = show dsk
        mem_s = show mem
573
        status_s = Types.instanceStatusToRaw status
Iustin Pop's avatar
Iustin Pop committed
574
575
        ndx = if null snode
              then [(pnode, pdx)]
576
              else [(pnode, pdx), (snode, sdx)]
577
        nl = Data.Map.fromList ndx
578
        tags = ""
Iustin Pop's avatar
Iustin Pop committed
579
        sbal = if autobal then "Y" else "N"
580
        sdt = Types.diskTemplateToRaw dt
581
        inst = Text.loadInst nl
582
               [name, mem_s, dsk_s, vcpus_s, status_s,
583
                sbal, pnode, snode, sdt, tags]
584
        fail1 = Text.loadInst nl
585
               [name, mem_s, dsk_s, vcpus_s, status_s,
586
                sbal, pnode, pnode, tags]
Iustin Pop's avatar
Iustin Pop committed
587
        _types = ( name::String, mem::Int, dsk::Int
588
                 , vcpus::Int, status::Types.InstanceStatus
Iustin Pop's avatar
Iustin Pop committed
589
                 , snode::String
Iustin Pop's avatar
Iustin Pop committed
590
                 , autobal::Bool)
Iustin Pop's avatar
Iustin Pop committed
591
592
    in
      case inst of
593
594
        Types.Bad msg -> printTestCase ("Failed to load instance: " ++ msg)
                         False
Iustin Pop's avatar
Iustin Pop committed
595
596
        Types.Ok (_, i) -> printTestCase "Mismatch in some field while\
                                         \ loading the instance" $
Iustin Pop's avatar
Iustin Pop committed
597
598
599
600
601
602
            Instance.name i == name &&
            Instance.vcpus i == vcpus &&
            Instance.mem i == mem &&
            Instance.pNode i == pdx &&
            Instance.sNode i == (if null snode
                                 then Node.noSecondary
603
                                 else sdx) &&
604
            Instance.autoBalance i == autobal &&
605
            Types.isBad fail1
Iustin Pop's avatar
Iustin Pop committed
606
607

prop_Text_Load_InstanceFail ktn fields =
608
    length fields /= 10 ==>
Iustin Pop's avatar
Iustin Pop committed
609
    case Text.loadInst nl fields of
610
611
612
613
      Types.Ok _ -> printTestCase "Managed to load instance from invalid\
                                  \ data" False
      Types.Bad msg -> printTestCase ("Unrecognised error message: " ++ msg) $
                       "Invalid/incomplete instance data: '" `isPrefixOf` msg
614
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629

prop_Text_Load_Node name tm nm fm td fd tc fo =
    let conv v = if v < 0
                    then "?"
                    else show v
        tm_s = conv tm
        nm_s = conv nm
        fm_s = conv fm
        td_s = conv td
        fd_s = conv fd
        tc_s = conv tc
        fo_s = if fo
               then "Y"
               else "N"
        any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
Iustin Pop's avatar
Iustin Pop committed
630
631
632
        gid = Group.uuid defGroup
    in case Text.loadNode defGroupAssoc
           [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
Iustin Pop's avatar
Iustin Pop committed
633
634
635
636
         Nothing -> False
         Just (name', node) ->
             if fo || any_broken
             then Node.offline node
637
638
639
640
641
642
643
644
             else Node.name node == name' && name' == name &&
                  Node.alias node == name &&
                  Node.tMem node == fromIntegral tm &&
                  Node.nMem node == nm &&
                  Node.fMem node == fm &&
                  Node.tDsk node == fromIntegral td &&
                  Node.fDsk node == fd &&
                  Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
645
646

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
647
    length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
648

649
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
650
651
    (Text.loadNode defGroupAssoc.
         Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
652
653
654
655
    Just (Node.name n, n)
    -- override failN1 to what loadNode returns by default
    where n = node { Node.failN1 = True, Node.offline = False }

656
657
658
659
660
661
662
testSuite "Text"
              [ 'prop_Text_Load_Instance
              , 'prop_Text_Load_InstanceFail
              , 'prop_Text_Load_Node
              , 'prop_Text_Load_NodeFail
              , 'prop_Text_NodeLSIdempotent
              ]
663

664
-- ** Node tests
665

Iustin Pop's avatar
Iustin Pop committed
666
667
668
669
670
671
672
prop_Node_setAlias node name =
    Node.name newnode == Node.name node &&
    Node.alias newnode == name
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
Iustin Pop's avatar
Iustin Pop committed
673
    Node.offline newnode ==? status
Iustin Pop's avatar
Iustin Pop committed
674
675
676
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
Iustin Pop's avatar
Iustin Pop committed
677
    Node.xMem newnode ==? xm
Iustin Pop's avatar
Iustin Pop committed
678
679
680
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
Iustin Pop's avatar
Iustin Pop committed
681
    Node.mCpu newnode ==? mc
Iustin Pop's avatar
Iustin Pop committed
682
683
    where newnode = Node.setMcpu node mc

684
685
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
686
prop_Node_addPriFM node inst = Instance.mem inst >= Node.fMem node &&
687
688
                               not (Node.failN1 node) &&
                               not (Instance.instanceOffline inst)
Iustin Pop's avatar
Iustin Pop committed
689
690
691
692
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailMem -> True
                                 _ -> False
693
    where _types = (node::Node.Node, inst::Instance.Instance)
Iustin Pop's avatar
Iustin Pop committed
694
695
696
697
698
699
700
701
702
703
704
705
706
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst = Instance.dsk inst >= Node.fDsk node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailDisk -> True
                                 _ -> False
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

Iustin Pop's avatar
Iustin Pop committed
707
prop_Node_addPriFC node inst (Positive extra) =
708
709
    not (Node.failN1 node) &&
    not (Instance.instanceOffline inst) ==>
Iustin Pop's avatar
Iustin Pop committed
710
711
712
        case Node.addPri node inst'' of
          Types.OpFail Types.FailCPU -> True
          _ -> False
Iustin Pop's avatar
Iustin Pop committed
713
714
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
Iustin Pop's avatar
Iustin Pop committed
715
          inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
716

717
718
-- | Check that an instance add with too high memory or disk will be
-- rejected.
719
prop_Node_addSec node inst pdx =
720
721
    ((Instance.mem inst >= (Node.fMem node - Node.rMem node) &&
      not (Instance.instanceOffline inst)) ||
722
     Instance.dsk inst >= Node.fDsk node) &&
Iustin Pop's avatar
Iustin Pop committed
723
    not (Node.failN1 node)
Iustin Pop's avatar
Iustin Pop committed
724
    ==> isFailure (Node.addSec node inst pdx)
725
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
726

727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
-- | Check that an offline instance with reasonable disk size can always
-- be added.
prop_Node_addPriOffline node =
    forAll (arbitrary `suchThat`
            (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                      Instance.instanceOffline x)) $ \inst ->
    case Node.addPri node inst of
      Types.OpGood _ -> True
      _ -> False

prop_Node_addSecOffline node pdx =
    forAll (arbitrary `suchThat`
            (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                      Instance.instanceOffline x)) $ \inst ->
    case Node.addSec node inst pdx of
      Types.OpGood _ -> True
      _ -> False

745
-- | Checks for memory reservation changes.
746
prop_Node_rMem inst =
747
    not (Instance.instanceOffline inst) ==>
748
    forAll (arbitrary `suchThat` ((> Types.unitMem) . Node.fMem)) $ \node ->
749
750
    -- ab = auto_balance, nb = non-auto_balance
    -- we use -1 as the primary node of the instance
751
    let inst' = inst { Instance.pNode = -1, Instance.autoBalance = True }
752
        inst_ab = setInstanceSmallerThanNode node inst'
753
        inst_nb = inst_ab { Instance.autoBalance = False }
754
        -- now we have the two instances, identical except the
755
        -- autoBalance attribute
756
757
758
759
        orig_rmem = Node.rMem node
        inst_idx = Instance.idx inst_ab
        node_add_ab = Node.addSec node inst_ab (-1)
        node_add_nb = Node.addSec node inst_nb (-1)
Iustin Pop's avatar
Iustin Pop committed
760
761
        node_del_ab = liftM (`Node.removeSec` inst_ab) node_add_ab
        node_del_nb = liftM (`Node.removeSec` inst_nb) node_add_nb
762
763
764
    in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
         (Types.OpGood a_ab, Types.OpGood a_nb,
          Types.OpGood d_ab, Types.OpGood d_nb) ->
765
             printTestCase "Consistency checks failed" $
766
767
768
769
770
771
772
773
774
             Node.rMem a_ab >  orig_rmem &&
             Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
             Node.rMem a_nb == orig_rmem &&
             Node.rMem d_ab == orig_rmem &&
             Node.rMem d_nb == orig_rmem &&
             -- this is not related to rMem, but as good a place to
             -- test as any
             inst_idx `elem` Node.sList a_ab &&
             not (inst_idx `elem` Node.sList d_ab)
775
776
         x -> printTestCase ("Failed to add/remove instances: " ++ show x)
              False
777

778
-- | Check mdsk setting.
Iustin Pop's avatar
Iustin Pop committed
779
780
781
782
783
prop_Node_setMdsk node mx =
    Node.loDsk node' >= 0 &&
    fromIntegral (Node.loDsk node') <= Node.tDsk node &&
    Node.availDisk node' >= 0 &&
    Node.availDisk node' <= Node.fDsk node' &&
Iustin Pop's avatar
Iustin Pop committed
784
785
    fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
    Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
786
787
788
789
790
791
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
Iustin Pop's avatar
Iustin Pop committed
792
    Node.delTags (Node.addTags m tags) tags ==? m
793
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
794
795
796

prop_Node_tagMaps_reject tags =
    not (null tags) ==>
Iustin Pop's avatar
Iustin Pop committed
797
    all (\t -> Node.rejectAddTags m [t]) tags
798
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
799

Iustin Pop's avatar
Iustin Pop committed
800
801
802
803
804
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

805
806
807
808
809
810
prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
Iustin Pop's avatar
Iustin Pop committed
811
     (null nodes || not (null ng))
812

813
814
815
816
817
818
819
820
821
testSuite "Node"
              [ 'prop_Node_setAlias
              , 'prop_Node_setOffline
              , 'prop_Node_setMcpu
              , 'prop_Node_setXmem
              , 'prop_Node_addPriFM
              , 'prop_Node_addPriFD
              , 'prop_Node_addPriFC
              , 'prop_Node_addSec
822
823
              , 'prop_Node_addPriOffline
              , 'prop_Node_addSecOffline
824
825
826
827
828
829
830
              , 'prop_Node_rMem
              , 'prop_Node_setMdsk
              , 'prop_Node_tagMaps_idempotent
              , 'prop_Node_tagMaps_reject
              , 'prop_Node_showField
              , 'prop_Node_computeGroups
              ]
831

832
-- ** Cluster tests
833

834
835
-- | Check that the cluster score is close to zero for a homogeneous
-- cluster.
Iustin Pop's avatar
Iustin Pop committed
836
837
prop_Score_Zero node =
    forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
838
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
839
     (Node.tDsk node > 0) && (Node.tMem node > 0)) ==>
840
    let fn = Node.buildPeers node Container.empty
841
842
        nlst = replicate count fn
        score = Cluster.compCVNodes nlst
843
844
    -- we can't say == 0 here as the floating point errors accumulate;
    -- this should be much lower than the default score in CLI.hs
Iustin Pop's avatar
Iustin Pop committed
845
    in score <= 1e-12
846

847
-- | Check that cluster stats are sane.
Iustin Pop's avatar
Iustin Pop committed
848
849
850
prop_CStats_sane node =
    forAll (choose (1, 1024)) $ \count ->
    (not (Node.offline node) && not (Node.failN1 node) &&
851
     (Node.availDisk node > 0) && (Node.availMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
852
853
    let fn = Node.buildPeers node Container.empty
        nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
Iustin Pop's avatar
Iustin Pop committed
854
        nl = Container.fromList nlst
Iustin Pop's avatar
Iustin Pop committed
855
856
857
858
        cstats = Cluster.totalResources nl
    in Cluster.csAdsk cstats >= 0 &&
       Cluster.csAdsk cstats <= Cluster.csFdsk cstats

859
-- | Check that one instance is allocated correctly, without
860
-- rebalances needed.
861
862
863
864
865
866
867
868
869
870
prop_ClusterAlloc_sane node inst =
    forAll (choose (5, 20)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && Node.availDisk node > 0
            && Node.availMem node > 0
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
871
872
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
873
         Types.Bad _ -> False
874
         Types.Ok as ->
875
876
877
             case Cluster.asSolution as of
               Nothing -> False
               Just (xnl, xi, _, cv) ->
878
                   let il' = Container.add (Instance.idx xi) xi il
879
                       tbl = Cluster.Table xnl il' cv []
880
                   in not (canBalance tbl True True False)
881
882
883

-- | Checks that on a 2-5 node cluster, we can allocate a random
-- instance spec via tiered allocation (whatever the original instance
884
-- spec), on either one or two nodes.
885
886
887
888
889
890
891
892
893
prop_ClusterCanTieredAlloc node inst =
    forAll (choose (2, 5)) $ \count ->
    forAll (choose (1, 2)) $ \rqnodes ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
894
        allocnodes = Cluster.genAllocNodes defGroupList nl rqnodes True
Iustin Pop's avatar
Iustin Pop committed
895
    in case allocnodes >>= \allocnodes' ->
896
        Cluster.tieredAlloc nl il (Just 1) inst allocnodes' [] [] of
897
         Types.Bad _ -> False
898
899
900
         Types.Ok (_, _, il', ixes, cstats) -> not (null ixes) &&
                                      IntMap.size il' == length ixes &&
                                      length ixes == length cstats
901
902

-- | Checks that on a 4-8 node cluster, once we allocate an instance,
903
-- we can also evacuate it.
904
905
906
907
908
909
910
911
912
prop_ClusterAllocEvac node inst =
    forAll (choose (4, 8)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
913
914
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
915
         Types.Bad _ -> False
916
         Types.Ok as ->
917
918
919
             case Cluster.asSolution as of
               Nothing -> False
               Just (xnl, xi, _, _) ->
920
921
                   let sdx = Instance.sNode xi
                       il' = Container.add (Instance.idx xi) xi il
Iustin Pop's avatar
Iustin Pop committed
922
923
924
                   in case IAlloc.processRelocate defGroupList xnl il'
                          (Instance.idx xi) 1 [sdx] of
                        Types.Ok _ -> True
925
926
927
                        _ -> False

-- | Check that allocating multiple instances on a cluster, then
928
-- adding an empty node, results in a valid rebalance.
929
930
prop_ClusterAllocBalance =
    forAll (genNode (Just 5) (Just 128)) $ \node ->
931
    forAll (choose (3, 5)) $ \count ->
932
    not (Node.offline node) && not (Node.failN1 node) ==>
933
934
935
    let nl = makeSmallCluster node count
        (hnode, nl') = IntMap.deleteFindMax nl
        il = Container.empty
936
        allocnodes = Cluster.genAllocNodes defGroupList nl' 2 True
937
        i_templ = createInstance Types.unitMem Types.unitDsk Types.unitCpu
Iustin Pop's avatar
Iustin Pop committed
938
    in case allocnodes >>= \allocnodes' ->
939
        Cluster.iterateAlloc nl' il (Just 5) i_templ allocnodes' [] [] of
940
         Types.Bad _ -> False
941
         Types.Ok (_, xnl, il', _, _) ->
942
943
944
                   let ynl = Container.add (Node.idx hnode) hnode xnl
                       cv = Cluster.compCV ynl
                       tbl = Cluster.Table ynl il' cv []
945
                   in canBalance tbl True True False
946

947
-- | Checks consistency.
948
949
950
prop_ClusterCheckConsistency node inst =
  let nl = makeSmallCluster node 3
      [node1, node2, node3] = Container.elems nl
Iustin Pop's avatar
Iustin Pop committed
951
      node3' = node3 { Node.group = 1 }
952
953
954
955
      nl' = Container.add (Node.idx node3') node3' nl
      inst1 = Instance.setBoth inst (Node.idx node1) (Node.idx node2)
      inst2 = Instance.setBoth inst (Node.idx node1) Node.noSecondary
      inst3 = Instance.setBoth inst (Node.idx node1) (Node.idx node3)
Iustin Pop's avatar
Iustin Pop committed
956
      ccheck = Cluster.findSplitInstances nl' . Container.fromList
957
958
959
960
  in null (ccheck [(0, inst1)]) &&
     null (ccheck [(0, inst2)]) &&
     (not . null $ ccheck [(0, inst3)])

961
-- | For now, we only test that we don't lose instances during the split.
962
963
964
965
966
967
968
969
970
prop_ClusterSplitCluster node inst =
  forAll (choose (0, 100)) $ \icnt ->
  let nl = makeSmallCluster node 2
      (nl', il') = foldl (\(ns, is) _ -> assignInstance ns is inst 0 1)
                   (nl, Container.empty) [1..icnt]
      gni = Cluster.splitCluster nl' il'
  in sum (map (Container.size . snd . snd) gni) == icnt &&
     all (\(guuid, (nl'', _)) -> all ((== guuid) . Node.group)
                                 (Container.elems nl'')) gni
971

972
973
974
975
976
977
978
979