QC.hs 39.2 KB
Newer Older
1
2
{-# LANGUAGE TemplateHaskell #-}

3
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
4
5
6
7
8

-}

{-

9
Copyright (C) 2009, 2010, 2011 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

28
module Ganeti.HTools.QC
Iustin Pop's avatar
Iustin Pop committed
29
30
31
32
33
34
35
36
37
38
39
40
  ( testUtils
  , testPeerMap
  , testContainer
  , testInstance
  , testNode
  , testText
  , testOpCodes
  , testJobs
  , testCluster
  , testLoader
  , testTypes
  ) where
41
42

import Test.QuickCheck
Iustin Pop's avatar
Iustin Pop committed
43
import Data.List (findIndex, intercalate, nub, isPrefixOf)
44
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
45
46
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
47
import qualified Data.Map
48
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
49
import qualified Ganeti.OpCodes as OpCodes
50
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
51
import qualified Ganeti.Luxi
52
53
54
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
55
import qualified Ganeti.HTools.ExtLoader
56
57
58
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
59
import qualified Ganeti.HTools.Luxi
60
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
61
import qualified Ganeti.HTools.Group as Group
62
import qualified Ganeti.HTools.PeerMap as PeerMap
63
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
64
import qualified Ganeti.HTools.Simu
65
66
67
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
68
import qualified Ganeti.HTools.Version
69
import qualified Ganeti.Constants as C
70

71
72
73
74
75
import qualified Ganeti.HTools.Program.Hail
import qualified Ganeti.HTools.Program.Hbal
import qualified Ganeti.HTools.Program.Hscan
import qualified Ganeti.HTools.Program.Hspace

76
import Ganeti.HTools.QCHelper (testSuite)
Iustin Pop's avatar
Iustin Pop committed
77

78
79
-- * Constants

80
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
81
82
83
maxMem :: Int
maxMem = 1024 * 1024

84
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
85
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
86
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
87

88
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
89
90
91
maxCpu :: Int
maxCpu = 1024

Iustin Pop's avatar
Iustin Pop committed
92
93
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
Iustin Pop's avatar
Iustin Pop committed
94
             Group.create "default" Types.defaultGroupID Types.AllocPreferred
Iustin Pop's avatar
Iustin Pop committed
95
96

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
97
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
98
99
100
101

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

102
103
-- * Helper functions

104
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
105
106
107
108
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

Iustin Pop's avatar
Iustin Pop committed
109
110
111
112
113
114
115
-- | Checks for equality with proper annotation.
(==?) :: (Show a, Eq a) => a -> a -> Property
(==?) x y = printTestCase
            ("Expected equality, but '" ++
             show x ++ "' /= '" ++ show y ++ "'") (x == y)
infix 3 ==?

116
-- | Update an instance to be smaller than a node.
117
setInstanceSmallerThanNode node inst =
Iustin Pop's avatar
Iustin Pop committed
118
119
120
121
  inst { Instance.mem = Node.availMem node `div` 2
       , Instance.dsk = Node.availDisk node `div` 2
       , Instance.vcpus = Node.availCpu node `div` 2
       }
122

123
-- | Create an instance given its spec.
124
createInstance mem dsk vcpus =
Iustin Pop's avatar
Iustin Pop committed
125
126
  Instance.create "inst-unnamed" mem dsk vcpus Types.Running [] True (-1) (-1)
    Types.DTDrbd8
127

128
-- | Create a small cluster by repeating a node spec.
129
130
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
Iustin Pop's avatar
Iustin Pop committed
131
132
133
134
  let fn = Node.buildPeers node Container.empty
      namelst = map (\n -> (Node.name n, n)) (replicate count fn)
      (_, nlst) = Loader.assignIndices namelst
  in nlst
135

Iustin Pop's avatar
Iustin Pop committed
136
137
138
139
140
141
142
-- | Make a small cluster, both nodes and instances.
makeSmallEmptyCluster :: Node.Node -> Int -> Instance.Instance
                      -> (Node.List, Instance.List, Instance.Instance)
makeSmallEmptyCluster node count inst =
  (makeSmallCluster node count, Container.empty,
   setInstanceSmallerThanNode node inst)

143
-- | Checks if a node is "big" enough.
144
145
146
147
148
isNodeBig :: Node.Node -> Int -> Bool
isNodeBig node size = Node.availDisk node > size * Types.unitDsk
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

149
150
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
151

152
-- | Assigns a new fresh instance to a cluster; this is not
153
-- allocation, so no resource checks are done.
154
155
156
157
158
159
160
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
Iustin Pop's avatar
Iustin Pop committed
161
162
                  then 0
                  else fst (Container.findMax il) + 1
163
164
165
166
167
168
169
170
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

171
172
-- * Arbitrary instances

173
-- | Defines a DNS name.
174
newtype DNSChar = DNSChar { dnsGetChar::Char }
175

176
instance Arbitrary DNSChar where
Iustin Pop's avatar
Iustin Pop committed
177
178
179
  arbitrary = do
    x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
    return (DNSChar x)
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194

getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)

getFQDN :: Gen String
getFQDN = do
  felem <- getName
  ncomps <- choose (1, 4)
  frest <- vector ncomps::Gen [[DNSChar]]
  let frest' = map (map dnsGetChar) frest
  return (felem ++ "." ++ intercalate "." frest')

195
instance Arbitrary Types.InstanceStatus where
196
    arbitrary = elements [minBound..maxBound]
197

198
199
-- let's generate a random instance
instance Arbitrary Instance.Instance where
Iustin Pop's avatar
Iustin Pop committed
200
201
202
203
204
205
206
207
208
209
  arbitrary = do
    name <- getFQDN
    mem <- choose (0, maxMem)
    dsk <- choose (0, maxDsk)
    run_st <- arbitrary
    pn <- arbitrary
    sn <- arbitrary
    vcpus <- choose (0, maxCpu)
    return $ Instance.create name mem dsk vcpus run_st [] True pn sn
              Types.DTDrbd8
210

211
212
213
214
215
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
216
217
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
Iustin Pop's avatar
Iustin Pop committed
218
219
220
221
222
        case min_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (0, 0, 0)
223
      (top_mem, top_dsk, top_cpu)  =
Iustin Pop's avatar
Iustin Pop committed
224
225
226
227
228
        case max_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (maxMem, maxDsk, maxCpu)
229
230
231
232
233
234
235
236
237
238
239
240
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
  return $ Node.buildPeers n Container.empty

241
242
-- and a random node
instance Arbitrary Node.Node where
Iustin Pop's avatar
Iustin Pop committed
243
  arbitrary = genNode Nothing Nothing
244

Iustin Pop's avatar
Iustin Pop committed
245
246
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
247
  arbitrary = elements [minBound..maxBound]
Iustin Pop's avatar
Iustin Pop committed
248
249
250
251
252
253
254
255

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
Iustin Pop's avatar
Iustin Pop committed
256
257
258
259
260
261
262
263
264
265
266
267
268
    case op_id of
      "OP_TEST_DELAY" ->
        liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
      "OP_INSTANCE_REPLACE_DISKS" ->
        liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
          arbitrary arbitrary arbitrary
      "OP_INSTANCE_FAILOVER" ->
        liftM3 OpCodes.OpInstanceFailover arbitrary arbitrary
          arbitrary
      "OP_INSTANCE_MIGRATE" ->
        liftM5 OpCodes.OpInstanceMigrate arbitrary arbitrary
          arbitrary arbitrary arbitrary
      _ -> fail "Wrong opcode"
Iustin Pop's avatar
Iustin Pop committed
269

270
271
272
273
274
275
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

276
277
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
Iustin Pop's avatar
Iustin Pop committed
278
279
280
  arbitrary = do
    v <- choose (0, 1)
    return $ SmallRatio v
281

282
283
284
285
286
287
instance Arbitrary Types.AllocPolicy where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Types.DiskTemplate where
  arbitrary = elements [minBound..maxBound]

288
instance Arbitrary Types.FailMode where
Iustin Pop's avatar
Iustin Pop committed
289
  arbitrary = elements [minBound..maxBound]
290
291

instance Arbitrary a => Arbitrary (Types.OpResult a) where
Iustin Pop's avatar
Iustin Pop committed
292
  arbitrary = arbitrary >>= \c ->
Iustin Pop's avatar
Iustin Pop committed
293
294
295
              if c
                then liftM Types.OpGood arbitrary
                else liftM Types.OpFail arbitrary
296

297
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
298

299
300
301
302
-- ** Utils tests

-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
303
prop_Utils_commaJoinSplit =
Iustin Pop's avatar
Iustin Pop committed
304
  forAll (arbitrary `suchThat`
Iustin Pop's avatar
Iustin Pop committed
305
          (\l -> l /= [""] && all (notElem ',') l )) $ \lst ->
Iustin Pop's avatar
Iustin Pop committed
306
  Utils.sepSplit ',' (Utils.commaJoin lst) ==? lst
Iustin Pop's avatar
Iustin Pop committed
307

308
-- | Split and join should always be idempotent.
Iustin Pop's avatar
Iustin Pop committed
309
prop_Utils_commaSplitJoin s =
Iustin Pop's avatar
Iustin Pop committed
310
  Utils.commaJoin (Utils.sepSplit ',' s) ==? s
311

312
-- | fromObjWithDefault, we test using the Maybe monad and an integer
313
-- value.
314
prop_Utils_fromObjWithDefault def_value random_key =
Iustin Pop's avatar
Iustin Pop committed
315
316
317
318
319
320
  -- a missing key will be returned with the default
  Utils.fromObjWithDefault [] random_key def_value == Just def_value &&
  -- a found key will be returned as is, not with default
  Utils.fromObjWithDefault [(random_key, J.showJSON def_value)]
       random_key (def_value+1) == Just def_value
    where _types = def_value :: Integer
321

322
-- | Test that functional if' behaves like the syntactic sugar if.
Iustin Pop's avatar
Iustin Pop committed
323
324
prop_Utils_if'if :: Bool -> Int -> Int -> Gen Prop
prop_Utils_if'if cnd a b =
Iustin Pop's avatar
Iustin Pop committed
325
  Utils.if' cnd a b ==? if cnd then a else b
326

Guido Trotter's avatar
Guido Trotter committed
327
-- | Test basic select functionality
Iustin Pop's avatar
Iustin Pop committed
328
329
330
331
prop_Utils_select :: Int      -- ^ Default result
                  -> [Int]    -- ^ List of False values
                  -> [Int]    -- ^ List of True values
                  -> Gen Prop -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
332
prop_Utils_select def lst1 lst2 =
Iustin Pop's avatar
Iustin Pop committed
333
  Utils.select def (flist ++ tlist) ==? expectedresult
Iustin Pop's avatar
Iustin Pop committed
334
335
336
    where expectedresult = Utils.if' (null lst2) def (head lst2)
          flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
337
338

-- | Test basic select functionality with undefined default
Iustin Pop's avatar
Iustin Pop committed
339
prop_Utils_select_undefd :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
340
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
341
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
342
prop_Utils_select_undefd lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
343
  Utils.select undefined (flist ++ tlist) ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
344
345
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
346
347

-- | Test basic select functionality with undefined list values
Iustin Pop's avatar
Iustin Pop committed
348
prop_Utils_select_undefv :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
349
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
350
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
351
prop_Utils_select_undefv lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
352
  Utils.select undefined cndlist ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
353
354
355
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
          cndlist = flist ++ tlist ++ [undefined]
356

Iustin Pop's avatar
Iustin Pop committed
357
prop_Utils_parseUnit (NonNegative n) =
Iustin Pop's avatar
Iustin Pop committed
358
359
360
361
362
363
364
365
366
367
  Utils.parseUnit (show n) == Types.Ok n &&
  Utils.parseUnit (show n ++ "m") == Types.Ok n &&
  (case Utils.parseUnit (show n ++ "M") of
     Types.Ok m -> if n > 0
                     then m < n  -- for positive values, X MB is < than X MiB
                     else m == 0 -- but for 0, 0 MB == 0 MiB
     Types.Bad _ -> False) &&
  Utils.parseUnit (show n ++ "g") == Types.Ok (n*1024) &&
  Utils.parseUnit (show n ++ "t") == Types.Ok (n*1048576) &&
  Types.isBad (Utils.parseUnit (show n ++ "x")::Types.Result Int)
Iustin Pop's avatar
Iustin Pop committed
368
    where _types = n::Int
Iustin Pop's avatar
Iustin Pop committed
369

370
-- | Test list for the Utils module.
371
testSuite "Utils"
Iustin Pop's avatar
Iustin Pop committed
372
373
374
375
376
377
378
379
380
            [ 'prop_Utils_commaJoinSplit
            , 'prop_Utils_commaSplitJoin
            , 'prop_Utils_fromObjWithDefault
            , 'prop_Utils_if'if
            , 'prop_Utils_select
            , 'prop_Utils_select_undefd
            , 'prop_Utils_select_undefv
            , 'prop_Utils_parseUnit
            ]
381

382
383
384
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
385
prop_PeerMap_addIdempotent pmap key em =
Iustin Pop's avatar
Iustin Pop committed
386
  fn puniq ==? fn (fn puniq)
387
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
388
389
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
390
          puniq = PeerMap.accumArray const pmap
391

392
-- | Make sure remove is idempotent.
393
prop_PeerMap_removeIdempotent pmap key =
Iustin Pop's avatar
Iustin Pop committed
394
  fn puniq ==? fn (fn puniq)
395
396
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
397
398
          puniq = PeerMap.accumArray const pmap

399
-- | Make sure a missing item returns 0.
400
prop_PeerMap_findMissing pmap key =
Iustin Pop's avatar
Iustin Pop committed
401
  PeerMap.find key (PeerMap.remove key puniq) ==? 0
402
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
403
404
          puniq = PeerMap.accumArray const pmap

405
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
406
prop_PeerMap_addFind pmap key em =
Iustin Pop's avatar
Iustin Pop committed
407
  PeerMap.find key (PeerMap.add key em puniq) ==? em
408
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
409
                    key::PeerMap.Key, em::PeerMap.Elem)
410
          puniq = PeerMap.accumArray const pmap
411

412
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
413
prop_PeerMap_maxElem pmap =
Iustin Pop's avatar
Iustin Pop committed
414
  PeerMap.maxElem puniq ==? if null puniq then 0
Iustin Pop's avatar
Iustin Pop committed
415
                              else (maximum . snd . unzip) puniq
416
    where _types = pmap::PeerMap.PeerMap
417
418
          puniq = PeerMap.accumArray const pmap

419
-- | List of tests for the PeerMap module.
420
testSuite "PeerMap"
Iustin Pop's avatar
Iustin Pop committed
421
422
423
424
425
426
            [ 'prop_PeerMap_addIdempotent
            , 'prop_PeerMap_removeIdempotent
            , 'prop_PeerMap_maxElem
            , 'prop_PeerMap_addFind
            , 'prop_PeerMap_findMissing
            ]
427

428
-- ** Container tests
429

Iustin Pop's avatar
Iustin Pop committed
430
431
-- we silence the following due to hlint bug fixed in later versions
{-# ANN prop_Container_addTwo "HLint: ignore Avoid lambda" #-}
432
prop_Container_addTwo cdata i1 i2 =
Iustin Pop's avatar
Iustin Pop committed
433
434
  fn i1 i2 cont == fn i2 i1 cont &&
  fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
435
436
437
438
439
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

440
441
442
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
Iustin Pop's avatar
Iustin Pop committed
443
  in Container.nameOf nl (Node.idx fnode) ==? Node.name fnode
444

445
-- | We test that in a cluster, given a random node, we can find it by
446
-- its name and alias, as long as all names and aliases are unique,
447
-- and that we fail to find a non-existing name.
448
449
450
451
452
453
prop_Container_findByName node othername =
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
  forAll (vector cnt) $ \ names ->
  (length . nub) (map fst names ++ map snd names) ==
  length names * 2 &&
Iustin Pop's avatar
Iustin Pop committed
454
  othername `notElem` (map fst names ++ map snd names) ==>
455
456
457
458
459
460
  let nl = makeSmallCluster node cnt
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
461
      nl' = Container.fromList nodes'
462
463
464
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
Iustin Pop's avatar
Iustin Pop committed
465
     isNothing (Container.findByName nl' othername)
466

467
testSuite "Container"
Iustin Pop's avatar
Iustin Pop committed
468
469
470
471
            [ 'prop_Container_addTwo
            , 'prop_Container_nameOf
            , 'prop_Container_findByName
            ]
472

473
474
-- ** Instance tests

475
476
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
477
prop_Instance_creat inst =
Iustin Pop's avatar
Iustin Pop committed
478
  Instance.name inst ==? Instance.alias inst
Iustin Pop's avatar
Iustin Pop committed
479

480
prop_Instance_setIdx inst idx =
Iustin Pop's avatar
Iustin Pop committed
481
  Instance.idx (Instance.setIdx inst idx) ==? idx
482
483
484
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
485
486
  Instance.name newinst == name &&
  Instance.alias newinst == name
Iustin Pop's avatar
Iustin Pop committed
487
488
489
490
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
Iustin Pop's avatar
Iustin Pop committed
491
492
  Instance.name newinst == Instance.name inst &&
  Instance.alias newinst == name
493
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
494
          newinst = Instance.setAlias inst name
495
496

prop_Instance_setPri inst pdx =
Iustin Pop's avatar
Iustin Pop committed
497
  Instance.pNode (Instance.setPri inst pdx) ==? pdx
498
499
500
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
Iustin Pop's avatar
Iustin Pop committed
501
  Instance.sNode (Instance.setSec inst sdx) ==? sdx
502
503
504
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
Iustin Pop's avatar
Iustin Pop committed
505
  Instance.pNode si == pdx && Instance.sNode si == sdx
506
507
508
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
509
prop_Instance_shrinkMG inst =
Iustin Pop's avatar
Iustin Pop committed
510
511
512
513
  Instance.mem inst >= 2 * Types.unitMem ==>
    case Instance.shrinkByType inst Types.FailMem of
      Types.Ok inst' -> Instance.mem inst' == Instance.mem inst - Types.unitMem
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
514
515

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
516
  forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
Iustin Pop's avatar
Iustin Pop committed
517
518
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
519
520

prop_Instance_shrinkCG inst =
Iustin Pop's avatar
Iustin Pop committed
521
522
523
524
525
  Instance.vcpus inst >= 2 * Types.unitCpu ==>
    case Instance.shrinkByType inst Types.FailCPU of
      Types.Ok inst' ->
        Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
526
527

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
528
  forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
Iustin Pop's avatar
Iustin Pop committed
529
530
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
531
532

prop_Instance_shrinkDG inst =
Iustin Pop's avatar
Iustin Pop committed
533
534
535
536
537
  Instance.dsk inst >= 2 * Types.unitDsk ==>
    case Instance.shrinkByType inst Types.FailDisk of
      Types.Ok inst' ->
        Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
538
539

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
540
  forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
Iustin Pop's avatar
Iustin Pop committed
541
542
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
543
544

prop_Instance_setMovable inst m =
Iustin Pop's avatar
Iustin Pop committed
545
  Instance.movable inst' ==? m
546
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
547

548
testSuite "Instance"
Iustin Pop's avatar
Iustin Pop committed
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
            [ 'prop_Instance_creat
            , 'prop_Instance_setIdx
            , 'prop_Instance_setName
            , 'prop_Instance_setAlias
            , 'prop_Instance_setPri
            , 'prop_Instance_setSec
            , 'prop_Instance_setBoth
            , 'prop_Instance_shrinkMG
            , 'prop_Instance_shrinkMF
            , 'prop_Instance_shrinkCG
            , 'prop_Instance_shrinkCF
            , 'prop_Instance_shrinkDG
            , 'prop_Instance_shrinkDF
            , 'prop_Instance_setMovable
            ]
Iustin Pop's avatar
Iustin Pop committed
564

565
566
-- ** Text backend tests

Iustin Pop's avatar
Iustin Pop committed
567
568
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
569
570
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
571
                        (NonNegative pdx) (NonNegative sdx) autobal dt =
Iustin Pop's avatar
Iustin Pop committed
572
573
574
575
576
577
  pnode /= snode && pdx /= sdx ==>
  let vcpus_s = show vcpus
      dsk_s = show dsk
      mem_s = show mem
      status_s = Types.instanceStatusToRaw status
      ndx = if null snode
Iustin Pop's avatar
Iustin Pop committed
578
              then [(pnode, pdx)]
579
              else [(pnode, pdx), (snode, sdx)]
Iustin Pop's avatar
Iustin Pop committed
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
      nl = Data.Map.fromList ndx
      tags = ""
      sbal = if autobal then "Y" else "N"
      sdt = Types.diskTemplateToRaw dt
      inst = Text.loadInst nl
             [name, mem_s, dsk_s, vcpus_s, status_s,
              sbal, pnode, snode, sdt, tags]
      fail1 = Text.loadInst nl
              [name, mem_s, dsk_s, vcpus_s, status_s,
               sbal, pnode, pnode, tags]
      _types = ( name::String, mem::Int, dsk::Int
               , vcpus::Int, status::Types.InstanceStatus
               , snode::String
               , autobal::Bool)
  in case inst of
       Types.Bad msg -> printTestCase ("Failed to load instance: " ++ msg)
                        False
       Types.Ok (_, i) -> printTestCase "Mismatch in some field while\
                                        \ loading the instance" $
               Instance.name i == name &&
               Instance.vcpus i == vcpus &&
               Instance.mem i == mem &&
               Instance.pNode i == pdx &&
               Instance.sNode i == (if null snode
                                      then Node.noSecondary
                                      else sdx) &&
               Instance.autoBalance i == autobal &&
               Types.isBad fail1
Iustin Pop's avatar
Iustin Pop committed
608
609

prop_Text_Load_InstanceFail ktn fields =
Iustin Pop's avatar
Iustin Pop committed
610
  length fields /= 10 ==>
Iustin Pop's avatar
Iustin Pop committed
611
    case Text.loadInst nl fields of
612
613
614
615
      Types.Ok _ -> printTestCase "Managed to load instance from invalid\
                                  \ data" False
      Types.Bad msg -> printTestCase ("Unrecognised error message: " ++ msg) $
                       "Invalid/incomplete instance data: '" `isPrefixOf` msg
616
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
617
618

prop_Text_Load_Node name tm nm fm td fd tc fo =
Iustin Pop's avatar
Iustin Pop committed
619
620
621
622
623
624
625
626
627
628
  let conv v = if v < 0
                 then "?"
                 else show v
      tm_s = conv tm
      nm_s = conv nm
      fm_s = conv fm
      td_s = conv td
      fd_s = conv fd
      tc_s = conv tc
      fo_s = if fo
Iustin Pop's avatar
Iustin Pop committed
629
630
               then "Y"
               else "N"
Iustin Pop's avatar
Iustin Pop committed
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
      any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
      gid = Group.uuid defGroup
  in case Text.loadNode defGroupAssoc
       [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
       Nothing -> False
       Just (name', node) ->
         if fo || any_broken
           then Node.offline node
           else Node.name node == name' && name' == name &&
                Node.alias node == name &&
                Node.tMem node == fromIntegral tm &&
                Node.nMem node == nm &&
                Node.fMem node == fm &&
                Node.tDsk node == fromIntegral td &&
                Node.fDsk node == fd &&
                Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
647
648

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
649
  length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
650

651
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
652
653
654
  (Text.loadNode defGroupAssoc.
       Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
  Just (Node.name n, n)
655
656
657
    -- override failN1 to what loadNode returns by default
    where n = node { Node.failN1 = True, Node.offline = False }

658
testSuite "Text"
Iustin Pop's avatar
Iustin Pop committed
659
660
661
662
663
664
            [ 'prop_Text_Load_Instance
            , 'prop_Text_Load_InstanceFail
            , 'prop_Text_Load_Node
            , 'prop_Text_Load_NodeFail
            , 'prop_Text_NodeLSIdempotent
            ]
665

666
-- ** Node tests
667

Iustin Pop's avatar
Iustin Pop committed
668
prop_Node_setAlias node name =
Iustin Pop's avatar
Iustin Pop committed
669
670
  Node.name newnode == Node.name node &&
  Node.alias newnode == name
Iustin Pop's avatar
Iustin Pop committed
671
672
673
674
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
Iustin Pop's avatar
Iustin Pop committed
675
  Node.offline newnode ==? status
Iustin Pop's avatar
Iustin Pop committed
676
677
678
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
Iustin Pop's avatar
Iustin Pop committed
679
  Node.xMem newnode ==? xm
Iustin Pop's avatar
Iustin Pop committed
680
681
682
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
Iustin Pop's avatar
Iustin Pop committed
683
  Node.mCpu newnode ==? mc
Iustin Pop's avatar
Iustin Pop committed
684
685
    where newnode = Node.setMcpu node mc

686
687
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
prop_Node_addPriFM node inst =
  Instance.mem inst >= Node.fMem node && not (Node.failN1 node) &&
  not (Instance.instanceOffline inst) ==>
  case Node.addPri node inst'' of
    Types.OpFail Types.FailMem -> True
    _ -> False
  where _types = (node::Node.Node, inst::Instance.Instance)
        inst' = setInstanceSmallerThanNode node inst
        inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst =
  Instance.dsk inst >= Node.fDsk node && not (Node.failN1 node) ==>
    case Node.addPri node inst'' of
      Types.OpFail Types.FailDisk -> True
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
703
704
705
706
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

Iustin Pop's avatar
Iustin Pop committed
707
prop_Node_addPriFC node inst (Positive extra) =
Iustin Pop's avatar
Iustin Pop committed
708
709
710
711
  not (Node.failN1 node) && not (Instance.instanceOffline inst) ==>
      case Node.addPri node inst'' of
        Types.OpFail Types.FailCPU -> True
        _ -> False
Iustin Pop's avatar
Iustin Pop committed
712
713
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
Iustin Pop's avatar
Iustin Pop committed
714
          inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
715

716
717
-- | Check that an instance add with too high memory or disk will be
-- rejected.
718
prop_Node_addSec node inst pdx =
Iustin Pop's avatar
Iustin Pop committed
719
720
721
722
723
  ((Instance.mem inst >= (Node.fMem node - Node.rMem node) &&
    not (Instance.instanceOffline inst)) ||
   Instance.dsk inst >= Node.fDsk node) &&
  not (Node.failN1 node) ==>
      isFailure (Node.addSec node inst pdx)
724
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
725

726
727
-- | Check that an offline instance with reasonable disk size can always
-- be added.
728
729
prop_Node_addPriOffline =
  forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
730
731
732
733
734
735
  forAll (arbitrary `suchThat`
          (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                   Instance.instanceOffline x)) $ \inst ->
  case Node.addPri node inst of
    Types.OpGood _ -> True
    _ -> False
736

737
738
prop_Node_addSecOffline pdx =
  forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
739
740
741
742
743
744
  forAll (arbitrary `suchThat`
          (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                   Instance.instanceOffline x)) $ \inst ->
  case Node.addSec node inst pdx of
    Types.OpGood _ -> True
    _ -> False
745

746
-- | Checks for memory reservation changes.
747
prop_Node_rMem inst =
Iustin Pop's avatar
Iustin Pop committed
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
  not (Instance.instanceOffline inst) ==>
  forAll (arbitrary `suchThat` ((> Types.unitMem) . Node.fMem)) $ \node ->
  -- ab = auto_balance, nb = non-auto_balance
  -- we use -1 as the primary node of the instance
  let inst' = inst { Instance.pNode = -1, Instance.autoBalance = True }
      inst_ab = setInstanceSmallerThanNode node inst'
      inst_nb = inst_ab { Instance.autoBalance = False }
      -- now we have the two instances, identical except the
      -- autoBalance attribute
      orig_rmem = Node.rMem node
      inst_idx = Instance.idx inst_ab
      node_add_ab = Node.addSec node inst_ab (-1)
      node_add_nb = Node.addSec node inst_nb (-1)
      node_del_ab = liftM (`Node.removeSec` inst_ab) node_add_ab
      node_del_nb = liftM (`Node.removeSec` inst_nb) node_add_nb
  in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
       (Types.OpGood a_ab, Types.OpGood a_nb,
        Types.OpGood d_ab, Types.OpGood d_nb) ->
         printTestCase "Consistency checks failed" $
           Node.rMem a_ab >  orig_rmem &&
           Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
           Node.rMem a_nb == orig_rmem &&
           Node.rMem d_ab == orig_rmem &&
           Node.rMem d_nb == orig_rmem &&
           -- this is not related to rMem, but as good a place to
           -- test as any
           inst_idx `elem` Node.sList a_ab &&
Iustin Pop's avatar
Iustin Pop committed
775
           inst_idx `notElem` Node.sList d_ab
Iustin Pop's avatar
Iustin Pop committed
776
       x -> printTestCase ("Failed to add/remove instances: " ++ show x) False
777

778
-- | Check mdsk setting.
Iustin Pop's avatar
Iustin Pop committed
779
prop_Node_setMdsk node mx =
Iustin Pop's avatar
Iustin Pop committed
780
781
782
783
784
785
  Node.loDsk node' >= 0 &&
  fromIntegral (Node.loDsk node') <= Node.tDsk node &&
  Node.availDisk node' >= 0 &&
  Node.availDisk node' <= Node.fDsk node' &&
  fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
  Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
786
787
788
789
790
791
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
Iustin Pop's avatar
Iustin Pop committed
792
  Node.delTags (Node.addTags m tags) tags ==? m
793
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
794
795

prop_Node_tagMaps_reject tags =
Iustin Pop's avatar
Iustin Pop committed
796
797
  not (null tags) ==>
  all (\t -> Node.rejectAddTags m [t]) tags
798
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
799

Iustin Pop's avatar
Iustin Pop committed
800
801
802
803
804
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

805
806
807
808
809
810
prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
Iustin Pop's avatar
Iustin Pop committed
811
     (null nodes || not (null ng))
812

813
testSuite "Node"
Iustin Pop's avatar
Iustin Pop committed
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
            [ 'prop_Node_setAlias
            , 'prop_Node_setOffline
            , 'prop_Node_setMcpu
            , 'prop_Node_setXmem
            , 'prop_Node_addPriFM
            , 'prop_Node_addPriFD
            , 'prop_Node_addPriFC
            , 'prop_Node_addSec
            , 'prop_Node_addPriOffline
            , 'prop_Node_addSecOffline
            , 'prop_Node_rMem
            , 'prop_Node_setMdsk
            , 'prop_Node_tagMaps_idempotent
            , 'prop_Node_tagMaps_reject
            , 'prop_Node_showField
            , 'prop_Node_computeGroups
            ]
831

832
-- ** Cluster tests
833

834
835
-- | Check that the cluster score is close to zero for a homogeneous
-- cluster.
Iustin Pop's avatar
Iustin Pop committed
836
prop_Score_Zero node =
Iustin Pop's avatar
Iustin Pop committed
837
  forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
838
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
839
     (Node.tDsk node > 0) && (Node.tMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
840
841
842
843
844
845
  let fn = Node.buildPeers node Container.empty
      nlst = replicate count fn
      score = Cluster.compCVNodes nlst
  -- we can't say == 0 here as the floating point errors accumulate;
  -- this should be much lower than the default score in CLI.hs
  in score <= 1e-12
846

847
-- | Check that cluster stats are sane.
Iustin Pop's avatar
Iustin Pop committed
848
prop_CStats_sane node =
Iustin Pop's avatar
Iustin Pop committed
849
  forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
850
    (not (Node.offline node) && not (Node.failN1 node) &&
851
     (Node.availDisk node > 0) && (Node.availMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
852
853
854
855
856
857
  let fn = Node.buildPeers node Container.empty
      nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
      nl = Container.fromList nlst
      cstats = Cluster.totalResources nl
  in Cluster.csAdsk cstats >= 0 &&
     Cluster.csAdsk cstats <= Cluster.csFdsk cstats
Iustin Pop's avatar
Iustin Pop committed
858

859
-- | Check that one instance is allocated correctly, without
860
-- rebalances needed.
861
prop_ClusterAlloc_sane node inst =
Iustin Pop's avatar
Iustin Pop committed
862
863
864
865
866
867
  forAll (choose (5, 20)) $ \count ->
  not (Node.offline node)
        && not (Node.failN1 node)
        && Node.availDisk node > 0
        && Node.availMem node > 0
        ==>
Iustin Pop's avatar
Iustin Pop committed
868
  let (nl, il, inst') = makeSmallEmptyCluster node count inst
Iustin Pop's avatar
Iustin Pop committed
869
870
871
872
873
874
875
876
877
878
  in case Cluster.genAllocNodes defGroupList nl 2 True >>=
     Cluster.tryAlloc nl il inst' of
       Types.Bad _ -> False
       Types.Ok as ->
         case Cluster.asSolution as of
           Nothing -> False
           Just (xnl, xi, _, cv) ->
             let il' = Container.add (Instance.idx xi) xi il
                 tbl = Cluster.Table xnl il' cv []
             in not (canBalance tbl True True False)
879
880
881

-- | Checks that on a 2-5 node cluster, we can allocate a random
-- instance spec via tiered allocation (whatever the original instance
882
-- spec), on either one or two nodes.
883
prop_ClusterCanTieredAlloc node inst =
Iustin Pop's avatar
Iustin Pop committed
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
  forAll (choose (2, 5)) $ \count ->
  forAll (choose (1, 2)) $ \rqnodes ->
  not (Node.offline node)
        && not (Node.failN1 node)
        && isNodeBig node 4
        ==>
  let nl = makeSmallCluster node count
      il = Container.empty
      allocnodes = Cluster.genAllocNodes defGroupList nl rqnodes True
  in case allocnodes >>= \allocnodes' ->
    Cluster.tieredAlloc nl il (Just 1) inst allocnodes' [] [] of
       Types.Bad _ -> False
       Types.Ok (_, _, il', ixes, cstats) -> not (null ixes) &&
                                             IntMap.size il' == length ixes &&
                                             length ixes == length cstats
899
900

-- | Checks that on a 4-8 node cluster, once we allocate an instance,
901
-- we can also evacuate it.
902
prop_ClusterAllocEvac node inst =
Iustin Pop's avatar
Iustin Pop committed
903
904
905
906
907
  forAll (choose (4, 8)) $ \count ->
  not (Node.offline node)
        && not (Node.failN1 node)
        && isNodeBig node 4
        ==>
Iustin Pop's avatar
Iustin Pop committed
908
  let (nl, il, inst') = makeSmallEmptyCluster node count inst
Iustin Pop's avatar
Iustin Pop committed
909
910
911
912
913
914
915
916
917
918
919
920
921
  in case Cluster.genAllocNodes defGroupList nl 2 True >>=
     Cluster.tryAlloc nl il inst' of
       Types.Bad _ -> False
       Types.Ok as ->
         case Cluster.asSolution as of
           Nothing -> False
           Just (xnl, xi, _, _) ->
             let sdx = Instance.sNode xi
                 il' = Container.add (Instance.idx xi) xi il
             in case IAlloc.processRelocate defGroupList xnl il'
                  (Instance.idx xi) 1 [sdx] of
                  Types.Ok _ -> True
                  _ -> False
922
923

-- | Check that allocating multiple instances on a cluster, then
924
-- adding an empty node, results in a valid rebalance.
925
prop_ClusterAllocBalance =
Iustin Pop's avatar
Iustin Pop committed
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
  forAll (genNode (Just 5) (Just 128)) $ \node ->
  forAll (choose (3, 5)) $ \count ->
  not (Node.offline node) && not (Node.failN1 node) ==>
  let nl = makeSmallCluster node count
      (hnode, nl') = IntMap.deleteFindMax nl
      il = Container.empty
      allocnodes = Cluster.genAllocNodes defGroupList nl' 2 True
      i_templ = createInstance Types.unitMem Types.unitDsk Types.unitCpu
  in case allocnodes >>= \allocnodes' ->
    Cluster.iterateAlloc nl' il (Just 5) i_templ allocnodes' [] [] of
       Types.Bad _ -> False
       Types.Ok (_, xnl, il', _, _) ->
         let ynl = Container.add (Node.idx hnode) hnode xnl
             cv = Cluster.compCV ynl
             tbl = Cluster.Table ynl il' cv []
         in canBalance tbl True True False
942

943
-- | Checks consistency.
944
945
946
prop_ClusterCheckConsistency node inst =
  let nl = makeSmallCluster node 3
      [node1, node2, node3] = Container.elems nl
Iustin Pop's avatar
Iustin Pop committed
947
      node3' = node3 { Node.group = 1 }
948
949
950
951
      nl' = Container.add (Node.idx node3') node3' nl
      inst1 = Instance.setBoth inst (Node.idx node1) (Node.idx node2)
      inst2 = Instance.setBoth inst (Node.idx node1) Node.noSecondary
      inst3 = Instance.setBoth inst (Node.idx node1) (Node.idx node3)
Iustin Pop's avatar
Iustin Pop committed
952
      ccheck = Cluster.findSplitInstances nl' . Container.fromList
953
954
955
956
  in null (ccheck [(0, inst1)]) &&
     null (ccheck [(0, inst2)]) &&
     (not . null $ ccheck [(0, inst3)])

957
-- | For now, we only test that we don't lose instances during the split.
958
959
960
961
962
963
964
965
966
prop_ClusterSplitCluster node inst =
  forAll (choose (0, 100)) $ \icnt ->
  let nl = makeSmallCluster node 2
      (nl', il') = foldl (\(ns, is) _ -> assignInstance ns is inst 0 1)
                   (nl, Container.empty) [1..icnt]
      gni = Cluster.splitCluster nl' il'
  in sum (map (Container.size . snd . snd) gni) == icnt &&
     all (\(guuid, (nl'', _)) -> all ((== guuid) . Node.group)
                                 (Container.elems nl'')) gni
967

968
testSuite "Cluster"
Iustin Pop's avatar
Iustin Pop committed
969
970
971
972
973
974
975
976
977
            [ 'prop_Score_Zero
            , 'prop_CStats_sane
            , 'prop_ClusterAlloc_sane
            , 'prop_ClusterCanTieredAlloc
            , 'prop_ClusterAllocEvac
            , 'prop_ClusterAllocBalance
            , 'prop_ClusterCheckConsistency
            , 'prop_ClusterSplitCluster
            ]
Iustin Pop's avatar
Iustin Pop committed
978

979
-- ** OpCodes tests
Iustin Pop's avatar
Iustin Pop committed
980

981
-- | Check that opcode serialization is idempotent.
Iustin Pop's avatar
Iustin Pop committed
982
983
prop_OpCodes_serialization op =
  case J.readJSON (J.showJSON op) of
Iustin Pop's avatar
Iustin Pop committed
984
985
    J.Error e -> printTestCase ("Cannot deserialise: " ++ e) False
    J.Ok op' -> op ==? op'
986
  where _types = op::OpCodes.OpCode
Iustin Pop's avatar
Iustin Pop committed
987

988
testSuite "OpCodes"
Iustin Pop's avatar
Iustin Pop committed
989
            [ 'prop_OpCodes_serialization ]
Iustin Pop's avatar
Iustin Pop committed
990

991
992
993
-- ** Jobs tests

-- | Check that (queued) job\/opcode status serialization is idempotent.
994
995
prop_OpStatus_serialization os =
  case J.readJSON (J.showJSON os) of
Iustin Pop's avatar
Iustin Pop committed
996
997
    J.Error e -> printTestCase ("Cannot deserialise: " ++ e) False
    J.Ok os' -> os ==? os'
998
999
1000
1001
  where _types = os::Jobs.OpStatus

prop_JobStatus_serialization js =
  case J.readJSON (J.showJSON js) of
Iustin Pop's avatar
Iustin Pop committed
1002
1003
    J.Error e -> printTestCase ("Cannot deserialise: " ++ e) False
    J.Ok js' -> js ==? js'
1004
1005
  where _types = js::Jobs.JobStatus

1006
testSuite "Jobs"
Iustin Pop's avatar
Iustin Pop committed
1007
1008
1009
            [ 'prop_OpStatus_serialization
            , 'prop_JobStatus_serialization
            ]
Iustin Pop's avatar