QC.hs 32.2 KB
Newer Older
1
{-| Unittests for ganeti-htools
Iustin Pop's avatar
Iustin Pop committed
2
3
4
5
6

-}

{-

7
Copyright (C) 2009, 2010, 2011 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

26
module Ganeti.HTools.QC
27
28
    ( testUtils
    , testPeerMap
29
30
31
32
    , testContainer
    , testInstance
    , testNode
    , testText
Iustin Pop's avatar
Iustin Pop committed
33
    , testOpCodes
34
    , testJobs
35
    , testCluster
Iustin Pop's avatar
Iustin Pop committed
36
    , testLoader
37
    ) where
38
39

import Test.QuickCheck
40
import Test.QuickCheck.Batch
Iustin Pop's avatar
Iustin Pop committed
41
import Data.List (findIndex, intercalate, nub, isPrefixOf)
42
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
43
44
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
45
import qualified Data.Map
46
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
47
import qualified Ganeti.OpCodes as OpCodes
48
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
49
import qualified Ganeti.Luxi
50
51
52
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
53
import qualified Ganeti.HTools.ExtLoader
54
55
56
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
57
import qualified Ganeti.HTools.Luxi
58
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
59
import qualified Ganeti.HTools.Group as Group
60
import qualified Ganeti.HTools.PeerMap as PeerMap
61
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
62
import qualified Ganeti.HTools.Simu
63
64
65
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
66
import qualified Ganeti.HTools.Version
67

68
69
-- * Constants

Iustin Pop's avatar
Iustin Pop committed
70
71
72
73
-- | Maximum memory (1TiB, somewhat random value)
maxMem :: Int
maxMem = 1024 * 1024

Iustin Pop's avatar
Iustin Pop committed
74
-- | Maximum disk (8TiB, somewhat random value)
Iustin Pop's avatar
Iustin Pop committed
75
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
76
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
77
78
79
80
81

-- | Max CPUs (1024, somewhat random value)
maxCpu :: Int
maxCpu = 1024

Iustin Pop's avatar
Iustin Pop committed
82
83
84
85
86
87
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
               Group.create "default" Utils.defaultGroupID
                    Types.AllocPreferred

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
88
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
89
90
91
92

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

93
94
-- * Helper functions

Iustin Pop's avatar
Iustin Pop committed
95
96
97
98
99
-- | Simple checker for whether OpResult is fail or pass
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

100
101
-- | Update an instance to be smaller than a node
setInstanceSmallerThanNode node inst =
102
103
104
    inst { Instance.mem = Node.availMem node `div` 2
         , Instance.dsk = Node.availDisk node `div` 2
         , Instance.vcpus = Node.availCpu node `div` 2
105
106
107
108
         }

-- | Create an instance given its spec
createInstance mem dsk vcpus =
109
    Instance.create "inst-unnamed" mem dsk vcpus "running" [] True (-1) (-1)
110
111
112
113
114
115
116

-- | Create a small cluster by repeating a node spec
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
    let fn = Node.buildPeers node Container.empty
        namelst = map (\n -> (Node.name n, n)) (replicate count fn)
        (_, nlst) = Loader.assignIndices namelst
117
    in nlst
118
119
120
121
122
123
124
125

-- | Checks if a node is "big" enough
isNodeBig :: Node.Node -> Int -> Bool
isNodeBig node size = Node.availDisk node > size * Types.unitDsk
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

canBalance :: Cluster.Table -> Bool -> Bool -> Bool
126
canBalance tbl dm evac = isJust $ Cluster.tryBalance tbl dm evac 0 0
127

128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
-- | Assigns a new fresh instance to a cluster; this is not
-- allocation, so no resource checks are done
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
                then 0
                else fst (Container.findMax il) + 1
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

147
148
-- * Arbitrary instances

149
150
-- copied from the introduction to quickcheck
instance Arbitrary Char where
151
    arbitrary = choose ('\32', '\128')
152

153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
newtype DNSChar = DNSChar { dnsGetChar::Char }
instance Arbitrary DNSChar where
    arbitrary = do
      x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
      return (DNSChar x)

getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)


getFQDN :: Gen String
getFQDN = do
  felem <- getName
  ncomps <- choose (1, 4)
  frest <- vector ncomps::Gen [[DNSChar]]
  let frest' = map (map dnsGetChar) frest
  return (felem ++ "." ++ intercalate "." frest')

174
175
176
-- let's generate a random instance
instance Arbitrary Instance.Instance where
    arbitrary = do
177
      name <- getFQDN
Iustin Pop's avatar
Iustin Pop committed
178
179
      mem <- choose (0, maxMem)
      dsk <- choose (0, maxDsk)
Iustin Pop's avatar
Iustin Pop committed
180
181
182
183
      run_st <- elements ["ERROR_up", "ERROR_down", "ADMIN_down"
                         , "ERROR_nodedown", "ERROR_nodeoffline"
                         , "running"
                         , "no_such_status1", "no_such_status2"]
184
185
      pn <- arbitrary
      sn <- arbitrary
Iustin Pop's avatar
Iustin Pop committed
186
      vcpus <- choose (0, maxCpu)
187
      return $ Instance.create name mem dsk vcpus run_st [] True pn sn
188
189
190
191

-- and a random node
instance Arbitrary Node.Node where
    arbitrary = do
192
      name <- getFQDN
Iustin Pop's avatar
Iustin Pop committed
193
      mem_t <- choose (0, maxMem)
194
195
      mem_f <- choose (0, mem_t)
      mem_n <- choose (0, mem_t - mem_f)
Iustin Pop's avatar
Iustin Pop committed
196
      dsk_t <- choose (0, maxDsk)
197
      dsk_f <- choose (0, dsk_t)
Iustin Pop's avatar
Iustin Pop committed
198
      cpu_t <- choose (0, maxCpu)
199
200
      offl <- arbitrary
      let n = Node.create name (fromIntegral mem_t) mem_n mem_f
Iustin Pop's avatar
Iustin Pop committed
201
              (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl
Iustin Pop's avatar
Iustin Pop committed
202
              0
203
          n' = Node.buildPeers n Container.empty
204
205
      return n'

Iustin Pop's avatar
Iustin Pop committed
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
  arbitrary = elements [ OpCodes.ReplaceOnPrimary
                       , OpCodes.ReplaceOnSecondary
                       , OpCodes.ReplaceNewSecondary
                       , OpCodes.ReplaceAuto
                       ]

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
    (case op_id of
        "OP_TEST_DELAY" ->
          liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
        "OP_INSTANCE_REPLACE_DISKS" ->
225
          liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
Iustin Pop's avatar
Iustin Pop committed
226
227
          arbitrary arbitrary arbitrary
        "OP_INSTANCE_FAILOVER" ->
228
          liftM2 OpCodes.OpInstanceFailover arbitrary arbitrary
Iustin Pop's avatar
Iustin Pop committed
229
        "OP_INSTANCE_MIGRATE" ->
230
          liftM4 OpCodes.OpInstanceMigrate arbitrary arbitrary arbitrary
231
          arbitrary
Iustin Pop's avatar
Iustin Pop committed
232
233
        _ -> fail "Wrong opcode")

234
235
236
237
238
239
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

240
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
241

242
243
244
245
246
247
248
249
-- If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idepotent
prop_Utils_commaJoinSplit lst = lst /= [""] &&
                                all (not . elem ',') lst ==>
                                Utils.sepSplit ',' (Utils.commaJoin lst) == lst
-- Split and join should always be idempotent
prop_Utils_commaSplitJoin s = Utils.commaJoin (Utils.sepSplit ',' s) == s

250
251
252
253
254
255
256
257
258
259
-- | fromObjWithDefault, we test using the Maybe monad and an integer
-- value
prop_Utils_fromObjWithDefault def_value random_key =
    -- a missing key will be returned with the default
    Utils.fromObjWithDefault [] random_key def_value == Just def_value &&
    -- a found key will be returned as is, not with default
    Utils.fromObjWithDefault [(random_key, J.showJSON def_value)]
         random_key (def_value+1) == Just def_value
        where _types = (def_value :: Integer)

260
261
262
testUtils =
  [ run prop_Utils_commaJoinSplit
  , run prop_Utils_commaSplitJoin
263
  , run prop_Utils_fromObjWithDefault
264
265
  ]

266
-- | Make sure add is idempotent
Iustin Pop's avatar
Iustin Pop committed
267
prop_PeerMap_addIdempotent pmap key em =
268
    fn puniq == fn (fn puniq)
269
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
270
271
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
272
          puniq = PeerMap.accumArray const pmap
273
274
275
276

-- | Make sure remove is idempotent
prop_PeerMap_removeIdempotent pmap key =
    fn puniq == fn (fn puniq)
277
278
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
279
280
281
282
283
          puniq = PeerMap.accumArray const pmap

-- | Make sure a missing item returns 0
prop_PeerMap_findMissing pmap key =
    PeerMap.find key (PeerMap.remove key puniq) == 0
284
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
285
286
287
          puniq = PeerMap.accumArray const pmap

-- | Make sure an added item is found
Iustin Pop's avatar
Iustin Pop committed
288
289
prop_PeerMap_addFind pmap key em =
    PeerMap.find key (PeerMap.add key em puniq) == em
290
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
291
                    key::PeerMap.Key, em::PeerMap.Elem)
292
          puniq = PeerMap.accumArray const pmap
293
294
295
296
297

-- | Manual check that maxElem returns the maximum indeed, or 0 for null
prop_PeerMap_maxElem pmap =
    PeerMap.maxElem puniq == if null puniq then 0
                             else (maximum . snd . unzip) puniq
298
    where _types = pmap::PeerMap.PeerMap
299
300
          puniq = PeerMap.accumArray const pmap

301
testPeerMap =
302
303
304
305
306
307
308
    [ run prop_PeerMap_addIdempotent
    , run prop_PeerMap_removeIdempotent
    , run prop_PeerMap_maxElem
    , run prop_PeerMap_addFind
    , run prop_PeerMap_findMissing
    ]

309
310
311
312
313
314
315
316
317
318
-- Container tests

prop_Container_addTwo cdata i1 i2 =
    fn i1 i2 cont == fn i2 i1 cont &&
       fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
  in Container.nameOf nl (Node.idx fnode) == Node.name fnode

-- We test that in a cluster, given a random node, we can find it by
-- its name and alias, as long as all names and aliases are unique,
-- and that we fail to find a non-existing name
prop_Container_findByName node othername =
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
  forAll (vector cnt) $ \ names ->
  (length . nub) (map fst names ++ map snd names) ==
  length names * 2 &&
  not (othername `elem` (map fst names ++ map snd names)) ==>
  let nl = makeSmallCluster node cnt
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
340
      nl' = Container.fromList nodes'
341
342
343
344
345
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
     Container.findByName nl' othername == Nothing

346
testContainer =
347
348
349
350
    [ run prop_Container_addTwo
    , run prop_Container_nameOf
    , run prop_Container_findByName
    ]
351

352
353
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
354
355
356
prop_Instance_creat inst =
    Instance.name inst == Instance.alias inst

357
358
359
360
361
prop_Instance_setIdx inst idx =
    Instance.idx (Instance.setIdx inst idx) == idx
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
362
363
364
365
366
367
368
369
    Instance.name newinst == name &&
    Instance.alias newinst == name
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
    Instance.name newinst == Instance.name inst &&
    Instance.alias newinst == name
370
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
371
          newinst = Instance.setAlias inst name
372
373

prop_Instance_setPri inst pdx =
374
    Instance.pNode (Instance.setPri inst pdx) == pdx
375
376
377
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
378
    Instance.sNode (Instance.setSec inst sdx) == sdx
379
380
381
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
382
    Instance.pNode si == pdx && Instance.sNode si == sdx
383
384
385
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
386
387
prop_Instance_runStatus_True inst =
    let run_st = Instance.running inst
388
        run_tx = Instance.runSt inst
Iustin Pop's avatar
Iustin Pop committed
389
    in
390
      run_tx `elem` Instance.runningStates ==> run_st
Iustin Pop's avatar
Iustin Pop committed
391
392
393

prop_Instance_runStatus_False inst =
    let run_st = Instance.running inst
394
        run_tx = Instance.runSt inst
Iustin Pop's avatar
Iustin Pop committed
395
    in
396
      run_tx `notElem` Instance.runningStates ==> not run_st
Iustin Pop's avatar
Iustin Pop committed
397

Iustin Pop's avatar
Iustin Pop committed
398
399
400
401
402
403
404
405
406
prop_Instance_shrinkMG inst =
    Instance.mem inst >= 2 * Types.unitMem ==>
        case Instance.shrinkByType inst Types.FailMem of
          Types.Ok inst' ->
              Instance.mem inst' == Instance.mem inst - Types.unitMem
          _ -> False

prop_Instance_shrinkMF inst =
    Instance.mem inst < 2 * Types.unitMem ==>
407
        Types.isBad $ Instance.shrinkByType inst Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
408
409
410
411
412
413
414
415
416
417

prop_Instance_shrinkCG inst =
    Instance.vcpus inst >= 2 * Types.unitCpu ==>
        case Instance.shrinkByType inst Types.FailCPU of
          Types.Ok inst' ->
              Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
          _ -> False

prop_Instance_shrinkCF inst =
    Instance.vcpus inst < 2 * Types.unitCpu ==>
418
        Types.isBad $ Instance.shrinkByType inst Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
419
420
421
422
423
424
425
426
427
428

prop_Instance_shrinkDG inst =
    Instance.dsk inst >= 2 * Types.unitDsk ==>
        case Instance.shrinkByType inst Types.FailDisk of
          Types.Ok inst' ->
              Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
          _ -> False

prop_Instance_shrinkDF inst =
    Instance.dsk inst < 2 * Types.unitDsk ==>
429
        Types.isBad $ Instance.shrinkByType inst Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
430
431
432

prop_Instance_setMovable inst m =
    Instance.movable inst' == m
433
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
434

435
testInstance =
Iustin Pop's avatar
Iustin Pop committed
436
437
    [ run prop_Instance_creat
    , run prop_Instance_setIdx
438
    , run prop_Instance_setName
Iustin Pop's avatar
Iustin Pop committed
439
    , run prop_Instance_setAlias
440
441
442
    , run prop_Instance_setPri
    , run prop_Instance_setSec
    , run prop_Instance_setBoth
Iustin Pop's avatar
Iustin Pop committed
443
444
    , run prop_Instance_runStatus_True
    , run prop_Instance_runStatus_False
Iustin Pop's avatar
Iustin Pop committed
445
446
447
448
449
450
451
    , run prop_Instance_shrinkMG
    , run prop_Instance_shrinkMF
    , run prop_Instance_shrinkCG
    , run prop_Instance_shrinkCF
    , run prop_Instance_shrinkDG
    , run prop_Instance_shrinkDF
    , run prop_Instance_setMovable
Iustin Pop's avatar
Iustin Pop committed
452
453
454
455
    ]

-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
456
prop_Text_Load_Instance name mem dsk vcpus status pnode snode pdx sdx autobal =
Iustin Pop's avatar
Iustin Pop committed
457
    not (null pnode) && pdx >= 0 && sdx >= 0 ==>
Iustin Pop's avatar
Iustin Pop committed
458
459
460
461
462
463
    let vcpus_s = show vcpus
        dsk_s = show dsk
        mem_s = show mem
        rsdx = if pdx == sdx
               then sdx + 1
               else sdx
Iustin Pop's avatar
Iustin Pop committed
464
465
466
        ndx = if null snode
              then [(pnode, pdx)]
              else [(pnode, pdx), (snode, rsdx)]
467
        nl = Data.Map.fromList ndx
468
        tags = ""
Iustin Pop's avatar
Iustin Pop committed
469
        sbal = if autobal then "Y" else "N"
470
        inst = Text.loadInst nl
Iustin Pop's avatar
Iustin Pop committed
471
472
               [name, mem_s, dsk_s, vcpus_s, status,
                sbal, pnode, snode, tags]:: Maybe (String, Instance.Instance)
473
        fail1 = Text.loadInst nl
Iustin Pop's avatar
Iustin Pop committed
474
475
               [name, mem_s, dsk_s, vcpus_s, status,
                sbal, pnode, pnode, tags]:: Maybe (String, Instance.Instance)
Iustin Pop's avatar
Iustin Pop committed
476
477
478
        _types = ( name::String, mem::Int, dsk::Int
                 , vcpus::Int, status::String
                 , pnode::String, snode::String
Iustin Pop's avatar
Iustin Pop committed
479
480
                 , pdx::Types.Ndx, sdx::Types.Ndx
                 , autobal::Bool)
Iustin Pop's avatar
Iustin Pop committed
481
482
483
484
485
486
487
    in
      case inst of
        Nothing -> False
        Just (_, i) ->
            (Instance.name i == name &&
             Instance.vcpus i == vcpus &&
             Instance.mem i == mem &&
488
             Instance.pNode i == pdx &&
Iustin Pop's avatar
Iustin Pop committed
489
490
491
             Instance.sNode i == (if null snode
                                  then Node.noSecondary
                                  else rsdx) &&
Iustin Pop's avatar
Iustin Pop committed
492
             Instance.auto_balance i == autobal &&
Iustin Pop's avatar
Iustin Pop committed
493
494
495
             isNothing fail1)

prop_Text_Load_InstanceFail ktn fields =
Iustin Pop's avatar
Iustin Pop committed
496
497
498
499
    length fields /= 9 ==>
    case Text.loadInst nl fields of
      Right _ -> False
      Left msg -> isPrefixOf "Invalid/incomplete instance data: '" msg
500
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515

prop_Text_Load_Node name tm nm fm td fd tc fo =
    let conv v = if v < 0
                    then "?"
                    else show v
        tm_s = conv tm
        nm_s = conv nm
        fm_s = conv fm
        td_s = conv td
        fd_s = conv fd
        tc_s = conv tc
        fo_s = if fo
               then "Y"
               else "N"
        any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
Iustin Pop's avatar
Iustin Pop committed
516
517
518
        gid = Group.uuid defGroup
    in case Text.loadNode defGroupAssoc
           [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
Iustin Pop's avatar
Iustin Pop committed
519
520
521
522
         Nothing -> False
         Just (name', node) ->
             if fo || any_broken
             then Node.offline node
523
524
525
526
527
528
529
530
             else Node.name node == name' && name' == name &&
                  Node.alias node == name &&
                  Node.tMem node == fromIntegral tm &&
                  Node.nMem node == nm &&
                  Node.fMem node == fm &&
                  Node.tDsk node == fromIntegral td &&
                  Node.fDsk node == fd &&
                  Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
531
532

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
533
    length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
534

535
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
536
537
    (Text.loadNode defGroupAssoc.
         Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
538
539
540
541
    Just (Node.name n, n)
    -- override failN1 to what loadNode returns by default
    where n = node { Node.failN1 = True, Node.offline = False }

542
testText =
Iustin Pop's avatar
Iustin Pop committed
543
    [ run prop_Text_Load_Instance
Iustin Pop's avatar
Iustin Pop committed
544
545
546
    , run prop_Text_Load_InstanceFail
    , run prop_Text_Load_Node
    , run prop_Text_Load_NodeFail
547
    , run prop_Text_NodeLSIdempotent
548
549
550
551
    ]

-- Node tests

Iustin Pop's avatar
Iustin Pop committed
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
prop_Node_setAlias node name =
    Node.name newnode == Node.name node &&
    Node.alias newnode == name
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
    Node.offline newnode == status
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
    Node.xMem newnode == xm
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
    Node.mCpu newnode == mc
    where newnode = Node.setMcpu node mc

570
-- | Check that an instance add with too high memory or disk will be rejected
Iustin Pop's avatar
Iustin Pop committed
571
572
573
574
575
576
prop_Node_addPriFM node inst = Instance.mem inst >= Node.fMem node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailMem -> True
                                 _ -> False
577
    where _types = (node::Node.Node, inst::Instance.Instance)
Iustin Pop's avatar
Iustin Pop committed
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst = Instance.dsk inst >= Node.fDsk node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailDisk -> True
                                 _ -> False
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

prop_Node_addPriFC node inst = Instance.vcpus inst > Node.availCpu node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailCPU -> True
                                 _ -> False
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.vcpus = Instance.vcpus inst }
600
601

-- | Check that an instance add with too high memory or disk will be rejected
602
prop_Node_addSec node inst pdx =
603
604
    (Instance.mem inst >= (Node.fMem node - Node.rMem node) ||
     Instance.dsk inst >= Node.fDsk node) &&
Iustin Pop's avatar
Iustin Pop committed
605
    not (Node.failN1 node)
Iustin Pop's avatar
Iustin Pop committed
606
    ==> isFailure (Node.addSec node inst pdx)
607
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
608

609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
-- | Checks for memory reservation changes
prop_Node_rMem node inst =
    -- ab = auto_balance, nb = non-auto_balance
    -- we use -1 as the primary node of the instance
    let inst' = inst { Instance.pNode = (-1), Instance.auto_balance = True}
        inst_ab = setInstanceSmallerThanNode node inst'
        inst_nb = inst_ab { Instance.auto_balance = False }
        -- now we have the two instances, identical except the
        -- auto_balance attribute
        orig_rmem = Node.rMem node
        inst_idx = Instance.idx inst_ab
        node_add_ab = Node.addSec node inst_ab (-1)
        node_add_nb = Node.addSec node inst_nb (-1)
        node_del_ab = liftM (flip Node.removeSec inst_ab) node_add_ab
        node_del_nb = liftM (flip Node.removeSec inst_nb) node_add_nb
    in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
         (Types.OpGood a_ab, Types.OpGood a_nb,
          Types.OpGood d_ab, Types.OpGood d_nb) ->
             Node.rMem a_ab >  orig_rmem &&
             Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
             Node.rMem a_nb == orig_rmem &&
             Node.rMem d_ab == orig_rmem &&
             Node.rMem d_nb == orig_rmem &&
             -- this is not related to rMem, but as good a place to
             -- test as any
             inst_idx `elem` Node.sList a_ab &&
             not (inst_idx `elem` Node.sList d_ab)
         _ -> False

Iustin Pop's avatar
Iustin Pop committed
638
639
640
641
642
643
644
645
646
647
648
649
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
    arbitrary = do
      v <- choose (0, 1)
      return $ SmallRatio v

-- | Check mdsk setting
prop_Node_setMdsk node mx =
    Node.loDsk node' >= 0 &&
    fromIntegral (Node.loDsk node') <= Node.tDsk node &&
    Node.availDisk node' >= 0 &&
    Node.availDisk node' <= Node.fDsk node' &&
Iustin Pop's avatar
Iustin Pop committed
650
651
    fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
    Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
652
653
654
655
656
657
658
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
    Node.delTags (Node.addTags m tags) tags == m
659
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
660
661
662
663

prop_Node_tagMaps_reject tags =
    not (null tags) ==>
    any (\t -> Node.rejectAddTags m [t]) tags
664
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
665

Iustin Pop's avatar
Iustin Pop committed
666
667
668
669
670
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

671
672
673
674
675
676
677
678
679

prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
     if null nodes then True else not (null ng)

680
testNode =
Iustin Pop's avatar
Iustin Pop committed
681
682
683
684
685
    [ run prop_Node_setAlias
    , run prop_Node_setOffline
    , run prop_Node_setMcpu
    , run prop_Node_setXmem
    , run prop_Node_addPriFM
Iustin Pop's avatar
Iustin Pop committed
686
687
    , run prop_Node_addPriFD
    , run prop_Node_addPriFC
688
    , run prop_Node_addSec
689
    , run prop_Node_rMem
Iustin Pop's avatar
Iustin Pop committed
690
691
692
    , run prop_Node_setMdsk
    , run prop_Node_tagMaps_idempotent
    , run prop_Node_tagMaps_reject
Iustin Pop's avatar
Iustin Pop committed
693
    , run prop_Node_showField
694
    , run prop_Node_computeGroups
695
    ]
696
697
698
699
700
701


-- Cluster tests

-- | Check that the cluster score is close to zero for a homogeneous cluster
prop_Score_Zero node count =
Iustin Pop's avatar
Iustin Pop committed
702
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
703
     (Node.tDsk node > 0) && (Node.tMem node > 0)) ==>
704
    let fn = Node.buildPeers node Container.empty
Iustin Pop's avatar
Iustin Pop committed
705
        nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
Iustin Pop's avatar
Iustin Pop committed
706
        nl = Container.fromList nlst
707
708
709
        score = Cluster.compCV nl
    -- we can't say == 0 here as the floating point errors accumulate;
    -- this should be much lower than the default score in CLI.hs
Iustin Pop's avatar
Iustin Pop committed
710
    in score <= 1e-15
711

Iustin Pop's avatar
Iustin Pop committed
712
713
714
-- | Check that cluster stats are sane
prop_CStats_sane node count =
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
715
     (Node.availDisk node > 0) && (Node.availMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
716
717
    let fn = Node.buildPeers node Container.empty
        nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
Iustin Pop's avatar
Iustin Pop committed
718
        nl = Container.fromList nlst
Iustin Pop's avatar
Iustin Pop committed
719
720
721
722
        cstats = Cluster.totalResources nl
    in Cluster.csAdsk cstats >= 0 &&
       Cluster.csAdsk cstats <= Cluster.csFdsk cstats

723
724
725
726
727
728
729
730
731
732
733
734
-- | Check that one instance is allocated correctly, without
-- rebalances needed
prop_ClusterAlloc_sane node inst =
    forAll (choose (5, 20)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && Node.availDisk node > 0
            && Node.availMem node > 0
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
735
736
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
737
         Types.Bad _ -> False
738
739
         Types.Ok as ->
             case Cluster.asSolutions as of
740
               [] -> False
741
               (xnl, xi, _, cv):[] ->
742
                   let il' = Container.add (Instance.idx xi) xi il
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
                       tbl = Cluster.Table xnl il' cv []
                   in not (canBalance tbl True False)
               _ -> False

-- | Checks that on a 2-5 node cluster, we can allocate a random
-- instance spec via tiered allocation (whatever the original instance
-- spec), on either one or two nodes
prop_ClusterCanTieredAlloc node inst =
    forAll (choose (2, 5)) $ \count ->
    forAll (choose (1, 2)) $ \rqnodes ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
759
        allocnodes = Cluster.genAllocNodes defGroupList nl rqnodes True
Iustin Pop's avatar
Iustin Pop committed
760
761
    in case allocnodes >>= \allocnodes' ->
        Cluster.tieredAlloc nl il inst allocnodes' [] [] of
762
         Types.Bad _ -> False
763
764
765
         Types.Ok (_, _, il', ixes, cstats) -> not (null ixes) &&
                                      IntMap.size il' == length ixes &&
                                      length ixes == length cstats
766
767
768
769
770
771
772
773
774
775
776
777

-- | Checks that on a 4-8 node cluster, once we allocate an instance,
-- we can also evacuate it
prop_ClusterAllocEvac node inst =
    forAll (choose (4, 8)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
778
779
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
780
         Types.Bad _ -> False
781
782
         Types.Ok as ->
             case Cluster.asSolutions as of
783
               [] -> False
784
               (xnl, xi, _, _):[] ->
785
786
                   let sdx = Instance.sNode xi
                       il' = Container.add (Instance.idx xi) xi il
787
                   in case Cluster.tryEvac xnl il' [Instance.idx xi] [sdx] of
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
                        Just _ -> True
                        _ -> False
               _ -> False

-- | Check that allocating multiple instances on a cluster, then
-- adding an empty node, results in a valid rebalance
prop_ClusterAllocBalance node =
    forAll (choose (3, 5)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            && not (isNodeBig node 8)
            ==>
    let nl = makeSmallCluster node count
        (hnode, nl') = IntMap.deleteFindMax nl
        il = Container.empty
804
        allocnodes = Cluster.genAllocNodes defGroupList nl' 2 True
805
        i_templ = createInstance Types.unitMem Types.unitDsk Types.unitCpu
Iustin Pop's avatar
Iustin Pop committed
806
807
    in case allocnodes >>= \allocnodes' ->
        Cluster.iterateAlloc nl' il i_templ allocnodes' [] [] of
808
         Types.Bad _ -> False
809
         Types.Ok (_, xnl, il', _, _) ->
810
811
812
813
814
                   let ynl = Container.add (Node.idx hnode) hnode xnl
                       cv = Cluster.compCV ynl
                       tbl = Cluster.Table ynl il' cv []
                   in canBalance tbl True False

815
816
817
818
-- | Checks consistency
prop_ClusterCheckConsistency node inst =
  let nl = makeSmallCluster node 3
      [node1, node2, node3] = Container.elems nl
Iustin Pop's avatar
Iustin Pop committed
819
      node3' = node3 { Node.group = 1 }
820
821
822
823
      nl' = Container.add (Node.idx node3') node3' nl
      inst1 = Instance.setBoth inst (Node.idx node1) (Node.idx node2)
      inst2 = Instance.setBoth inst (Node.idx node1) Node.noSecondary
      inst3 = Instance.setBoth inst (Node.idx node1) (Node.idx node3)
Iustin Pop's avatar
Iustin Pop committed
824
      ccheck = Cluster.findSplitInstances nl' . Container.fromList
825
826
827
828
  in null (ccheck [(0, inst1)]) &&
     null (ccheck [(0, inst2)]) &&
     (not . null $ ccheck [(0, inst3)])

829
830
831
832
833
834
835
836
837
838
-- For now, we only test that we don't lose instances during the split
prop_ClusterSplitCluster node inst =
  forAll (choose (0, 100)) $ \icnt ->
  let nl = makeSmallCluster node 2
      (nl', il') = foldl (\(ns, is) _ -> assignInstance ns is inst 0 1)
                   (nl, Container.empty) [1..icnt]
      gni = Cluster.splitCluster nl' il'
  in sum (map (Container.size . snd . snd) gni) == icnt &&
     all (\(guuid, (nl'', _)) -> all ((== guuid) . Node.group)
                                 (Container.elems nl'')) gni
839

840
testCluster =
841
    [ run prop_Score_Zero
Iustin Pop's avatar
Iustin Pop committed
842
    , run prop_CStats_sane
843
844
845
846
    , run prop_ClusterAlloc_sane
    , run prop_ClusterCanTieredAlloc
    , run prop_ClusterAllocEvac
    , run prop_ClusterAllocBalance
847
    , run prop_ClusterCheckConsistency
848
    , run prop_ClusterSplitCluster
849
    ]
Iustin Pop's avatar
Iustin Pop committed
850
851
852
853
854
855
856

-- | Check that opcode serialization is idempotent

prop_OpCodes_serialization op =
  case J.readJSON (J.showJSON op) of
    J.Error _ -> False
    J.Ok op' -> op == op'
857
  where _types = op::OpCodes.OpCode
Iustin Pop's avatar
Iustin Pop committed
858
859
860
861

testOpCodes =
  [ run prop_OpCodes_serialization
  ]
Iustin Pop's avatar
Iustin Pop committed
862

863
-- | Check that (queued) job\/opcode status serialization is idempotent
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
prop_OpStatus_serialization os =
  case J.readJSON (J.showJSON os) of
    J.Error _ -> False
    J.Ok os' -> os == os'
  where _types = os::Jobs.OpStatus

prop_JobStatus_serialization js =
  case J.readJSON (J.showJSON js) of
    J.Error _ -> False
    J.Ok js' -> js == js'
  where _types = js::Jobs.JobStatus

testJobs =
  [ run prop_OpStatus_serialization
  , run prop_JobStatus_serialization
  ]

Iustin Pop's avatar
Iustin Pop committed
881
882
883
-- | Loader tests

prop_Loader_lookupNode ktn inst node =
884
885
  Loader.lookupNode nl inst node == Data.Map.lookup node nl
  where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
886
887

prop_Loader_lookupInstance kti inst =
888
889
890
891
892
893
894
895
  Loader.lookupInstance il inst == Data.Map.lookup inst il
  where il = Data.Map.fromList kti

prop_Loader_assignIndices nodes =
  Data.Map.size nassoc == length nodes &&
  Container.size kt == length nodes &&
  (if not (null nodes)
   then maximum (IntMap.keys kt) == length nodes - 1
Iustin Pop's avatar
Iustin Pop committed
896
   else True)
897
  where (nassoc, kt) = Loader.assignIndices (map (\n -> (Node.name n, n)) nodes)
Iustin Pop's avatar
Iustin Pop committed
898
899
900
901
902


-- | Checks that the number of primary instances recorded on the nodes
-- is zero
prop_Loader_mergeData ns =
Iustin Pop's avatar
Iustin Pop committed
903
  let na = Container.fromList $ map (\n -> (Node.idx n, n)) ns
904
  in case Loader.mergeData [] [] []
905
         (Loader.emptyCluster {Loader.cdNodes = na}) of
Iustin Pop's avatar
Iustin Pop committed
906
    Types.Bad _ -> False
907
    Types.Ok (Loader.ClusterData _ nl il _) ->
Iustin Pop's avatar
Iustin Pop committed
908
909
910
      let nodes = Container.elems nl
          instances = Container.elems il
      in (sum . map (length . Node.pList)) nodes == 0 &&
911
         null instances
Iustin Pop's avatar
Iustin Pop committed
912
913
914
915
916
917
918

testLoader =
  [ run prop_Loader_lookupNode
  , run prop_Loader_lookupInstance
  , run prop_Loader_assignIndices
  , run prop_Loader_mergeData
  ]