QC.hs 33.5 KB
Newer Older
1
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
2
3
4
5
6

-}

{-

7
Copyright (C) 2009, 2010, 2011 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

26
module Ganeti.HTools.QC
27
28
    ( testUtils
    , testPeerMap
29
30
31
32
    , testContainer
    , testInstance
    , testNode
    , testText
Iustin Pop's avatar
Iustin Pop committed
33
    , testOpCodes
34
    , testJobs
35
    , testCluster
Iustin Pop's avatar
Iustin Pop committed
36
    , testLoader
37
    ) where
38
39

import Test.QuickCheck
Iustin Pop's avatar
Iustin Pop committed
40
import Data.List (findIndex, intercalate, nub, isPrefixOf)
41
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
42
43
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
44
import qualified Data.Map
45
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
46
import qualified Ganeti.OpCodes as OpCodes
47
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
48
import qualified Ganeti.Luxi
49
50
51
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
52
import qualified Ganeti.HTools.ExtLoader
53
54
55
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
56
import qualified Ganeti.HTools.Luxi
57
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
58
import qualified Ganeti.HTools.Group as Group
59
import qualified Ganeti.HTools.PeerMap as PeerMap
60
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
61
import qualified Ganeti.HTools.Simu
62
63
64
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
65
import qualified Ganeti.HTools.Version
66
import qualified Ganeti.Constants as C
67

Iustin Pop's avatar
Iustin Pop committed
68
69
70
run :: Testable prop => prop -> Args -> IO Result
run = flip quickCheckWithResult

71
72
-- * Constants

73
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
74
75
76
maxMem :: Int
maxMem = 1024 * 1024

77
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
78
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
79
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
80

81
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
82
83
84
maxCpu :: Int
maxCpu = 1024

Iustin Pop's avatar
Iustin Pop committed
85
86
87
88
89
90
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
               Group.create "default" Utils.defaultGroupID
                    Types.AllocPreferred

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
91
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
92
93
94
95

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

96
97
-- * Helper functions

98
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
99
100
101
102
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

103
-- | Update an instance to be smaller than a node.
104
setInstanceSmallerThanNode node inst =
105
106
107
    inst { Instance.mem = Node.availMem node `div` 2
         , Instance.dsk = Node.availDisk node `div` 2
         , Instance.vcpus = Node.availCpu node `div` 2
108
109
         }

110
-- | Create an instance given its spec.
111
createInstance mem dsk vcpus =
112
    Instance.create "inst-unnamed" mem dsk vcpus "running" [] True (-1) (-1)
113

114
-- | Create a small cluster by repeating a node spec.
115
116
117
118
119
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
    let fn = Node.buildPeers node Container.empty
        namelst = map (\n -> (Node.name n, n)) (replicate count fn)
        (_, nlst) = Loader.assignIndices namelst
120
    in nlst
121

122
-- | Checks if a node is "big" enough.
123
124
125
126
127
isNodeBig :: Node.Node -> Int -> Bool
isNodeBig node size = Node.availDisk node > size * Types.unitDsk
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

128
129
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
130

131
-- | Assigns a new fresh instance to a cluster; this is not
132
-- allocation, so no resource checks are done.
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
                then 0
                else fst (Container.findMax il) + 1
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

150
151
-- * Arbitrary instances

152
-- | Defines a DNS name.
153
newtype DNSChar = DNSChar { dnsGetChar::Char }
154

155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
instance Arbitrary DNSChar where
    arbitrary = do
      x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
      return (DNSChar x)

getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)


getFQDN :: Gen String
getFQDN = do
  felem <- getName
  ncomps <- choose (1, 4)
  frest <- vector ncomps::Gen [[DNSChar]]
  let frest' = map (map dnsGetChar) frest
  return (felem ++ "." ++ intercalate "." frest')

175
176
177
-- let's generate a random instance
instance Arbitrary Instance.Instance where
    arbitrary = do
178
      name <- getFQDN
Iustin Pop's avatar
Iustin Pop committed
179
180
      mem <- choose (0, maxMem)
      dsk <- choose (0, maxDsk)
181
182
183
184
185
186
187
188
      run_st <- elements [ C.inststErrorup
                         , C.inststErrordown
                         , C.inststAdmindown
                         , C.inststNodedown
                         , C.inststNodeoffline
                         , C.inststRunning
                         , "no_such_status1"
                         , "no_such_status2"]
189
190
      pn <- arbitrary
      sn <- arbitrary
Iustin Pop's avatar
Iustin Pop committed
191
      vcpus <- choose (0, maxCpu)
192
      return $ Instance.create name mem dsk vcpus run_st [] True pn sn
193

194
195
196
197
198
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
          case min_multiplier of
            Just mm -> (mm * Types.unitMem,
                        mm * Types.unitDsk,
                        mm * Types.unitCpu)
            Nothing -> (0, 0, 0)
      (top_mem, top_dsk, top_cpu)  =
          case max_multiplier of
            Just mm -> (mm * Types.unitMem,
                        mm * Types.unitDsk,
                        mm * Types.unitCpu)
            Nothing -> (maxMem, maxDsk, maxCpu)
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
  return $ Node.buildPeers n Container.empty

224
225
-- and a random node
instance Arbitrary Node.Node where
226
    arbitrary = genNode Nothing Nothing
227

Iustin Pop's avatar
Iustin Pop committed
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
  arbitrary = elements [ OpCodes.ReplaceOnPrimary
                       , OpCodes.ReplaceOnSecondary
                       , OpCodes.ReplaceNewSecondary
                       , OpCodes.ReplaceAuto
                       ]

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
    (case op_id of
        "OP_TEST_DELAY" ->
          liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
        "OP_INSTANCE_REPLACE_DISKS" ->
247
          liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
Iustin Pop's avatar
Iustin Pop committed
248
249
          arbitrary arbitrary arbitrary
        "OP_INSTANCE_FAILOVER" ->
250
          liftM2 OpCodes.OpInstanceFailover arbitrary arbitrary
Iustin Pop's avatar
Iustin Pop committed
251
        "OP_INSTANCE_MIGRATE" ->
252
          liftM4 OpCodes.OpInstanceMigrate arbitrary arbitrary arbitrary
253
          arbitrary
Iustin Pop's avatar
Iustin Pop committed
254
255
        _ -> fail "Wrong opcode")

256
257
258
259
260
261
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

262
263
264
265
266
267
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
    arbitrary = do
      v <- choose (0, 1)
      return $ SmallRatio v

268
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
269

270
271
272
273
-- ** Utils tests

-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
274
275
276
277
278
prop_Utils_commaJoinSplit =
    forAll (arbitrary `suchThat`
            (\l -> l /= [""] && all (not . elem ',') l )) $ \lst ->
    Utils.sepSplit ',' (Utils.commaJoin lst) == lst

279
-- | Split and join should always be idempotent.
280
281
prop_Utils_commaSplitJoin s = Utils.commaJoin (Utils.sepSplit ',' s) == s

282
-- | fromObjWithDefault, we test using the Maybe monad and an integer
283
-- value.
284
285
286
287
288
289
prop_Utils_fromObjWithDefault def_value random_key =
    -- a missing key will be returned with the default
    Utils.fromObjWithDefault [] random_key def_value == Just def_value &&
    -- a found key will be returned as is, not with default
    Utils.fromObjWithDefault [(random_key, J.showJSON def_value)]
         random_key (def_value+1) == Just def_value
Iustin Pop's avatar
Iustin Pop committed
290
        where _types = def_value :: Integer
291

292
-- | Test list for the Utils module.
293
294
295
testUtils =
  [ run prop_Utils_commaJoinSplit
  , run prop_Utils_commaSplitJoin
296
  , run prop_Utils_fromObjWithDefault
297
298
  ]

299
300
301
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
302
prop_PeerMap_addIdempotent pmap key em =
303
    fn puniq == fn (fn puniq)
304
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
305
306
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
307
          puniq = PeerMap.accumArray const pmap
308

309
-- | Make sure remove is idempotent.
310
311
prop_PeerMap_removeIdempotent pmap key =
    fn puniq == fn (fn puniq)
312
313
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
314
315
          puniq = PeerMap.accumArray const pmap

316
-- | Make sure a missing item returns 0.
317
318
prop_PeerMap_findMissing pmap key =
    PeerMap.find key (PeerMap.remove key puniq) == 0
319
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
320
321
          puniq = PeerMap.accumArray const pmap

322
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
323
324
prop_PeerMap_addFind pmap key em =
    PeerMap.find key (PeerMap.add key em puniq) == em
325
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
326
                    key::PeerMap.Key, em::PeerMap.Elem)
327
          puniq = PeerMap.accumArray const pmap
328

329
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
330
331
332
prop_PeerMap_maxElem pmap =
    PeerMap.maxElem puniq == if null puniq then 0
                             else (maximum . snd . unzip) puniq
333
    where _types = pmap::PeerMap.PeerMap
334
335
          puniq = PeerMap.accumArray const pmap

336
-- | List of tests for the PeerMap module.
337
testPeerMap =
338
339
340
341
342
343
344
    [ run prop_PeerMap_addIdempotent
    , run prop_PeerMap_removeIdempotent
    , run prop_PeerMap_maxElem
    , run prop_PeerMap_addFind
    , run prop_PeerMap_findMissing
    ]

345
-- ** Container tests
346
347
348
349
350
351
352
353
354

prop_Container_addTwo cdata i1 i2 =
    fn i1 i2 cont == fn i2 i1 cont &&
       fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

355
356
357
358
359
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
  in Container.nameOf nl (Node.idx fnode) == Node.name fnode

360
-- | We test that in a cluster, given a random node, we can find it by
361
-- its name and alias, as long as all names and aliases are unique,
362
-- and that we fail to find a non-existing name.
363
364
365
366
367
368
369
370
371
372
373
374
375
prop_Container_findByName node othername =
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
  forAll (vector cnt) $ \ names ->
  (length . nub) (map fst names ++ map snd names) ==
  length names * 2 &&
  not (othername `elem` (map fst names ++ map snd names)) ==>
  let nl = makeSmallCluster node cnt
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
376
      nl' = Container.fromList nodes'
377
378
379
380
381
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
     Container.findByName nl' othername == Nothing

382
testContainer =
383
384
385
386
    [ run prop_Container_addTwo
    , run prop_Container_nameOf
    , run prop_Container_findByName
    ]
387

388
389
-- ** Instance tests

390
391
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
392
393
394
prop_Instance_creat inst =
    Instance.name inst == Instance.alias inst

395
396
397
398
399
prop_Instance_setIdx inst idx =
    Instance.idx (Instance.setIdx inst idx) == idx
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
400
401
402
403
404
405
406
407
    Instance.name newinst == name &&
    Instance.alias newinst == name
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
    Instance.name newinst == Instance.name inst &&
    Instance.alias newinst == name
408
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
409
          newinst = Instance.setAlias inst name
410
411

prop_Instance_setPri inst pdx =
412
    Instance.pNode (Instance.setPri inst pdx) == pdx
413
414
415
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
416
    Instance.sNode (Instance.setSec inst sdx) == sdx
417
418
419
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
420
    Instance.pNode si == pdx && Instance.sNode si == sdx
421
422
423
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
424
425
426
427
prop_Instance_runStatus_True =
    forAll (arbitrary `suchThat`
            ((`elem` Instance.runningStates) . Instance.runSt))
    Instance.running
Iustin Pop's avatar
Iustin Pop committed
428
429
430

prop_Instance_runStatus_False inst =
    let run_st = Instance.running inst
431
        run_tx = Instance.runSt inst
Iustin Pop's avatar
Iustin Pop committed
432
    in
433
      run_tx `notElem` Instance.runningStates ==> not run_st
Iustin Pop's avatar
Iustin Pop committed
434

Iustin Pop's avatar
Iustin Pop committed
435
436
437
438
439
440
441
442
prop_Instance_shrinkMG inst =
    Instance.mem inst >= 2 * Types.unitMem ==>
        case Instance.shrinkByType inst Types.FailMem of
          Types.Ok inst' ->
              Instance.mem inst' == Instance.mem inst - Types.unitMem
          _ -> False

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
443
444
445
    forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
446
447
448
449
450
451
452
453
454

prop_Instance_shrinkCG inst =
    Instance.vcpus inst >= 2 * Types.unitCpu ==>
        case Instance.shrinkByType inst Types.FailCPU of
          Types.Ok inst' ->
              Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
          _ -> False

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
455
456
457
    forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
458
459
460
461
462
463
464
465
466

prop_Instance_shrinkDG inst =
    Instance.dsk inst >= 2 * Types.unitDsk ==>
        case Instance.shrinkByType inst Types.FailDisk of
          Types.Ok inst' ->
              Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
          _ -> False

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
467
468
469
    forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
470
471
472

prop_Instance_setMovable inst m =
    Instance.movable inst' == m
473
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
474

475
testInstance =
Iustin Pop's avatar
Iustin Pop committed
476
477
    [ run prop_Instance_creat
    , run prop_Instance_setIdx
478
    , run prop_Instance_setName
Iustin Pop's avatar
Iustin Pop committed
479
    , run prop_Instance_setAlias
480
481
482
    , run prop_Instance_setPri
    , run prop_Instance_setSec
    , run prop_Instance_setBoth
Iustin Pop's avatar
Iustin Pop committed
483
484
    , run prop_Instance_runStatus_True
    , run prop_Instance_runStatus_False
Iustin Pop's avatar
Iustin Pop committed
485
486
487
488
489
490
491
    , run prop_Instance_shrinkMG
    , run prop_Instance_shrinkMF
    , run prop_Instance_shrinkCG
    , run prop_Instance_shrinkCF
    , run prop_Instance_shrinkDG
    , run prop_Instance_shrinkDF
    , run prop_Instance_setMovable
Iustin Pop's avatar
Iustin Pop committed
492
493
    ]

494
495
-- ** Text backend tests

Iustin Pop's avatar
Iustin Pop committed
496
497
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
498
499
500
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
                        (NonNegative pdx) (NonNegative sdx) autobal =
501
    pnode /= snode && pdx /= sdx ==>
Iustin Pop's avatar
Iustin Pop committed
502
503
504
    let vcpus_s = show vcpus
        dsk_s = show dsk
        mem_s = show mem
Iustin Pop's avatar
Iustin Pop committed
505
506
        ndx = if null snode
              then [(pnode, pdx)]
507
              else [(pnode, pdx), (snode, sdx)]
508
        nl = Data.Map.fromList ndx
509
        tags = ""
Iustin Pop's avatar
Iustin Pop committed
510
        sbal = if autobal then "Y" else "N"
511
        inst = Text.loadInst nl
Iustin Pop's avatar
Iustin Pop committed
512
513
               [name, mem_s, dsk_s, vcpus_s, status,
                sbal, pnode, snode, tags]:: Maybe (String, Instance.Instance)
514
        fail1 = Text.loadInst nl
Iustin Pop's avatar
Iustin Pop committed
515
516
               [name, mem_s, dsk_s, vcpus_s, status,
                sbal, pnode, pnode, tags]:: Maybe (String, Instance.Instance)
Iustin Pop's avatar
Iustin Pop committed
517
518
        _types = ( name::String, mem::Int, dsk::Int
                 , vcpus::Int, status::String
Iustin Pop's avatar
Iustin Pop committed
519
                 , snode::String
Iustin Pop's avatar
Iustin Pop committed
520
                 , autobal::Bool)
Iustin Pop's avatar
Iustin Pop committed
521
522
523
524
    in
      case inst of
        Nothing -> False
        Just (_, i) ->
Iustin Pop's avatar
Iustin Pop committed
525
526
527
528
529
530
            Instance.name i == name &&
            Instance.vcpus i == vcpus &&
            Instance.mem i == mem &&
            Instance.pNode i == pdx &&
            Instance.sNode i == (if null snode
                                 then Node.noSecondary
531
                                 else sdx) &&
532
            Instance.autoBalance i == autobal &&
Iustin Pop's avatar
Iustin Pop committed
533
            isNothing fail1
Iustin Pop's avatar
Iustin Pop committed
534
535

prop_Text_Load_InstanceFail ktn fields =
Iustin Pop's avatar
Iustin Pop committed
536
537
    length fields /= 9 ==>
    case Text.loadInst nl fields of
Iustin Pop's avatar
Iustin Pop committed
538
539
      Types.Ok _ -> False
      Types.Bad msg -> "Invalid/incomplete instance data: '" `isPrefixOf` msg
540
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555

prop_Text_Load_Node name tm nm fm td fd tc fo =
    let conv v = if v < 0
                    then "?"
                    else show v
        tm_s = conv tm
        nm_s = conv nm
        fm_s = conv fm
        td_s = conv td
        fd_s = conv fd
        tc_s = conv tc
        fo_s = if fo
               then "Y"
               else "N"
        any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
Iustin Pop's avatar
Iustin Pop committed
556
557
558
        gid = Group.uuid defGroup
    in case Text.loadNode defGroupAssoc
           [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
Iustin Pop's avatar
Iustin Pop committed
559
560
561
562
         Nothing -> False
         Just (name', node) ->
             if fo || any_broken
             then Node.offline node
563
564
565
566
567
568
569
570
             else Node.name node == name' && name' == name &&
                  Node.alias node == name &&
                  Node.tMem node == fromIntegral tm &&
                  Node.nMem node == nm &&
                  Node.fMem node == fm &&
                  Node.tDsk node == fromIntegral td &&
                  Node.fDsk node == fd &&
                  Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
571
572

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
573
    length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
574

575
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
576
577
    (Text.loadNode defGroupAssoc.
         Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
578
579
580
581
    Just (Node.name n, n)
    -- override failN1 to what loadNode returns by default
    where n = node { Node.failN1 = True, Node.offline = False }

582
testText =
Iustin Pop's avatar
Iustin Pop committed
583
    [ run prop_Text_Load_Instance
Iustin Pop's avatar
Iustin Pop committed
584
585
586
    , run prop_Text_Load_InstanceFail
    , run prop_Text_Load_Node
    , run prop_Text_Load_NodeFail
587
    , run prop_Text_NodeLSIdempotent
588
589
    ]

590
-- ** Node tests
591

Iustin Pop's avatar
Iustin Pop committed
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
prop_Node_setAlias node name =
    Node.name newnode == Node.name node &&
    Node.alias newnode == name
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
    Node.offline newnode == status
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
    Node.xMem newnode == xm
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
    Node.mCpu newnode == mc
    where newnode = Node.setMcpu node mc

610
611
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
612
613
614
615
616
617
prop_Node_addPriFM node inst = Instance.mem inst >= Node.fMem node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailMem -> True
                                 _ -> False
618
    where _types = (node::Node.Node, inst::Instance.Instance)
Iustin Pop's avatar
Iustin Pop committed
619
620
621
622
623
624
625
626
627
628
629
630
631
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst = Instance.dsk inst >= Node.fDsk node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailDisk -> True
                                 _ -> False
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

Iustin Pop's avatar
Iustin Pop committed
632
633
634
635
636
prop_Node_addPriFC node inst (Positive extra) =
    not (Node.failN1 node) ==>
        case Node.addPri node inst'' of
          Types.OpFail Types.FailCPU -> True
          _ -> False
Iustin Pop's avatar
Iustin Pop committed
637
638
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
Iustin Pop's avatar
Iustin Pop committed
639
          inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
640

641
642
-- | Check that an instance add with too high memory or disk will be
-- rejected.
643
prop_Node_addSec node inst pdx =
644
645
    (Instance.mem inst >= (Node.fMem node - Node.rMem node) ||
     Instance.dsk inst >= Node.fDsk node) &&
Iustin Pop's avatar
Iustin Pop committed
646
    not (Node.failN1 node)
Iustin Pop's avatar
Iustin Pop committed
647
    ==> isFailure (Node.addSec node inst pdx)
648
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
649

650
-- | Checks for memory reservation changes.
651
652
prop_Node_rMem inst =
    forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
653
654
    -- ab = auto_balance, nb = non-auto_balance
    -- we use -1 as the primary node of the instance
655
    let inst' = inst { Instance.pNode = -1, Instance.autoBalance = True }
656
        inst_ab = setInstanceSmallerThanNode node inst'
657
        inst_nb = inst_ab { Instance.autoBalance = False }
658
        -- now we have the two instances, identical except the
659
        -- autoBalance attribute
660
661
662
663
664
665
666
667
668
        orig_rmem = Node.rMem node
        inst_idx = Instance.idx inst_ab
        node_add_ab = Node.addSec node inst_ab (-1)
        node_add_nb = Node.addSec node inst_nb (-1)
        node_del_ab = liftM (flip Node.removeSec inst_ab) node_add_ab
        node_del_nb = liftM (flip Node.removeSec inst_nb) node_add_nb
    in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
         (Types.OpGood a_ab, Types.OpGood a_nb,
          Types.OpGood d_ab, Types.OpGood d_nb) ->
669
             printTestCase "Consistency checks failed" $
670
671
672
673
674
675
676
677
678
             Node.rMem a_ab >  orig_rmem &&
             Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
             Node.rMem a_nb == orig_rmem &&
             Node.rMem d_ab == orig_rmem &&
             Node.rMem d_nb == orig_rmem &&
             -- this is not related to rMem, but as good a place to
             -- test as any
             inst_idx `elem` Node.sList a_ab &&
             not (inst_idx `elem` Node.sList d_ab)
679
680
         x -> printTestCase ("Failed to add/remove instances: " ++ show x)
              False
681

682
-- | Check mdsk setting.
Iustin Pop's avatar
Iustin Pop committed
683
684
685
686
687
prop_Node_setMdsk node mx =
    Node.loDsk node' >= 0 &&
    fromIntegral (Node.loDsk node') <= Node.tDsk node &&
    Node.availDisk node' >= 0 &&
    Node.availDisk node' <= Node.fDsk node' &&
Iustin Pop's avatar
Iustin Pop committed
688
689
    fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
    Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
690
691
692
693
694
695
696
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
    Node.delTags (Node.addTags m tags) tags == m
697
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
698
699
700
701

prop_Node_tagMaps_reject tags =
    not (null tags) ==>
    any (\t -> Node.rejectAddTags m [t]) tags
702
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
703

Iustin Pop's avatar
Iustin Pop committed
704
705
706
707
708
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

709
710
711
712
713
714
715

prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
Iustin Pop's avatar
Iustin Pop committed
716
     (null nodes || not (null ng))
717

718
testNode =
Iustin Pop's avatar
Iustin Pop committed
719
720
721
722
723
    [ run prop_Node_setAlias
    , run prop_Node_setOffline
    , run prop_Node_setMcpu
    , run prop_Node_setXmem
    , run prop_Node_addPriFM
Iustin Pop's avatar
Iustin Pop committed
724
725
    , run prop_Node_addPriFD
    , run prop_Node_addPriFC
726
    , run prop_Node_addSec
727
    , run prop_Node_rMem
Iustin Pop's avatar
Iustin Pop committed
728
729
730
    , run prop_Node_setMdsk
    , run prop_Node_tagMaps_idempotent
    , run prop_Node_tagMaps_reject
Iustin Pop's avatar
Iustin Pop committed
731
    , run prop_Node_showField
732
    , run prop_Node_computeGroups
733
    ]
734
735


736
-- ** Cluster tests
737

738
739
-- | Check that the cluster score is close to zero for a homogeneous
-- cluster.
Iustin Pop's avatar
Iustin Pop committed
740
741
prop_Score_Zero node =
    forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
742
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
743
     (Node.tDsk node > 0) && (Node.tMem node > 0)) ==>
744
    let fn = Node.buildPeers node Container.empty
Iustin Pop's avatar
Iustin Pop committed
745
        nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
Iustin Pop's avatar
Iustin Pop committed
746
        nl = Container.fromList nlst
747
748
749
        score = Cluster.compCV nl
    -- we can't say == 0 here as the floating point errors accumulate;
    -- this should be much lower than the default score in CLI.hs
Iustin Pop's avatar
Iustin Pop committed
750
    in score <= 1e-12
751

752
-- | Check that cluster stats are sane.
Iustin Pop's avatar
Iustin Pop committed
753
754
755
prop_CStats_sane node =
    forAll (choose (1, 1024)) $ \count ->
    (not (Node.offline node) && not (Node.failN1 node) &&
756
     (Node.availDisk node > 0) && (Node.availMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
757
758
    let fn = Node.buildPeers node Container.empty
        nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
Iustin Pop's avatar
Iustin Pop committed
759
        nl = Container.fromList nlst
Iustin Pop's avatar
Iustin Pop committed
760
761
762
763
        cstats = Cluster.totalResources nl
    in Cluster.csAdsk cstats >= 0 &&
       Cluster.csAdsk cstats <= Cluster.csFdsk cstats

764
-- | Check that one instance is allocated correctly, without
765
-- rebalances needed.
766
767
768
769
770
771
772
773
774
775
prop_ClusterAlloc_sane node inst =
    forAll (choose (5, 20)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && Node.availDisk node > 0
            && Node.availMem node > 0
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
776
777
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
778
         Types.Bad _ -> False
779
780
         Types.Ok as ->
             case Cluster.asSolutions as of
781
               [] -> False
782
               (xnl, xi, _, cv):[] ->
783
                   let il' = Container.add (Instance.idx xi) xi il
784
                       tbl = Cluster.Table xnl il' cv []
785
                   in not (canBalance tbl True True False)
786
787
788
789
               _ -> False

-- | Checks that on a 2-5 node cluster, we can allocate a random
-- instance spec via tiered allocation (whatever the original instance
790
-- spec), on either one or two nodes.
791
792
793
794
795
796
797
798
799
prop_ClusterCanTieredAlloc node inst =
    forAll (choose (2, 5)) $ \count ->
    forAll (choose (1, 2)) $ \rqnodes ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
800
        allocnodes = Cluster.genAllocNodes defGroupList nl rqnodes True
Iustin Pop's avatar
Iustin Pop committed
801
802
    in case allocnodes >>= \allocnodes' ->
        Cluster.tieredAlloc nl il inst allocnodes' [] [] of
803
         Types.Bad _ -> False
804
805
806
         Types.Ok (_, _, il', ixes, cstats) -> not (null ixes) &&
                                      IntMap.size il' == length ixes &&
                                      length ixes == length cstats
807
808

-- | Checks that on a 4-8 node cluster, once we allocate an instance,
809
-- we can also evacuate it.
810
811
812
813
814
815
816
817
818
prop_ClusterAllocEvac node inst =
    forAll (choose (4, 8)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
819
820
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
821
         Types.Bad _ -> False
822
823
         Types.Ok as ->
             case Cluster.asSolutions as of
824
               [] -> False
825
               (xnl, xi, _, _):[] ->
826
827
                   let sdx = Instance.sNode xi
                       il' = Container.add (Instance.idx xi) xi il
828
                   in case Cluster.tryEvac xnl il' [Instance.idx xi] [sdx] of
829
830
831
832
833
                        Just _ -> True
                        _ -> False
               _ -> False

-- | Check that allocating multiple instances on a cluster, then
834
-- adding an empty node, results in a valid rebalance.
835
836
prop_ClusterAllocBalance =
    forAll (genNode (Just 5) (Just 128)) $ \node ->
837
    forAll (choose (3, 5)) $ \count ->
838
    not (Node.offline node) && not (Node.failN1 node) ==>
839
840
841
    let nl = makeSmallCluster node count
        (hnode, nl') = IntMap.deleteFindMax nl
        il = Container.empty
842
        allocnodes = Cluster.genAllocNodes defGroupList nl' 2 True
843
        i_templ = createInstance Types.unitMem Types.unitDsk Types.unitCpu
Iustin Pop's avatar
Iustin Pop committed
844
845
    in case allocnodes >>= \allocnodes' ->
        Cluster.iterateAlloc nl' il i_templ allocnodes' [] [] of
846
         Types.Bad _ -> False
847
         Types.Ok (_, xnl, il', _, _) ->
848
849
850
                   let ynl = Container.add (Node.idx hnode) hnode xnl
                       cv = Cluster.compCV ynl
                       tbl = Cluster.Table ynl il' cv []
851
                   in canBalance tbl True True False
852

853
-- | Checks consistency.
854
855
856
prop_ClusterCheckConsistency node inst =
  let nl = makeSmallCluster node 3
      [node1, node2, node3] = Container.elems nl
Iustin Pop's avatar
Iustin Pop committed
857
      node3' = node3 { Node.group = 1 }
858
859
860
861
      nl' = Container.add (Node.idx node3') node3' nl
      inst1 = Instance.setBoth inst (Node.idx node1) (Node.idx node2)
      inst2 = Instance.setBoth inst (Node.idx node1) Node.noSecondary
      inst3 = Instance.setBoth inst (Node.idx node1) (Node.idx node3)
Iustin Pop's avatar
Iustin Pop committed
862
      ccheck = Cluster.findSplitInstances nl' . Container.fromList
863
864
865
866
  in null (ccheck [(0, inst1)]) &&
     null (ccheck [(0, inst2)]) &&
     (not . null $ ccheck [(0, inst3)])

867
-- | For now, we only test that we don't lose instances during the split.
868
869
870
871
872
873
874
875
876
prop_ClusterSplitCluster node inst =
  forAll (choose (0, 100)) $ \icnt ->
  let nl = makeSmallCluster node 2
      (nl', il') = foldl (\(ns, is) _ -> assignInstance ns is inst 0 1)
                   (nl, Container.empty) [1..icnt]
      gni = Cluster.splitCluster nl' il'
  in sum (map (Container.size . snd . snd) gni) == icnt &&
     all (\(guuid, (nl'', _)) -> all ((== guuid) . Node.group)
                                 (Container.elems nl'')) gni
877

878
testCluster =
879
    [ run prop_Score_Zero
Iustin Pop's avatar
Iustin Pop committed
880
    , run prop_CStats_sane
881
882
883
884
    , run prop_ClusterAlloc_sane
    , run prop_ClusterCanTieredAlloc
    , run prop_ClusterAllocEvac
    , run prop_ClusterAllocBalance
885
    , run prop_ClusterCheckConsistency
886
    , run prop_ClusterSplitCluster
887
    ]
Iustin Pop's avatar
Iustin Pop committed
888

889
-- ** OpCodes tests
Iustin Pop's avatar
Iustin Pop committed
890

891
-- | Check that opcode serialization is idempotent.
Iustin Pop's avatar
Iustin Pop committed
892
893
894
895
prop_OpCodes_serialization op =
  case J.readJSON (J.showJSON op) of
    J.Error _ -> False
    J.Ok op' -> op == op'
896
  where _types = op::OpCodes.OpCode
Iustin Pop's avatar
Iustin Pop committed
897
898
899
900

testOpCodes =
  [ run prop_OpCodes_serialization
  ]
Iustin Pop's avatar
Iustin Pop committed
901

902
903
904
-- ** Jobs tests

-- | Check that (queued) job\/opcode status serialization is idempotent.
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
prop_OpStatus_serialization os =
  case J.readJSON (J.showJSON os) of
    J.Error _ -> False
    J.Ok os' -> os == os'
  where _types = os::Jobs.OpStatus

prop_JobStatus_serialization js =
  case J.readJSON (J.showJSON js) of
    J.Error _ -> False
    J.Ok js' -> js == js'
  where _types = js::Jobs.JobStatus

testJobs =
  [ run prop_OpStatus_serialization
  , run prop_JobStatus_serialization
  ]

922
-- ** Loader tests
Iustin Pop's avatar
Iustin Pop committed
923
924

prop_Loader_lookupNode ktn inst node =
925
926
  Loader.lookupNode nl inst node == Data.Map.lookup node nl
  where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
927
928

prop_Loader_lookupInstance kti inst =
929
930
931
932
933
934
935
936
  Loader.lookupInstance il inst == Data.Map.lookup inst il
  where il = Data.Map.fromList kti

prop_Loader_assignIndices nodes =
  Data.Map.size nassoc == length nodes &&
  Container.size kt == length nodes &&
  (if not (null nodes)
   then maximum (IntMap.keys kt) == length nodes - 1
Iustin Pop's avatar
Iustin Pop committed
937
   else True)
938
  where (nassoc, kt) = Loader.assignIndices (map (\n -> (Node.name n, n)) nodes)
Iustin Pop's avatar
Iustin Pop committed
939
940

-- | Checks that the number of primary instances recorded on the nodes
941
-- is zero.
Iustin Pop's avatar
Iustin Pop committed
942
prop_Loader_mergeData ns =
Iustin Pop's avatar
Iustin Pop committed
943
  let na = Container.fromList $ map (\n -> (Node.idx n, n)) ns
944
  in case Loader.mergeData [] [] [] []
945
         (Loader.emptyCluster {Loader.cdNodes = na}) of
Iustin Pop's avatar
Iustin Pop committed
946
    Types.Bad _ -> False
947
    Types.Ok (Loader.ClusterData _ nl il _) ->
Iustin Pop's avatar
Iustin Pop committed
948
949
950
      let nodes = Container.elems nl
          instances = Container.elems il
      in (sum . map (length . Node.pList)) nodes == 0 &&
951
         null instances
Iustin Pop's avatar
Iustin Pop committed
952
953
954
955
956
957
958

testLoader =
  [ run prop_Loader_lookupNode
  , run prop_Loader_lookupInstance
  , run prop_Loader_assignIndices
  , run prop_Loader_mergeData
  ]