bootstrap.py 21.3 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
#
#

# Copyright (C) 2006, 2007, 2008 Google Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
# General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
# 02110-1301, USA.


"""Functions to bootstrap a new cluster.

"""

import os
import os.path
import re
29
import logging
30
import time
31
32
33
34
35
36
37

from ganeti import rpc
from ganeti import ssh
from ganeti import utils
from ganeti import errors
from ganeti import config
from ganeti import constants
38
from ganeti import objects
39
from ganeti import ssconf
40
from ganeti import serializer
41
from ganeti import hypervisor
42

43

44
def _InitSSHSetup():
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
  """Setup the SSH configuration for the cluster.

  This generates a dsa keypair for root, adds the pub key to the
  permitted hosts and adds the hostkey to its own known hosts.

  """
  priv_key, pub_key, auth_keys = ssh.GetUserFiles(constants.GANETI_RUNAS)

  for name in priv_key, pub_key:
    if os.path.exists(name):
      utils.CreateBackup(name)
    utils.RemoveFile(name)

  result = utils.RunCmd(["ssh-keygen", "-t", "dsa",
                         "-f", priv_key,
                         "-q", "-N", ""])
  if result.failed:
    raise errors.OpExecError("Could not generate ssh keypair, error %s" %
                             result.output)

65
  utils.AddAuthorizedKey(auth_keys, utils.ReadFile(pub_key))
66
67


68
69
70
71
72
73
74
def GenerateHmacKey(file_name):
  """Writes a new HMAC key.

  @type file_name: str
  @param file_name: Path to output file

  """
75
76
77
78
  utils.WriteFile(file_name, data="%s\n" % utils.GenerateSecret(), mode=0400,
                  backup=True)


79
def GenerateClusterCrypto(new_cluster_cert, new_rapi_cert, new_confd_hmac_key,
80
81
82
83
84
85
86
                          rapi_cert_pem=None):
  """Updates the cluster certificates, keys and secrets.

  @type new_cluster_cert: bool
  @param new_cluster_cert: Whether to generate a new cluster certificate
  @type new_rapi_cert: bool
  @param new_rapi_cert: Whether to generate a new RAPI certificate
87
88
  @type new_confd_hmac_key: bool
  @param new_confd_hmac_key: Whether to generate a new HMAC key
89
90
91
92
  @type rapi_cert_pem: string
  @param rapi_cert_pem: New RAPI certificate in PEM format

  """
93
94
  # noded SSL certificate
  cluster_cert_exists = os.path.exists(constants.NODED_CERT_FILE)
95
96
  if new_cluster_cert or not cluster_cert_exists:
    if cluster_cert_exists:
97
      utils.CreateBackup(constants.NODED_CERT_FILE)
98
99

    logging.debug("Generating new cluster certificate at %s",
100
                  constants.NODED_CERT_FILE)
101
    utils.GenerateSelfSignedSslCert(constants.NODED_CERT_FILE)
102

103
104
105
106
  # confd HMAC key
  if new_confd_hmac_key or not os.path.exists(constants.CONFD_HMAC_KEY):
    logging.debug("Writing new confd HMAC key to %s", constants.CONFD_HMAC_KEY)
    GenerateHmacKey(constants.CONFD_HMAC_KEY)
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122

  # RAPI
  rapi_cert_exists = os.path.exists(constants.RAPI_CERT_FILE)

  if rapi_cert_pem:
    # Assume rapi_pem contains a valid PEM-formatted certificate and key
    logging.debug("Writing RAPI certificate at %s",
                  constants.RAPI_CERT_FILE)
    utils.WriteFile(constants.RAPI_CERT_FILE, data=rapi_cert_pem, backup=True)

  elif new_rapi_cert or not rapi_cert_exists:
    if rapi_cert_exists:
      utils.CreateBackup(constants.RAPI_CERT_FILE)

    logging.debug("Generating new RAPI certificate at %s",
                  constants.RAPI_CERT_FILE)
123
    utils.GenerateSelfSignedSslCert(constants.RAPI_CERT_FILE)
124
125


126
def _InitGanetiServerSetup(master_name):
127
128
129
130
131
132
  """Setup the necessary configuration for the initial node daemon.

  This creates the nodepass file containing the shared password for
  the cluster and also generates the SSL certificate.

  """
133
134
  # Generate cluster secrets
  GenerateClusterCrypto(True, False, False)
135

136
  result = utils.RunCmd([constants.DAEMON_UTIL, "start", constants.NODED])
137
138
139
140
141
  if result.failed:
    raise errors.OpExecError("Could not start the node daemon, command %s"
                             " had exitcode %s and error %s" %
                             (result.cmd, result.exit_code, result.output))

142
143
144
145
146
147
148
  _WaitForNodeDaemon(master_name)


def _WaitForNodeDaemon(node_name):
  """Wait for node daemon to become responsive.

  """
149
  def _CheckNodeDaemon():
150
    result = rpc.RpcRunner.call_version([node_name])[node_name]
151
152
    if result.fail_msg:
      raise utils.RetryAgain()
153

154
155
156
  try:
    utils.Retry(_CheckNodeDaemon, 1.0, 10.0)
  except utils.RetryTimeout:
157
158
159
    raise errors.OpExecError("Node daemon on %s didn't answer queries within"
                             " 10 seconds" % node_name)

160

161
def InitCluster(cluster_name, mac_prefix,
162
                master_netdev, file_storage_dir, candidate_pool_size,
163
164
                secondary_ip=None, vg_name=None, beparams=None,
                nicparams=None, hvparams=None, enabled_hypervisors=None,
165
                modify_etc_hosts=True, modify_ssh_setup=True):
166
167
  """Initialise the cluster.

168
169
170
  @type candidate_pool_size: int
  @param candidate_pool_size: master candidate pool size

171
  """
172
  # TODO: complete the docstring
173
  if config.ConfigWriter.IsCluster():
174
175
    raise errors.OpPrereqError("Cluster is already initialised",
                               errors.ECODE_STATE)
176

177
178
  if not enabled_hypervisors:
    raise errors.OpPrereqError("Enabled hypervisors list must contain at"
179
                               " least one member", errors.ECODE_INVAL)
180
181
182
  invalid_hvs = set(enabled_hypervisors) - constants.HYPER_TYPES
  if invalid_hvs:
    raise errors.OpPrereqError("Enabled hypervisors contains invalid"
183
184
                               " entries: %s" % invalid_hvs,
                               errors.ECODE_INVAL)
185

186
  hostname = utils.GetHostInfo()
187
188
189
190

  if hostname.ip.startswith("127."):
    raise errors.OpPrereqError("This host's IP resolves to the private"
                               " range (%s). Please fix DNS or %s." %
191
192
                               (hostname.ip, constants.ETC_HOSTS),
                               errors.ECODE_ENVIRON)
193

194
  if not utils.OwnIpAddress(hostname.ip):
195
196
    raise errors.OpPrereqError("Inconsistency: this host's name resolves"
                               " to %s,\nbut this ip address does not"
197
198
                               " belong to this host. Aborting." %
                               hostname.ip, errors.ECODE_ENVIRON)
199

200
  clustername = utils.GetHostInfo(utils.HostInfo.NormalizeName(cluster_name))
201
202
203

  if utils.TcpPing(clustername.ip, constants.DEFAULT_NODED_PORT,
                   timeout=5):
204
205
    raise errors.OpPrereqError("Cluster IP already active. Aborting.",
                               errors.ECODE_NOTUNIQUE)
206
207
208

  if secondary_ip:
    if not utils.IsValidIP(secondary_ip):
209
210
      raise errors.OpPrereqError("Invalid secondary ip given",
                                 errors.ECODE_INVAL)
211
    if (secondary_ip != hostname.ip and
212
        not utils.OwnIpAddress(secondary_ip)):
213
214
      raise errors.OpPrereqError("You gave %s as secondary IP,"
                                 " but it does not belong to this host." %
215
                                 secondary_ip, errors.ECODE_ENVIRON)
216
217
  else:
    secondary_ip = hostname.ip
218
219
220
221
222
223
224

  if vg_name is not None:
    # Check if volume group is valid
    vgstatus = utils.CheckVolumeGroupSize(utils.ListVolumeGroups(), vg_name,
                                          constants.MIN_VG_SIZE)
    if vgstatus:
      raise errors.OpPrereqError("Error: %s\nspecify --no-lvm-storage if"
225
226
                                 " you are not using lvm" % vgstatus,
                                 errors.ECODE_INVAL)
227
228
229
230
231

  file_storage_dir = os.path.normpath(file_storage_dir)

  if not os.path.isabs(file_storage_dir):
    raise errors.OpPrereqError("The file storage directory you passed is"
232
                               " not an absolute path.", errors.ECODE_INVAL)
233
234
235
236
237
238

  if not os.path.exists(file_storage_dir):
    try:
      os.makedirs(file_storage_dir, 0750)
    except OSError, err:
      raise errors.OpPrereqError("Cannot create file storage directory"
239
240
                                 " '%s': %s" % (file_storage_dir, err),
                                 errors.ECODE_ENVIRON)
241
242
243

  if not os.path.isdir(file_storage_dir):
    raise errors.OpPrereqError("The file storage directory '%s' is not"
244
245
                               " a directory." % file_storage_dir,
                               errors.ECODE_ENVIRON)
246
247

  if not re.match("^[0-9a-z]{2}:[0-9a-z]{2}:[0-9a-z]{2}$", mac_prefix):
248
249
    raise errors.OpPrereqError("Invalid mac prefix given '%s'" % mac_prefix,
                               errors.ECODE_INVAL)
250
251
252
253
254

  result = utils.RunCmd(["ip", "link", "show", "dev", master_netdev])
  if result.failed:
    raise errors.OpPrereqError("Invalid master netdev given (%s): '%s'" %
                               (master_netdev,
255
                                result.output.strip()), errors.ECODE_INVAL)
256

257
258
259
  dirs = [(constants.RUN_GANETI_DIR, constants.RUN_DIRS_MODE)]
  utils.EnsureDirs(dirs)

260
  utils.ForceDictType(beparams, constants.BES_PARAMETER_TYPES)
261
262
263
  utils.ForceDictType(nicparams, constants.NICS_PARAMETER_TYPES)
  objects.NIC.CheckParameterSyntax(nicparams)

264
265
266
267
268
  # hvparams is a mapping of hypervisor->hvparams dict
  for hv_name, hv_params in hvparams.iteritems():
    utils.ForceDictType(hv_params, constants.HVS_PARAMETER_TYPES)
    hv_class = hypervisor.GetHypervisor(hv_name)
    hv_class.CheckParameterSyntax(hv_params)
269

270
  # set up the inter-node password and certificate
271
  _InitGanetiServerSetup(hostname.name)
272
273

  # set up ssh config and /etc/hosts
274
  sshline = utils.ReadFile(constants.SSH_HOST_RSA_PUB)
275
276
  sshkey = sshline.split(" ")[1]

277
278
279
  if modify_etc_hosts:
    utils.AddHostToEtcHosts(hostname.name)

280
281
  if modify_ssh_setup:
    _InitSSHSetup()
282

283
284
  now = time.time()

285
  # init of cluster config file
286
287
288
289
290
291
292
  cluster_config = objects.Cluster(
    serial_no=1,
    rsahostkeypub=sshkey,
    highest_used_port=(constants.FIRST_DRBD_PORT - 1),
    mac_prefix=mac_prefix,
    volume_group_name=vg_name,
    tcpudp_port_pool=set(),
293
294
295
296
297
    master_node=hostname.name,
    master_ip=clustername.ip,
    master_netdev=master_netdev,
    cluster_name=clustername.name,
    file_storage_dir=file_storage_dir,
298
    enabled_hypervisors=enabled_hypervisors,
299
    beparams={constants.PP_DEFAULT: beparams},
300
    nicparams={constants.PP_DEFAULT: nicparams},
301
    hvparams=hvparams,
302
    candidate_pool_size=candidate_pool_size,
Guido Trotter's avatar
Guido Trotter committed
303
    modify_etc_hosts=modify_etc_hosts,
304
    modify_ssh_setup=modify_ssh_setup,
305
306
307
    ctime=now,
    mtime=now,
    uuid=utils.NewUUID(),
308
309
310
    )
  master_node_config = objects.Node(name=hostname.name,
                                    primary_ip=hostname.ip,
311
                                    secondary_ip=secondary_ip,
312
313
                                    serial_no=1,
                                    master_candidate=True,
314
                                    offline=False, drained=False,
315
                                    )
316
  InitConfig(constants.CONFIG_VERSION, cluster_config, master_node_config)
317
  cfg = config.ConfigWriter()
318
  ssh.WriteKnownHostsFile(cfg, constants.SSH_KNOWN_HOSTS_FILE)
319
  cfg.Update(cfg.GetClusterInfo(), logging.error)
320

Iustin Pop's avatar
Iustin Pop committed
321
322
  # start the master ip
  # TODO: Review rpc call from bootstrap
323
  # TODO: Warn on failed start master
324
  rpc.RpcRunner.call_node_start_master(hostname.name, True, False)
Iustin Pop's avatar
Iustin Pop committed
325

326

Oleksiy Mishchenko's avatar
Oleksiy Mishchenko committed
327
328
def InitConfig(version, cluster_config, master_node_config,
               cfg_file=constants.CLUSTER_CONF_FILE):
Iustin Pop's avatar
Iustin Pop committed
329
330
331
332
333
334
  """Create the initial cluster configuration.

  It will contain the current node, which will also be the master
  node, and no instances.

  @type version: int
Iustin Pop's avatar
Iustin Pop committed
335
336
337
338
339
340
341
342
  @param version: configuration version
  @type cluster_config: L{objects.Cluster}
  @param cluster_config: cluster configuration
  @type master_node_config: L{objects.Node}
  @param master_node_config: master node configuration
  @type cfg_file: string
  @param cfg_file: configuration file path

Iustin Pop's avatar
Iustin Pop committed
343
344
345
346
347
  """
  nodes = {
    master_node_config.name: master_node_config,
    }

348
  now = time.time()
Iustin Pop's avatar
Iustin Pop committed
349
350
351
352
  config_data = objects.ConfigData(version=version,
                                   cluster=cluster_config,
                                   nodes=nodes,
                                   instances={},
353
354
                                   serial_no=1,
                                   ctime=now, mtime=now)
355
356
357
  utils.WriteFile(cfg_file,
                  data=serializer.Dump(config_data.ToDict()),
                  mode=0600)
Oleksiy Mishchenko's avatar
Oleksiy Mishchenko committed
358
359


Iustin Pop's avatar
Iustin Pop committed
360
361
362
363
364
365
366
def FinalizeClusterDestroy(master):
  """Execute the last steps of cluster destroy

  This function shuts down all the daemons, completing the destroy
  begun in cmdlib.LUDestroyOpcode.

  """
367
368
  cfg = config.ConfigWriter()
  modify_ssh_setup = cfg.GetClusterInfo().modify_ssh_setup
369
  result = rpc.RpcRunner.call_node_stop_master(master, True)
370
  msg = result.fail_msg
371
  if msg:
372
    logging.warning("Could not disable the master role: %s", msg)
373
  result = rpc.RpcRunner.call_node_leave_cluster(master, modify_ssh_setup)
374
  msg = result.fail_msg
375
376
377
  if msg:
    logging.warning("Could not shutdown the node daemon and cleanup"
                    " the node: %s", msg)
Iustin Pop's avatar
Iustin Pop committed
378
379


Iustin Pop's avatar
Iustin Pop committed
380
def SetupNodeDaemon(cluster_name, node, ssh_key_check):
381
382
  """Add a node to the cluster.

383
384
385
  This function must be called before the actual opcode, and will ssh
  to the remote node, copy the needed files, and start ganeti-noded,
  allowing the master to do the rest via normal rpc calls.
386

Iustin Pop's avatar
Iustin Pop committed
387
388
389
  @param cluster_name: the cluster name
  @param node: the name of the new node
  @param ssh_key_check: whether to do a strict key check
390
391

  """
Iustin Pop's avatar
Iustin Pop committed
392
  sshrunner = ssh.SshRunner(cluster_name)
393

394
  noded_cert = utils.ReadFile(constants.NODED_CERT_FILE)
395
  rapi_cert = utils.ReadFile(constants.RAPI_CERT_FILE)
396
  confd_hmac_key = utils.ReadFile(constants.CONFD_HMAC_KEY)
397

398
399
400
  # in the base64 pem encoding, neither '!' nor '.' are valid chars,
  # so we use this to detect an invalid certificate; as long as the
  # cert doesn't contain this, the here-document will be correctly
401
402
  # parsed by the shell sequence below. HMAC keys are hexadecimal strings,
  # so the same restrictions apply.
403
  for content in (noded_cert, rapi_cert, confd_hmac_key):
404
405
    if re.search('^!EOF\.', content, re.MULTILINE):
      raise errors.OpExecError("invalid SSL certificate or HMAC key")
406
407
408

  if not noded_cert.endswith("\n"):
    noded_cert += "\n"
409
410
  if not rapi_cert.endswith("\n"):
    rapi_cert += "\n"
411
412
  if not confd_hmac_key.endswith("\n"):
    confd_hmac_key += "\n"
413
414
415
416
417
418
419

  # set up inter-node password and certificate and restarts the node daemon
  # and then connect with ssh to set password and start ganeti-noded
  # note that all the below variables are sanitized at this point,
  # either by being constants or by the checks above
  mycommand = ("umask 077 && "
               "cat > '%s' << '!EOF.' && \n"
420
421
422
               "%s!EOF.\n"
               "cat > '%s' << '!EOF.' && \n"
               "%s!EOF.\n"
423
424
425
               "cat > '%s' << '!EOF.' && \n"
               "%s!EOF.\n"
               "chmod 0400 %s %s %s && "
426
               "%s start %s" %
427
               (constants.NODED_CERT_FILE, noded_cert,
428
                constants.RAPI_CERT_FILE, rapi_cert,
429
                constants.CONFD_HMAC_KEY, confd_hmac_key,
430
                constants.NODED_CERT_FILE, constants.RAPI_CERT_FILE,
431
                constants.CONFD_HMAC_KEY,
432
                constants.DAEMON_UTIL, constants.NODED))
433

434
435
436
437
  result = sshrunner.Run(node, 'root', mycommand, batch=False,
                         ask_key=ssh_key_check,
                         use_cluster_key=False,
                         strict_host_check=ssh_key_check)
438
439
440
441
442
  if result.failed:
    raise errors.OpExecError("Remote command on node %s, error: %s,"
                             " output: %s" %
                             (node, result.fail_reason, result.output))

443
444
  _WaitForNodeDaemon(node)

445

446
def MasterFailover(no_voting=False):
447
448
449
450
451
452
  """Failover the master node.

  This checks that we are not already the master, and will cause the
  current master to cease being master, and the non-master to become
  new master.

453
454
455
456
  @type no_voting: boolean
  @param no_voting: force the operation without remote nodes agreement
                      (dangerous)

457
  """
458
  sstore = ssconf.SimpleStore()
459

460
461
462
  old_master, new_master = ssconf.GetMasterAndMyself(sstore)
  node_list = sstore.GetNodeList()
  mc_list = sstore.GetMasterCandidates()
463
464
465
466
467

  if old_master == new_master:
    raise errors.OpPrereqError("This commands must be run on the node"
                               " where you want the new master to be."
                               " %s is already the master" %
468
                               old_master, errors.ECODE_INVAL)
469

470
471
472
473
474
475
  if new_master not in mc_list:
    mc_no_master = [name for name in mc_list if name != old_master]
    raise errors.OpPrereqError("This node is not among the nodes marked"
                               " as master candidates. Only these nodes"
                               " can become masters. Current list of"
                               " master candidates is:\n"
476
477
                               "%s" % ('\n'.join(mc_no_master)),
                               errors.ECODE_STATE)
478

479
480
481
482
483
484
485
  if not no_voting:
    vote_list = GatherMasterVotes(node_list)

    if vote_list:
      voted_master = vote_list[0][0]
      if voted_master is None:
        raise errors.OpPrereqError("Cluster is inconsistent, most nodes did"
486
                                   " not respond.", errors.ECODE_ENVIRON)
487
488
489
490
491
      elif voted_master != old_master:
        raise errors.OpPrereqError("I have a wrong configuration, I believe"
                                   " the master is %s but the other nodes"
                                   " voted %s. Please resync the configuration"
                                   " of this node." %
492
493
                                   (old_master, voted_master),
                                   errors.ECODE_STATE)
494
495
496
497
  # end checks

  rcode = 0

498
  logging.info("Setting master to %s, old master: %s", new_master, old_master)
499

500
  result = rpc.RpcRunner.call_node_stop_master(old_master, True)
501
  msg = result.fail_msg
502
  if msg:
503
    logging.error("Could not disable the master role on the old master"
504
                 " %s, please disable manually: %s", old_master, msg)
505

Michael Hanselmann's avatar
Michael Hanselmann committed
506
  # Here we have a phase where no master should be running
507

Iustin Pop's avatar
Iustin Pop committed
508
509
510
  # instantiate a real config writer, as we now know we have the
  # configuration data
  cfg = config.ConfigWriter()
511

Iustin Pop's avatar
Iustin Pop committed
512
513
514
515
  cluster_info = cfg.GetClusterInfo()
  cluster_info.master_node = new_master
  # this will also regenerate the ssconf files, since we updated the
  # cluster info
516
  cfg.Update(cluster_info, logging.error)
517

518
  result = rpc.RpcRunner.call_node_start_master(new_master, True, no_voting)
519
  msg = result.fail_msg
520
  if msg:
521
    logging.error("Could not start the master role on the new master"
522
                  " %s, please check: %s", new_master, msg)
523
524
525
    rcode = 1

  return rcode
526
527


528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
def GetMaster():
  """Returns the current master node.

  This is a separate function in bootstrap since it's needed by
  gnt-cluster, and instead of importing directly ssconf, it's better
  to abstract it in bootstrap, where we do use ssconf in other
  functions too.

  """
  sstore = ssconf.SimpleStore()

  old_master, _ = ssconf.GetMasterAndMyself(sstore)

  return old_master


544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
def GatherMasterVotes(node_list):
  """Check the agreement on who is the master.

  This function will return a list of (node, number of votes), ordered
  by the number of votes. Errors will be denoted by the key 'None'.

  Note that the sum of votes is the number of nodes this machine
  knows, whereas the number of entries in the list could be different
  (if some nodes vote for another master).

  We remove ourselves from the list since we know that (bugs aside)
  since we use the same source for configuration information for both
  backend and boostrap, we'll always vote for ourselves.

  @type node_list: list
  @param node_list: the list of nodes to query for master info; the current
Michael Hanselmann's avatar
Michael Hanselmann committed
560
      node will be removed if it is in the list
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
  @rtype: list
  @return: list of (node, votes)

  """
  myself = utils.HostInfo().name
  try:
    node_list.remove(myself)
  except ValueError:
    pass
  if not node_list:
    # no nodes left (eventually after removing myself)
    return []
  results = rpc.RpcRunner.call_master_info(node_list)
  if not isinstance(results, dict):
    # this should not happen (unless internal error in rpc)
    logging.critical("Can't complete rpc call, aborting master startup")
    return [(None, len(node_list))]
  votes = {}
  for node in results:
580
    nres = results[node]
581
    data = nres.payload
582
    msg = nres.fail_msg
583
584
585
586
587
588
589
590
    fail = False
    if msg:
      logging.warning("Error contacting node %s: %s", node, msg)
      fail = True
    elif not isinstance(data, (tuple, list)) or len(data) < 3:
      logging.warning("Invalid data received from node %s: %s", node, data)
      fail = True
    if fail:
591
592
593
594
      if None not in votes:
        votes[None] = 0
      votes[None] += 1
      continue
595
    master_node = data[2]
596
597
598
599
600
601
602
603
604
605
606
    if master_node not in votes:
      votes[master_node] = 0
    votes[master_node] += 1

  vote_list = [v for v in votes.items()]
  # sort first on number of votes then on name, since we want None
  # sorted later if we have the half of the nodes not responding, and
  # half voting all for the same master
  vote_list.sort(key=lambda x: (x[1], x[0]), reverse=True)

  return vote_list