QC.hs 52.2 KB
Newer Older
1
2
{-# LANGUAGE TemplateHaskell #-}

3
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
4
5
6
7
8

-}

{-

Iustin Pop's avatar
Iustin Pop committed
9
Copyright (C) 2009, 2010, 2011, 2012 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

28
module Ganeti.HTools.QC
Iustin Pop's avatar
Iustin Pop committed
29
30
31
32
33
34
35
36
37
38
39
40
  ( testUtils
  , testPeerMap
  , testContainer
  , testInstance
  , testNode
  , testText
  , testOpCodes
  , testJobs
  , testCluster
  , testLoader
  , testTypes
  ) where
41
42

import Test.QuickCheck
Iustin Pop's avatar
Iustin Pop committed
43
import Data.List (findIndex, intercalate, nub, isPrefixOf)
44
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
45
46
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
47
import qualified Data.Map
48
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
49
import qualified Ganeti.OpCodes as OpCodes
50
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
51
import qualified Ganeti.Luxi
52
53
54
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
55
import qualified Ganeti.HTools.ExtLoader
56
57
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
58
import qualified Ganeti.HTools.JSON as JSON
59
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
60
import qualified Ganeti.HTools.Luxi
61
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
62
import qualified Ganeti.HTools.Group as Group
63
import qualified Ganeti.HTools.PeerMap as PeerMap
64
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
65
import qualified Ganeti.HTools.Simu
66
67
68
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
69
import qualified Ganeti.HTools.Version
70
import qualified Ganeti.Constants as C
71

72
73
74
75
76
import qualified Ganeti.HTools.Program.Hail
import qualified Ganeti.HTools.Program.Hbal
import qualified Ganeti.HTools.Program.Hscan
import qualified Ganeti.HTools.Program.Hspace

77
import Ganeti.HTools.QCHelper (testSuite)
Iustin Pop's avatar
Iustin Pop committed
78

79
80
-- * Constants

81
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
82
83
84
maxMem :: Int
maxMem = 1024 * 1024

85
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
86
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
87
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
88

89
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
90
91
92
maxCpu :: Int
maxCpu = 1024

93
94
95
96
-- | All disk templates (used later)
allDiskTemplates :: [Types.DiskTemplate]
allDiskTemplates = [minBound..maxBound]

97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
-- | Null iPolicy, and by null we mean very liberal.
nullIPolicy = Types.IPolicy
  { Types.iPolicyMinSpec = Types.ISpec { Types.iSpecMemorySize = 0
                                       , Types.iSpecCpuCount   = 0
                                       , Types.iSpecDiskSize   = 0
                                       , Types.iSpecDiskCount  = 0
                                       , Types.iSpecNicCount   = 0
                                       }
  , Types.iPolicyMaxSpec = Types.ISpec { Types.iSpecMemorySize = maxBound
                                       , Types.iSpecCpuCount   = maxBound
                                       , Types.iSpecDiskSize   = maxBound
                                       , Types.iSpecDiskCount  = C.maxDisks
                                       , Types.iSpecNicCount   = C.maxNics
                                       }
  , Types.iPolicyStdSpec = Types.ISpec { Types.iSpecMemorySize = Types.unitMem
                                       , Types.iSpecCpuCount   = Types.unitCpu
                                       , Types.iSpecDiskSize   = Types.unitDsk
                                       , Types.iSpecDiskCount  = 1
                                       , Types.iSpecNicCount   = 1
                                       }
  , Types.iPolicyDiskTemplates = [Types.DTDrbd8, Types.DTPlain]
  }


Iustin Pop's avatar
Iustin Pop committed
121
122
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
Iustin Pop's avatar
Iustin Pop committed
123
             Group.create "default" Types.defaultGroupID Types.AllocPreferred
124
                  nullIPolicy
Iustin Pop's avatar
Iustin Pop committed
125
126

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
127
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
128
129
130
131

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

132
133
-- * Helper functions

134
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
135
136
137
138
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

Iustin Pop's avatar
Iustin Pop committed
139
140
141
142
143
144
145
-- | Checks for equality with proper annotation.
(==?) :: (Show a, Eq a) => a -> a -> Property
(==?) x y = printTestCase
            ("Expected equality, but '" ++
             show x ++ "' /= '" ++ show y ++ "'") (x == y)
infix 3 ==?

Iustin Pop's avatar
Iustin Pop committed
146
147
148
149
-- | Show a message and fail the test.
failTest :: String -> Property
failTest msg = printTestCase msg False

150
-- | Update an instance to be smaller than a node.
151
setInstanceSmallerThanNode node inst =
Iustin Pop's avatar
Iustin Pop committed
152
153
154
155
  inst { Instance.mem = Node.availMem node `div` 2
       , Instance.dsk = Node.availDisk node `div` 2
       , Instance.vcpus = Node.availCpu node `div` 2
       }
156

157
158
159
160
161
162
-- | Check if an instance is smaller than a node.
isInstanceSmallerThanNode node inst =
  Instance.mem inst   <= Node.availMem node `div` 2 &&
  Instance.dsk inst   <= Node.availDisk node `div` 2 &&
  Instance.vcpus inst <= Node.availCpu node `div` 2

163
-- | Create an instance given its spec.
164
createInstance mem dsk vcpus =
Iustin Pop's avatar
Iustin Pop committed
165
166
  Instance.create "inst-unnamed" mem dsk vcpus Types.Running [] True (-1) (-1)
    Types.DTDrbd8
167

168
-- | Create a small cluster by repeating a node spec.
169
170
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
171
172
173
174
175
176
177
  let origname = Node.name node
      origalias = Node.alias node
      nodes = map (\idx -> node { Node.name = origname ++ "-" ++ show idx
                                , Node.alias = origalias ++ "-" ++ show idx })
              [1..count]
      fn = flip Node.buildPeers Container.empty
      namelst = map (\n -> (Node.name n, fn n)) nodes
Iustin Pop's avatar
Iustin Pop committed
178
179
      (_, nlst) = Loader.assignIndices namelst
  in nlst
180

Iustin Pop's avatar
Iustin Pop committed
181
182
183
184
185
186
187
-- | Make a small cluster, both nodes and instances.
makeSmallEmptyCluster :: Node.Node -> Int -> Instance.Instance
                      -> (Node.List, Instance.List, Instance.Instance)
makeSmallEmptyCluster node count inst =
  (makeSmallCluster node count, Container.empty,
   setInstanceSmallerThanNode node inst)

188
-- | Checks if a node is "big" enough.
189
190
isNodeBig :: Int -> Node.Node -> Bool
isNodeBig size node = Node.availDisk node > size * Types.unitDsk
191
192
193
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

194
195
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
196

197
-- | Assigns a new fresh instance to a cluster; this is not
198
-- allocation, so no resource checks are done.
199
200
201
202
203
204
205
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
Iustin Pop's avatar
Iustin Pop committed
206
207
                  then 0
                  else fst (Container.findMax il) + 1
208
209
210
211
212
213
214
215
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

216
217
218
219
220
221
222
-- | Generates a list of a given size with non-duplicate elements.
genUniquesList :: (Eq a, Arbitrary a) => Int -> Gen [a]
genUniquesList cnt =
  foldM (\lst _ -> do
           newelem <- arbitrary `suchThat` (`notElem` lst)
           return (newelem:lst)) [] [1..cnt]

223
224
-- * Arbitrary instances

225
-- | Defines a DNS name.
226
newtype DNSChar = DNSChar { dnsGetChar::Char }
227

228
instance Arbitrary DNSChar where
Iustin Pop's avatar
Iustin Pop committed
229
230
231
  arbitrary = do
    x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
    return (DNSChar x)
232

233
-- | Generates a single name component.
234
235
236
237
238
239
getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)

240
-- | Generates an entire FQDN.
241
242
243
getFQDN :: Gen String
getFQDN = do
  ncomps <- choose (1, 4)
244
245
  names <- mapM (const getName) [1..ncomps::Int]
  return $ intercalate "." names
246

247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
-- | Defines a tag type.
newtype TagChar = TagChar { tagGetChar :: Char }

-- | All valid tag chars. This doesn't need to match _exactly_
-- Ganeti's own tag regex, just enough for it to be close.
tagChar :: [Char]
tagChar = ['a'..'z'] ++ ['A'..'Z'] ++ ['0'..'9'] ++ ".+*/:@-"

instance Arbitrary TagChar where
  arbitrary = do
    c <- elements tagChar
    return (TagChar c)

-- | Generates a tag
genTag :: Gen [TagChar]
genTag = do
  -- the correct value would be C.maxTagLen, but that's way too
  -- verbose in unittests, and at the moment I don't see any possible
  -- bugs with longer tags and the way we use tags in htools
  n <- choose (1, 10)
  vector n

-- | Generates a list of tags (correctly upper bounded).
genTags :: Gen [String]
genTags = do
  -- the correct value would be C.maxTagsPerObj, but per the comment
  -- in genTag, we don't use tags enough in htools to warrant testing
  -- such big values
  n <- choose (0, 10::Int)
  tags <- mapM (const genTag) [1..n]
  return $ map (map tagGetChar) tags

279
instance Arbitrary Types.InstanceStatus where
280
    arbitrary = elements [minBound..maxBound]
281

282
283
-- let's generate a random instance
instance Arbitrary Instance.Instance where
Iustin Pop's avatar
Iustin Pop committed
284
285
286
287
288
289
290
291
292
293
  arbitrary = do
    name <- getFQDN
    mem <- choose (0, maxMem)
    dsk <- choose (0, maxDsk)
    run_st <- arbitrary
    pn <- arbitrary
    sn <- arbitrary
    vcpus <- choose (0, maxCpu)
    return $ Instance.create name mem dsk vcpus run_st [] True pn sn
              Types.DTDrbd8
294

295
296
297
298
299
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
300
301
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
Iustin Pop's avatar
Iustin Pop committed
302
303
304
305
306
        case min_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (0, 0, 0)
307
      (top_mem, top_dsk, top_cpu)  =
Iustin Pop's avatar
Iustin Pop committed
308
309
310
311
312
        case max_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (maxMem, maxDsk, maxCpu)
313
314
315
316
317
318
319
320
321
322
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
Iustin Pop's avatar
Iustin Pop committed
323
324
      n' = Node.setPolicy nullIPolicy n
  return $ Node.buildPeers n' Container.empty
325

326
327
328
329
330
331
332
333
334
-- | Helper function to generate a sane node.
genOnlineNode :: Gen Node.Node
genOnlineNode = do
  arbitrary `suchThat` (\n -> not (Node.offline n) &&
                              not (Node.failN1 n) &&
                              Node.availDisk n > 0 &&
                              Node.availMem n > 0 &&
                              Node.availCpu n > 0)

335
336
-- and a random node
instance Arbitrary Node.Node where
Iustin Pop's avatar
Iustin Pop committed
337
  arbitrary = genNode Nothing Nothing
338

Iustin Pop's avatar
Iustin Pop committed
339
340
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
341
  arbitrary = elements [minBound..maxBound]
Iustin Pop's avatar
Iustin Pop committed
342
343
344
345
346
347
348
349

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
Iustin Pop's avatar
Iustin Pop committed
350
351
352
353
354
355
356
357
358
359
360
361
362
    case op_id of
      "OP_TEST_DELAY" ->
        liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
      "OP_INSTANCE_REPLACE_DISKS" ->
        liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
          arbitrary arbitrary arbitrary
      "OP_INSTANCE_FAILOVER" ->
        liftM3 OpCodes.OpInstanceFailover arbitrary arbitrary
          arbitrary
      "OP_INSTANCE_MIGRATE" ->
        liftM5 OpCodes.OpInstanceMigrate arbitrary arbitrary
          arbitrary arbitrary arbitrary
      _ -> fail "Wrong opcode"
Iustin Pop's avatar
Iustin Pop committed
363

364
365
366
367
368
369
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

370
371
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
Iustin Pop's avatar
Iustin Pop committed
372
373
374
  arbitrary = do
    v <- choose (0, 1)
    return $ SmallRatio v
375

376
377
378
379
380
381
instance Arbitrary Types.AllocPolicy where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Types.DiskTemplate where
  arbitrary = elements [minBound..maxBound]

382
instance Arbitrary Types.FailMode where
Iustin Pop's avatar
Iustin Pop committed
383
  arbitrary = elements [minBound..maxBound]
384

385
386
387
instance Arbitrary Types.EvacMode where
  arbitrary = elements [minBound..maxBound]

388
instance Arbitrary a => Arbitrary (Types.OpResult a) where
Iustin Pop's avatar
Iustin Pop committed
389
  arbitrary = arbitrary >>= \c ->
Iustin Pop's avatar
Iustin Pop committed
390
391
392
              if c
                then liftM Types.OpGood arbitrary
                else liftM Types.OpFail arbitrary
393

394
395
instance Arbitrary Types.ISpec where
  arbitrary = do
396
    mem_s <- arbitrary::Gen (NonNegative Int)
397
398
    dsk_c <- arbitrary::Gen (NonNegative Int)
    dsk_s <- arbitrary::Gen (NonNegative Int)
399
400
401
402
    cpu_c <- arbitrary::Gen (NonNegative Int)
    nic_c <- arbitrary::Gen (NonNegative Int)
    return Types.ISpec { Types.iSpecMemorySize = fromIntegral mem_s
                       , Types.iSpecCpuCount   = fromIntegral cpu_c
403
404
                       , Types.iSpecDiskSize   = fromIntegral dsk_s
                       , Types.iSpecDiskCount  = fromIntegral dsk_c
405
                       , Types.iSpecNicCount   = fromIntegral nic_c
406
407
                       }

408
409
410
411
412
413
414
415
416
417
418
419
420
421
-- | Generates an ispec bigger than the given one.
genBiggerISpec :: Types.ISpec -> Gen Types.ISpec
genBiggerISpec imin = do
  mem_s <- choose (Types.iSpecMemorySize imin, maxBound)
  dsk_c <- choose (Types.iSpecDiskCount imin, maxBound)
  dsk_s <- choose (Types.iSpecDiskSize imin, maxBound)
  cpu_c <- choose (Types.iSpecCpuCount imin, maxBound)
  nic_c <- choose (Types.iSpecNicCount imin, maxBound)
  return Types.ISpec { Types.iSpecMemorySize = fromIntegral mem_s
                     , Types.iSpecCpuCount   = fromIntegral cpu_c
                     , Types.iSpecDiskSize   = fromIntegral dsk_s
                     , Types.iSpecDiskCount  = fromIntegral dsk_c
                     , Types.iSpecNicCount   = fromIntegral nic_c
                     }
422
423
424
425

instance Arbitrary Types.IPolicy where
  arbitrary = do
    imin <- arbitrary
426
427
428
429
    istd <- genBiggerISpec imin
    imax <- genBiggerISpec istd
    num_tmpl <- choose (0, length allDiskTemplates)
    dts  <- genUniquesList num_tmpl
430
431
432
433
434
435
    return Types.IPolicy { Types.iPolicyMinSpec = imin
                         , Types.iPolicyStdSpec = istd
                         , Types.iPolicyMaxSpec = imax
                         , Types.iPolicyDiskTemplates = dts
                         }

436
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
437

438
439
440
441
-- ** Utils tests

-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
442
prop_Utils_commaJoinSplit =
Iustin Pop's avatar
Iustin Pop committed
443
  forAll (arbitrary `suchThat`
Iustin Pop's avatar
Iustin Pop committed
444
          (\l -> l /= [""] && all (notElem ',') l )) $ \lst ->
Iustin Pop's avatar
Iustin Pop committed
445
  Utils.sepSplit ',' (Utils.commaJoin lst) ==? lst
Iustin Pop's avatar
Iustin Pop committed
446

447
-- | Split and join should always be idempotent.
Iustin Pop's avatar
Iustin Pop committed
448
prop_Utils_commaSplitJoin s =
Iustin Pop's avatar
Iustin Pop committed
449
  Utils.commaJoin (Utils.sepSplit ',' s) ==? s
450

451
-- | fromObjWithDefault, we test using the Maybe monad and an integer
452
-- value.
453
prop_Utils_fromObjWithDefault def_value random_key =
Iustin Pop's avatar
Iustin Pop committed
454
  -- a missing key will be returned with the default
455
  JSON.fromObjWithDefault [] random_key def_value == Just def_value &&
Iustin Pop's avatar
Iustin Pop committed
456
  -- a found key will be returned as is, not with default
457
  JSON.fromObjWithDefault [(random_key, J.showJSON def_value)]
Iustin Pop's avatar
Iustin Pop committed
458
459
       random_key (def_value+1) == Just def_value
    where _types = def_value :: Integer
460

461
-- | Test that functional if' behaves like the syntactic sugar if.
Iustin Pop's avatar
Iustin Pop committed
462
463
prop_Utils_if'if :: Bool -> Int -> Int -> Gen Prop
prop_Utils_if'if cnd a b =
Iustin Pop's avatar
Iustin Pop committed
464
  Utils.if' cnd a b ==? if cnd then a else b
465

Guido Trotter's avatar
Guido Trotter committed
466
-- | Test basic select functionality
Iustin Pop's avatar
Iustin Pop committed
467
468
469
470
prop_Utils_select :: Int      -- ^ Default result
                  -> [Int]    -- ^ List of False values
                  -> [Int]    -- ^ List of True values
                  -> Gen Prop -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
471
prop_Utils_select def lst1 lst2 =
Iustin Pop's avatar
Iustin Pop committed
472
  Utils.select def (flist ++ tlist) ==? expectedresult
Iustin Pop's avatar
Iustin Pop committed
473
474
475
    where expectedresult = Utils.if' (null lst2) def (head lst2)
          flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
476
477

-- | Test basic select functionality with undefined default
Iustin Pop's avatar
Iustin Pop committed
478
prop_Utils_select_undefd :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
479
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
480
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
481
prop_Utils_select_undefd lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
482
  Utils.select undefined (flist ++ tlist) ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
483
484
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
485
486

-- | Test basic select functionality with undefined list values
Iustin Pop's avatar
Iustin Pop committed
487
prop_Utils_select_undefv :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
488
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
489
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
490
prop_Utils_select_undefv lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
491
  Utils.select undefined cndlist ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
492
493
494
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
          cndlist = flist ++ tlist ++ [undefined]
495

Iustin Pop's avatar
Iustin Pop committed
496
prop_Utils_parseUnit (NonNegative n) =
Iustin Pop's avatar
Iustin Pop committed
497
498
499
500
501
502
503
504
505
506
  Utils.parseUnit (show n) == Types.Ok n &&
  Utils.parseUnit (show n ++ "m") == Types.Ok n &&
  (case Utils.parseUnit (show n ++ "M") of
     Types.Ok m -> if n > 0
                     then m < n  -- for positive values, X MB is < than X MiB
                     else m == 0 -- but for 0, 0 MB == 0 MiB
     Types.Bad _ -> False) &&
  Utils.parseUnit (show n ++ "g") == Types.Ok (n*1024) &&
  Utils.parseUnit (show n ++ "t") == Types.Ok (n*1048576) &&
  Types.isBad (Utils.parseUnit (show n ++ "x")::Types.Result Int)
Iustin Pop's avatar
Iustin Pop committed
507
    where _types = n::Int
Iustin Pop's avatar
Iustin Pop committed
508

509
-- | Test list for the Utils module.
510
testSuite "Utils"
Iustin Pop's avatar
Iustin Pop committed
511
512
513
514
515
516
517
518
519
            [ 'prop_Utils_commaJoinSplit
            , 'prop_Utils_commaSplitJoin
            , 'prop_Utils_fromObjWithDefault
            , 'prop_Utils_if'if
            , 'prop_Utils_select
            , 'prop_Utils_select_undefd
            , 'prop_Utils_select_undefv
            , 'prop_Utils_parseUnit
            ]
520

521
522
523
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
524
prop_PeerMap_addIdempotent pmap key em =
Iustin Pop's avatar
Iustin Pop committed
525
  fn puniq ==? fn (fn puniq)
526
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
527
528
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
529
          puniq = PeerMap.accumArray const pmap
530

531
-- | Make sure remove is idempotent.
532
prop_PeerMap_removeIdempotent pmap key =
Iustin Pop's avatar
Iustin Pop committed
533
  fn puniq ==? fn (fn puniq)
534
535
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
536
537
          puniq = PeerMap.accumArray const pmap

538
-- | Make sure a missing item returns 0.
539
prop_PeerMap_findMissing pmap key =
Iustin Pop's avatar
Iustin Pop committed
540
  PeerMap.find key (PeerMap.remove key puniq) ==? 0
541
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
542
543
          puniq = PeerMap.accumArray const pmap

544
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
545
prop_PeerMap_addFind pmap key em =
Iustin Pop's avatar
Iustin Pop committed
546
  PeerMap.find key (PeerMap.add key em puniq) ==? em
547
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
548
                    key::PeerMap.Key, em::PeerMap.Elem)
549
          puniq = PeerMap.accumArray const pmap
550

551
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
552
prop_PeerMap_maxElem pmap =
Iustin Pop's avatar
Iustin Pop committed
553
  PeerMap.maxElem puniq ==? if null puniq then 0
Iustin Pop's avatar
Iustin Pop committed
554
                              else (maximum . snd . unzip) puniq
555
    where _types = pmap::PeerMap.PeerMap
556
557
          puniq = PeerMap.accumArray const pmap

558
-- | List of tests for the PeerMap module.
559
testSuite "PeerMap"
Iustin Pop's avatar
Iustin Pop committed
560
561
562
563
564
565
            [ 'prop_PeerMap_addIdempotent
            , 'prop_PeerMap_removeIdempotent
            , 'prop_PeerMap_maxElem
            , 'prop_PeerMap_addFind
            , 'prop_PeerMap_findMissing
            ]
566

567
-- ** Container tests
568

Iustin Pop's avatar
Iustin Pop committed
569
570
-- we silence the following due to hlint bug fixed in later versions
{-# ANN prop_Container_addTwo "HLint: ignore Avoid lambda" #-}
571
prop_Container_addTwo cdata i1 i2 =
Iustin Pop's avatar
Iustin Pop committed
572
573
  fn i1 i2 cont == fn i2 i1 cont &&
  fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
574
575
576
577
578
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

579
580
581
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
Iustin Pop's avatar
Iustin Pop committed
582
  in Container.nameOf nl (Node.idx fnode) ==? Node.name fnode
583

584
-- | We test that in a cluster, given a random node, we can find it by
585
-- its name and alias, as long as all names and aliases are unique,
586
-- and that we fail to find a non-existing name.
587
prop_Container_findByName node =
588
589
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
590
591
592
593
  forAll (genUniquesList (cnt * 2)) $ \ allnames ->
  forAll (arbitrary `suchThat` (`notElem` allnames)) $ \ othername ->
  let names = zip (take cnt allnames) (drop cnt allnames)
      nl = makeSmallCluster node cnt
594
595
596
597
598
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
599
      nl' = Container.fromList nodes'
600
601
602
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
Iustin Pop's avatar
Iustin Pop committed
603
     isNothing (Container.findByName nl' othername)
604

605
testSuite "Container"
Iustin Pop's avatar
Iustin Pop committed
606
607
608
609
            [ 'prop_Container_addTwo
            , 'prop_Container_nameOf
            , 'prop_Container_findByName
            ]
610

611
612
-- ** Instance tests

613
614
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
615
prop_Instance_creat inst =
Iustin Pop's avatar
Iustin Pop committed
616
  Instance.name inst ==? Instance.alias inst
Iustin Pop's avatar
Iustin Pop committed
617

618
prop_Instance_setIdx inst idx =
Iustin Pop's avatar
Iustin Pop committed
619
  Instance.idx (Instance.setIdx inst idx) ==? idx
620
621
622
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
623
624
  Instance.name newinst == name &&
  Instance.alias newinst == name
Iustin Pop's avatar
Iustin Pop committed
625
626
627
628
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
Iustin Pop's avatar
Iustin Pop committed
629
630
  Instance.name newinst == Instance.name inst &&
  Instance.alias newinst == name
631
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
632
          newinst = Instance.setAlias inst name
633
634

prop_Instance_setPri inst pdx =
Iustin Pop's avatar
Iustin Pop committed
635
  Instance.pNode (Instance.setPri inst pdx) ==? pdx
636
637
638
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
Iustin Pop's avatar
Iustin Pop committed
639
  Instance.sNode (Instance.setSec inst sdx) ==? sdx
640
641
642
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
Iustin Pop's avatar
Iustin Pop committed
643
  Instance.pNode si == pdx && Instance.sNode si == sdx
644
645
646
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
647
prop_Instance_shrinkMG inst =
Iustin Pop's avatar
Iustin Pop committed
648
649
650
651
  Instance.mem inst >= 2 * Types.unitMem ==>
    case Instance.shrinkByType inst Types.FailMem of
      Types.Ok inst' -> Instance.mem inst' == Instance.mem inst - Types.unitMem
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
652
653

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
654
  forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
Iustin Pop's avatar
Iustin Pop committed
655
656
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
657
658

prop_Instance_shrinkCG inst =
Iustin Pop's avatar
Iustin Pop committed
659
660
661
662
663
  Instance.vcpus inst >= 2 * Types.unitCpu ==>
    case Instance.shrinkByType inst Types.FailCPU of
      Types.Ok inst' ->
        Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
664
665

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
666
  forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
Iustin Pop's avatar
Iustin Pop committed
667
668
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
669
670

prop_Instance_shrinkDG inst =
Iustin Pop's avatar
Iustin Pop committed
671
672
673
674
675
  Instance.dsk inst >= 2 * Types.unitDsk ==>
    case Instance.shrinkByType inst Types.FailDisk of
      Types.Ok inst' ->
        Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
676
677

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
678
  forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
Iustin Pop's avatar
Iustin Pop committed
679
680
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
681
682

prop_Instance_setMovable inst m =
Iustin Pop's avatar
Iustin Pop committed
683
  Instance.movable inst' ==? m
684
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
685

686
testSuite "Instance"
Iustin Pop's avatar
Iustin Pop committed
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
            [ 'prop_Instance_creat
            , 'prop_Instance_setIdx
            , 'prop_Instance_setName
            , 'prop_Instance_setAlias
            , 'prop_Instance_setPri
            , 'prop_Instance_setSec
            , 'prop_Instance_setBoth
            , 'prop_Instance_shrinkMG
            , 'prop_Instance_shrinkMF
            , 'prop_Instance_shrinkCG
            , 'prop_Instance_shrinkCF
            , 'prop_Instance_shrinkDG
            , 'prop_Instance_shrinkDF
            , 'prop_Instance_setMovable
            ]
Iustin Pop's avatar
Iustin Pop committed
702

703
704
-- ** Text backend tests

Iustin Pop's avatar
Iustin Pop committed
705
706
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
707
708
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
709
                        (NonNegative pdx) (NonNegative sdx) autobal dt =
Iustin Pop's avatar
Iustin Pop committed
710
711
712
713
714
715
  pnode /= snode && pdx /= sdx ==>
  let vcpus_s = show vcpus
      dsk_s = show dsk
      mem_s = show mem
      status_s = Types.instanceStatusToRaw status
      ndx = if null snode
Iustin Pop's avatar
Iustin Pop committed
716
              then [(pnode, pdx)]
717
              else [(pnode, pdx), (snode, sdx)]
Iustin Pop's avatar
Iustin Pop committed
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
      nl = Data.Map.fromList ndx
      tags = ""
      sbal = if autobal then "Y" else "N"
      sdt = Types.diskTemplateToRaw dt
      inst = Text.loadInst nl
             [name, mem_s, dsk_s, vcpus_s, status_s,
              sbal, pnode, snode, sdt, tags]
      fail1 = Text.loadInst nl
              [name, mem_s, dsk_s, vcpus_s, status_s,
               sbal, pnode, pnode, tags]
      _types = ( name::String, mem::Int, dsk::Int
               , vcpus::Int, status::Types.InstanceStatus
               , snode::String
               , autobal::Bool)
  in case inst of
Iustin Pop's avatar
Iustin Pop committed
733
       Types.Bad msg -> failTest $ "Failed to load instance: " ++ msg
Iustin Pop's avatar
Iustin Pop committed
734
735
736
737
738
739
740
741
742
743
744
       Types.Ok (_, i) -> printTestCase "Mismatch in some field while\
                                        \ loading the instance" $
               Instance.name i == name &&
               Instance.vcpus i == vcpus &&
               Instance.mem i == mem &&
               Instance.pNode i == pdx &&
               Instance.sNode i == (if null snode
                                      then Node.noSecondary
                                      else sdx) &&
               Instance.autoBalance i == autobal &&
               Types.isBad fail1
Iustin Pop's avatar
Iustin Pop committed
745
746

prop_Text_Load_InstanceFail ktn fields =
Iustin Pop's avatar
Iustin Pop committed
747
  length fields /= 10 ==>
Iustin Pop's avatar
Iustin Pop committed
748
    case Text.loadInst nl fields of
Iustin Pop's avatar
Iustin Pop committed
749
      Types.Ok _ -> failTest "Managed to load instance from invalid data"
750
751
      Types.Bad msg -> printTestCase ("Unrecognised error message: " ++ msg) $
                       "Invalid/incomplete instance data: '" `isPrefixOf` msg
752
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
753
754

prop_Text_Load_Node name tm nm fm td fd tc fo =
Iustin Pop's avatar
Iustin Pop committed
755
756
757
758
759
760
761
762
763
764
  let conv v = if v < 0
                 then "?"
                 else show v
      tm_s = conv tm
      nm_s = conv nm
      fm_s = conv fm
      td_s = conv td
      fd_s = conv fd
      tc_s = conv tc
      fo_s = if fo
Iustin Pop's avatar
Iustin Pop committed
765
766
               then "Y"
               else "N"
Iustin Pop's avatar
Iustin Pop committed
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
      any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
      gid = Group.uuid defGroup
  in case Text.loadNode defGroupAssoc
       [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
       Nothing -> False
       Just (name', node) ->
         if fo || any_broken
           then Node.offline node
           else Node.name node == name' && name' == name &&
                Node.alias node == name &&
                Node.tMem node == fromIntegral tm &&
                Node.nMem node == nm &&
                Node.fMem node == fm &&
                Node.tDsk node == fromIntegral td &&
                Node.fDsk node == fd &&
                Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
783
784

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
785
  length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
786

787
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
788
789
790
  (Text.loadNode defGroupAssoc.
       Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
  Just (Node.name n, n)
791
    -- override failN1 to what loadNode returns by default
Iustin Pop's avatar
Iustin Pop committed
792
793
    where n = node { Node.failN1 = True, Node.offline = False
                   , Node.iPolicy = Types.defIPolicy }
794

795
796
797
prop_Text_ISpecIdempotent ispec =
  case Text.loadISpec "dummy" . Utils.sepSplit ',' .
       Text.serializeISpec $ ispec of
Iustin Pop's avatar
Iustin Pop committed
798
    Types.Bad msg -> failTest $ "Failed to load ispec: " ++ msg
799
800
801
802
803
    Types.Ok ispec' -> ispec ==? ispec'

prop_Text_IPolicyIdempotent ipol =
  case Text.loadIPolicy . Utils.sepSplit '|' $
       Text.serializeIPolicy owner ipol of
Iustin Pop's avatar
Iustin Pop committed
804
    Types.Bad msg -> failTest $ "Failed to load ispec: " ++ msg
805
806
807
    Types.Ok res -> (owner, ipol) ==? res
  where owner = "dummy"

808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
-- | This property, while being in the text tests, does more than just
-- test end-to-end the serialisation and loading back workflow; it
-- also tests the Loader.mergeData and the actuall
-- Cluster.iterateAlloc (for well-behaving w.r.t. instance
-- allocations, not for the business logic). As such, it's a quite
-- complex and slow test, and that's the reason we restrict it to
-- small cluster sizes.
prop_Text_CreateSerialise =
  forAll genTags $ \ctags ->
  forAll (choose (1, 2)) $ \reqnodes ->
  forAll (choose (1, 20)) $ \maxiter ->
  forAll (choose (2, 10)) $ \count ->
  forAll genOnlineNode $ \node ->
  forAll (arbitrary `suchThat` isInstanceSmallerThanNode node) $ \inst ->
  let inst' = Instance.setMovable inst $ Utils.if' (reqnodes == 2) True False
      nl = makeSmallCluster node count
  in case Cluster.genAllocNodes defGroupList nl reqnodes True >>= \allocn ->
     Cluster.iterateAlloc nl Container.empty (Just maxiter) inst' allocn [] []
     of
Iustin Pop's avatar
Iustin Pop committed
827
       Types.Bad msg -> failTest $ "Failed to allocate: " ++ msg
828
829
830
831
832
833
834
       Types.Ok (_, _, _, [], _) -> printTestCase
                                    "Failed to allocate: no allocations" False
       Types.Ok (_, nl', il', _, _) ->
         let cdata = Loader.ClusterData defGroupList nl' il' ctags
                     Types.defIPolicy
             saved = Text.serializeCluster cdata
         in case Text.parseData saved >>= Loader.mergeData [] [] [] [] of
Iustin Pop's avatar
Iustin Pop committed
835
              Types.Bad msg -> failTest $ "Failed to load/merge: " ++ msg
836
837
838
839
              Types.Ok (Loader.ClusterData gl2 nl2 il2 ctags2 cpol2) ->
                ctags ==? ctags2 .&&.
                Types.defIPolicy ==? cpol2 .&&.
                il' ==? il2 .&&.
840
841
                defGroupList ==? gl2 .&&.
                nl' ==? nl2
842

843
testSuite "Text"
Iustin Pop's avatar
Iustin Pop committed
844
845
846
847
848
            [ 'prop_Text_Load_Instance
            , 'prop_Text_Load_InstanceFail
            , 'prop_Text_Load_Node
            , 'prop_Text_Load_NodeFail
            , 'prop_Text_NodeLSIdempotent
849
850
            , 'prop_Text_ISpecIdempotent
            , 'prop_Text_IPolicyIdempotent
851
            , 'prop_Text_CreateSerialise
Iustin Pop's avatar
Iustin Pop committed
852
            ]
853

854
-- ** Node tests
855

Iustin Pop's avatar
Iustin Pop committed
856
prop_Node_setAlias node name =
Iustin Pop's avatar
Iustin Pop committed
857
858
  Node.name newnode == Node.name node &&
  Node.alias newnode == name
Iustin Pop's avatar
Iustin Pop committed
859
860
861
862
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
Iustin Pop's avatar
Iustin Pop committed
863
  Node.offline newnode ==? status
Iustin Pop's avatar
Iustin Pop committed
864
865
866
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
Iustin Pop's avatar
Iustin Pop committed
867
  Node.xMem newnode ==? xm
Iustin Pop's avatar
Iustin Pop committed
868
869
870
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
Iustin Pop's avatar
Iustin Pop committed
871
  Node.mCpu newnode ==? mc
Iustin Pop's avatar
Iustin Pop committed
872
873
    where newnode = Node.setMcpu node mc

874
875
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
prop_Node_addPriFM node inst =
  Instance.mem inst >= Node.fMem node && not (Node.failN1 node) &&
  not (Instance.instanceOffline inst) ==>
  case Node.addPri node inst'' of
    Types.OpFail Types.FailMem -> True
    _ -> False
  where _types = (node::Node.Node, inst::Instance.Instance)
        inst' = setInstanceSmallerThanNode node inst
        inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst =
  Instance.dsk inst >= Node.fDsk node && not (Node.failN1 node) ==>
    case Node.addPri node inst'' of
      Types.OpFail Types.FailDisk -> True
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
891
892
893
894
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

895
896
897
898
899
900
901
902
prop_Node_addPriFC (Positive extra) =
  forAll genOnlineNode $ \node ->
  forAll (arbitrary `suchThat` Instance.instanceNotOffline) $ \inst ->
  let inst' = setInstanceSmallerThanNode node inst
      inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
  in case Node.addPri node inst'' of
       Types.OpFail Types.FailCPU -> property True
       v -> failTest $ "Expected OpFail FailCPU, but got " ++ show v
903

904
905
-- | Check that an instance add with too high memory or disk will be
-- rejected.
906
prop_Node_addSec node inst pdx =
Iustin Pop's avatar
Iustin Pop committed
907
908
909
910
911
  ((Instance.mem inst >= (Node.fMem node - Node.rMem node) &&
    not (Instance.instanceOffline inst)) ||
   Instance.dsk inst >= Node.fDsk node) &&
  not (Node.failN1 node) ==>
      isFailure (Node.addSec node inst pdx)
912
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
913

914
915
-- | Check that an offline instance with reasonable disk size can always
-- be added.
916
917
prop_Node_addPriOffline =
  forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
918
919
920
921
922
923
  forAll (arbitrary `suchThat`
          (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                   Instance.instanceOffline x)) $ \inst ->
  case Node.addPri node inst of
    Types.OpGood _ -> True
    _ -> False
924

925
prop_Node_addSecOffline pdx =
926
  forAll genOnlineNode $ \node ->
Iustin Pop's avatar
Iustin Pop committed
927
  forAll (arbitrary `suchThat`
928
929
          (\ inst -> Instance.dsk inst  < Node.availDisk node)) $ \inst ->
  case Node.addSec node (inst { Instance.runSt = Types.AdminOffline }) pdx of
Iustin Pop's avatar
Iustin Pop committed
930
931
    Types.OpGood _ -> True
    _ -> False
932

933
-- | Checks for memory reservation changes.
934
prop_Node_rMem inst =
Iustin Pop's avatar
Iustin Pop committed
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
  not (Instance.instanceOffline inst) ==>
  forAll (arbitrary `suchThat` ((> Types.unitMem) . Node.fMem)) $ \node ->
  -- ab = auto_balance, nb = non-auto_balance
  -- we use -1 as the primary node of the instance
  let inst' = inst { Instance.pNode = -1, Instance.autoBalance = True }
      inst_ab = setInstanceSmallerThanNode node inst'
      inst_nb = inst_ab { Instance.autoBalance = False }
      -- now we have the two instances, identical except the
      -- autoBalance attribute
      orig_rmem = Node.rMem node
      inst_idx = Instance.idx inst_ab
      node_add_ab = Node.addSec node inst_ab (-1)
      node_add_nb = Node.addSec node inst_nb (-1)
      node_del_ab = liftM (`Node.removeSec` inst_ab) node_add_ab
      node_del_nb = liftM (`Node.removeSec` inst_nb) node_add_nb
  in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
       (Types.OpGood a_ab, Types.OpGood a_nb,
        Types.OpGood d_ab, Types.OpGood d_nb) ->
         printTestCase "Consistency checks failed" $
           Node.rMem a_ab >  orig_rmem &&
           Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
           Node.rMem a_nb == orig_rmem &&
           Node.rMem d_ab == orig_rmem &&
           Node.rMem d_nb == orig_rmem &&
           -- this is not related to rMem, but as good a place to
           -- test as any
           inst_idx `elem` Node.sList a_ab &&
Iustin Pop's avatar
Iustin Pop committed
962
           inst_idx `notElem` Node.sList d_ab
Iustin Pop's avatar
Iustin Pop committed
963
       x -> failTest $ "Failed to add/remove instances: " ++ show x
964

965
-- | Check mdsk setting.
Iustin Pop's avatar
Iustin Pop committed
966
prop_Node_setMdsk node mx =
Iustin Pop's avatar
Iustin Pop committed
967
968
969
970
971
972
  Node.loDsk node' >= 0 &&
  fromIntegral (Node.loDsk node') <= Node.tDsk node &&
  Node.availDisk node' >= 0 &&
  Node.availDisk node' <= Node.fDsk node' &&
  fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
  Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
973
974
975
976
977
978
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
Iustin Pop's avatar
Iustin Pop committed
979
  Node.delTags (Node.addTags m tags) tags ==? m
980
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
981
982

prop_Node_tagMaps_reject tags =
Iustin Pop's avatar
Iustin Pop committed
983
984
  not (null tags) ==>
  all (\t -> Node.rejectAddTags m [t]) tags
985
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
986

Iustin Pop's avatar
Iustin Pop committed
987
988
989
990
991
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

992
993
994
995
996
997
prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
Iustin Pop's avatar
Iustin Pop committed
998
     (null nodes || not (null ng))
999

1000
testSuite "Node"
Iustin Pop's avatar
Iustin Pop committed
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
            [ 'prop_Node_setAlias
            , 'prop_Node_setOffline
            , 'prop_Node_setMcpu
            , 'prop_Node_setXmem
            , 'prop_Node_addPriFM
            , 'prop_Node_addPriFD
            , 'prop_Node_addPriFC
            , 'prop_Node_addSec
            , 'prop_Node_addPriOffline
            , 'prop_Node_addSecOffline
            , 'prop_Node_rMem
            , 'prop_Node_setMdsk
            , 'prop_Node_tagMaps_idempotent
            , 'prop_Node_tagMaps_reject
            , 'prop_Node_showField
            , 'prop_Node_computeGroups
            ]
1018

1019
-- ** Cluster tests
1020

1021
1022
-- | Check that the cluster score is close to zero for a homogeneous
-- cluster.
Iustin Pop's avatar
Iustin Pop committed
1023
prop_Score_Zero node =
Iustin Pop's avatar
Iustin Pop committed
1024
  forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
1025
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
Iustin Pop's avatar