QC.hs 47.6 KB
Newer Older
1
2
{-# LANGUAGE TemplateHaskell #-}

3
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
4
5
6
7
8

-}

{-

Iustin Pop's avatar
Iustin Pop committed
9
Copyright (C) 2009, 2010, 2011, 2012 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

28
module Ganeti.HTools.QC
Iustin Pop's avatar
Iustin Pop committed
29
30
31
32
33
34
35
36
37
38
39
40
  ( testUtils
  , testPeerMap
  , testContainer
  , testInstance
  , testNode
  , testText
  , testOpCodes
  , testJobs
  , testCluster
  , testLoader
  , testTypes
  ) where
41
42

import Test.QuickCheck
Iustin Pop's avatar
Iustin Pop committed
43
import Data.List (findIndex, intercalate, nub, isPrefixOf)
44
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
45
46
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
47
import qualified Data.Map
48
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
49
import qualified Ganeti.OpCodes as OpCodes
50
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
51
import qualified Ganeti.Luxi
52
53
54
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
55
import qualified Ganeti.HTools.ExtLoader
56
57
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
58
import qualified Ganeti.HTools.JSON as JSON
59
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
60
import qualified Ganeti.HTools.Luxi
61
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
62
import qualified Ganeti.HTools.Group as Group
63
import qualified Ganeti.HTools.PeerMap as PeerMap
64
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
65
import qualified Ganeti.HTools.Simu
66
67
68
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
69
import qualified Ganeti.HTools.Version
70
import qualified Ganeti.Constants as C
71

72
73
74
75
76
import qualified Ganeti.HTools.Program.Hail
import qualified Ganeti.HTools.Program.Hbal
import qualified Ganeti.HTools.Program.Hscan
import qualified Ganeti.HTools.Program.Hspace

77
import Ganeti.HTools.QCHelper (testSuite)
Iustin Pop's avatar
Iustin Pop committed
78

79
80
-- * Constants

81
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
82
83
84
maxMem :: Int
maxMem = 1024 * 1024

85
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
86
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
87
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
88

89
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
90
91
92
maxCpu :: Int
maxCpu = 1024

93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
-- | Null iPolicy, and by null we mean very liberal.
nullIPolicy = Types.IPolicy
  { Types.iPolicyMinSpec = Types.ISpec { Types.iSpecMemorySize = 0
                                       , Types.iSpecCpuCount   = 0
                                       , Types.iSpecDiskSize   = 0
                                       , Types.iSpecDiskCount  = 0
                                       , Types.iSpecNicCount   = 0
                                       }
  , Types.iPolicyMaxSpec = Types.ISpec { Types.iSpecMemorySize = maxBound
                                       , Types.iSpecCpuCount   = maxBound
                                       , Types.iSpecDiskSize   = maxBound
                                       , Types.iSpecDiskCount  = C.maxDisks
                                       , Types.iSpecNicCount   = C.maxNics
                                       }
  , Types.iPolicyStdSpec = Types.ISpec { Types.iSpecMemorySize = Types.unitMem
                                       , Types.iSpecCpuCount   = Types.unitCpu
                                       , Types.iSpecDiskSize   = Types.unitDsk
                                       , Types.iSpecDiskCount  = 1
                                       , Types.iSpecNicCount   = 1
                                       }
  , Types.iPolicyDiskTemplates = [Types.DTDrbd8, Types.DTPlain]
  }


Iustin Pop's avatar
Iustin Pop committed
117
118
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
Iustin Pop's avatar
Iustin Pop committed
119
             Group.create "default" Types.defaultGroupID Types.AllocPreferred
120
                  nullIPolicy
Iustin Pop's avatar
Iustin Pop committed
121
122

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
123
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
124
125
126
127

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

128
129
-- * Helper functions

130
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
131
132
133
134
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

Iustin Pop's avatar
Iustin Pop committed
135
136
137
138
139
140
141
-- | Checks for equality with proper annotation.
(==?) :: (Show a, Eq a) => a -> a -> Property
(==?) x y = printTestCase
            ("Expected equality, but '" ++
             show x ++ "' /= '" ++ show y ++ "'") (x == y)
infix 3 ==?

142
-- | Update an instance to be smaller than a node.
143
setInstanceSmallerThanNode node inst =
Iustin Pop's avatar
Iustin Pop committed
144
145
146
147
  inst { Instance.mem = Node.availMem node `div` 2
       , Instance.dsk = Node.availDisk node `div` 2
       , Instance.vcpus = Node.availCpu node `div` 2
       }
148

149
150
151
152
153
154
-- | Check if an instance is smaller than a node.
isInstanceSmallerThanNode node inst =
  Instance.mem inst   <= Node.availMem node `div` 2 &&
  Instance.dsk inst   <= Node.availDisk node `div` 2 &&
  Instance.vcpus inst <= Node.availCpu node `div` 2

155
-- | Create an instance given its spec.
156
createInstance mem dsk vcpus =
Iustin Pop's avatar
Iustin Pop committed
157
158
  Instance.create "inst-unnamed" mem dsk vcpus Types.Running [] True (-1) (-1)
    Types.DTDrbd8
159

160
-- | Create a small cluster by repeating a node spec.
161
162
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
163
164
165
166
167
168
169
  let origname = Node.name node
      origalias = Node.alias node
      nodes = map (\idx -> node { Node.name = origname ++ "-" ++ show idx
                                , Node.alias = origalias ++ "-" ++ show idx })
              [1..count]
      fn = flip Node.buildPeers Container.empty
      namelst = map (\n -> (Node.name n, fn n)) nodes
Iustin Pop's avatar
Iustin Pop committed
170
171
      (_, nlst) = Loader.assignIndices namelst
  in nlst
172

Iustin Pop's avatar
Iustin Pop committed
173
174
175
176
177
178
179
-- | Make a small cluster, both nodes and instances.
makeSmallEmptyCluster :: Node.Node -> Int -> Instance.Instance
                      -> (Node.List, Instance.List, Instance.Instance)
makeSmallEmptyCluster node count inst =
  (makeSmallCluster node count, Container.empty,
   setInstanceSmallerThanNode node inst)

180
-- | Checks if a node is "big" enough.
181
182
isNodeBig :: Int -> Node.Node -> Bool
isNodeBig size node = Node.availDisk node > size * Types.unitDsk
183
184
185
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

186
187
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
188

189
-- | Assigns a new fresh instance to a cluster; this is not
190
-- allocation, so no resource checks are done.
191
192
193
194
195
196
197
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
Iustin Pop's avatar
Iustin Pop committed
198
199
                  then 0
                  else fst (Container.findMax il) + 1
200
201
202
203
204
205
206
207
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

208
209
-- * Arbitrary instances

210
-- | Defines a DNS name.
211
newtype DNSChar = DNSChar { dnsGetChar::Char }
212

213
instance Arbitrary DNSChar where
Iustin Pop's avatar
Iustin Pop committed
214
215
216
  arbitrary = do
    x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
    return (DNSChar x)
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231

getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)

getFQDN :: Gen String
getFQDN = do
  felem <- getName
  ncomps <- choose (1, 4)
  frest <- vector ncomps::Gen [[DNSChar]]
  let frest' = map (map dnsGetChar) frest
  return (felem ++ "." ++ intercalate "." frest')

232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
-- | Defines a tag type.
newtype TagChar = TagChar { tagGetChar :: Char }

-- | All valid tag chars. This doesn't need to match _exactly_
-- Ganeti's own tag regex, just enough for it to be close.
tagChar :: [Char]
tagChar = ['a'..'z'] ++ ['A'..'Z'] ++ ['0'..'9'] ++ ".+*/:@-"

instance Arbitrary TagChar where
  arbitrary = do
    c <- elements tagChar
    return (TagChar c)

-- | Generates a tag
genTag :: Gen [TagChar]
genTag = do
  -- the correct value would be C.maxTagLen, but that's way too
  -- verbose in unittests, and at the moment I don't see any possible
  -- bugs with longer tags and the way we use tags in htools
  n <- choose (1, 10)
  vector n

-- | Generates a list of tags (correctly upper bounded).
genTags :: Gen [String]
genTags = do
  -- the correct value would be C.maxTagsPerObj, but per the comment
  -- in genTag, we don't use tags enough in htools to warrant testing
  -- such big values
  n <- choose (0, 10::Int)
  tags <- mapM (const genTag) [1..n]
  return $ map (map tagGetChar) tags

264
instance Arbitrary Types.InstanceStatus where
265
    arbitrary = elements [minBound..maxBound]
266

267
268
-- let's generate a random instance
instance Arbitrary Instance.Instance where
Iustin Pop's avatar
Iustin Pop committed
269
270
271
272
273
274
275
276
277
278
  arbitrary = do
    name <- getFQDN
    mem <- choose (0, maxMem)
    dsk <- choose (0, maxDsk)
    run_st <- arbitrary
    pn <- arbitrary
    sn <- arbitrary
    vcpus <- choose (0, maxCpu)
    return $ Instance.create name mem dsk vcpus run_st [] True pn sn
              Types.DTDrbd8
279

280
281
282
283
284
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
285
286
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
Iustin Pop's avatar
Iustin Pop committed
287
288
289
290
291
        case min_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (0, 0, 0)
292
      (top_mem, top_dsk, top_cpu)  =
Iustin Pop's avatar
Iustin Pop committed
293
294
295
296
297
        case max_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (maxMem, maxDsk, maxCpu)
298
299
300
301
302
303
304
305
306
307
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
Iustin Pop's avatar
Iustin Pop committed
308
309
      n' = Node.setPolicy nullIPolicy n
  return $ Node.buildPeers n' Container.empty
310

311
312
313
314
315
316
317
318
319
-- | Helper function to generate a sane node.
genOnlineNode :: Gen Node.Node
genOnlineNode = do
  arbitrary `suchThat` (\n -> not (Node.offline n) &&
                              not (Node.failN1 n) &&
                              Node.availDisk n > 0 &&
                              Node.availMem n > 0 &&
                              Node.availCpu n > 0)

320
321
-- and a random node
instance Arbitrary Node.Node where
Iustin Pop's avatar
Iustin Pop committed
322
  arbitrary = genNode Nothing Nothing
323

Iustin Pop's avatar
Iustin Pop committed
324
325
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
326
  arbitrary = elements [minBound..maxBound]
Iustin Pop's avatar
Iustin Pop committed
327
328
329
330
331
332
333
334

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
Iustin Pop's avatar
Iustin Pop committed
335
336
337
338
339
340
341
342
343
344
345
346
347
    case op_id of
      "OP_TEST_DELAY" ->
        liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
      "OP_INSTANCE_REPLACE_DISKS" ->
        liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
          arbitrary arbitrary arbitrary
      "OP_INSTANCE_FAILOVER" ->
        liftM3 OpCodes.OpInstanceFailover arbitrary arbitrary
          arbitrary
      "OP_INSTANCE_MIGRATE" ->
        liftM5 OpCodes.OpInstanceMigrate arbitrary arbitrary
          arbitrary arbitrary arbitrary
      _ -> fail "Wrong opcode"
Iustin Pop's avatar
Iustin Pop committed
348

349
350
351
352
353
354
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

355
356
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
Iustin Pop's avatar
Iustin Pop committed
357
358
359
  arbitrary = do
    v <- choose (0, 1)
    return $ SmallRatio v
360

361
362
363
364
365
366
instance Arbitrary Types.AllocPolicy where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Types.DiskTemplate where
  arbitrary = elements [minBound..maxBound]

367
instance Arbitrary Types.FailMode where
Iustin Pop's avatar
Iustin Pop committed
368
  arbitrary = elements [minBound..maxBound]
369
370

instance Arbitrary a => Arbitrary (Types.OpResult a) where
Iustin Pop's avatar
Iustin Pop committed
371
  arbitrary = arbitrary >>= \c ->
Iustin Pop's avatar
Iustin Pop committed
372
373
374
              if c
                then liftM Types.OpGood arbitrary
                else liftM Types.OpFail arbitrary
375

376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
instance Arbitrary Types.ISpec where
  arbitrary = do
    mem <- arbitrary::Gen (NonNegative Int)
    dsk_c <- arbitrary::Gen (NonNegative Int)
    dsk_s <- arbitrary::Gen (NonNegative Int)
    cpu <- arbitrary::Gen (NonNegative Int)
    nic <- arbitrary::Gen (NonNegative Int)
    return Types.ISpec { Types.iSpecMemorySize = fromIntegral mem
                       , Types.iSpecCpuCount   = fromIntegral cpu
                       , Types.iSpecDiskSize   = fromIntegral dsk_s
                       , Types.iSpecDiskCount  = fromIntegral dsk_c
                       , Types.iSpecNicCount   = fromIntegral nic
                       }

-- | Helper function to check whether a spec is LTE than another
iSpecSmaller :: Types.ISpec -> Types.ISpec -> Bool
iSpecSmaller imin imax =
  Types.iSpecMemorySize imin <= Types.iSpecMemorySize imax &&
  Types.iSpecCpuCount imin   <= Types.iSpecCpuCount imax &&
  Types.iSpecDiskSize imin   <= Types.iSpecDiskSize imax &&
  Types.iSpecDiskCount imin  <= Types.iSpecDiskCount imax &&
  Types.iSpecNicCount imin   <= Types.iSpecNicCount imax

instance Arbitrary Types.IPolicy where
  arbitrary = do
    imin <- arbitrary
    istd <- arbitrary `suchThat` (iSpecSmaller imin)
    imax <- arbitrary `suchThat` (iSpecSmaller istd)
    dts  <- arbitrary
    return Types.IPolicy { Types.iPolicyMinSpec = imin
                         , Types.iPolicyStdSpec = istd
                         , Types.iPolicyMaxSpec = imax
                         , Types.iPolicyDiskTemplates = dts
                         }

411
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
412

413
414
415
416
-- ** Utils tests

-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
417
prop_Utils_commaJoinSplit =
Iustin Pop's avatar
Iustin Pop committed
418
  forAll (arbitrary `suchThat`
Iustin Pop's avatar
Iustin Pop committed
419
          (\l -> l /= [""] && all (notElem ',') l )) $ \lst ->
Iustin Pop's avatar
Iustin Pop committed
420
  Utils.sepSplit ',' (Utils.commaJoin lst) ==? lst
Iustin Pop's avatar
Iustin Pop committed
421

422
-- | Split and join should always be idempotent.
Iustin Pop's avatar
Iustin Pop committed
423
prop_Utils_commaSplitJoin s =
Iustin Pop's avatar
Iustin Pop committed
424
  Utils.commaJoin (Utils.sepSplit ',' s) ==? s
425

426
-- | fromObjWithDefault, we test using the Maybe monad and an integer
427
-- value.
428
prop_Utils_fromObjWithDefault def_value random_key =
Iustin Pop's avatar
Iustin Pop committed
429
  -- a missing key will be returned with the default
430
  JSON.fromObjWithDefault [] random_key def_value == Just def_value &&
Iustin Pop's avatar
Iustin Pop committed
431
  -- a found key will be returned as is, not with default
432
  JSON.fromObjWithDefault [(random_key, J.showJSON def_value)]
Iustin Pop's avatar
Iustin Pop committed
433
434
       random_key (def_value+1) == Just def_value
    where _types = def_value :: Integer
435

436
-- | Test that functional if' behaves like the syntactic sugar if.
Iustin Pop's avatar
Iustin Pop committed
437
438
prop_Utils_if'if :: Bool -> Int -> Int -> Gen Prop
prop_Utils_if'if cnd a b =
Iustin Pop's avatar
Iustin Pop committed
439
  Utils.if' cnd a b ==? if cnd then a else b
440

Guido Trotter's avatar
Guido Trotter committed
441
-- | Test basic select functionality
Iustin Pop's avatar
Iustin Pop committed
442
443
444
445
prop_Utils_select :: Int      -- ^ Default result
                  -> [Int]    -- ^ List of False values
                  -> [Int]    -- ^ List of True values
                  -> Gen Prop -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
446
prop_Utils_select def lst1 lst2 =
Iustin Pop's avatar
Iustin Pop committed
447
  Utils.select def (flist ++ tlist) ==? expectedresult
Iustin Pop's avatar
Iustin Pop committed
448
449
450
    where expectedresult = Utils.if' (null lst2) def (head lst2)
          flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
451
452

-- | Test basic select functionality with undefined default
Iustin Pop's avatar
Iustin Pop committed
453
prop_Utils_select_undefd :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
454
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
455
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
456
prop_Utils_select_undefd lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
457
  Utils.select undefined (flist ++ tlist) ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
458
459
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
460
461

-- | Test basic select functionality with undefined list values
Iustin Pop's avatar
Iustin Pop committed
462
prop_Utils_select_undefv :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
463
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
464
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
465
prop_Utils_select_undefv lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
466
  Utils.select undefined cndlist ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
467
468
469
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
          cndlist = flist ++ tlist ++ [undefined]
470

Iustin Pop's avatar
Iustin Pop committed
471
prop_Utils_parseUnit (NonNegative n) =
Iustin Pop's avatar
Iustin Pop committed
472
473
474
475
476
477
478
479
480
481
  Utils.parseUnit (show n) == Types.Ok n &&
  Utils.parseUnit (show n ++ "m") == Types.Ok n &&
  (case Utils.parseUnit (show n ++ "M") of
     Types.Ok m -> if n > 0
                     then m < n  -- for positive values, X MB is < than X MiB
                     else m == 0 -- but for 0, 0 MB == 0 MiB
     Types.Bad _ -> False) &&
  Utils.parseUnit (show n ++ "g") == Types.Ok (n*1024) &&
  Utils.parseUnit (show n ++ "t") == Types.Ok (n*1048576) &&
  Types.isBad (Utils.parseUnit (show n ++ "x")::Types.Result Int)
Iustin Pop's avatar
Iustin Pop committed
482
    where _types = n::Int
Iustin Pop's avatar
Iustin Pop committed
483

484
-- | Test list for the Utils module.
485
testSuite "Utils"
Iustin Pop's avatar
Iustin Pop committed
486
487
488
489
490
491
492
493
494
            [ 'prop_Utils_commaJoinSplit
            , 'prop_Utils_commaSplitJoin
            , 'prop_Utils_fromObjWithDefault
            , 'prop_Utils_if'if
            , 'prop_Utils_select
            , 'prop_Utils_select_undefd
            , 'prop_Utils_select_undefv
            , 'prop_Utils_parseUnit
            ]
495

496
497
498
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
499
prop_PeerMap_addIdempotent pmap key em =
Iustin Pop's avatar
Iustin Pop committed
500
  fn puniq ==? fn (fn puniq)
501
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
502
503
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
504
          puniq = PeerMap.accumArray const pmap
505

506
-- | Make sure remove is idempotent.
507
prop_PeerMap_removeIdempotent pmap key =
Iustin Pop's avatar
Iustin Pop committed
508
  fn puniq ==? fn (fn puniq)
509
510
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
511
512
          puniq = PeerMap.accumArray const pmap

513
-- | Make sure a missing item returns 0.
514
prop_PeerMap_findMissing pmap key =
Iustin Pop's avatar
Iustin Pop committed
515
  PeerMap.find key (PeerMap.remove key puniq) ==? 0
516
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
517
518
          puniq = PeerMap.accumArray const pmap

519
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
520
prop_PeerMap_addFind pmap key em =
Iustin Pop's avatar
Iustin Pop committed
521
  PeerMap.find key (PeerMap.add key em puniq) ==? em
522
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
523
                    key::PeerMap.Key, em::PeerMap.Elem)
524
          puniq = PeerMap.accumArray const pmap
525

526
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
527
prop_PeerMap_maxElem pmap =
Iustin Pop's avatar
Iustin Pop committed
528
  PeerMap.maxElem puniq ==? if null puniq then 0
Iustin Pop's avatar
Iustin Pop committed
529
                              else (maximum . snd . unzip) puniq
530
    where _types = pmap::PeerMap.PeerMap
531
532
          puniq = PeerMap.accumArray const pmap

533
-- | List of tests for the PeerMap module.
534
testSuite "PeerMap"
Iustin Pop's avatar
Iustin Pop committed
535
536
537
538
539
540
            [ 'prop_PeerMap_addIdempotent
            , 'prop_PeerMap_removeIdempotent
            , 'prop_PeerMap_maxElem
            , 'prop_PeerMap_addFind
            , 'prop_PeerMap_findMissing
            ]
541

542
-- ** Container tests
543

Iustin Pop's avatar
Iustin Pop committed
544
545
-- we silence the following due to hlint bug fixed in later versions
{-# ANN prop_Container_addTwo "HLint: ignore Avoid lambda" #-}
546
prop_Container_addTwo cdata i1 i2 =
Iustin Pop's avatar
Iustin Pop committed
547
548
  fn i1 i2 cont == fn i2 i1 cont &&
  fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
549
550
551
552
553
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

554
555
556
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
Iustin Pop's avatar
Iustin Pop committed
557
  in Container.nameOf nl (Node.idx fnode) ==? Node.name fnode
558

559
-- | We test that in a cluster, given a random node, we can find it by
560
-- its name and alias, as long as all names and aliases are unique,
561
-- and that we fail to find a non-existing name.
562
563
564
565
566
567
prop_Container_findByName node othername =
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
  forAll (vector cnt) $ \ names ->
  (length . nub) (map fst names ++ map snd names) ==
  length names * 2 &&
Iustin Pop's avatar
Iustin Pop committed
568
  othername `notElem` (map fst names ++ map snd names) ==>
569
570
571
572
573
574
  let nl = makeSmallCluster node cnt
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
575
      nl' = Container.fromList nodes'
576
577
578
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
Iustin Pop's avatar
Iustin Pop committed
579
     isNothing (Container.findByName nl' othername)
580

581
testSuite "Container"
Iustin Pop's avatar
Iustin Pop committed
582
583
584
585
            [ 'prop_Container_addTwo
            , 'prop_Container_nameOf
            , 'prop_Container_findByName
            ]
586

587
588
-- ** Instance tests

589
590
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
591
prop_Instance_creat inst =
Iustin Pop's avatar
Iustin Pop committed
592
  Instance.name inst ==? Instance.alias inst
Iustin Pop's avatar
Iustin Pop committed
593

594
prop_Instance_setIdx inst idx =
Iustin Pop's avatar
Iustin Pop committed
595
  Instance.idx (Instance.setIdx inst idx) ==? idx
596
597
598
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
599
600
  Instance.name newinst == name &&
  Instance.alias newinst == name
Iustin Pop's avatar
Iustin Pop committed
601
602
603
604
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
Iustin Pop's avatar
Iustin Pop committed
605
606
  Instance.name newinst == Instance.name inst &&
  Instance.alias newinst == name
607
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
608
          newinst = Instance.setAlias inst name
609
610

prop_Instance_setPri inst pdx =
Iustin Pop's avatar
Iustin Pop committed
611
  Instance.pNode (Instance.setPri inst pdx) ==? pdx
612
613
614
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
Iustin Pop's avatar
Iustin Pop committed
615
  Instance.sNode (Instance.setSec inst sdx) ==? sdx
616
617
618
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
Iustin Pop's avatar
Iustin Pop committed
619
  Instance.pNode si == pdx && Instance.sNode si == sdx
620
621
622
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
623
prop_Instance_shrinkMG inst =
Iustin Pop's avatar
Iustin Pop committed
624
625
626
627
  Instance.mem inst >= 2 * Types.unitMem ==>
    case Instance.shrinkByType inst Types.FailMem of
      Types.Ok inst' -> Instance.mem inst' == Instance.mem inst - Types.unitMem
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
628
629

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
630
  forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
Iustin Pop's avatar
Iustin Pop committed
631
632
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
633
634

prop_Instance_shrinkCG inst =
Iustin Pop's avatar
Iustin Pop committed
635
636
637
638
639
  Instance.vcpus inst >= 2 * Types.unitCpu ==>
    case Instance.shrinkByType inst Types.FailCPU of
      Types.Ok inst' ->
        Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
640
641

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
642
  forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
Iustin Pop's avatar
Iustin Pop committed
643
644
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
645
646

prop_Instance_shrinkDG inst =
Iustin Pop's avatar
Iustin Pop committed
647
648
649
650
651
  Instance.dsk inst >= 2 * Types.unitDsk ==>
    case Instance.shrinkByType inst Types.FailDisk of
      Types.Ok inst' ->
        Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
652
653

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
654
  forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
Iustin Pop's avatar
Iustin Pop committed
655
656
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
657
658

prop_Instance_setMovable inst m =
Iustin Pop's avatar
Iustin Pop committed
659
  Instance.movable inst' ==? m
660
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
661

662
testSuite "Instance"
Iustin Pop's avatar
Iustin Pop committed
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
            [ 'prop_Instance_creat
            , 'prop_Instance_setIdx
            , 'prop_Instance_setName
            , 'prop_Instance_setAlias
            , 'prop_Instance_setPri
            , 'prop_Instance_setSec
            , 'prop_Instance_setBoth
            , 'prop_Instance_shrinkMG
            , 'prop_Instance_shrinkMF
            , 'prop_Instance_shrinkCG
            , 'prop_Instance_shrinkCF
            , 'prop_Instance_shrinkDG
            , 'prop_Instance_shrinkDF
            , 'prop_Instance_setMovable
            ]
Iustin Pop's avatar
Iustin Pop committed
678

679
680
-- ** Text backend tests

Iustin Pop's avatar
Iustin Pop committed
681
682
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
683
684
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
685
                        (NonNegative pdx) (NonNegative sdx) autobal dt =
Iustin Pop's avatar
Iustin Pop committed
686
687
688
689
690
691
  pnode /= snode && pdx /= sdx ==>
  let vcpus_s = show vcpus
      dsk_s = show dsk
      mem_s = show mem
      status_s = Types.instanceStatusToRaw status
      ndx = if null snode
Iustin Pop's avatar
Iustin Pop committed
692
              then [(pnode, pdx)]
693
              else [(pnode, pdx), (snode, sdx)]
Iustin Pop's avatar
Iustin Pop committed
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
      nl = Data.Map.fromList ndx
      tags = ""
      sbal = if autobal then "Y" else "N"
      sdt = Types.diskTemplateToRaw dt
      inst = Text.loadInst nl
             [name, mem_s, dsk_s, vcpus_s, status_s,
              sbal, pnode, snode, sdt, tags]
      fail1 = Text.loadInst nl
              [name, mem_s, dsk_s, vcpus_s, status_s,
               sbal, pnode, pnode, tags]
      _types = ( name::String, mem::Int, dsk::Int
               , vcpus::Int, status::Types.InstanceStatus
               , snode::String
               , autobal::Bool)
  in case inst of
       Types.Bad msg -> printTestCase ("Failed to load instance: " ++ msg)
                        False
       Types.Ok (_, i) -> printTestCase "Mismatch in some field while\
                                        \ loading the instance" $
               Instance.name i == name &&
               Instance.vcpus i == vcpus &&
               Instance.mem i == mem &&
               Instance.pNode i == pdx &&
               Instance.sNode i == (if null snode
                                      then Node.noSecondary
                                      else sdx) &&
               Instance.autoBalance i == autobal &&
               Types.isBad fail1
Iustin Pop's avatar
Iustin Pop committed
722
723

prop_Text_Load_InstanceFail ktn fields =
Iustin Pop's avatar
Iustin Pop committed
724
  length fields /= 10 ==>
Iustin Pop's avatar
Iustin Pop committed
725
    case Text.loadInst nl fields of
726
727
728
729
      Types.Ok _ -> printTestCase "Managed to load instance from invalid\
                                  \ data" False
      Types.Bad msg -> printTestCase ("Unrecognised error message: " ++ msg) $
                       "Invalid/incomplete instance data: '" `isPrefixOf` msg
730
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
731
732

prop_Text_Load_Node name tm nm fm td fd tc fo =
Iustin Pop's avatar
Iustin Pop committed
733
734
735
736
737
738
739
740
741
742
  let conv v = if v < 0
                 then "?"
                 else show v
      tm_s = conv tm
      nm_s = conv nm
      fm_s = conv fm
      td_s = conv td
      fd_s = conv fd
      tc_s = conv tc
      fo_s = if fo
Iustin Pop's avatar
Iustin Pop committed
743
744
               then "Y"
               else "N"
Iustin Pop's avatar
Iustin Pop committed
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
      any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
      gid = Group.uuid defGroup
  in case Text.loadNode defGroupAssoc
       [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
       Nothing -> False
       Just (name', node) ->
         if fo || any_broken
           then Node.offline node
           else Node.name node == name' && name' == name &&
                Node.alias node == name &&
                Node.tMem node == fromIntegral tm &&
                Node.nMem node == nm &&
                Node.fMem node == fm &&
                Node.tDsk node == fromIntegral td &&
                Node.fDsk node == fd &&
                Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
761
762

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
763
  length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
764

765
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
766
767
768
  (Text.loadNode defGroupAssoc.
       Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
  Just (Node.name n, n)
769
    -- override failN1 to what loadNode returns by default
Iustin Pop's avatar
Iustin Pop committed
770
771
    where n = node { Node.failN1 = True, Node.offline = False
                   , Node.iPolicy = Types.defIPolicy }
772

773
774
775
776
777
778
779
780
781
782
783
784
785
prop_Text_ISpecIdempotent ispec =
  case Text.loadISpec "dummy" . Utils.sepSplit ',' .
       Text.serializeISpec $ ispec of
    Types.Bad msg -> printTestCase ("Failed to load ispec: " ++ msg) False
    Types.Ok ispec' -> ispec ==? ispec'

prop_Text_IPolicyIdempotent ipol =
  case Text.loadIPolicy . Utils.sepSplit '|' $
       Text.serializeIPolicy owner ipol of
    Types.Bad msg -> printTestCase ("Failed to load ispec: " ++ msg) False
    Types.Ok res -> (owner, ipol) ==? res
  where owner = "dummy"

786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
-- | This property, while being in the text tests, does more than just
-- test end-to-end the serialisation and loading back workflow; it
-- also tests the Loader.mergeData and the actuall
-- Cluster.iterateAlloc (for well-behaving w.r.t. instance
-- allocations, not for the business logic). As such, it's a quite
-- complex and slow test, and that's the reason we restrict it to
-- small cluster sizes.
prop_Text_CreateSerialise =
  forAll genTags $ \ctags ->
  forAll (choose (1, 2)) $ \reqnodes ->
  forAll (choose (1, 20)) $ \maxiter ->
  forAll (choose (2, 10)) $ \count ->
  forAll genOnlineNode $ \node ->
  forAll (arbitrary `suchThat` isInstanceSmallerThanNode node) $ \inst ->
  let inst' = Instance.setMovable inst $ Utils.if' (reqnodes == 2) True False
      nl = makeSmallCluster node count
  in case Cluster.genAllocNodes defGroupList nl reqnodes True >>= \allocn ->
     Cluster.iterateAlloc nl Container.empty (Just maxiter) inst' allocn [] []
     of
       Types.Bad msg -> printTestCase ("Failed to allocate: " ++ msg) False
       Types.Ok (_, _, _, [], _) -> printTestCase
                                    "Failed to allocate: no allocations" False
       Types.Ok (_, nl', il', _, _) ->
         let cdata = Loader.ClusterData defGroupList nl' il' ctags
                     Types.defIPolicy
             saved = Text.serializeCluster cdata
         in case Text.parseData saved >>= Loader.mergeData [] [] [] [] of
              Types.Bad msg -> printTestCase ("Failed to load/merge: " ++
                                              msg) False
              Types.Ok (Loader.ClusterData gl2 nl2 il2 ctags2 cpol2) ->
                ctags ==? ctags2 .&&.
                Types.defIPolicy ==? cpol2 .&&.
                il' ==? il2 .&&.
819
820
                defGroupList ==? gl2 .&&.
                nl' ==? nl2
821

822
testSuite "Text"
Iustin Pop's avatar
Iustin Pop committed
823
824
825
826
827
            [ 'prop_Text_Load_Instance
            , 'prop_Text_Load_InstanceFail
            , 'prop_Text_Load_Node
            , 'prop_Text_Load_NodeFail
            , 'prop_Text_NodeLSIdempotent
828
829
            , 'prop_Text_ISpecIdempotent
            , 'prop_Text_IPolicyIdempotent
830
            , 'prop_Text_CreateSerialise
Iustin Pop's avatar
Iustin Pop committed
831
            ]
832

833
-- ** Node tests
834

Iustin Pop's avatar
Iustin Pop committed
835
prop_Node_setAlias node name =
Iustin Pop's avatar
Iustin Pop committed
836
837
  Node.name newnode == Node.name node &&
  Node.alias newnode == name
Iustin Pop's avatar
Iustin Pop committed
838
839
840
841
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
Iustin Pop's avatar
Iustin Pop committed
842
  Node.offline newnode ==? status
Iustin Pop's avatar
Iustin Pop committed
843
844
845
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
Iustin Pop's avatar
Iustin Pop committed
846
  Node.xMem newnode ==? xm
Iustin Pop's avatar
Iustin Pop committed
847
848
849
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
Iustin Pop's avatar
Iustin Pop committed
850
  Node.mCpu newnode ==? mc
Iustin Pop's avatar
Iustin Pop committed
851
852
    where newnode = Node.setMcpu node mc

853
854
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
prop_Node_addPriFM node inst =
  Instance.mem inst >= Node.fMem node && not (Node.failN1 node) &&
  not (Instance.instanceOffline inst) ==>
  case Node.addPri node inst'' of
    Types.OpFail Types.FailMem -> True
    _ -> False
  where _types = (node::Node.Node, inst::Instance.Instance)
        inst' = setInstanceSmallerThanNode node inst
        inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst =
  Instance.dsk inst >= Node.fDsk node && not (Node.failN1 node) ==>
    case Node.addPri node inst'' of
      Types.OpFail Types.FailDisk -> True
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
870
871
872
873
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

Iustin Pop's avatar
Iustin Pop committed
874
prop_Node_addPriFC node inst (Positive extra) =
Iustin Pop's avatar
Iustin Pop committed
875
876
877
878
  not (Node.failN1 node) && not (Instance.instanceOffline inst) ==>
      case Node.addPri node inst'' of
        Types.OpFail Types.FailCPU -> True
        _ -> False
Iustin Pop's avatar
Iustin Pop committed
879
880
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
Iustin Pop's avatar
Iustin Pop committed
881
          inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
882

883
884
-- | Check that an instance add with too high memory or disk will be
-- rejected.
885
prop_Node_addSec node inst pdx =
Iustin Pop's avatar
Iustin Pop committed
886
887
888
889
890
  ((Instance.mem inst >= (Node.fMem node - Node.rMem node) &&
    not (Instance.instanceOffline inst)) ||
   Instance.dsk inst >= Node.fDsk node) &&
  not (Node.failN1 node) ==>
      isFailure (Node.addSec node inst pdx)
891
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
892

893
894
-- | Check that an offline instance with reasonable disk size can always
-- be added.
895
896
prop_Node_addPriOffline =
  forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
897
898
899
900
901
902
  forAll (arbitrary `suchThat`
          (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                   Instance.instanceOffline x)) $ \inst ->
  case Node.addPri node inst of
    Types.OpGood _ -> True
    _ -> False
903

904
905
prop_Node_addSecOffline pdx =
  forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
906
907
908
909
910
911
  forAll (arbitrary `suchThat`
          (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                   Instance.instanceOffline x)) $ \inst ->
  case Node.addSec node inst pdx of
    Types.OpGood _ -> True
    _ -> False
912

913
-- | Checks for memory reservation changes.
914
prop_Node_rMem inst =
Iustin Pop's avatar
Iustin Pop committed
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
  not (Instance.instanceOffline inst) ==>
  forAll (arbitrary `suchThat` ((> Types.unitMem) . Node.fMem)) $ \node ->
  -- ab = auto_balance, nb = non-auto_balance
  -- we use -1 as the primary node of the instance
  let inst' = inst { Instance.pNode = -1, Instance.autoBalance = True }
      inst_ab = setInstanceSmallerThanNode node inst'
      inst_nb = inst_ab { Instance.autoBalance = False }
      -- now we have the two instances, identical except the
      -- autoBalance attribute
      orig_rmem = Node.rMem node
      inst_idx = Instance.idx inst_ab
      node_add_ab = Node.addSec node inst_ab (-1)
      node_add_nb = Node.addSec node inst_nb (-1)
      node_del_ab = liftM (`Node.removeSec` inst_ab) node_add_ab
      node_del_nb = liftM (`Node.removeSec` inst_nb) node_add_nb
  in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
       (Types.OpGood a_ab, Types.OpGood a_nb,
        Types.OpGood d_ab, Types.OpGood d_nb) ->
         printTestCase "Consistency checks failed" $
           Node.rMem a_ab >  orig_rmem &&
           Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
           Node.rMem a_nb == orig_rmem &&
           Node.rMem d_ab == orig_rmem &&
           Node.rMem d_nb == orig_rmem &&
           -- this is not related to rMem, but as good a place to
           -- test as any
           inst_idx `elem` Node.sList a_ab &&
Iustin Pop's avatar
Iustin Pop committed
942
           inst_idx `notElem` Node.sList d_ab
Iustin Pop's avatar
Iustin Pop committed
943
       x -> printTestCase ("Failed to add/remove instances: " ++ show x) False
944

945
-- | Check mdsk setting.
Iustin Pop's avatar
Iustin Pop committed
946
prop_Node_setMdsk node mx =
Iustin Pop's avatar
Iustin Pop committed
947
948
949
950
951
952
  Node.loDsk node' >= 0 &&
  fromIntegral (Node.loDsk node') <= Node.tDsk node &&
  Node.availDisk node' >= 0 &&
  Node.availDisk node' <= Node.fDsk node' &&
  fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
  Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
953
954
955
956
957
958
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
Iustin Pop's avatar
Iustin Pop committed
959
  Node.delTags (Node.addTags m tags) tags ==? m
960
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
961
962

prop_Node_tagMaps_reject tags =
Iustin Pop's avatar
Iustin Pop committed
963
964
  not (null tags) ==>
  all (\t -> Node.rejectAddTags m [t]) tags
965
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
966

Iustin Pop's avatar
Iustin Pop committed
967
968
969
970
971
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

972
973
974
975
976
977
prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
Iustin Pop's avatar
Iustin Pop committed
978
     (null nodes || not (null ng))
979

980
testSuite "Node"
Iustin Pop's avatar
Iustin Pop committed
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
            [ 'prop_Node_setAlias
            , 'prop_Node_setOffline
            , 'prop_Node_setMcpu
            , 'prop_Node_setXmem
            , 'prop_Node_addPriFM
            , 'prop_Node_addPriFD
            , 'prop_Node_addPriFC
            , 'prop_Node_addSec
            , 'prop_Node_addPriOffline
            , 'prop_Node_addSecOffline
            , 'prop_Node_rMem
            , 'prop_Node_setMdsk
            , 'prop_Node_tagMaps_idempotent
            , 'prop_Node_tagMaps_reject
            , 'prop_Node_showField
            , 'prop_Node_computeGroups
            ]
998

999
-- ** Cluster tests
1000

1001
1002
-- | Check that the cluster score is close to zero for a homogeneous
-- cluster.
Iustin Pop's avatar
Iustin Pop committed
1003
prop_Score_Zero node =
Iustin Pop's avatar
Iustin Pop committed
1004
  forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
1005
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
1006
     (Node.tDsk node > 0) && (Node.tMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
1007
1008
1009
1010
1011
1012
  let fn = Node.buildPeers node Container.empty
      nlst = replicate count fn
      score = Cluster.compCVNodes nlst
  -- we can't say == 0 here as the floating point errors accumulate;
  -- this should be much lower than the default score in CLI.hs
  in score <= 1e-12
1013

1014
-- | Check that cluster stats are sane.
1015
prop_CStats_sane =
Iustin Pop's avatar
Iustin Pop committed
1016
  forAll (choose (1, 1024)) $ \count ->
1017
  forAll genOnlineNode $ \node ->
Iustin Pop's avatar
Iustin Pop committed
1018
1019
1020
1021
1022
1023
  let fn = Node.buildPeers node Container.empty
      nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
      nl = Container.fromList nlst
      cstats = Cluster.totalResources nl
  in Cluster.csAdsk cstats >= 0 &&
     Cluster.csAdsk cstats <= Cluster.csFdsk cstats
Iustin Pop's avatar
Iustin Pop committed
1024

1025
-- | Check that one instance is allocated correctly, without
1026
-- rebalances needed.
1027
prop_ClusterAlloc_sane inst =
Iustin Pop's avatar
Iustin Pop committed
1028
  forAll (choose (5, 20)) $ \count ->
1029
  forAll genOnlineNode $ \node ->
Iustin Pop's avatar
Iustin Pop committed
1030
  let (nl, il, inst') = makeSmallEmptyCluster node count inst
Iustin Pop's avatar
Iustin Pop committed
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
  in case Cluster.genAllocNodes defGroupList nl 2 True >>=
     Cluster.tryAlloc nl il inst' of
       Types.Bad _ -> False
       Types.Ok as ->
         case Cluster.asSolution as of
           Nothing -> False
           Just (xnl, xi, _, cv) ->
             let il' = Container.add (Instance.idx xi) xi il
                 tbl = Cluster.Table xnl il' cv []
             in not (canBalance tbl True True False)
1041
1042
1043

-- | Checks that on a 2-5 node cluster, we can allocate a random
-- instance spec via tiered allocation (whatever the original instance
1044
-- spec), on either one or two nodes.
1045
prop_ClusterCanTieredAlloc inst =
Iustin Pop's avatar
Iustin Pop committed
1046
1047
  forAll (choose (2, 5)) $ \count ->
  forAll (choose (1, 2)) $ \rqnodes ->
1048
  forAll (genOnlineNode `suchThat` (isNodeBig 4)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
1049
1050
1051
1052
1053
1054
1055
1056
1057
  let nl = makeSmallCluster node count
      il = Container.empty
      allocnodes = Cluster.genAllocNodes defGroupList nl rqnodes True
  in case allocnodes >>= \allocnodes' ->
    Cluster.tieredAlloc nl il (Just 1) inst allocnodes' [] [] of
       Types.Bad _ -> False
       Types.Ok (_, _, il', ixes, cstats) -> not (null ixes) &&
                                             IntMap.size il' == length ixes &&
                                             length ixes == length cstats
1058
1059

-- | Checks that on a 4-8 node cluster, once we allocate an instance,