QC.hs 59.8 KB
Newer Older
1
2
{-# LANGUAGE TemplateHaskell #-}

3
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
4
5
6
7
8

-}

{-

Iustin Pop's avatar
Iustin Pop committed
9
Copyright (C) 2009, 2010, 2011, 2012 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

28
module Ganeti.HTools.QC
Iustin Pop's avatar
Iustin Pop committed
29
30
31
32
33
34
  ( testUtils
  , testPeerMap
  , testContainer
  , testInstance
  , testNode
  , testText
35
  , testSimu
Iustin Pop's avatar
Iustin Pop committed
36
37
38
39
40
  , testOpCodes
  , testJobs
  , testCluster
  , testLoader
  , testTypes
41
  , testCLI
Iustin Pop's avatar
Iustin Pop committed
42
  ) where
43
44

import Test.QuickCheck
45
import Text.Printf (printf)
Iustin Pop's avatar
Iustin Pop committed
46
import Data.List (findIndex, intercalate, nub, isPrefixOf)
47
import qualified Data.Set as Set
48
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
49
import Control.Monad
Iustin Pop's avatar
Iustin Pop committed
50
import qualified System.Console.GetOpt as GetOpt
Iustin Pop's avatar
Iustin Pop committed
51
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
52
import qualified Data.Map
53
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
54

Iustin Pop's avatar
Iustin Pop committed
55
import qualified Ganeti.OpCodes as OpCodes
56
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
57
import qualified Ganeti.Luxi
58
59
60
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
61
import qualified Ganeti.HTools.ExtLoader
62
63
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
64
import qualified Ganeti.HTools.JSON as JSON
65
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
66
import qualified Ganeti.HTools.Luxi
67
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
68
import qualified Ganeti.HTools.Group as Group
69
import qualified Ganeti.HTools.PeerMap as PeerMap
70
import qualified Ganeti.HTools.Rapi
71
import qualified Ganeti.HTools.Simu as Simu
72
73
74
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
75
import qualified Ganeti.HTools.Version
76
import qualified Ganeti.Constants as C
77

78
import qualified Ganeti.HTools.Program as Program
79
80
81
82
83
import qualified Ganeti.HTools.Program.Hail
import qualified Ganeti.HTools.Program.Hbal
import qualified Ganeti.HTools.Program.Hscan
import qualified Ganeti.HTools.Program.Hspace

84
import Ganeti.HTools.QCHelper (testSuite)
Iustin Pop's avatar
Iustin Pop committed
85

86
87
-- * Constants

88
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
89
90
91
maxMem :: Int
maxMem = 1024 * 1024

92
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
93
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
94
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
95

96
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
97
98
99
maxCpu :: Int
maxCpu = 1024

100
101
102
103
104
105
106
107
-- | Max vcpu ratio (random value).
maxVcpuRatio :: Double
maxVcpuRatio = 1024.0

-- | Max spindle ratio (random value).
maxSpindleRatio :: Double
maxSpindleRatio = 1024.0

108
109
110
111
-- | All disk templates (used later)
allDiskTemplates :: [Types.DiskTemplate]
allDiskTemplates = [minBound..maxBound]

112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
-- | Null iPolicy, and by null we mean very liberal.
nullIPolicy = Types.IPolicy
  { Types.iPolicyMinSpec = Types.ISpec { Types.iSpecMemorySize = 0
                                       , Types.iSpecCpuCount   = 0
                                       , Types.iSpecDiskSize   = 0
                                       , Types.iSpecDiskCount  = 0
                                       , Types.iSpecNicCount   = 0
                                       }
  , Types.iPolicyMaxSpec = Types.ISpec { Types.iSpecMemorySize = maxBound
                                       , Types.iSpecCpuCount   = maxBound
                                       , Types.iSpecDiskSize   = maxBound
                                       , Types.iSpecDiskCount  = C.maxDisks
                                       , Types.iSpecNicCount   = C.maxNics
                                       }
  , Types.iPolicyStdSpec = Types.ISpec { Types.iSpecMemorySize = Types.unitMem
                                       , Types.iSpecCpuCount   = Types.unitCpu
                                       , Types.iSpecDiskSize   = Types.unitDsk
                                       , Types.iSpecDiskCount  = 1
                                       , Types.iSpecNicCount   = 1
                                       }
  , Types.iPolicyDiskTemplates = [Types.DTDrbd8, Types.DTPlain]
133
134
135
  , Types.iPolicyVcpuRatio = maxVcpuRatio -- somewhat random value, high
                                          -- enough to not impact us
  , Types.iPolicySpindleRatio = maxSpindleRatio
136
137
138
  }


Iustin Pop's avatar
Iustin Pop committed
139
140
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
Iustin Pop's avatar
Iustin Pop committed
141
             Group.create "default" Types.defaultGroupID Types.AllocPreferred
142
                  nullIPolicy
Iustin Pop's avatar
Iustin Pop committed
143
144

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
145
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
146
147
148
149

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

150
151
-- * Helper functions

152
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
153
154
155
156
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

Iustin Pop's avatar
Iustin Pop committed
157
158
159
160
161
162
163
-- | Checks for equality with proper annotation.
(==?) :: (Show a, Eq a) => a -> a -> Property
(==?) x y = printTestCase
            ("Expected equality, but '" ++
             show x ++ "' /= '" ++ show y ++ "'") (x == y)
infix 3 ==?

Iustin Pop's avatar
Iustin Pop committed
164
165
166
167
-- | Show a message and fail the test.
failTest :: String -> Property
failTest msg = printTestCase msg False

168
-- | Update an instance to be smaller than a node.
169
setInstanceSmallerThanNode node inst =
Iustin Pop's avatar
Iustin Pop committed
170
171
172
173
  inst { Instance.mem = Node.availMem node `div` 2
       , Instance.dsk = Node.availDisk node `div` 2
       , Instance.vcpus = Node.availCpu node `div` 2
       }
174

175
-- | Create an instance given its spec.
176
createInstance mem dsk vcpus =
Iustin Pop's avatar
Iustin Pop committed
177
178
  Instance.create "inst-unnamed" mem dsk vcpus Types.Running [] True (-1) (-1)
    Types.DTDrbd8
179

180
-- | Create a small cluster by repeating a node spec.
181
182
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
183
184
185
186
187
188
189
  let origname = Node.name node
      origalias = Node.alias node
      nodes = map (\idx -> node { Node.name = origname ++ "-" ++ show idx
                                , Node.alias = origalias ++ "-" ++ show idx })
              [1..count]
      fn = flip Node.buildPeers Container.empty
      namelst = map (\n -> (Node.name n, fn n)) nodes
Iustin Pop's avatar
Iustin Pop committed
190
191
      (_, nlst) = Loader.assignIndices namelst
  in nlst
192

Iustin Pop's avatar
Iustin Pop committed
193
194
195
196
197
198
199
-- | Make a small cluster, both nodes and instances.
makeSmallEmptyCluster :: Node.Node -> Int -> Instance.Instance
                      -> (Node.List, Instance.List, Instance.Instance)
makeSmallEmptyCluster node count inst =
  (makeSmallCluster node count, Container.empty,
   setInstanceSmallerThanNode node inst)

200
-- | Checks if a node is "big" enough.
201
202
isNodeBig :: Int -> Node.Node -> Bool
isNodeBig size node = Node.availDisk node > size * Types.unitDsk
203
204
205
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

206
207
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
208

209
-- | Assigns a new fresh instance to a cluster; this is not
210
-- allocation, so no resource checks are done.
211
212
213
214
215
216
217
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
Iustin Pop's avatar
Iustin Pop committed
218
219
                  then 0
                  else fst (Container.findMax il) + 1
220
221
222
223
224
225
226
227
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

228
229
230
231
232
233
234
-- | Generates a list of a given size with non-duplicate elements.
genUniquesList :: (Eq a, Arbitrary a) => Int -> Gen [a]
genUniquesList cnt =
  foldM (\lst _ -> do
           newelem <- arbitrary `suchThat` (`notElem` lst)
           return (newelem:lst)) [] [1..cnt]

235
236
-- * Arbitrary instances

237
-- | Defines a DNS name.
238
newtype DNSChar = DNSChar { dnsGetChar::Char }
239

240
instance Arbitrary DNSChar where
Iustin Pop's avatar
Iustin Pop committed
241
242
243
  arbitrary = do
    x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
    return (DNSChar x)
244

245
-- | Generates a single name component.
246
247
248
249
250
251
getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)

252
-- | Generates an entire FQDN.
253
254
255
getFQDN :: Gen String
getFQDN = do
  ncomps <- choose (1, 4)
256
257
  names <- mapM (const getName) [1..ncomps::Int]
  return $ intercalate "." names
258

259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
-- | Defines a tag type.
newtype TagChar = TagChar { tagGetChar :: Char }

-- | All valid tag chars. This doesn't need to match _exactly_
-- Ganeti's own tag regex, just enough for it to be close.
tagChar :: [Char]
tagChar = ['a'..'z'] ++ ['A'..'Z'] ++ ['0'..'9'] ++ ".+*/:@-"

instance Arbitrary TagChar where
  arbitrary = do
    c <- elements tagChar
    return (TagChar c)

-- | Generates a tag
genTag :: Gen [TagChar]
genTag = do
  -- the correct value would be C.maxTagLen, but that's way too
  -- verbose in unittests, and at the moment I don't see any possible
  -- bugs with longer tags and the way we use tags in htools
  n <- choose (1, 10)
  vector n

-- | Generates a list of tags (correctly upper bounded).
genTags :: Gen [String]
genTags = do
  -- the correct value would be C.maxTagsPerObj, but per the comment
  -- in genTag, we don't use tags enough in htools to warrant testing
  -- such big values
  n <- choose (0, 10::Int)
  tags <- mapM (const genTag) [1..n]
  return $ map (map tagGetChar) tags

291
instance Arbitrary Types.InstanceStatus where
292
    arbitrary = elements [minBound..maxBound]
293

294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
-- | Generates a random instance with maximum disk/mem/cpu values.
genInstanceSmallerThan :: Int -> Int -> Int -> Gen Instance.Instance
genInstanceSmallerThan lim_mem lim_dsk lim_cpu = do
  name <- getFQDN
  mem <- choose (0, lim_mem)
  dsk <- choose (0, lim_dsk)
  run_st <- arbitrary
  pn <- arbitrary
  sn <- arbitrary
  vcpus <- choose (0, lim_cpu)
  return $ Instance.create name mem dsk vcpus run_st [] True pn sn
         Types.DTDrbd8

-- | Generates an instance smaller than a node.
genInstanceSmallerThanNode :: Node.Node -> Gen Instance.Instance
genInstanceSmallerThanNode node =
  genInstanceSmallerThan (Node.availMem node `div` 2)
                         (Node.availDisk node `div` 2)
                         (Node.availCpu node `div` 2)

314
315
-- let's generate a random instance
instance Arbitrary Instance.Instance where
316
  arbitrary = genInstanceSmallerThan maxMem maxDsk maxCpu
317

318
319
320
321
322
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
323
324
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
Iustin Pop's avatar
Iustin Pop committed
325
326
327
328
329
        case min_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (0, 0, 0)
330
      (top_mem, top_dsk, top_cpu)  =
Iustin Pop's avatar
Iustin Pop committed
331
332
333
334
335
        case max_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (maxMem, maxDsk, maxCpu)
336
337
338
339
340
341
342
343
344
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
345
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 1 0
Iustin Pop's avatar
Iustin Pop committed
346
347
      n' = Node.setPolicy nullIPolicy n
  return $ Node.buildPeers n' Container.empty
348

349
350
351
352
353
354
355
356
357
-- | Helper function to generate a sane node.
genOnlineNode :: Gen Node.Node
genOnlineNode = do
  arbitrary `suchThat` (\n -> not (Node.offline n) &&
                              not (Node.failN1 n) &&
                              Node.availDisk n > 0 &&
                              Node.availMem n > 0 &&
                              Node.availCpu n > 0)

358
359
-- and a random node
instance Arbitrary Node.Node where
Iustin Pop's avatar
Iustin Pop committed
360
  arbitrary = genNode Nothing Nothing
361

Iustin Pop's avatar
Iustin Pop committed
362
363
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
364
  arbitrary = elements [minBound..maxBound]
Iustin Pop's avatar
Iustin Pop committed
365
366
367
368
369
370
371
372

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
Iustin Pop's avatar
Iustin Pop committed
373
374
375
376
377
378
379
380
381
382
383
384
385
    case op_id of
      "OP_TEST_DELAY" ->
        liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
      "OP_INSTANCE_REPLACE_DISKS" ->
        liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
          arbitrary arbitrary arbitrary
      "OP_INSTANCE_FAILOVER" ->
        liftM3 OpCodes.OpInstanceFailover arbitrary arbitrary
          arbitrary
      "OP_INSTANCE_MIGRATE" ->
        liftM5 OpCodes.OpInstanceMigrate arbitrary arbitrary
          arbitrary arbitrary arbitrary
      _ -> fail "Wrong opcode"
Iustin Pop's avatar
Iustin Pop committed
386

387
388
389
390
391
392
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

393
394
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
Iustin Pop's avatar
Iustin Pop committed
395
396
397
  arbitrary = do
    v <- choose (0, 1)
    return $ SmallRatio v
398

399
400
401
402
403
404
instance Arbitrary Types.AllocPolicy where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Types.DiskTemplate where
  arbitrary = elements [minBound..maxBound]

405
instance Arbitrary Types.FailMode where
Iustin Pop's avatar
Iustin Pop committed
406
  arbitrary = elements [minBound..maxBound]
407

408
409
410
instance Arbitrary Types.EvacMode where
  arbitrary = elements [minBound..maxBound]

411
instance Arbitrary a => Arbitrary (Types.OpResult a) where
Iustin Pop's avatar
Iustin Pop committed
412
  arbitrary = arbitrary >>= \c ->
Iustin Pop's avatar
Iustin Pop committed
413
414
415
              if c
                then liftM Types.OpGood arbitrary
                else liftM Types.OpFail arbitrary
416

417
418
instance Arbitrary Types.ISpec where
  arbitrary = do
419
    mem_s <- arbitrary::Gen (NonNegative Int)
420
421
    dsk_c <- arbitrary::Gen (NonNegative Int)
    dsk_s <- arbitrary::Gen (NonNegative Int)
422
423
424
425
    cpu_c <- arbitrary::Gen (NonNegative Int)
    nic_c <- arbitrary::Gen (NonNegative Int)
    return Types.ISpec { Types.iSpecMemorySize = fromIntegral mem_s
                       , Types.iSpecCpuCount   = fromIntegral cpu_c
426
427
                       , Types.iSpecDiskSize   = fromIntegral dsk_s
                       , Types.iSpecDiskCount  = fromIntegral dsk_c
428
                       , Types.iSpecNicCount   = fromIntegral nic_c
429
430
                       }

431
432
433
434
435
436
437
438
439
440
441
442
443
444
-- | Generates an ispec bigger than the given one.
genBiggerISpec :: Types.ISpec -> Gen Types.ISpec
genBiggerISpec imin = do
  mem_s <- choose (Types.iSpecMemorySize imin, maxBound)
  dsk_c <- choose (Types.iSpecDiskCount imin, maxBound)
  dsk_s <- choose (Types.iSpecDiskSize imin, maxBound)
  cpu_c <- choose (Types.iSpecCpuCount imin, maxBound)
  nic_c <- choose (Types.iSpecNicCount imin, maxBound)
  return Types.ISpec { Types.iSpecMemorySize = fromIntegral mem_s
                     , Types.iSpecCpuCount   = fromIntegral cpu_c
                     , Types.iSpecDiskSize   = fromIntegral dsk_s
                     , Types.iSpecDiskCount  = fromIntegral dsk_c
                     , Types.iSpecNicCount   = fromIntegral nic_c
                     }
445
446
447
448

instance Arbitrary Types.IPolicy where
  arbitrary = do
    imin <- arbitrary
449
450
451
452
    istd <- genBiggerISpec imin
    imax <- genBiggerISpec istd
    num_tmpl <- choose (0, length allDiskTemplates)
    dts  <- genUniquesList num_tmpl
453
454
    vcpu_ratio <- choose (1.0, maxVcpuRatio)
    spindle_ratio <- choose (1.0, maxSpindleRatio)
455
456
457
458
    return Types.IPolicy { Types.iPolicyMinSpec = imin
                         , Types.iPolicyStdSpec = istd
                         , Types.iPolicyMaxSpec = imax
                         , Types.iPolicyDiskTemplates = dts
459
                         , Types.iPolicyVcpuRatio = vcpu_ratio
460
                         , Types.iPolicySpindleRatio = spindle_ratio
461
462
                         }

463
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
464

465
466
-- ** Utils tests

467
468
469
470
471
-- | Helper to generate a small string that doesn't contain commas.
genNonCommaString = do
  size <- choose (0, 20) -- arbitrary max size
  vectorOf size (arbitrary `suchThat` ((/=) ','))

472
473
-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
474
prop_Utils_commaJoinSplit =
475
476
  forAll (choose (0, 20)) $ \llen ->
  forAll (vectorOf llen genNonCommaString `suchThat` ((/=) [""])) $ \lst ->
Iustin Pop's avatar
Iustin Pop committed
477
  Utils.sepSplit ',' (Utils.commaJoin lst) ==? lst
Iustin Pop's avatar
Iustin Pop committed
478

479
-- | Split and join should always be idempotent.
Iustin Pop's avatar
Iustin Pop committed
480
prop_Utils_commaSplitJoin s =
Iustin Pop's avatar
Iustin Pop committed
481
  Utils.commaJoin (Utils.sepSplit ',' s) ==? s
482

483
-- | fromObjWithDefault, we test using the Maybe monad and an integer
484
-- value.
485
prop_Utils_fromObjWithDefault def_value random_key =
Iustin Pop's avatar
Iustin Pop committed
486
  -- a missing key will be returned with the default
487
  JSON.fromObjWithDefault [] random_key def_value == Just def_value &&
Iustin Pop's avatar
Iustin Pop committed
488
  -- a found key will be returned as is, not with default
489
  JSON.fromObjWithDefault [(random_key, J.showJSON def_value)]
Iustin Pop's avatar
Iustin Pop committed
490
491
       random_key (def_value+1) == Just def_value
    where _types = def_value :: Integer
492

493
-- | Test that functional if' behaves like the syntactic sugar if.
Iustin Pop's avatar
Iustin Pop committed
494
495
prop_Utils_if'if :: Bool -> Int -> Int -> Gen Prop
prop_Utils_if'if cnd a b =
Iustin Pop's avatar
Iustin Pop committed
496
  Utils.if' cnd a b ==? if cnd then a else b
497

Guido Trotter's avatar
Guido Trotter committed
498
-- | Test basic select functionality
Iustin Pop's avatar
Iustin Pop committed
499
500
501
502
prop_Utils_select :: Int      -- ^ Default result
                  -> [Int]    -- ^ List of False values
                  -> [Int]    -- ^ List of True values
                  -> Gen Prop -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
503
prop_Utils_select def lst1 lst2 =
Iustin Pop's avatar
Iustin Pop committed
504
  Utils.select def (flist ++ tlist) ==? expectedresult
Iustin Pop's avatar
Iustin Pop committed
505
506
507
    where expectedresult = Utils.if' (null lst2) def (head lst2)
          flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
508
509

-- | Test basic select functionality with undefined default
Iustin Pop's avatar
Iustin Pop committed
510
prop_Utils_select_undefd :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
511
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
512
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
513
prop_Utils_select_undefd lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
514
  Utils.select undefined (flist ++ tlist) ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
515
516
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
517
518

-- | Test basic select functionality with undefined list values
Iustin Pop's avatar
Iustin Pop committed
519
prop_Utils_select_undefv :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
520
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
521
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
522
prop_Utils_select_undefv lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
523
  Utils.select undefined cndlist ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
524
525
526
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
          cndlist = flist ++ tlist ++ [undefined]
527

Iustin Pop's avatar
Iustin Pop committed
528
prop_Utils_parseUnit (NonNegative n) =
Iustin Pop's avatar
Iustin Pop committed
529
530
531
532
533
534
535
536
537
538
  Utils.parseUnit (show n) == Types.Ok n &&
  Utils.parseUnit (show n ++ "m") == Types.Ok n &&
  (case Utils.parseUnit (show n ++ "M") of
     Types.Ok m -> if n > 0
                     then m < n  -- for positive values, X MB is < than X MiB
                     else m == 0 -- but for 0, 0 MB == 0 MiB
     Types.Bad _ -> False) &&
  Utils.parseUnit (show n ++ "g") == Types.Ok (n*1024) &&
  Utils.parseUnit (show n ++ "t") == Types.Ok (n*1048576) &&
  Types.isBad (Utils.parseUnit (show n ++ "x")::Types.Result Int)
Iustin Pop's avatar
Iustin Pop committed
539
    where _types = n::Int
Iustin Pop's avatar
Iustin Pop committed
540

541
-- | Test list for the Utils module.
542
testSuite "Utils"
Iustin Pop's avatar
Iustin Pop committed
543
544
545
546
547
548
549
550
551
            [ 'prop_Utils_commaJoinSplit
            , 'prop_Utils_commaSplitJoin
            , 'prop_Utils_fromObjWithDefault
            , 'prop_Utils_if'if
            , 'prop_Utils_select
            , 'prop_Utils_select_undefd
            , 'prop_Utils_select_undefv
            , 'prop_Utils_parseUnit
            ]
552

553
554
555
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
556
prop_PeerMap_addIdempotent pmap key em =
Iustin Pop's avatar
Iustin Pop committed
557
  fn puniq ==? fn (fn puniq)
558
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
559
560
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
561
          puniq = PeerMap.accumArray const pmap
562

563
-- | Make sure remove is idempotent.
564
prop_PeerMap_removeIdempotent pmap key =
Iustin Pop's avatar
Iustin Pop committed
565
  fn puniq ==? fn (fn puniq)
566
567
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
568
569
          puniq = PeerMap.accumArray const pmap

570
-- | Make sure a missing item returns 0.
571
prop_PeerMap_findMissing pmap key =
Iustin Pop's avatar
Iustin Pop committed
572
  PeerMap.find key (PeerMap.remove key puniq) ==? 0
573
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
574
575
          puniq = PeerMap.accumArray const pmap

576
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
577
prop_PeerMap_addFind pmap key em =
Iustin Pop's avatar
Iustin Pop committed
578
  PeerMap.find key (PeerMap.add key em puniq) ==? em
579
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
580
                    key::PeerMap.Key, em::PeerMap.Elem)
581
          puniq = PeerMap.accumArray const pmap
582

583
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
584
prop_PeerMap_maxElem pmap =
Iustin Pop's avatar
Iustin Pop committed
585
  PeerMap.maxElem puniq ==? if null puniq then 0
Iustin Pop's avatar
Iustin Pop committed
586
                              else (maximum . snd . unzip) puniq
587
    where _types = pmap::PeerMap.PeerMap
588
589
          puniq = PeerMap.accumArray const pmap

590
-- | List of tests for the PeerMap module.
591
testSuite "PeerMap"
Iustin Pop's avatar
Iustin Pop committed
592
593
594
595
596
597
            [ 'prop_PeerMap_addIdempotent
            , 'prop_PeerMap_removeIdempotent
            , 'prop_PeerMap_maxElem
            , 'prop_PeerMap_addFind
            , 'prop_PeerMap_findMissing
            ]
598

599
-- ** Container tests
600

Iustin Pop's avatar
Iustin Pop committed
601
602
-- we silence the following due to hlint bug fixed in later versions
{-# ANN prop_Container_addTwo "HLint: ignore Avoid lambda" #-}
603
prop_Container_addTwo cdata i1 i2 =
Iustin Pop's avatar
Iustin Pop committed
604
605
  fn i1 i2 cont == fn i2 i1 cont &&
  fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
606
607
608
609
610
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

611
612
613
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
Iustin Pop's avatar
Iustin Pop committed
614
  in Container.nameOf nl (Node.idx fnode) ==? Node.name fnode
615

616
-- | We test that in a cluster, given a random node, we can find it by
617
-- its name and alias, as long as all names and aliases are unique,
618
-- and that we fail to find a non-existing name.
619
prop_Container_findByName node =
620
621
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
622
623
624
625
  forAll (genUniquesList (cnt * 2)) $ \ allnames ->
  forAll (arbitrary `suchThat` (`notElem` allnames)) $ \ othername ->
  let names = zip (take cnt allnames) (drop cnt allnames)
      nl = makeSmallCluster node cnt
626
627
628
629
630
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
631
      nl' = Container.fromList nodes'
632
633
634
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
Iustin Pop's avatar
Iustin Pop committed
635
     isNothing (Container.findByName nl' othername)
636

637
testSuite "Container"
Iustin Pop's avatar
Iustin Pop committed
638
639
640
641
            [ 'prop_Container_addTwo
            , 'prop_Container_nameOf
            , 'prop_Container_findByName
            ]
642

643
644
-- ** Instance tests

645
646
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
647
prop_Instance_creat inst =
Iustin Pop's avatar
Iustin Pop committed
648
  Instance.name inst ==? Instance.alias inst
Iustin Pop's avatar
Iustin Pop committed
649

650
prop_Instance_setIdx inst idx =
Iustin Pop's avatar
Iustin Pop committed
651
  Instance.idx (Instance.setIdx inst idx) ==? idx
652
653
654
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
655
656
  Instance.name newinst == name &&
  Instance.alias newinst == name
Iustin Pop's avatar
Iustin Pop committed
657
658
659
660
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
Iustin Pop's avatar
Iustin Pop committed
661
662
  Instance.name newinst == Instance.name inst &&
  Instance.alias newinst == name
663
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
664
          newinst = Instance.setAlias inst name
665
666

prop_Instance_setPri inst pdx =
Iustin Pop's avatar
Iustin Pop committed
667
  Instance.pNode (Instance.setPri inst pdx) ==? pdx
668
669
670
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
Iustin Pop's avatar
Iustin Pop committed
671
  Instance.sNode (Instance.setSec inst sdx) ==? sdx
672
673
674
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
Iustin Pop's avatar
Iustin Pop committed
675
  Instance.pNode si == pdx && Instance.sNode si == sdx
676
677
678
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
679
prop_Instance_shrinkMG inst =
Iustin Pop's avatar
Iustin Pop committed
680
681
682
683
  Instance.mem inst >= 2 * Types.unitMem ==>
    case Instance.shrinkByType inst Types.FailMem of
      Types.Ok inst' -> Instance.mem inst' == Instance.mem inst - Types.unitMem
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
684
685

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
686
  forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
Iustin Pop's avatar
Iustin Pop committed
687
688
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
689
690

prop_Instance_shrinkCG inst =
Iustin Pop's avatar
Iustin Pop committed
691
692
693
694
695
  Instance.vcpus inst >= 2 * Types.unitCpu ==>
    case Instance.shrinkByType inst Types.FailCPU of
      Types.Ok inst' ->
        Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
696
697

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
698
  forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
Iustin Pop's avatar
Iustin Pop committed
699
700
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
701
702

prop_Instance_shrinkDG inst =
Iustin Pop's avatar
Iustin Pop committed
703
704
705
706
707
  Instance.dsk inst >= 2 * Types.unitDsk ==>
    case Instance.shrinkByType inst Types.FailDisk of
      Types.Ok inst' ->
        Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
708
709

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
710
  forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
Iustin Pop's avatar
Iustin Pop committed
711
712
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
713
714

prop_Instance_setMovable inst m =
Iustin Pop's avatar
Iustin Pop committed
715
  Instance.movable inst' ==? m
716
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
717

718
testSuite "Instance"
Iustin Pop's avatar
Iustin Pop committed
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
            [ 'prop_Instance_creat
            , 'prop_Instance_setIdx
            , 'prop_Instance_setName
            , 'prop_Instance_setAlias
            , 'prop_Instance_setPri
            , 'prop_Instance_setSec
            , 'prop_Instance_setBoth
            , 'prop_Instance_shrinkMG
            , 'prop_Instance_shrinkMF
            , 'prop_Instance_shrinkCG
            , 'prop_Instance_shrinkCF
            , 'prop_Instance_shrinkDG
            , 'prop_Instance_shrinkDF
            , 'prop_Instance_setMovable
            ]
Iustin Pop's avatar
Iustin Pop committed
734

735
736
737
-- ** Backends

-- *** Text backend tests
738

Iustin Pop's avatar
Iustin Pop committed
739
740
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
741
742
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
743
                        (NonNegative pdx) (NonNegative sdx) autobal dt =
Iustin Pop's avatar
Iustin Pop committed
744
745
746
747
748
749
  pnode /= snode && pdx /= sdx ==>
  let vcpus_s = show vcpus
      dsk_s = show dsk
      mem_s = show mem
      status_s = Types.instanceStatusToRaw status
      ndx = if null snode
Iustin Pop's avatar
Iustin Pop committed
750
              then [(pnode, pdx)]
751
              else [(pnode, pdx), (snode, sdx)]
Iustin Pop's avatar
Iustin Pop committed
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
      nl = Data.Map.fromList ndx
      tags = ""
      sbal = if autobal then "Y" else "N"
      sdt = Types.diskTemplateToRaw dt
      inst = Text.loadInst nl
             [name, mem_s, dsk_s, vcpus_s, status_s,
              sbal, pnode, snode, sdt, tags]
      fail1 = Text.loadInst nl
              [name, mem_s, dsk_s, vcpus_s, status_s,
               sbal, pnode, pnode, tags]
      _types = ( name::String, mem::Int, dsk::Int
               , vcpus::Int, status::Types.InstanceStatus
               , snode::String
               , autobal::Bool)
  in case inst of
Iustin Pop's avatar
Iustin Pop committed
767
       Types.Bad msg -> failTest $ "Failed to load instance: " ++ msg
Iustin Pop's avatar
Iustin Pop committed
768
769
770
771
772
773
774
775
776
777
778
       Types.Ok (_, i) -> printTestCase "Mismatch in some field while\
                                        \ loading the instance" $
               Instance.name i == name &&
               Instance.vcpus i == vcpus &&
               Instance.mem i == mem &&
               Instance.pNode i == pdx &&
               Instance.sNode i == (if null snode
                                      then Node.noSecondary
                                      else sdx) &&
               Instance.autoBalance i == autobal &&
               Types.isBad fail1
Iustin Pop's avatar
Iustin Pop committed
779
780

prop_Text_Load_InstanceFail ktn fields =
Iustin Pop's avatar
Iustin Pop committed
781
  length fields /= 10 ==>
Iustin Pop's avatar
Iustin Pop committed
782
    case Text.loadInst nl fields of
Iustin Pop's avatar
Iustin Pop committed
783
      Types.Ok _ -> failTest "Managed to load instance from invalid data"
784
785
      Types.Bad msg -> printTestCase ("Unrecognised error message: " ++ msg) $
                       "Invalid/incomplete instance data: '" `isPrefixOf` msg
786
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
787
788

prop_Text_Load_Node name tm nm fm td fd tc fo =
Iustin Pop's avatar
Iustin Pop committed
789
790
791
792
793
794
795
796
797
798
  let conv v = if v < 0
                 then "?"
                 else show v
      tm_s = conv tm
      nm_s = conv nm
      fm_s = conv fm
      td_s = conv td
      fd_s = conv fd
      tc_s = conv tc
      fo_s = if fo
Iustin Pop's avatar
Iustin Pop committed
799
800
               then "Y"
               else "N"
Iustin Pop's avatar
Iustin Pop committed
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
      any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
      gid = Group.uuid defGroup
  in case Text.loadNode defGroupAssoc
       [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
       Nothing -> False
       Just (name', node) ->
         if fo || any_broken
           then Node.offline node
           else Node.name node == name' && name' == name &&
                Node.alias node == name &&
                Node.tMem node == fromIntegral tm &&
                Node.nMem node == nm &&
                Node.fMem node == fm &&
                Node.tDsk node == fromIntegral td &&
                Node.fDsk node == fd &&
                Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
817
818

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
819
  length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
820

821
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
822
  (Text.loadNode defGroupAssoc.
823
       Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==?
Iustin Pop's avatar
Iustin Pop committed
824
  Just (Node.name n, n)
825
    -- override failN1 to what loadNode returns by default
826
827
    where n = Node.setPolicy Types.defIPolicy $
              node { Node.failN1 = True, Node.offline = False }
828

829
830
831
prop_Text_ISpecIdempotent ispec =
  case Text.loadISpec "dummy" . Utils.sepSplit ',' .
       Text.serializeISpec $ ispec of
Iustin Pop's avatar
Iustin Pop committed
832
    Types.Bad msg -> failTest $ "Failed to load ispec: " ++ msg
833
834
835
836
837
    Types.Ok ispec' -> ispec ==? ispec'

prop_Text_IPolicyIdempotent ipol =
  case Text.loadIPolicy . Utils.sepSplit '|' $
       Text.serializeIPolicy owner ipol of
Iustin Pop's avatar
Iustin Pop committed
838
    Types.Bad msg -> failTest $ "Failed to load ispec: " ++ msg
839
840
841
    Types.Ok res -> (owner, ipol) ==? res
  where owner = "dummy"

842
843
844
845
846
847
848
849
850
851
852
853
854
-- | This property, while being in the text tests, does more than just
-- test end-to-end the serialisation and loading back workflow; it
-- also tests the Loader.mergeData and the actuall
-- Cluster.iterateAlloc (for well-behaving w.r.t. instance
-- allocations, not for the business logic). As such, it's a quite
-- complex and slow test, and that's the reason we restrict it to
-- small cluster sizes.
prop_Text_CreateSerialise =
  forAll genTags $ \ctags ->
  forAll (choose (1, 2)) $ \reqnodes ->
  forAll (choose (1, 20)) $ \maxiter ->
  forAll (choose (2, 10)) $ \count ->
  forAll genOnlineNode $ \node ->
855
856
  forAll (genInstanceSmallerThanNode node) $ \inst ->
  let inst' = Instance.setMovable inst (reqnodes == 2)
857
858
859
860
      nl = makeSmallCluster node count
  in case Cluster.genAllocNodes defGroupList nl reqnodes True >>= \allocn ->
     Cluster.iterateAlloc nl Container.empty (Just maxiter) inst' allocn [] []
     of
Iustin Pop's avatar
Iustin Pop committed
861
       Types.Bad msg -> failTest $ "Failed to allocate: " ++ msg
862
863
864
865
866
867
868
       Types.Ok (_, _, _, [], _) -> printTestCase
                                    "Failed to allocate: no allocations" False
       Types.Ok (_, nl', il', _, _) ->
         let cdata = Loader.ClusterData defGroupList nl' il' ctags
                     Types.defIPolicy
             saved = Text.serializeCluster cdata
         in case Text.parseData saved >>= Loader.mergeData [] [] [] [] of
Iustin Pop's avatar
Iustin Pop committed
869
              Types.Bad msg -> failTest $ "Failed to load/merge: " ++ msg
870
871
872
873
              Types.Ok (Loader.ClusterData gl2 nl2 il2 ctags2 cpol2) ->
                ctags ==? ctags2 .&&.
                Types.defIPolicy ==? cpol2 .&&.
                il' ==? il2 .&&.
874
875
                defGroupList ==? gl2 .&&.
                nl' ==? nl2
876

877
testSuite "Text"
Iustin Pop's avatar
Iustin Pop committed
878
879
880
881
882
            [ 'prop_Text_Load_Instance
            , 'prop_Text_Load_InstanceFail
            , 'prop_Text_Load_Node
            , 'prop_Text_Load_NodeFail
            , 'prop_Text_NodeLSIdempotent
883
884
            , 'prop_Text_ISpecIdempotent
            , 'prop_Text_IPolicyIdempotent
885
            , 'prop_Text_CreateSerialise
Iustin Pop's avatar
Iustin Pop committed
886
            ]
887

888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
-- *** Simu backend

-- | Generates a tuple of specs for simulation.
genSimuSpec :: Gen (String, Int, Int, Int, Int)
genSimuSpec = do
  pol <- elements [C.allocPolicyPreferred,
                   C.allocPolicyLastResort, C.allocPolicyUnallocable,
                  "p", "a", "u"]
 -- should be reasonable (nodes/group), bigger values only complicate
 -- the display of failed tests, and we don't care (in this particular
 -- test) about big node groups
  nodes <- choose (0, 20)
  dsk <- choose (0, maxDsk)
  mem <- choose (0, maxMem)
  cpu <- choose (0, maxCpu)
  return (pol, nodes, dsk, mem, cpu)

-- | Checks that given a set of corrects specs, we can load them
-- successfully, and that at high-level the values look right.
prop_SimuLoad =
  forAll (choose (0, 10)) $ \ngroups ->
  forAll (replicateM ngroups genSimuSpec) $ \specs ->
  let strspecs = map (\(p, n, d, m, c) -> printf "%s,%d,%d,%d,%d"
                                          p n d m c::String) specs
      totnodes = sum $ map (\(_, n, _, _, _) -> n) specs
      mdc_in = concatMap (\(_, n, d, m, c) ->
                            replicate n (fromIntegral m, fromIntegral d,
                                         fromIntegral c,
                                         fromIntegral m, fromIntegral d)) specs
  in case Simu.parseData strspecs of
       Types.Bad msg -> failTest $ "Failed to load specs: " ++ msg
       Types.Ok (Loader.ClusterData gl nl il tags ipol) ->
         let nodes = map snd $ IntMap.toAscList nl
             nidx = map Node.idx nodes
             mdc_out = map (\n -> (Node.tMem n, Node.tDsk n, Node.tCpu n,
                                   Node.fMem n, Node.fDsk n)) nodes
         in
         Container.size gl ==? ngroups .&&.
         Container.size nl ==? totnodes .&&.
         Container.size il ==? 0 .&&.
         length tags ==? 0 .&&.
         ipol ==? Types.defIPolicy .&&.
         nidx ==? [1..totnodes] .&&.
         mdc_in ==? mdc_out .&&.
         map Group.iPolicy (Container.elems gl) ==?
             replicate ngroups Types.defIPolicy

testSuite "Simu"
            [ 'prop_SimuLoad
            ]

939
-- ** Node tests
940

Iustin Pop's avatar
Iustin Pop committed
941
prop_Node_setAlias node name =
Iustin Pop's avatar
Iustin Pop committed
942
943
  Node.name newnode == Node.name node &&
  Node.alias newnode == name
Iustin Pop's avatar
Iustin Pop committed
944
945
946
947
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
Iustin Pop's avatar
Iustin Pop committed
948
  Node.offline newnode ==? status
Iustin Pop's avatar
Iustin Pop committed
949
950
951
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
Iustin Pop's avatar
Iustin Pop committed
952
  Node.xMem newnode ==? xm
Iustin Pop's avatar
Iustin Pop committed
953
954
955
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
956
  Types.iPolicyVcpuRatio (Node.iPolicy newnode) ==? mc
Iustin Pop's avatar
Iustin Pop committed
957
958
    where newnode = Node.setMcpu node mc

959
960
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
961
962
prop_Node_addPriFM node inst =
  Instance.mem inst >= Node.fMem node && not (Node.failN1 node) &&
Iustin Pop's avatar
Iustin Pop committed
963
  not (Instance.isOffline inst) ==>
Iustin Pop's avatar
Iustin Pop committed
964
965
966
967
968
969
970
971
972
973
974
975
  case Node.addPri node inst'' of
    Types.OpFail Types.FailMem -> True
    _ -> False
  where _types = (node::Node.Node, inst::Instance.Instance)
        inst' = setInstanceSmallerThanNode node inst
        inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst =
  Instance.dsk inst >= Node.fDsk node && not (Node.failN1 node) ==>
    case Node.addPri node inst'' of
      Types.OpFail Types.FailDisk -> True
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
976
977
978
979
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

980
981
prop_Node_addPriFC =
  forAll (choose (1, maxCpu)) $ \extra ->
982
  forAll genOnlineNode $ \node ->
Iustin Pop's avatar
Iustin Pop committed
983
  forAll (arbitrary `suchThat` Instance.notOffline) $ \inst ->
984
985
986
987
988
  let inst' = setInstanceSmallerThanNode node inst
      inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
  in case Node.addPri node inst'' of
       Types.OpFail Types.FailCPU -> property True
       v -> failTest $ "Expected OpFail FailCPU, but got " ++ show v
989

990
991
-- | Check that an instance add with too high memory or disk will be
-- rejected.
992
prop_Node_addSec node inst pdx =
Iustin Pop's avatar
Iustin Pop committed
993
  ((Instance.mem inst >= (Node.fMem node - Node.rMem node) &&
Iustin Pop's avatar
Iustin Pop committed
994
    not (Instance.isOffline inst)) ||
Iustin Pop's avatar
Iustin Pop committed
995
996
997
   Instance.dsk inst >= Node.fDsk node) &&
  not (Node.failN1 node) ==>
      isFailure (Node.addSec node inst pdx)
998
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
999

Iustin Pop's avatar
Iustin Pop committed
1000
1001
1002
-- | Check that an offline instance with reasonable disk size but
-- extra mem/cpu can always be added.
prop_Node_addOffline (NonNegative extra_mem) (NonNegative extra_cpu) pdx =
1003
  forAll genOnlineNode $ \node ->
Iustin Pop's avatar
Iustin Pop committed
1004
1005
1006
1007
1008
1009
1010
  forAll (genInstanceSmallerThanNode node) $ \inst ->
  let inst' = inst { Instance.runSt = Types.AdminOffline
                   , Instance.mem = Node.availMem node + extra_mem
                   , Instance.vcpus = Node.availCpu node + extra_cpu }
  in case (Node.addPri node inst', Node.addSec node inst' pdx) of
       (Types.OpGood _, Types.OpGood _) -> property True
       v -> failTest $ "Expected OpGood/OpGood, but got: " ++ show v
1011

1012
-- | Checks for memory reservation changes.
1013
prop_Node_rMem inst =
Iustin Pop's avatar
Iustin Pop committed
1014
  not (Instance.isOffline inst) ==>
Iustin Pop's avatar
Iustin Pop committed
1015
  forAll (genOnlineNode `suchThat` ((> Types.unitMem) . Node.fMem)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
1016
1017
1018
1019
1020
1021
1022