QC.hs 40.6 KB
Newer Older
1
2
{-# LANGUAGE TemplateHaskell #-}

3
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
4
5
6
7
8

-}

{-

9
Copyright (C) 2009, 2010, 2011 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

28
module Ganeti.HTools.QC
29
30
    ( testUtils
    , testPeerMap
31
32
33
34
    , testContainer
    , testInstance
    , testNode
    , testText
Iustin Pop's avatar
Iustin Pop committed
35
    , testOpCodes
36
    , testJobs
37
    , testCluster
Iustin Pop's avatar
Iustin Pop committed
38
    , testLoader
39
    , testTypes
40
    ) where
41
42

import Test.QuickCheck
Iustin Pop's avatar
Iustin Pop committed
43
import Data.List (findIndex, intercalate, nub, isPrefixOf)
44
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
45
46
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
47
import qualified Data.Map
48
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
49
import qualified Ganeti.OpCodes as OpCodes
50
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
51
import qualified Ganeti.Luxi
52
53
54
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
55
import qualified Ganeti.HTools.ExtLoader
56
57
58
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
59
import qualified Ganeti.HTools.Luxi
60
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
61
import qualified Ganeti.HTools.Group as Group
62
import qualified Ganeti.HTools.PeerMap as PeerMap
63
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
64
import qualified Ganeti.HTools.Simu
65
66
67
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
68
import qualified Ganeti.HTools.Version
69
import qualified Ganeti.Constants as C
70

71
72
73
74
75
import qualified Ganeti.HTools.Program.Hail
import qualified Ganeti.HTools.Program.Hbal
import qualified Ganeti.HTools.Program.Hscan
import qualified Ganeti.HTools.Program.Hspace

76
import Ganeti.HTools.QCHelper (testSuite)
Iustin Pop's avatar
Iustin Pop committed
77

78
79
-- * Constants

80
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
81
82
83
maxMem :: Int
maxMem = 1024 * 1024

84
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
85
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
86
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
87

88
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
89
90
91
maxCpu :: Int
maxCpu = 1024

Iustin Pop's avatar
Iustin Pop committed
92
93
94
95
96
97
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
               Group.create "default" Utils.defaultGroupID
                    Types.AllocPreferred

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
98
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
99
100
101
102

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

103
104
-- * Helper functions

105
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
106
107
108
109
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

Iustin Pop's avatar
Iustin Pop committed
110
111
112
113
114
115
116
-- | Checks for equality with proper annotation.
(==?) :: (Show a, Eq a) => a -> a -> Property
(==?) x y = printTestCase
            ("Expected equality, but '" ++
             show x ++ "' /= '" ++ show y ++ "'") (x == y)
infix 3 ==?

117
-- | Update an instance to be smaller than a node.
118
setInstanceSmallerThanNode node inst =
119
120
121
    inst { Instance.mem = Node.availMem node `div` 2
         , Instance.dsk = Node.availDisk node `div` 2
         , Instance.vcpus = Node.availCpu node `div` 2
122
123
         }

124
-- | Create an instance given its spec.
125
createInstance mem dsk vcpus =
126
    Instance.create "inst-unnamed" mem dsk vcpus Types.Running [] True (-1) (-1)
127
                    Types.DTDrbd8
128

129
-- | Create a small cluster by repeating a node spec.
130
131
132
133
134
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
    let fn = Node.buildPeers node Container.empty
        namelst = map (\n -> (Node.name n, n)) (replicate count fn)
        (_, nlst) = Loader.assignIndices namelst
135
    in nlst
136

137
-- | Checks if a node is "big" enough.
138
139
140
141
142
isNodeBig :: Node.Node -> Int -> Bool
isNodeBig node size = Node.availDisk node > size * Types.unitDsk
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

143
144
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
145

146
-- | Assigns a new fresh instance to a cluster; this is not
147
-- allocation, so no resource checks are done.
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
                then 0
                else fst (Container.findMax il) + 1
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

165
166
-- * Arbitrary instances

167
-- | Defines a DNS name.
168
newtype DNSChar = DNSChar { dnsGetChar::Char }
169

170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
instance Arbitrary DNSChar where
    arbitrary = do
      x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
      return (DNSChar x)

getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)


getFQDN :: Gen String
getFQDN = do
  felem <- getName
  ncomps <- choose (1, 4)
  frest <- vector ncomps::Gen [[DNSChar]]
  let frest' = map (map dnsGetChar) frest
  return (felem ++ "." ++ intercalate "." frest')

190
191
192
193
194
195
196
197
198
199
instance Arbitrary Types.InstanceStatus where
    arbitrary = elements [ Types.AdminDown
                         , Types.AdminOffline
                         , Types.ErrorDown
                         , Types.ErrorUp
                         , Types.NodeDown
                         , Types.NodeOffline
                         , Types.Running
                         , Types.WrongNode]

200
201
202
-- let's generate a random instance
instance Arbitrary Instance.Instance where
    arbitrary = do
203
      name <- getFQDN
Iustin Pop's avatar
Iustin Pop committed
204
205
      mem <- choose (0, maxMem)
      dsk <- choose (0, maxDsk)
206
      run_st <- arbitrary
207
208
      pn <- arbitrary
      sn <- arbitrary
Iustin Pop's avatar
Iustin Pop committed
209
      vcpus <- choose (0, maxCpu)
210
      return $ Instance.create name mem dsk vcpus run_st [] True pn sn
211
                               Types.DTDrbd8
212

213
214
215
216
217
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
          case min_multiplier of
            Just mm -> (mm * Types.unitMem,
                        mm * Types.unitDsk,
                        mm * Types.unitCpu)
            Nothing -> (0, 0, 0)
      (top_mem, top_dsk, top_cpu)  =
          case max_multiplier of
            Just mm -> (mm * Types.unitMem,
                        mm * Types.unitDsk,
                        mm * Types.unitCpu)
            Nothing -> (maxMem, maxDsk, maxCpu)
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
  return $ Node.buildPeers n Container.empty

243
244
-- and a random node
instance Arbitrary Node.Node where
245
    arbitrary = genNode Nothing Nothing
246

Iustin Pop's avatar
Iustin Pop committed
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
  arbitrary = elements [ OpCodes.ReplaceOnPrimary
                       , OpCodes.ReplaceOnSecondary
                       , OpCodes.ReplaceNewSecondary
                       , OpCodes.ReplaceAuto
                       ]

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
    (case op_id of
        "OP_TEST_DELAY" ->
          liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
        "OP_INSTANCE_REPLACE_DISKS" ->
266
          liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
Iustin Pop's avatar
Iustin Pop committed
267
268
          arbitrary arbitrary arbitrary
        "OP_INSTANCE_FAILOVER" ->
269
270
          liftM3 OpCodes.OpInstanceFailover arbitrary arbitrary
                 arbitrary
Iustin Pop's avatar
Iustin Pop committed
271
        "OP_INSTANCE_MIGRATE" ->
272
273
          liftM5 OpCodes.OpInstanceMigrate arbitrary arbitrary
                 arbitrary arbitrary
274
          arbitrary
Iustin Pop's avatar
Iustin Pop committed
275
276
        _ -> fail "Wrong opcode")

277
278
279
280
281
282
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

283
284
285
286
287
288
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
    arbitrary = do
      v <- choose (0, 1)
      return $ SmallRatio v

289
290
291
292
293
294
instance Arbitrary Types.AllocPolicy where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Types.DiskTemplate where
  arbitrary = elements [minBound..maxBound]

295
296
297
298
299
300
301
302
303
instance Arbitrary Types.FailMode where
    arbitrary = elements [minBound..maxBound]

instance Arbitrary a => Arbitrary (Types.OpResult a) where
    arbitrary = arbitrary >>= \c ->
                case c of
                  False -> liftM Types.OpFail arbitrary
                  True -> liftM Types.OpGood arbitrary

304
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
305

306
307
308
309
-- ** Utils tests

-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
310
311
312
prop_Utils_commaJoinSplit =
    forAll (arbitrary `suchThat`
            (\l -> l /= [""] && all (not . elem ',') l )) $ \lst ->
Iustin Pop's avatar
Iustin Pop committed
313
    Utils.sepSplit ',' (Utils.commaJoin lst) ==? lst
Iustin Pop's avatar
Iustin Pop committed
314

315
-- | Split and join should always be idempotent.
Iustin Pop's avatar
Iustin Pop committed
316
317
prop_Utils_commaSplitJoin s =
    Utils.commaJoin (Utils.sepSplit ',' s) ==? s
318

319
-- | fromObjWithDefault, we test using the Maybe monad and an integer
320
-- value.
321
322
323
324
325
326
prop_Utils_fromObjWithDefault def_value random_key =
    -- a missing key will be returned with the default
    Utils.fromObjWithDefault [] random_key def_value == Just def_value &&
    -- a found key will be returned as is, not with default
    Utils.fromObjWithDefault [(random_key, J.showJSON def_value)]
         random_key (def_value+1) == Just def_value
Iustin Pop's avatar
Iustin Pop committed
327
        where _types = def_value :: Integer
328

329
-- | Test that functional if' behaves like the syntactic sugar if.
Iustin Pop's avatar
Iustin Pop committed
330
331
332
prop_Utils_if'if :: Bool -> Int -> Int -> Gen Prop
prop_Utils_if'if cnd a b =
    Utils.if' cnd a b ==? if cnd then a else b
333

Guido Trotter's avatar
Guido Trotter committed
334
-- | Test basic select functionality
Iustin Pop's avatar
Iustin Pop committed
335
336
337
338
prop_Utils_select :: Int      -- ^ Default result
                  -> [Int]    -- ^ List of False values
                  -> [Int]    -- ^ List of True values
                  -> Gen Prop -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
339
prop_Utils_select def lst1 lst2 =
Iustin Pop's avatar
Iustin Pop committed
340
  Utils.select def cndlist ==? expectedresult
Guido Trotter's avatar
Guido Trotter committed
341
  where expectedresult = Utils.if' (null lst2) def (head lst2)
342
343
        flist = map (\e -> (False, e)) lst1
        tlist = map (\e -> (True, e)) lst2
Guido Trotter's avatar
Guido Trotter committed
344
345
346
        cndlist = flist ++ tlist

-- | Test basic select functionality with undefined default
Iustin Pop's avatar
Iustin Pop committed
347
prop_Utils_select_undefd :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
348
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
349
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
350
prop_Utils_select_undefd lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
351
  Utils.select undefined cndlist ==? head lst2
Guido Trotter's avatar
Guido Trotter committed
352
353
354
355
356
  where flist = map (\e -> (False, e)) lst1
        tlist = map (\e -> (True, e)) lst2
        cndlist = flist ++ tlist

-- | Test basic select functionality with undefined list values
Iustin Pop's avatar
Iustin Pop committed
357
prop_Utils_select_undefv :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
358
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
359
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
360
prop_Utils_select_undefv lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
361
  Utils.select undefined cndlist ==? head lst2
Guido Trotter's avatar
Guido Trotter committed
362
363
364
  where flist = map (\e -> (False, e)) lst1
        tlist = map (\e -> (True, e)) lst2
        cndlist = flist ++ tlist ++ [undefined]
365

Iustin Pop's avatar
Iustin Pop committed
366
367
368
369
370
371
372
373
374
375
376
prop_Utils_parseUnit (NonNegative n) =
    Utils.parseUnit (show n) == Types.Ok n &&
    Utils.parseUnit (show n ++ "m") == Types.Ok n &&
    (case Utils.parseUnit (show n ++ "M") of
      Types.Ok m -> if n > 0
                    then m < n  -- for positive values, X MB is less than X MiB
                    else m == 0 -- but for 0, 0 MB == 0 MiB
      Types.Bad _ -> False) &&
    Utils.parseUnit (show n ++ "g") == Types.Ok (n*1024) &&
    Utils.parseUnit (show n ++ "t") == Types.Ok (n*1048576) &&
    Types.isBad (Utils.parseUnit (show n ++ "x")::Types.Result Int)
Iustin Pop's avatar
Iustin Pop committed
377
    where _types = n::Int
Iustin Pop's avatar
Iustin Pop committed
378

379
-- | Test list for the Utils module.
380
381
382
383
384
385
386
387
388
389
testSuite "Utils"
              [ 'prop_Utils_commaJoinSplit
              , 'prop_Utils_commaSplitJoin
              , 'prop_Utils_fromObjWithDefault
              , 'prop_Utils_if'if
              , 'prop_Utils_select
              , 'prop_Utils_select_undefd
              , 'prop_Utils_select_undefv
              , 'prop_Utils_parseUnit
              ]
390

391
392
393
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
394
prop_PeerMap_addIdempotent pmap key em =
Iustin Pop's avatar
Iustin Pop committed
395
    fn puniq ==? fn (fn puniq)
396
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
397
398
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
399
          puniq = PeerMap.accumArray const pmap
400

401
-- | Make sure remove is idempotent.
402
prop_PeerMap_removeIdempotent pmap key =
Iustin Pop's avatar
Iustin Pop committed
403
    fn puniq ==? fn (fn puniq)
404
405
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
406
407
          puniq = PeerMap.accumArray const pmap

408
-- | Make sure a missing item returns 0.
409
prop_PeerMap_findMissing pmap key =
Iustin Pop's avatar
Iustin Pop committed
410
    PeerMap.find key (PeerMap.remove key puniq) ==? 0
411
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
412
413
          puniq = PeerMap.accumArray const pmap

414
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
415
prop_PeerMap_addFind pmap key em =
Iustin Pop's avatar
Iustin Pop committed
416
    PeerMap.find key (PeerMap.add key em puniq) ==? em
417
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
418
                    key::PeerMap.Key, em::PeerMap.Elem)
419
          puniq = PeerMap.accumArray const pmap
420

421
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
422
prop_PeerMap_maxElem pmap =
Iustin Pop's avatar
Iustin Pop committed
423
424
    PeerMap.maxElem puniq ==? if null puniq then 0
                              else (maximum . snd . unzip) puniq
425
    where _types = pmap::PeerMap.PeerMap
426
427
          puniq = PeerMap.accumArray const pmap

428
-- | List of tests for the PeerMap module.
429
430
431
432
433
434
435
testSuite "PeerMap"
              [ 'prop_PeerMap_addIdempotent
              , 'prop_PeerMap_removeIdempotent
              , 'prop_PeerMap_maxElem
              , 'prop_PeerMap_addFind
              , 'prop_PeerMap_findMissing
              ]
436

437
-- ** Container tests
438
439
440
441
442
443
444
445
446

prop_Container_addTwo cdata i1 i2 =
    fn i1 i2 cont == fn i2 i1 cont &&
       fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

447
448
449
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
Iustin Pop's avatar
Iustin Pop committed
450
  in Container.nameOf nl (Node.idx fnode) ==? Node.name fnode
451

452
-- | We test that in a cluster, given a random node, we can find it by
453
-- its name and alias, as long as all names and aliases are unique,
454
-- and that we fail to find a non-existing name.
455
456
457
458
459
460
461
462
463
464
465
466
467
prop_Container_findByName node othername =
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
  forAll (vector cnt) $ \ names ->
  (length . nub) (map fst names ++ map snd names) ==
  length names * 2 &&
  not (othername `elem` (map fst names ++ map snd names)) ==>
  let nl = makeSmallCluster node cnt
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
468
      nl' = Container.fromList nodes'
469
470
471
472
473
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
     Container.findByName nl' othername == Nothing

474
475
476
477
478
testSuite "Container"
              [ 'prop_Container_addTwo
              , 'prop_Container_nameOf
              , 'prop_Container_findByName
              ]
479

480
481
-- ** Instance tests

482
483
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
484
prop_Instance_creat inst =
Iustin Pop's avatar
Iustin Pop committed
485
    Instance.name inst ==? Instance.alias inst
Iustin Pop's avatar
Iustin Pop committed
486

487
prop_Instance_setIdx inst idx =
Iustin Pop's avatar
Iustin Pop committed
488
    Instance.idx (Instance.setIdx inst idx) ==? idx
489
490
491
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
492
493
494
495
496
497
498
499
    Instance.name newinst == name &&
    Instance.alias newinst == name
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
    Instance.name newinst == Instance.name inst &&
    Instance.alias newinst == name
500
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
501
          newinst = Instance.setAlias inst name
502
503

prop_Instance_setPri inst pdx =
Iustin Pop's avatar
Iustin Pop committed
504
    Instance.pNode (Instance.setPri inst pdx) ==? pdx
505
506
507
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
Iustin Pop's avatar
Iustin Pop committed
508
    Instance.sNode (Instance.setSec inst sdx) ==? sdx
509
510
511
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
512
    Instance.pNode si == pdx && Instance.sNode si == sdx
513
514
515
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
516
517
518
519
520
521
522
523
prop_Instance_shrinkMG inst =
    Instance.mem inst >= 2 * Types.unitMem ==>
        case Instance.shrinkByType inst Types.FailMem of
          Types.Ok inst' ->
              Instance.mem inst' == Instance.mem inst - Types.unitMem
          _ -> False

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
524
525
526
    forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
527
528
529
530
531
532
533
534
535

prop_Instance_shrinkCG inst =
    Instance.vcpus inst >= 2 * Types.unitCpu ==>
        case Instance.shrinkByType inst Types.FailCPU of
          Types.Ok inst' ->
              Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
          _ -> False

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
536
537
538
    forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
539
540
541
542
543
544
545
546
547

prop_Instance_shrinkDG inst =
    Instance.dsk inst >= 2 * Types.unitDsk ==>
        case Instance.shrinkByType inst Types.FailDisk of
          Types.Ok inst' ->
              Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
          _ -> False

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
548
549
550
    forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
551
552

prop_Instance_setMovable inst m =
Iustin Pop's avatar
Iustin Pop committed
553
    Instance.movable inst' ==? m
554
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
555

556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
testSuite "Instance"
              [ 'prop_Instance_creat
              , 'prop_Instance_setIdx
              , 'prop_Instance_setName
              , 'prop_Instance_setAlias
              , 'prop_Instance_setPri
              , 'prop_Instance_setSec
              , 'prop_Instance_setBoth
              , 'prop_Instance_shrinkMG
              , 'prop_Instance_shrinkMF
              , 'prop_Instance_shrinkCG
              , 'prop_Instance_shrinkCF
              , 'prop_Instance_shrinkDG
              , 'prop_Instance_shrinkDF
              , 'prop_Instance_setMovable
              ]
Iustin Pop's avatar
Iustin Pop committed
572

573
574
-- ** Text backend tests

Iustin Pop's avatar
Iustin Pop committed
575
576
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
577
578
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
579
                        (NonNegative pdx) (NonNegative sdx) autobal dt =
580
    pnode /= snode && pdx /= sdx ==>
Iustin Pop's avatar
Iustin Pop committed
581
582
583
    let vcpus_s = show vcpus
        dsk_s = show dsk
        mem_s = show mem
584
        status_s = Types.instanceStatusToRaw status
Iustin Pop's avatar
Iustin Pop committed
585
586
        ndx = if null snode
              then [(pnode, pdx)]
587
              else [(pnode, pdx), (snode, sdx)]
588
        nl = Data.Map.fromList ndx
589
        tags = ""
Iustin Pop's avatar
Iustin Pop committed
590
        sbal = if autobal then "Y" else "N"
591
        sdt = Types.diskTemplateToRaw dt
592
        inst = Text.loadInst nl
593
               [name, mem_s, dsk_s, vcpus_s, status_s,
594
                sbal, pnode, snode, sdt, tags]
595
        fail1 = Text.loadInst nl
596
               [name, mem_s, dsk_s, vcpus_s, status_s,
597
                sbal, pnode, pnode, tags]
Iustin Pop's avatar
Iustin Pop committed
598
        _types = ( name::String, mem::Int, dsk::Int
599
                 , vcpus::Int, status::Types.InstanceStatus
Iustin Pop's avatar
Iustin Pop committed
600
                 , snode::String
Iustin Pop's avatar
Iustin Pop committed
601
                 , autobal::Bool)
Iustin Pop's avatar
Iustin Pop committed
602
603
    in
      case inst of
604
605
        Types.Bad msg -> printTestCase ("Failed to load instance: " ++ msg)
                         False
Iustin Pop's avatar
Iustin Pop committed
606
607
        Types.Ok (_, i) -> printTestCase "Mismatch in some field while\
                                         \ loading the instance" $
Iustin Pop's avatar
Iustin Pop committed
608
609
610
611
612
613
            Instance.name i == name &&
            Instance.vcpus i == vcpus &&
            Instance.mem i == mem &&
            Instance.pNode i == pdx &&
            Instance.sNode i == (if null snode
                                 then Node.noSecondary
614
                                 else sdx) &&
615
            Instance.autoBalance i == autobal &&
616
            Types.isBad fail1
Iustin Pop's avatar
Iustin Pop committed
617
618

prop_Text_Load_InstanceFail ktn fields =
619
    length fields /= 10 ==>
Iustin Pop's avatar
Iustin Pop committed
620
    case Text.loadInst nl fields of
621
622
623
624
      Types.Ok _ -> printTestCase "Managed to load instance from invalid\
                                  \ data" False
      Types.Bad msg -> printTestCase ("Unrecognised error message: " ++ msg) $
                       "Invalid/incomplete instance data: '" `isPrefixOf` msg
625
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640

prop_Text_Load_Node name tm nm fm td fd tc fo =
    let conv v = if v < 0
                    then "?"
                    else show v
        tm_s = conv tm
        nm_s = conv nm
        fm_s = conv fm
        td_s = conv td
        fd_s = conv fd
        tc_s = conv tc
        fo_s = if fo
               then "Y"
               else "N"
        any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
Iustin Pop's avatar
Iustin Pop committed
641
642
643
        gid = Group.uuid defGroup
    in case Text.loadNode defGroupAssoc
           [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
Iustin Pop's avatar
Iustin Pop committed
644
645
646
647
         Nothing -> False
         Just (name', node) ->
             if fo || any_broken
             then Node.offline node
648
649
650
651
652
653
654
655
             else Node.name node == name' && name' == name &&
                  Node.alias node == name &&
                  Node.tMem node == fromIntegral tm &&
                  Node.nMem node == nm &&
                  Node.fMem node == fm &&
                  Node.tDsk node == fromIntegral td &&
                  Node.fDsk node == fd &&
                  Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
656
657

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
658
    length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
659

660
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
661
662
    (Text.loadNode defGroupAssoc.
         Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
663
664
665
666
    Just (Node.name n, n)
    -- override failN1 to what loadNode returns by default
    where n = node { Node.failN1 = True, Node.offline = False }

667
668
669
670
671
672
673
testSuite "Text"
              [ 'prop_Text_Load_Instance
              , 'prop_Text_Load_InstanceFail
              , 'prop_Text_Load_Node
              , 'prop_Text_Load_NodeFail
              , 'prop_Text_NodeLSIdempotent
              ]
674

675
-- ** Node tests
676

Iustin Pop's avatar
Iustin Pop committed
677
678
679
680
681
682
683
prop_Node_setAlias node name =
    Node.name newnode == Node.name node &&
    Node.alias newnode == name
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
Iustin Pop's avatar
Iustin Pop committed
684
    Node.offline newnode ==? status
Iustin Pop's avatar
Iustin Pop committed
685
686
687
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
Iustin Pop's avatar
Iustin Pop committed
688
    Node.xMem newnode ==? xm
Iustin Pop's avatar
Iustin Pop committed
689
690
691
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
Iustin Pop's avatar
Iustin Pop committed
692
    Node.mCpu newnode ==? mc
Iustin Pop's avatar
Iustin Pop committed
693
694
    where newnode = Node.setMcpu node mc

695
696
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
697
prop_Node_addPriFM node inst = Instance.mem inst >= Node.fMem node &&
698
699
                               not (Node.failN1 node) &&
                               not (Instance.instanceOffline inst)
Iustin Pop's avatar
Iustin Pop committed
700
701
702
703
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailMem -> True
                                 _ -> False
704
    where _types = (node::Node.Node, inst::Instance.Instance)
Iustin Pop's avatar
Iustin Pop committed
705
706
707
708
709
710
711
712
713
714
715
716
717
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst = Instance.dsk inst >= Node.fDsk node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailDisk -> True
                                 _ -> False
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

Iustin Pop's avatar
Iustin Pop committed
718
prop_Node_addPriFC node inst (Positive extra) =
719
720
    not (Node.failN1 node) &&
    not (Instance.instanceOffline inst) ==>
Iustin Pop's avatar
Iustin Pop committed
721
722
723
        case Node.addPri node inst'' of
          Types.OpFail Types.FailCPU -> True
          _ -> False
Iustin Pop's avatar
Iustin Pop committed
724
725
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
Iustin Pop's avatar
Iustin Pop committed
726
          inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
727

728
729
-- | Check that an instance add with too high memory or disk will be
-- rejected.
730
prop_Node_addSec node inst pdx =
731
732
    ((Instance.mem inst >= (Node.fMem node - Node.rMem node) &&
      not (Instance.instanceOffline inst)) ||
733
     Instance.dsk inst >= Node.fDsk node) &&
Iustin Pop's avatar
Iustin Pop committed
734
    not (Node.failN1 node)
Iustin Pop's avatar
Iustin Pop committed
735
    ==> isFailure (Node.addSec node inst pdx)
736
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
737

738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
-- | Check that an offline instance with reasonable disk size can always
-- be added.
prop_Node_addPriOffline node =
    forAll (arbitrary `suchThat`
            (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                      Instance.instanceOffline x)) $ \inst ->
    case Node.addPri node inst of
      Types.OpGood _ -> True
      _ -> False

prop_Node_addSecOffline node pdx =
    forAll (arbitrary `suchThat`
            (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                      Instance.instanceOffline x)) $ \inst ->
    case Node.addSec node inst pdx of
      Types.OpGood _ -> True
      _ -> False

756
-- | Checks for memory reservation changes.
757
prop_Node_rMem inst =
758
    not (Instance.instanceOffline inst) ==>
759
    forAll (arbitrary `suchThat` ((> Types.unitMem) . Node.fMem)) $ \node ->
760
761
    -- ab = auto_balance, nb = non-auto_balance
    -- we use -1 as the primary node of the instance
762
    let inst' = inst { Instance.pNode = -1, Instance.autoBalance = True }
763
        inst_ab = setInstanceSmallerThanNode node inst'
764
        inst_nb = inst_ab { Instance.autoBalance = False }
765
        -- now we have the two instances, identical except the
766
        -- autoBalance attribute
767
768
769
770
        orig_rmem = Node.rMem node
        inst_idx = Instance.idx inst_ab
        node_add_ab = Node.addSec node inst_ab (-1)
        node_add_nb = Node.addSec node inst_nb (-1)
Iustin Pop's avatar
Iustin Pop committed
771
772
        node_del_ab = liftM (`Node.removeSec` inst_ab) node_add_ab
        node_del_nb = liftM (`Node.removeSec` inst_nb) node_add_nb
773
774
775
    in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
         (Types.OpGood a_ab, Types.OpGood a_nb,
          Types.OpGood d_ab, Types.OpGood d_nb) ->
776
             printTestCase "Consistency checks failed" $
777
778
779
780
781
782
783
784
785
             Node.rMem a_ab >  orig_rmem &&
             Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
             Node.rMem a_nb == orig_rmem &&
             Node.rMem d_ab == orig_rmem &&
             Node.rMem d_nb == orig_rmem &&
             -- this is not related to rMem, but as good a place to
             -- test as any
             inst_idx `elem` Node.sList a_ab &&
             not (inst_idx `elem` Node.sList d_ab)
786
787
         x -> printTestCase ("Failed to add/remove instances: " ++ show x)
              False
788

789
-- | Check mdsk setting.
Iustin Pop's avatar
Iustin Pop committed
790
791
792
793
794
prop_Node_setMdsk node mx =
    Node.loDsk node' >= 0 &&
    fromIntegral (Node.loDsk node') <= Node.tDsk node &&
    Node.availDisk node' >= 0 &&
    Node.availDisk node' <= Node.fDsk node' &&
Iustin Pop's avatar
Iustin Pop committed
795
796
    fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
    Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
797
798
799
800
801
802
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
Iustin Pop's avatar
Iustin Pop committed
803
    Node.delTags (Node.addTags m tags) tags ==? m
804
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
805
806
807

prop_Node_tagMaps_reject tags =
    not (null tags) ==>
Iustin Pop's avatar
Iustin Pop committed
808
    all (\t -> Node.rejectAddTags m [t]) tags
809
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
810

Iustin Pop's avatar
Iustin Pop committed
811
812
813
814
815
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

816
817
818
819
820
821
prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
Iustin Pop's avatar
Iustin Pop committed
822
     (null nodes || not (null ng))
823

824
825
826
827
828
829
830
831
832
testSuite "Node"
              [ 'prop_Node_setAlias
              , 'prop_Node_setOffline
              , 'prop_Node_setMcpu
              , 'prop_Node_setXmem
              , 'prop_Node_addPriFM
              , 'prop_Node_addPriFD
              , 'prop_Node_addPriFC
              , 'prop_Node_addSec
833
834
              , 'prop_Node_addPriOffline
              , 'prop_Node_addSecOffline
835
836
837
838
839
840
841
              , 'prop_Node_rMem
              , 'prop_Node_setMdsk
              , 'prop_Node_tagMaps_idempotent
              , 'prop_Node_tagMaps_reject
              , 'prop_Node_showField
              , 'prop_Node_computeGroups
              ]
842

843
-- ** Cluster tests
844

845
846
-- | Check that the cluster score is close to zero for a homogeneous
-- cluster.
Iustin Pop's avatar
Iustin Pop committed
847
848
prop_Score_Zero node =
    forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
849
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
850
     (Node.tDsk node > 0) && (Node.tMem node > 0)) ==>
851
    let fn = Node.buildPeers node Container.empty
852
853
        nlst = replicate count fn
        score = Cluster.compCVNodes nlst
854
855
    -- we can't say == 0 here as the floating point errors accumulate;
    -- this should be much lower than the default score in CLI.hs
Iustin Pop's avatar
Iustin Pop committed
856
    in score <= 1e-12
857

858
-- | Check that cluster stats are sane.
Iustin Pop's avatar
Iustin Pop committed
859
860
861
prop_CStats_sane node =
    forAll (choose (1, 1024)) $ \count ->
    (not (Node.offline node) && not (Node.failN1 node) &&
862
     (Node.availDisk node > 0) && (Node.availMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
863
864
    let fn = Node.buildPeers node Container.empty
        nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
Iustin Pop's avatar
Iustin Pop committed
865
        nl = Container.fromList nlst
Iustin Pop's avatar
Iustin Pop committed
866
867
868
869
        cstats = Cluster.totalResources nl
    in Cluster.csAdsk cstats >= 0 &&
       Cluster.csAdsk cstats <= Cluster.csFdsk cstats

870
-- | Check that one instance is allocated correctly, without
871
-- rebalances needed.
872
873
874
875
876
877
878
879
880
881
prop_ClusterAlloc_sane node inst =
    forAll (choose (5, 20)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && Node.availDisk node > 0
            && Node.availMem node > 0
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
882
883
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
884
         Types.Bad _ -> False
885
         Types.Ok as ->
886
887
888
             case Cluster.asSolution as of
               Nothing -> False
               Just (xnl, xi, _, cv) ->
889
                   let il' = Container.add (Instance.idx xi) xi il
890
                       tbl = Cluster.Table xnl il' cv []
891
                   in not (canBalance tbl True True False)
892
893
894

-- | Checks that on a 2-5 node cluster, we can allocate a random
-- instance spec via tiered allocation (whatever the original instance
895
-- spec), on either one or two nodes.
896
897
898
899
900
901
902
903
904
prop_ClusterCanTieredAlloc node inst =
    forAll (choose (2, 5)) $ \count ->
    forAll (choose (1, 2)) $ \rqnodes ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
905
        allocnodes = Cluster.genAllocNodes defGroupList nl rqnodes True
Iustin Pop's avatar
Iustin Pop committed
906
    in case allocnodes >>= \allocnodes' ->
907
        Cluster.tieredAlloc nl il (Just 1) inst allocnodes' [] [] of
908
         Types.Bad _ -> False
909
910
911
         Types.Ok (_, _, il', ixes, cstats) -> not (null ixes) &&
                                      IntMap.size il' == length ixes &&
                                      length ixes == length cstats
912
913

-- | Checks that on a 4-8 node cluster, once we allocate an instance,
914
-- we can also evacuate it.
915
916
917
918
919
920
921
922
923
prop_ClusterAllocEvac node inst =
    forAll (choose (4, 8)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
924
925
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
926
         Types.Bad _ -> False
927
         Types.Ok as ->
928
929
930
             case Cluster.asSolution as of
               Nothing -> False
               Just (xnl, xi, _, _) ->
931
932
                   let sdx = Instance.sNode xi
                       il' = Container.add (Instance.idx xi) xi il
Iustin Pop's avatar
Iustin Pop committed
933
934
935
                   in case IAlloc.processRelocate defGroupList xnl il'
                          (Instance.idx xi) 1 [sdx] of
                        Types.Ok _ -> True
936
937
938
                        _ -> False

-- | Check that allocating multiple instances on a cluster, then
939
-- adding an empty node, results in a valid rebalance.
940
941
prop_ClusterAllocBalance =
    forAll (genNode (Just 5) (Just 128)) $ \node ->
942
    forAll (choose (3, 5)) $ \count ->
943
    not (Node.offline node) && not (Node.failN1 node) ==>
944
945
946
    let nl = makeSmallCluster node count
        (hnode, nl') = IntMap.deleteFindMax nl
        il = Container.empty
947
        allocnodes = Cluster.genAllocNodes defGroupList nl' 2 True
948
        i_templ = createInstance Types.unitMem Types.unitDsk Types.unitCpu
Iustin Pop's avatar
Iustin Pop committed
949
    in case allocnodes >>= \allocnodes' ->
950
        Cluster.iterateAlloc nl' il (Just 5) i_templ allocnodes' [] [] of
951
         Types.Bad _ -> False
952
         Types.Ok (_, xnl, il', _, _) ->
953
954
955
                   let ynl = Container.add (Node.idx hnode) hnode xnl
                       cv = Cluster.compCV ynl
                       tbl = Cluster.Table ynl il' cv []
956
                   in canBalance tbl True True False
957

958
-- | Checks consistency.
959
960
961
prop_ClusterCheckConsistency node inst =
  let nl = makeSmallCluster node 3
      [node1, node2, node3] = Container.elems nl
Iustin Pop's avatar
Iustin Pop committed
962
      node3' = node3 { Node.group = 1 }
963
964
965
966
      nl' = Container.add (Node.idx node3') node3' nl
      inst1 = Instance.setBoth inst (Node.idx node1) (Node.idx node2)
      inst2 = Instance.setBoth inst (Node.idx node1) Node.noSecondary
      inst3 = Instance.setBoth inst (Node.idx node1) (Node.idx node3)
Iustin Pop's avatar
Iustin Pop committed
967
      ccheck = Cluster.findSplitInstances nl' . Container.fromList
968
969
970
971
  in null (ccheck [(0, inst1)]) &&
     null (ccheck [(0, inst2)]) &&
     (not . null $ ccheck [(0, inst3)])

972
-- | For now, we only test that we don't lose instances during the split.
973
974
975
976
977
978
979
980
981
prop_ClusterSplitCluster node inst =
  forAll (choose (0, 100)) $ \icnt ->
  let nl = makeSmallCluster node 2
      (nl', il') = foldl (\(ns, is) _ -> assignInstance ns is inst 0 1)
                   (nl, Container.empty) [1..icnt]
      gni = Cluster.splitCluster nl' il'
  in sum (map (Container.size . snd . snd) gni) == icnt &&
     all (\(guuid, (nl'', _)) -> all ((== guuid) . Node.group)
                                 (Container.elems nl'')) gni
982

983
984
985
986
987
988
989
990
991
992
testSuite "Cluster"
              [ 'prop_Score_Zero
              , 'prop_CStats_sane
              , 'prop_ClusterAlloc_sane
              , 'prop_ClusterCanTieredAlloc
              , 'prop_ClusterAllocEvac
              , 'prop_ClusterAllocBalance
              , 'prop_ClusterCheckConsistency
              , 'prop_ClusterSplitCluster
              ]
Iustin Pop's avatar