QC.hs 33 KB
Newer Older
1
{-| Unittests for ganeti-htools
Iustin Pop's avatar
Iustin Pop committed
2
3
4
5
6

-}

{-

7
Copyright (C) 2009, 2010, 2011 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

26
module Ganeti.HTools.QC
27
28
    ( testUtils
    , testPeerMap
29
30
31
32
    , testContainer
    , testInstance
    , testNode
    , testText
Iustin Pop's avatar
Iustin Pop committed
33
    , testOpCodes
34
    , testJobs
35
    , testCluster
Iustin Pop's avatar
Iustin Pop committed
36
    , testLoader
37
    ) where
38
39

import Test.QuickCheck
Iustin Pop's avatar
Iustin Pop committed
40
import Data.List (findIndex, intercalate, nub, isPrefixOf)
41
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
42
43
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
44
import qualified Data.Map
45
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
46
import qualified Ganeti.OpCodes as OpCodes
47
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
48
import qualified Ganeti.Luxi
49
50
51
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
52
import qualified Ganeti.HTools.ExtLoader
53
54
55
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
56
import qualified Ganeti.HTools.Luxi
57
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
58
import qualified Ganeti.HTools.Group as Group
59
import qualified Ganeti.HTools.PeerMap as PeerMap
60
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
61
import qualified Ganeti.HTools.Simu
62
63
64
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
65
import qualified Ganeti.HTools.Version
66
import qualified Ganeti.Constants as C
67

Iustin Pop's avatar
Iustin Pop committed
68
69
70
run :: Testable prop => prop -> Args -> IO Result
run = flip quickCheckWithResult

71
72
-- * Constants

Iustin Pop's avatar
Iustin Pop committed
73
74
75
76
-- | Maximum memory (1TiB, somewhat random value)
maxMem :: Int
maxMem = 1024 * 1024

Iustin Pop's avatar
Iustin Pop committed
77
-- | Maximum disk (8TiB, somewhat random value)
Iustin Pop's avatar
Iustin Pop committed
78
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
79
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
80
81
82
83
84

-- | Max CPUs (1024, somewhat random value)
maxCpu :: Int
maxCpu = 1024

Iustin Pop's avatar
Iustin Pop committed
85
86
87
88
89
90
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
               Group.create "default" Utils.defaultGroupID
                    Types.AllocPreferred

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
91
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
92
93
94
95

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

96
97
-- * Helper functions

Iustin Pop's avatar
Iustin Pop committed
98
99
100
101
102
-- | Simple checker for whether OpResult is fail or pass
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

103
104
-- | Update an instance to be smaller than a node
setInstanceSmallerThanNode node inst =
105
106
107
    inst { Instance.mem = Node.availMem node `div` 2
         , Instance.dsk = Node.availDisk node `div` 2
         , Instance.vcpus = Node.availCpu node `div` 2
108
109
110
111
         }

-- | Create an instance given its spec
createInstance mem dsk vcpus =
112
    Instance.create "inst-unnamed" mem dsk vcpus "running" [] True (-1) (-1)
113
114
115
116
117
118
119

-- | Create a small cluster by repeating a node spec
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
    let fn = Node.buildPeers node Container.empty
        namelst = map (\n -> (Node.name n, n)) (replicate count fn)
        (_, nlst) = Loader.assignIndices namelst
120
    in nlst
121
122
123
124
125
126
127

-- | Checks if a node is "big" enough
isNodeBig :: Node.Node -> Int -> Bool
isNodeBig node size = Node.availDisk node > size * Types.unitDsk
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

128
129
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
130

131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
-- | Assigns a new fresh instance to a cluster; this is not
-- allocation, so no resource checks are done
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
                then 0
                else fst (Container.findMax il) + 1
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

150
151
-- * Arbitrary instances

152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
newtype DNSChar = DNSChar { dnsGetChar::Char }
instance Arbitrary DNSChar where
    arbitrary = do
      x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
      return (DNSChar x)

getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)


getFQDN :: Gen String
getFQDN = do
  felem <- getName
  ncomps <- choose (1, 4)
  frest <- vector ncomps::Gen [[DNSChar]]
  let frest' = map (map dnsGetChar) frest
  return (felem ++ "." ++ intercalate "." frest')

173
174
175
-- let's generate a random instance
instance Arbitrary Instance.Instance where
    arbitrary = do
176
      name <- getFQDN
Iustin Pop's avatar
Iustin Pop committed
177
178
      mem <- choose (0, maxMem)
      dsk <- choose (0, maxDsk)
179
180
181
182
183
184
185
186
      run_st <- elements [ C.inststErrorup
                         , C.inststErrordown
                         , C.inststAdmindown
                         , C.inststNodedown
                         , C.inststNodeoffline
                         , C.inststRunning
                         , "no_such_status1"
                         , "no_such_status2"]
187
188
      pn <- arbitrary
      sn <- arbitrary
Iustin Pop's avatar
Iustin Pop committed
189
      vcpus <- choose (0, maxCpu)
190
      return $ Instance.create name mem dsk vcpus run_st [] True pn sn
191

192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
genNode :: Maybe Int -> Maybe Int -> Gen Node.Node
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
          case min_multiplier of
            Just mm -> (mm * Types.unitMem,
                        mm * Types.unitDsk,
                        mm * Types.unitCpu)
            Nothing -> (0, 0, 0)
      (top_mem, top_dsk, top_cpu)  =
          case max_multiplier of
            Just mm -> (mm * Types.unitMem,
                        mm * Types.unitDsk,
                        mm * Types.unitCpu)
            Nothing -> (maxMem, maxDsk, maxCpu)
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
  return $ Node.buildPeers n Container.empty

218
219
-- and a random node
instance Arbitrary Node.Node where
220
    arbitrary = genNode Nothing Nothing
221

Iustin Pop's avatar
Iustin Pop committed
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
  arbitrary = elements [ OpCodes.ReplaceOnPrimary
                       , OpCodes.ReplaceOnSecondary
                       , OpCodes.ReplaceNewSecondary
                       , OpCodes.ReplaceAuto
                       ]

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
    (case op_id of
        "OP_TEST_DELAY" ->
          liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
        "OP_INSTANCE_REPLACE_DISKS" ->
241
          liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
Iustin Pop's avatar
Iustin Pop committed
242
243
          arbitrary arbitrary arbitrary
        "OP_INSTANCE_FAILOVER" ->
244
          liftM2 OpCodes.OpInstanceFailover arbitrary arbitrary
Iustin Pop's avatar
Iustin Pop committed
245
        "OP_INSTANCE_MIGRATE" ->
246
          liftM4 OpCodes.OpInstanceMigrate arbitrary arbitrary arbitrary
247
          arbitrary
Iustin Pop's avatar
Iustin Pop committed
248
249
        _ -> fail "Wrong opcode")

250
251
252
253
254
255
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

256
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
257

258
259
-- If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idepotent
Iustin Pop's avatar
Iustin Pop committed
260
261
262
263
264
prop_Utils_commaJoinSplit =
    forAll (arbitrary `suchThat`
            (\l -> l /= [""] && all (not . elem ',') l )) $ \lst ->
    Utils.sepSplit ',' (Utils.commaJoin lst) == lst

265
266
267
-- Split and join should always be idempotent
prop_Utils_commaSplitJoin s = Utils.commaJoin (Utils.sepSplit ',' s) == s

268
269
270
271
272
273
274
275
-- | fromObjWithDefault, we test using the Maybe monad and an integer
-- value
prop_Utils_fromObjWithDefault def_value random_key =
    -- a missing key will be returned with the default
    Utils.fromObjWithDefault [] random_key def_value == Just def_value &&
    -- a found key will be returned as is, not with default
    Utils.fromObjWithDefault [(random_key, J.showJSON def_value)]
         random_key (def_value+1) == Just def_value
Iustin Pop's avatar
Iustin Pop committed
276
        where _types = def_value :: Integer
277

278
279
280
testUtils =
  [ run prop_Utils_commaJoinSplit
  , run prop_Utils_commaSplitJoin
281
  , run prop_Utils_fromObjWithDefault
282
283
  ]

284
-- | Make sure add is idempotent
Iustin Pop's avatar
Iustin Pop committed
285
prop_PeerMap_addIdempotent pmap key em =
286
    fn puniq == fn (fn puniq)
287
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
288
289
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
290
          puniq = PeerMap.accumArray const pmap
291
292
293
294

-- | Make sure remove is idempotent
prop_PeerMap_removeIdempotent pmap key =
    fn puniq == fn (fn puniq)
295
296
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
297
298
299
300
301
          puniq = PeerMap.accumArray const pmap

-- | Make sure a missing item returns 0
prop_PeerMap_findMissing pmap key =
    PeerMap.find key (PeerMap.remove key puniq) == 0
302
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
303
304
305
          puniq = PeerMap.accumArray const pmap

-- | Make sure an added item is found
Iustin Pop's avatar
Iustin Pop committed
306
307
prop_PeerMap_addFind pmap key em =
    PeerMap.find key (PeerMap.add key em puniq) == em
308
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
309
                    key::PeerMap.Key, em::PeerMap.Elem)
310
          puniq = PeerMap.accumArray const pmap
311
312
313
314
315

-- | Manual check that maxElem returns the maximum indeed, or 0 for null
prop_PeerMap_maxElem pmap =
    PeerMap.maxElem puniq == if null puniq then 0
                             else (maximum . snd . unzip) puniq
316
    where _types = pmap::PeerMap.PeerMap
317
318
          puniq = PeerMap.accumArray const pmap

319
testPeerMap =
320
321
322
323
324
325
326
    [ run prop_PeerMap_addIdempotent
    , run prop_PeerMap_removeIdempotent
    , run prop_PeerMap_maxElem
    , run prop_PeerMap_addFind
    , run prop_PeerMap_findMissing
    ]

327
328
329
330
331
332
333
334
335
336
-- Container tests

prop_Container_addTwo cdata i1 i2 =
    fn i1 i2 cont == fn i2 i1 cont &&
       fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
  in Container.nameOf nl (Node.idx fnode) == Node.name fnode

-- We test that in a cluster, given a random node, we can find it by
-- its name and alias, as long as all names and aliases are unique,
-- and that we fail to find a non-existing name
prop_Container_findByName node othername =
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
  forAll (vector cnt) $ \ names ->
  (length . nub) (map fst names ++ map snd names) ==
  length names * 2 &&
  not (othername `elem` (map fst names ++ map snd names)) ==>
  let nl = makeSmallCluster node cnt
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
358
      nl' = Container.fromList nodes'
359
360
361
362
363
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
     Container.findByName nl' othername == Nothing

364
testContainer =
365
366
367
368
    [ run prop_Container_addTwo
    , run prop_Container_nameOf
    , run prop_Container_findByName
    ]
369

370
371
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
372
373
374
prop_Instance_creat inst =
    Instance.name inst == Instance.alias inst

375
376
377
378
379
prop_Instance_setIdx inst idx =
    Instance.idx (Instance.setIdx inst idx) == idx
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
380
381
382
383
384
385
386
387
    Instance.name newinst == name &&
    Instance.alias newinst == name
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
    Instance.name newinst == Instance.name inst &&
    Instance.alias newinst == name
388
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
389
          newinst = Instance.setAlias inst name
390
391

prop_Instance_setPri inst pdx =
392
    Instance.pNode (Instance.setPri inst pdx) == pdx
393
394
395
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
396
    Instance.sNode (Instance.setSec inst sdx) == sdx
397
398
399
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
400
    Instance.pNode si == pdx && Instance.sNode si == sdx
401
402
403
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
404
405
406
407
prop_Instance_runStatus_True =
    forAll (arbitrary `suchThat`
            ((`elem` Instance.runningStates) . Instance.runSt))
    Instance.running
Iustin Pop's avatar
Iustin Pop committed
408
409
410

prop_Instance_runStatus_False inst =
    let run_st = Instance.running inst
411
        run_tx = Instance.runSt inst
Iustin Pop's avatar
Iustin Pop committed
412
    in
413
      run_tx `notElem` Instance.runningStates ==> not run_st
Iustin Pop's avatar
Iustin Pop committed
414

Iustin Pop's avatar
Iustin Pop committed
415
416
417
418
419
420
421
422
prop_Instance_shrinkMG inst =
    Instance.mem inst >= 2 * Types.unitMem ==>
        case Instance.shrinkByType inst Types.FailMem of
          Types.Ok inst' ->
              Instance.mem inst' == Instance.mem inst - Types.unitMem
          _ -> False

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
423
424
425
    forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
426
427
428
429
430
431
432
433
434

prop_Instance_shrinkCG inst =
    Instance.vcpus inst >= 2 * Types.unitCpu ==>
        case Instance.shrinkByType inst Types.FailCPU of
          Types.Ok inst' ->
              Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
          _ -> False

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
435
436
437
    forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
438
439
440
441
442
443
444
445
446

prop_Instance_shrinkDG inst =
    Instance.dsk inst >= 2 * Types.unitDsk ==>
        case Instance.shrinkByType inst Types.FailDisk of
          Types.Ok inst' ->
              Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
          _ -> False

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
447
448
449
    forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
450
451
452

prop_Instance_setMovable inst m =
    Instance.movable inst' == m
453
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
454

455
testInstance =
Iustin Pop's avatar
Iustin Pop committed
456
457
    [ run prop_Instance_creat
    , run prop_Instance_setIdx
458
    , run prop_Instance_setName
Iustin Pop's avatar
Iustin Pop committed
459
    , run prop_Instance_setAlias
460
461
462
    , run prop_Instance_setPri
    , run prop_Instance_setSec
    , run prop_Instance_setBoth
Iustin Pop's avatar
Iustin Pop committed
463
464
    , run prop_Instance_runStatus_True
    , run prop_Instance_runStatus_False
Iustin Pop's avatar
Iustin Pop committed
465
466
467
468
469
470
471
    , run prop_Instance_shrinkMG
    , run prop_Instance_shrinkMF
    , run prop_Instance_shrinkCG
    , run prop_Instance_shrinkCF
    , run prop_Instance_shrinkDG
    , run prop_Instance_shrinkDF
    , run prop_Instance_setMovable
Iustin Pop's avatar
Iustin Pop committed
472
473
474
475
    ]

-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
476
477
478
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
                        (NonNegative pdx) (NonNegative sdx) autobal =
479
    pnode /= snode && pdx /= sdx ==>
Iustin Pop's avatar
Iustin Pop committed
480
481
482
    let vcpus_s = show vcpus
        dsk_s = show dsk
        mem_s = show mem
Iustin Pop's avatar
Iustin Pop committed
483
484
        ndx = if null snode
              then [(pnode, pdx)]
485
              else [(pnode, pdx), (snode, sdx)]
486
        nl = Data.Map.fromList ndx
487
        tags = ""
Iustin Pop's avatar
Iustin Pop committed
488
        sbal = if autobal then "Y" else "N"
489
        inst = Text.loadInst nl
Iustin Pop's avatar
Iustin Pop committed
490
491
               [name, mem_s, dsk_s, vcpus_s, status,
                sbal, pnode, snode, tags]:: Maybe (String, Instance.Instance)
492
        fail1 = Text.loadInst nl
Iustin Pop's avatar
Iustin Pop committed
493
494
               [name, mem_s, dsk_s, vcpus_s, status,
                sbal, pnode, pnode, tags]:: Maybe (String, Instance.Instance)
Iustin Pop's avatar
Iustin Pop committed
495
496
        _types = ( name::String, mem::Int, dsk::Int
                 , vcpus::Int, status::String
Iustin Pop's avatar
Iustin Pop committed
497
                 , snode::String
Iustin Pop's avatar
Iustin Pop committed
498
                 , autobal::Bool)
Iustin Pop's avatar
Iustin Pop committed
499
500
501
502
    in
      case inst of
        Nothing -> False
        Just (_, i) ->
Iustin Pop's avatar
Iustin Pop committed
503
504
505
506
507
508
            Instance.name i == name &&
            Instance.vcpus i == vcpus &&
            Instance.mem i == mem &&
            Instance.pNode i == pdx &&
            Instance.sNode i == (if null snode
                                 then Node.noSecondary
509
                                 else sdx) &&
Iustin Pop's avatar
Iustin Pop committed
510
511
            Instance.auto_balance i == autobal &&
            isNothing fail1
Iustin Pop's avatar
Iustin Pop committed
512
513

prop_Text_Load_InstanceFail ktn fields =
Iustin Pop's avatar
Iustin Pop committed
514
515
    length fields /= 9 ==>
    case Text.loadInst nl fields of
Iustin Pop's avatar
Iustin Pop committed
516
517
      Types.Ok _ -> False
      Types.Bad msg -> "Invalid/incomplete instance data: '" `isPrefixOf` msg
518
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533

prop_Text_Load_Node name tm nm fm td fd tc fo =
    let conv v = if v < 0
                    then "?"
                    else show v
        tm_s = conv tm
        nm_s = conv nm
        fm_s = conv fm
        td_s = conv td
        fd_s = conv fd
        tc_s = conv tc
        fo_s = if fo
               then "Y"
               else "N"
        any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
Iustin Pop's avatar
Iustin Pop committed
534
535
536
        gid = Group.uuid defGroup
    in case Text.loadNode defGroupAssoc
           [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
Iustin Pop's avatar
Iustin Pop committed
537
538
539
540
         Nothing -> False
         Just (name', node) ->
             if fo || any_broken
             then Node.offline node
541
542
543
544
545
546
547
548
             else Node.name node == name' && name' == name &&
                  Node.alias node == name &&
                  Node.tMem node == fromIntegral tm &&
                  Node.nMem node == nm &&
                  Node.fMem node == fm &&
                  Node.tDsk node == fromIntegral td &&
                  Node.fDsk node == fd &&
                  Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
549
550

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
551
    length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
552

553
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
554
555
    (Text.loadNode defGroupAssoc.
         Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
556
557
558
559
    Just (Node.name n, n)
    -- override failN1 to what loadNode returns by default
    where n = node { Node.failN1 = True, Node.offline = False }

560
testText =
Iustin Pop's avatar
Iustin Pop committed
561
    [ run prop_Text_Load_Instance
Iustin Pop's avatar
Iustin Pop committed
562
563
564
    , run prop_Text_Load_InstanceFail
    , run prop_Text_Load_Node
    , run prop_Text_Load_NodeFail
565
    , run prop_Text_NodeLSIdempotent
566
567
568
569
    ]

-- Node tests

Iustin Pop's avatar
Iustin Pop committed
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
prop_Node_setAlias node name =
    Node.name newnode == Node.name node &&
    Node.alias newnode == name
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
    Node.offline newnode == status
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
    Node.xMem newnode == xm
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
    Node.mCpu newnode == mc
    where newnode = Node.setMcpu node mc

588
-- | Check that an instance add with too high memory or disk will be rejected
Iustin Pop's avatar
Iustin Pop committed
589
590
591
592
593
594
prop_Node_addPriFM node inst = Instance.mem inst >= Node.fMem node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailMem -> True
                                 _ -> False
595
    where _types = (node::Node.Node, inst::Instance.Instance)
Iustin Pop's avatar
Iustin Pop committed
596
597
598
599
600
601
602
603
604
605
606
607
608
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst = Instance.dsk inst >= Node.fDsk node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailDisk -> True
                                 _ -> False
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

Iustin Pop's avatar
Iustin Pop committed
609
610
611
612
613
prop_Node_addPriFC node inst (Positive extra) =
    not (Node.failN1 node) ==>
        case Node.addPri node inst'' of
          Types.OpFail Types.FailCPU -> True
          _ -> False
Iustin Pop's avatar
Iustin Pop committed
614
615
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
Iustin Pop's avatar
Iustin Pop committed
616
          inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
617
618

-- | Check that an instance add with too high memory or disk will be rejected
619
prop_Node_addSec node inst pdx =
620
621
    (Instance.mem inst >= (Node.fMem node - Node.rMem node) ||
     Instance.dsk inst >= Node.fDsk node) &&
Iustin Pop's avatar
Iustin Pop committed
622
    not (Node.failN1 node)
Iustin Pop's avatar
Iustin Pop committed
623
    ==> isFailure (Node.addSec node inst pdx)
624
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
625

626
-- | Checks for memory reservation changes
627
628
prop_Node_rMem inst =
    forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
629
630
    -- ab = auto_balance, nb = non-auto_balance
    -- we use -1 as the primary node of the instance
Iustin Pop's avatar
Iustin Pop committed
631
    let inst' = inst { Instance.pNode = -1, Instance.auto_balance = True }
632
633
634
635
636
637
638
639
640
641
642
643
644
        inst_ab = setInstanceSmallerThanNode node inst'
        inst_nb = inst_ab { Instance.auto_balance = False }
        -- now we have the two instances, identical except the
        -- auto_balance attribute
        orig_rmem = Node.rMem node
        inst_idx = Instance.idx inst_ab
        node_add_ab = Node.addSec node inst_ab (-1)
        node_add_nb = Node.addSec node inst_nb (-1)
        node_del_ab = liftM (flip Node.removeSec inst_ab) node_add_ab
        node_del_nb = liftM (flip Node.removeSec inst_nb) node_add_nb
    in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
         (Types.OpGood a_ab, Types.OpGood a_nb,
          Types.OpGood d_ab, Types.OpGood d_nb) ->
645
             printTestCase "Consistency checks failed" $
646
647
648
649
650
651
652
653
654
             Node.rMem a_ab >  orig_rmem &&
             Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
             Node.rMem a_nb == orig_rmem &&
             Node.rMem d_ab == orig_rmem &&
             Node.rMem d_nb == orig_rmem &&
             -- this is not related to rMem, but as good a place to
             -- test as any
             inst_idx `elem` Node.sList a_ab &&
             not (inst_idx `elem` Node.sList d_ab)
655
656
         x -> printTestCase ("Failed to add/remove instances: " ++ show x)
              False
657

Iustin Pop's avatar
Iustin Pop committed
658
659
660
661
662
663
664
665
666
667
668
669
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
    arbitrary = do
      v <- choose (0, 1)
      return $ SmallRatio v

-- | Check mdsk setting
prop_Node_setMdsk node mx =
    Node.loDsk node' >= 0 &&
    fromIntegral (Node.loDsk node') <= Node.tDsk node &&
    Node.availDisk node' >= 0 &&
    Node.availDisk node' <= Node.fDsk node' &&
Iustin Pop's avatar
Iustin Pop committed
670
671
    fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
    Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
672
673
674
675
676
677
678
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
    Node.delTags (Node.addTags m tags) tags == m
679
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
680
681
682
683

prop_Node_tagMaps_reject tags =
    not (null tags) ==>
    any (\t -> Node.rejectAddTags m [t]) tags
684
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
685

Iustin Pop's avatar
Iustin Pop committed
686
687
688
689
690
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

691
692
693
694
695
696
697

prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
Iustin Pop's avatar
Iustin Pop committed
698
     (null nodes || not (null ng))
699

700
testNode =
Iustin Pop's avatar
Iustin Pop committed
701
702
703
704
705
    [ run prop_Node_setAlias
    , run prop_Node_setOffline
    , run prop_Node_setMcpu
    , run prop_Node_setXmem
    , run prop_Node_addPriFM
Iustin Pop's avatar
Iustin Pop committed
706
707
    , run prop_Node_addPriFD
    , run prop_Node_addPriFC
708
    , run prop_Node_addSec
709
    , run prop_Node_rMem
Iustin Pop's avatar
Iustin Pop committed
710
711
712
    , run prop_Node_setMdsk
    , run prop_Node_tagMaps_idempotent
    , run prop_Node_tagMaps_reject
Iustin Pop's avatar
Iustin Pop committed
713
    , run prop_Node_showField
714
    , run prop_Node_computeGroups
715
    ]
716
717
718
719
720


-- Cluster tests

-- | Check that the cluster score is close to zero for a homogeneous cluster
Iustin Pop's avatar
Iustin Pop committed
721
722
prop_Score_Zero node =
    forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
723
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
724
     (Node.tDsk node > 0) && (Node.tMem node > 0)) ==>
725
    let fn = Node.buildPeers node Container.empty
Iustin Pop's avatar
Iustin Pop committed
726
        nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
Iustin Pop's avatar
Iustin Pop committed
727
        nl = Container.fromList nlst
728
729
730
        score = Cluster.compCV nl
    -- we can't say == 0 here as the floating point errors accumulate;
    -- this should be much lower than the default score in CLI.hs
Iustin Pop's avatar
Iustin Pop committed
731
    in score <= 1e-12
732

Iustin Pop's avatar
Iustin Pop committed
733
-- | Check that cluster stats are sane
Iustin Pop's avatar
Iustin Pop committed
734
735
736
prop_CStats_sane node =
    forAll (choose (1, 1024)) $ \count ->
    (not (Node.offline node) && not (Node.failN1 node) &&
737
     (Node.availDisk node > 0) && (Node.availMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
738
739
    let fn = Node.buildPeers node Container.empty
        nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
Iustin Pop's avatar
Iustin Pop committed
740
        nl = Container.fromList nlst
Iustin Pop's avatar
Iustin Pop committed
741
742
743
744
        cstats = Cluster.totalResources nl
    in Cluster.csAdsk cstats >= 0 &&
       Cluster.csAdsk cstats <= Cluster.csFdsk cstats

745
746
747
748
749
750
751
752
753
754
755
756
-- | Check that one instance is allocated correctly, without
-- rebalances needed
prop_ClusterAlloc_sane node inst =
    forAll (choose (5, 20)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && Node.availDisk node > 0
            && Node.availMem node > 0
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
757
758
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
759
         Types.Bad _ -> False
760
761
         Types.Ok as ->
             case Cluster.asSolutions as of
762
               [] -> False
763
               (xnl, xi, _, cv):[] ->
764
                   let il' = Container.add (Instance.idx xi) xi il
765
                       tbl = Cluster.Table xnl il' cv []
766
                   in not (canBalance tbl True True False)
767
768
769
770
771
772
773
774
775
776
777
778
779
780
               _ -> False

-- | Checks that on a 2-5 node cluster, we can allocate a random
-- instance spec via tiered allocation (whatever the original instance
-- spec), on either one or two nodes
prop_ClusterCanTieredAlloc node inst =
    forAll (choose (2, 5)) $ \count ->
    forAll (choose (1, 2)) $ \rqnodes ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
781
        allocnodes = Cluster.genAllocNodes defGroupList nl rqnodes True
Iustin Pop's avatar
Iustin Pop committed
782
783
    in case allocnodes >>= \allocnodes' ->
        Cluster.tieredAlloc nl il inst allocnodes' [] [] of
784
         Types.Bad _ -> False
785
786
787
         Types.Ok (_, _, il', ixes, cstats) -> not (null ixes) &&
                                      IntMap.size il' == length ixes &&
                                      length ixes == length cstats
788
789
790
791
792
793
794
795
796
797
798
799

-- | Checks that on a 4-8 node cluster, once we allocate an instance,
-- we can also evacuate it
prop_ClusterAllocEvac node inst =
    forAll (choose (4, 8)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
800
801
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
802
         Types.Bad _ -> False
803
804
         Types.Ok as ->
             case Cluster.asSolutions as of
805
               [] -> False
806
               (xnl, xi, _, _):[] ->
807
808
                   let sdx = Instance.sNode xi
                       il' = Container.add (Instance.idx xi) xi il
809
                   in case Cluster.tryEvac xnl il' [Instance.idx xi] [sdx] of
810
811
812
813
814
815
                        Just _ -> True
                        _ -> False
               _ -> False

-- | Check that allocating multiple instances on a cluster, then
-- adding an empty node, results in a valid rebalance
816
817
prop_ClusterAllocBalance =
    forAll (genNode (Just 5) (Just 128)) $ \node ->
818
    forAll (choose (3, 5)) $ \count ->
819
    not (Node.offline node) && not (Node.failN1 node) ==>
820
821
822
    let nl = makeSmallCluster node count
        (hnode, nl') = IntMap.deleteFindMax nl
        il = Container.empty
823
        allocnodes = Cluster.genAllocNodes defGroupList nl' 2 True
824
        i_templ = createInstance Types.unitMem Types.unitDsk Types.unitCpu
Iustin Pop's avatar
Iustin Pop committed
825
826
    in case allocnodes >>= \allocnodes' ->
        Cluster.iterateAlloc nl' il i_templ allocnodes' [] [] of
827
         Types.Bad _ -> False
828
         Types.Ok (_, xnl, il', _, _) ->
829
830
831
                   let ynl = Container.add (Node.idx hnode) hnode xnl
                       cv = Cluster.compCV ynl
                       tbl = Cluster.Table ynl il' cv []
832
                   in canBalance tbl True True False
833

834
835
836
837
-- | Checks consistency
prop_ClusterCheckConsistency node inst =
  let nl = makeSmallCluster node 3
      [node1, node2, node3] = Container.elems nl
Iustin Pop's avatar
Iustin Pop committed
838
      node3' = node3 { Node.group = 1 }
839
840
841
842
      nl' = Container.add (Node.idx node3') node3' nl
      inst1 = Instance.setBoth inst (Node.idx node1) (Node.idx node2)
      inst2 = Instance.setBoth inst (Node.idx node1) Node.noSecondary
      inst3 = Instance.setBoth inst (Node.idx node1) (Node.idx node3)
Iustin Pop's avatar
Iustin Pop committed
843
      ccheck = Cluster.findSplitInstances nl' . Container.fromList
844
845
846
847
  in null (ccheck [(0, inst1)]) &&
     null (ccheck [(0, inst2)]) &&
     (not . null $ ccheck [(0, inst3)])

848
849
850
851
852
853
854
855
856
857
-- For now, we only test that we don't lose instances during the split
prop_ClusterSplitCluster node inst =
  forAll (choose (0, 100)) $ \icnt ->
  let nl = makeSmallCluster node 2
      (nl', il') = foldl (\(ns, is) _ -> assignInstance ns is inst 0 1)
                   (nl, Container.empty) [1..icnt]
      gni = Cluster.splitCluster nl' il'
  in sum (map (Container.size . snd . snd) gni) == icnt &&
     all (\(guuid, (nl'', _)) -> all ((== guuid) . Node.group)
                                 (Container.elems nl'')) gni
858

859
testCluster =
860
    [ run prop_Score_Zero
Iustin Pop's avatar
Iustin Pop committed
861
    , run prop_CStats_sane
862
863
864
865
    , run prop_ClusterAlloc_sane
    , run prop_ClusterCanTieredAlloc
    , run prop_ClusterAllocEvac
    , run prop_ClusterAllocBalance
866
    , run prop_ClusterCheckConsistency
867
    , run prop_ClusterSplitCluster
868
    ]
Iustin Pop's avatar
Iustin Pop committed
869
870
871
872
873
874
875

-- | Check that opcode serialization is idempotent

prop_OpCodes_serialization op =
  case J.readJSON (J.showJSON op) of
    J.Error _ -> False
    J.Ok op' -> op == op'
876
  where _types = op::OpCodes.OpCode
Iustin Pop's avatar
Iustin Pop committed
877
878
879
880

testOpCodes =
  [ run prop_OpCodes_serialization
  ]
Iustin Pop's avatar
Iustin Pop committed
881

882
-- | Check that (queued) job\/opcode status serialization is idempotent
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
prop_OpStatus_serialization os =
  case J.readJSON (J.showJSON os) of
    J.Error _ -> False
    J.Ok os' -> os == os'
  where _types = os::Jobs.OpStatus

prop_JobStatus_serialization js =
  case J.readJSON (J.showJSON js) of
    J.Error _ -> False
    J.Ok js' -> js == js'
  where _types = js::Jobs.JobStatus

testJobs =
  [ run prop_OpStatus_serialization
  , run prop_JobStatus_serialization
  ]

Iustin Pop's avatar
Iustin Pop committed
900
901
902
-- | Loader tests

prop_Loader_lookupNode ktn inst node =
903
904
  Loader.lookupNode nl inst node == Data.Map.lookup node nl
  where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
905
906

prop_Loader_lookupInstance kti inst =
907
908
909
910
911
912
913
914
  Loader.lookupInstance il inst == Data.Map.lookup inst il
  where il = Data.Map.fromList kti

prop_Loader_assignIndices nodes =
  Data.Map.size nassoc == length nodes &&
  Container.size kt == length nodes &&
  (if not (null nodes)
   then maximum (IntMap.keys kt) == length nodes - 1
Iustin Pop's avatar
Iustin Pop committed
915
   else True)
916
  where (nassoc, kt) = Loader.assignIndices (map (\n -> (Node.name n, n)) nodes)
Iustin Pop's avatar
Iustin Pop committed
917
918
919
920
921


-- | Checks that the number of primary instances recorded on the nodes
-- is zero
prop_Loader_mergeData ns =
Iustin Pop's avatar
Iustin Pop committed
922
  let na = Container.fromList $ map (\n -> (Node.idx n, n)) ns
923
  in case Loader.mergeData [] [] [] []
924
         (Loader.emptyCluster {Loader.cdNodes = na}) of
Iustin Pop's avatar
Iustin Pop committed
925
    Types.Bad _ -> False
926
    Types.Ok (Loader.ClusterData _ nl il _) ->
Iustin Pop's avatar
Iustin Pop committed
927
928
929
      let nodes = Container.elems nl
          instances = Container.elems il
      in (sum . map (length . Node.pList)) nodes == 0 &&
930
         null instances
Iustin Pop's avatar
Iustin Pop committed
931
932
933
934
935
936
937

testLoader =
  [ run prop_Loader_lookupNode
  , run prop_Loader_lookupInstance
  , run prop_Loader_assignIndices
  , run prop_Loader_mergeData
  ]