QC.hs 52.4 KB
Newer Older
1
2
{-# LANGUAGE TemplateHaskell #-}

3
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
4
5
6
7
8

-}

{-

Iustin Pop's avatar
Iustin Pop committed
9
Copyright (C) 2009, 2010, 2011, 2012 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

28
module Ganeti.HTools.QC
Iustin Pop's avatar
Iustin Pop committed
29
30
31
32
33
34
35
36
37
38
39
40
  ( testUtils
  , testPeerMap
  , testContainer
  , testInstance
  , testNode
  , testText
  , testOpCodes
  , testJobs
  , testCluster
  , testLoader
  , testTypes
  ) where
41
42

import Test.QuickCheck
Iustin Pop's avatar
Iustin Pop committed
43
import Data.List (findIndex, intercalate, nub, isPrefixOf)
44
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
45
46
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
47
import qualified Data.Map
48
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
49
import qualified Ganeti.OpCodes as OpCodes
50
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
51
import qualified Ganeti.Luxi
52
53
54
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
55
import qualified Ganeti.HTools.ExtLoader
56
57
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
58
import qualified Ganeti.HTools.JSON as JSON
59
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
60
import qualified Ganeti.HTools.Luxi
61
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
62
import qualified Ganeti.HTools.Group as Group
63
import qualified Ganeti.HTools.PeerMap as PeerMap
64
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
65
import qualified Ganeti.HTools.Simu
66
67
68
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
69
import qualified Ganeti.HTools.Version
70
import qualified Ganeti.Constants as C
71

72
73
74
75
76
import qualified Ganeti.HTools.Program.Hail
import qualified Ganeti.HTools.Program.Hbal
import qualified Ganeti.HTools.Program.Hscan
import qualified Ganeti.HTools.Program.Hspace

77
import Ganeti.HTools.QCHelper (testSuite)
Iustin Pop's avatar
Iustin Pop committed
78

79
80
-- * Constants

81
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
82
83
84
maxMem :: Int
maxMem = 1024 * 1024

85
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
86
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
87
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
88

89
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
90
91
92
maxCpu :: Int
maxCpu = 1024

93
94
95
96
-- | All disk templates (used later)
allDiskTemplates :: [Types.DiskTemplate]
allDiskTemplates = [minBound..maxBound]

97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
-- | Null iPolicy, and by null we mean very liberal.
nullIPolicy = Types.IPolicy
  { Types.iPolicyMinSpec = Types.ISpec { Types.iSpecMemorySize = 0
                                       , Types.iSpecCpuCount   = 0
                                       , Types.iSpecDiskSize   = 0
                                       , Types.iSpecDiskCount  = 0
                                       , Types.iSpecNicCount   = 0
                                       }
  , Types.iPolicyMaxSpec = Types.ISpec { Types.iSpecMemorySize = maxBound
                                       , Types.iSpecCpuCount   = maxBound
                                       , Types.iSpecDiskSize   = maxBound
                                       , Types.iSpecDiskCount  = C.maxDisks
                                       , Types.iSpecNicCount   = C.maxNics
                                       }
  , Types.iPolicyStdSpec = Types.ISpec { Types.iSpecMemorySize = Types.unitMem
                                       , Types.iSpecCpuCount   = Types.unitCpu
                                       , Types.iSpecDiskSize   = Types.unitDsk
                                       , Types.iSpecDiskCount  = 1
                                       , Types.iSpecNicCount   = 1
                                       }
  , Types.iPolicyDiskTemplates = [Types.DTDrbd8, Types.DTPlain]
  }


Iustin Pop's avatar
Iustin Pop committed
121
122
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
Iustin Pop's avatar
Iustin Pop committed
123
             Group.create "default" Types.defaultGroupID Types.AllocPreferred
124
                  nullIPolicy
Iustin Pop's avatar
Iustin Pop committed
125
126

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
127
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
128
129
130
131

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

132
133
-- * Helper functions

134
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
135
136
137
138
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

Iustin Pop's avatar
Iustin Pop committed
139
140
141
142
143
144
145
-- | Checks for equality with proper annotation.
(==?) :: (Show a, Eq a) => a -> a -> Property
(==?) x y = printTestCase
            ("Expected equality, but '" ++
             show x ++ "' /= '" ++ show y ++ "'") (x == y)
infix 3 ==?

Iustin Pop's avatar
Iustin Pop committed
146
147
148
149
-- | Show a message and fail the test.
failTest :: String -> Property
failTest msg = printTestCase msg False

150
-- | Update an instance to be smaller than a node.
151
setInstanceSmallerThanNode node inst =
Iustin Pop's avatar
Iustin Pop committed
152
153
154
155
  inst { Instance.mem = Node.availMem node `div` 2
       , Instance.dsk = Node.availDisk node `div` 2
       , Instance.vcpus = Node.availCpu node `div` 2
       }
156

157
-- | Create an instance given its spec.
158
createInstance mem dsk vcpus =
Iustin Pop's avatar
Iustin Pop committed
159
160
  Instance.create "inst-unnamed" mem dsk vcpus Types.Running [] True (-1) (-1)
    Types.DTDrbd8
161

162
-- | Create a small cluster by repeating a node spec.
163
164
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
165
166
167
168
169
170
171
  let origname = Node.name node
      origalias = Node.alias node
      nodes = map (\idx -> node { Node.name = origname ++ "-" ++ show idx
                                , Node.alias = origalias ++ "-" ++ show idx })
              [1..count]
      fn = flip Node.buildPeers Container.empty
      namelst = map (\n -> (Node.name n, fn n)) nodes
Iustin Pop's avatar
Iustin Pop committed
172
173
      (_, nlst) = Loader.assignIndices namelst
  in nlst
174

Iustin Pop's avatar
Iustin Pop committed
175
176
177
178
179
180
181
-- | Make a small cluster, both nodes and instances.
makeSmallEmptyCluster :: Node.Node -> Int -> Instance.Instance
                      -> (Node.List, Instance.List, Instance.Instance)
makeSmallEmptyCluster node count inst =
  (makeSmallCluster node count, Container.empty,
   setInstanceSmallerThanNode node inst)

182
-- | Checks if a node is "big" enough.
183
184
isNodeBig :: Int -> Node.Node -> Bool
isNodeBig size node = Node.availDisk node > size * Types.unitDsk
185
186
187
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

188
189
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
190

191
-- | Assigns a new fresh instance to a cluster; this is not
192
-- allocation, so no resource checks are done.
193
194
195
196
197
198
199
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
Iustin Pop's avatar
Iustin Pop committed
200
201
                  then 0
                  else fst (Container.findMax il) + 1
202
203
204
205
206
207
208
209
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

210
211
212
213
214
215
216
-- | Generates a list of a given size with non-duplicate elements.
genUniquesList :: (Eq a, Arbitrary a) => Int -> Gen [a]
genUniquesList cnt =
  foldM (\lst _ -> do
           newelem <- arbitrary `suchThat` (`notElem` lst)
           return (newelem:lst)) [] [1..cnt]

217
218
-- * Arbitrary instances

219
-- | Defines a DNS name.
220
newtype DNSChar = DNSChar { dnsGetChar::Char }
221

222
instance Arbitrary DNSChar where
Iustin Pop's avatar
Iustin Pop committed
223
224
225
  arbitrary = do
    x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
    return (DNSChar x)
226

227
-- | Generates a single name component.
228
229
230
231
232
233
getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)

234
-- | Generates an entire FQDN.
235
236
237
getFQDN :: Gen String
getFQDN = do
  ncomps <- choose (1, 4)
238
239
  names <- mapM (const getName) [1..ncomps::Int]
  return $ intercalate "." names
240

241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
-- | Defines a tag type.
newtype TagChar = TagChar { tagGetChar :: Char }

-- | All valid tag chars. This doesn't need to match _exactly_
-- Ganeti's own tag regex, just enough for it to be close.
tagChar :: [Char]
tagChar = ['a'..'z'] ++ ['A'..'Z'] ++ ['0'..'9'] ++ ".+*/:@-"

instance Arbitrary TagChar where
  arbitrary = do
    c <- elements tagChar
    return (TagChar c)

-- | Generates a tag
genTag :: Gen [TagChar]
genTag = do
  -- the correct value would be C.maxTagLen, but that's way too
  -- verbose in unittests, and at the moment I don't see any possible
  -- bugs with longer tags and the way we use tags in htools
  n <- choose (1, 10)
  vector n

-- | Generates a list of tags (correctly upper bounded).
genTags :: Gen [String]
genTags = do
  -- the correct value would be C.maxTagsPerObj, but per the comment
  -- in genTag, we don't use tags enough in htools to warrant testing
  -- such big values
  n <- choose (0, 10::Int)
  tags <- mapM (const genTag) [1..n]
  return $ map (map tagGetChar) tags

273
instance Arbitrary Types.InstanceStatus where
274
    arbitrary = elements [minBound..maxBound]
275

276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
-- | Generates a random instance with maximum disk/mem/cpu values.
genInstanceSmallerThan :: Int -> Int -> Int -> Gen Instance.Instance
genInstanceSmallerThan lim_mem lim_dsk lim_cpu = do
  name <- getFQDN
  mem <- choose (0, lim_mem)
  dsk <- choose (0, lim_dsk)
  run_st <- arbitrary
  pn <- arbitrary
  sn <- arbitrary
  vcpus <- choose (0, lim_cpu)
  return $ Instance.create name mem dsk vcpus run_st [] True pn sn
         Types.DTDrbd8

-- | Generates an instance smaller than a node.
genInstanceSmallerThanNode :: Node.Node -> Gen Instance.Instance
genInstanceSmallerThanNode node =
  genInstanceSmallerThan (Node.availMem node `div` 2)
                         (Node.availDisk node `div` 2)
                         (Node.availCpu node `div` 2)

296
297
-- let's generate a random instance
instance Arbitrary Instance.Instance where
298
  arbitrary = genInstanceSmallerThan maxMem maxDsk maxCpu
299

300
301
302
303
304
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
305
306
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
Iustin Pop's avatar
Iustin Pop committed
307
308
309
310
311
        case min_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (0, 0, 0)
312
      (top_mem, top_dsk, top_cpu)  =
Iustin Pop's avatar
Iustin Pop committed
313
314
315
316
317
        case max_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (maxMem, maxDsk, maxCpu)
318
319
320
321
322
323
324
325
326
327
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
Iustin Pop's avatar
Iustin Pop committed
328
329
      n' = Node.setPolicy nullIPolicy n
  return $ Node.buildPeers n' Container.empty
330

331
332
333
334
335
336
337
338
339
-- | Helper function to generate a sane node.
genOnlineNode :: Gen Node.Node
genOnlineNode = do
  arbitrary `suchThat` (\n -> not (Node.offline n) &&
                              not (Node.failN1 n) &&
                              Node.availDisk n > 0 &&
                              Node.availMem n > 0 &&
                              Node.availCpu n > 0)

340
341
-- and a random node
instance Arbitrary Node.Node where
Iustin Pop's avatar
Iustin Pop committed
342
  arbitrary = genNode Nothing Nothing
343

Iustin Pop's avatar
Iustin Pop committed
344
345
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
346
  arbitrary = elements [minBound..maxBound]
Iustin Pop's avatar
Iustin Pop committed
347
348
349
350
351
352
353
354

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
Iustin Pop's avatar
Iustin Pop committed
355
356
357
358
359
360
361
362
363
364
365
366
367
    case op_id of
      "OP_TEST_DELAY" ->
        liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
      "OP_INSTANCE_REPLACE_DISKS" ->
        liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
          arbitrary arbitrary arbitrary
      "OP_INSTANCE_FAILOVER" ->
        liftM3 OpCodes.OpInstanceFailover arbitrary arbitrary
          arbitrary
      "OP_INSTANCE_MIGRATE" ->
        liftM5 OpCodes.OpInstanceMigrate arbitrary arbitrary
          arbitrary arbitrary arbitrary
      _ -> fail "Wrong opcode"
Iustin Pop's avatar
Iustin Pop committed
368

369
370
371
372
373
374
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

375
376
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
Iustin Pop's avatar
Iustin Pop committed
377
378
379
  arbitrary = do
    v <- choose (0, 1)
    return $ SmallRatio v
380

381
382
383
384
385
386
instance Arbitrary Types.AllocPolicy where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Types.DiskTemplate where
  arbitrary = elements [minBound..maxBound]

387
instance Arbitrary Types.FailMode where
Iustin Pop's avatar
Iustin Pop committed
388
  arbitrary = elements [minBound..maxBound]
389

390
391
392
instance Arbitrary Types.EvacMode where
  arbitrary = elements [minBound..maxBound]

393
instance Arbitrary a => Arbitrary (Types.OpResult a) where
Iustin Pop's avatar
Iustin Pop committed
394
  arbitrary = arbitrary >>= \c ->
Iustin Pop's avatar
Iustin Pop committed
395
396
397
              if c
                then liftM Types.OpGood arbitrary
                else liftM Types.OpFail arbitrary
398

399
400
instance Arbitrary Types.ISpec where
  arbitrary = do
401
    mem_s <- arbitrary::Gen (NonNegative Int)
402
403
    dsk_c <- arbitrary::Gen (NonNegative Int)
    dsk_s <- arbitrary::Gen (NonNegative Int)
404
405
406
407
    cpu_c <- arbitrary::Gen (NonNegative Int)
    nic_c <- arbitrary::Gen (NonNegative Int)
    return Types.ISpec { Types.iSpecMemorySize = fromIntegral mem_s
                       , Types.iSpecCpuCount   = fromIntegral cpu_c
408
409
                       , Types.iSpecDiskSize   = fromIntegral dsk_s
                       , Types.iSpecDiskCount  = fromIntegral dsk_c
410
                       , Types.iSpecNicCount   = fromIntegral nic_c
411
412
                       }

413
414
415
416
417
418
419
420
421
422
423
424
425
426
-- | Generates an ispec bigger than the given one.
genBiggerISpec :: Types.ISpec -> Gen Types.ISpec
genBiggerISpec imin = do
  mem_s <- choose (Types.iSpecMemorySize imin, maxBound)
  dsk_c <- choose (Types.iSpecDiskCount imin, maxBound)
  dsk_s <- choose (Types.iSpecDiskSize imin, maxBound)
  cpu_c <- choose (Types.iSpecCpuCount imin, maxBound)
  nic_c <- choose (Types.iSpecNicCount imin, maxBound)
  return Types.ISpec { Types.iSpecMemorySize = fromIntegral mem_s
                     , Types.iSpecCpuCount   = fromIntegral cpu_c
                     , Types.iSpecDiskSize   = fromIntegral dsk_s
                     , Types.iSpecDiskCount  = fromIntegral dsk_c
                     , Types.iSpecNicCount   = fromIntegral nic_c
                     }
427
428
429
430

instance Arbitrary Types.IPolicy where
  arbitrary = do
    imin <- arbitrary
431
432
433
434
    istd <- genBiggerISpec imin
    imax <- genBiggerISpec istd
    num_tmpl <- choose (0, length allDiskTemplates)
    dts  <- genUniquesList num_tmpl
435
436
437
438
439
440
    return Types.IPolicy { Types.iPolicyMinSpec = imin
                         , Types.iPolicyStdSpec = istd
                         , Types.iPolicyMaxSpec = imax
                         , Types.iPolicyDiskTemplates = dts
                         }

441
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
442

443
444
445
446
-- ** Utils tests

-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
447
prop_Utils_commaJoinSplit =
Iustin Pop's avatar
Iustin Pop committed
448
  forAll (arbitrary `suchThat`
Iustin Pop's avatar
Iustin Pop committed
449
          (\l -> l /= [""] && all (notElem ',') l )) $ \lst ->
Iustin Pop's avatar
Iustin Pop committed
450
  Utils.sepSplit ',' (Utils.commaJoin lst) ==? lst
Iustin Pop's avatar
Iustin Pop committed
451

452
-- | Split and join should always be idempotent.
Iustin Pop's avatar
Iustin Pop committed
453
prop_Utils_commaSplitJoin s =
Iustin Pop's avatar
Iustin Pop committed
454
  Utils.commaJoin (Utils.sepSplit ',' s) ==? s
455

456
-- | fromObjWithDefault, we test using the Maybe monad and an integer
457
-- value.
458
prop_Utils_fromObjWithDefault def_value random_key =
Iustin Pop's avatar
Iustin Pop committed
459
  -- a missing key will be returned with the default
460
  JSON.fromObjWithDefault [] random_key def_value == Just def_value &&
Iustin Pop's avatar
Iustin Pop committed
461
  -- a found key will be returned as is, not with default
462
  JSON.fromObjWithDefault [(random_key, J.showJSON def_value)]
Iustin Pop's avatar
Iustin Pop committed
463
464
       random_key (def_value+1) == Just def_value
    where _types = def_value :: Integer
465

466
-- | Test that functional if' behaves like the syntactic sugar if.
Iustin Pop's avatar
Iustin Pop committed
467
468
prop_Utils_if'if :: Bool -> Int -> Int -> Gen Prop
prop_Utils_if'if cnd a b =
Iustin Pop's avatar
Iustin Pop committed
469
  Utils.if' cnd a b ==? if cnd then a else b
470

Guido Trotter's avatar
Guido Trotter committed
471
-- | Test basic select functionality
Iustin Pop's avatar
Iustin Pop committed
472
473
474
475
prop_Utils_select :: Int      -- ^ Default result
                  -> [Int]    -- ^ List of False values
                  -> [Int]    -- ^ List of True values
                  -> Gen Prop -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
476
prop_Utils_select def lst1 lst2 =
Iustin Pop's avatar
Iustin Pop committed
477
  Utils.select def (flist ++ tlist) ==? expectedresult
Iustin Pop's avatar
Iustin Pop committed
478
479
480
    where expectedresult = Utils.if' (null lst2) def (head lst2)
          flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
481
482

-- | Test basic select functionality with undefined default
Iustin Pop's avatar
Iustin Pop committed
483
prop_Utils_select_undefd :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
484
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
485
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
486
prop_Utils_select_undefd lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
487
  Utils.select undefined (flist ++ tlist) ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
488
489
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
490
491

-- | Test basic select functionality with undefined list values
Iustin Pop's avatar
Iustin Pop committed
492
prop_Utils_select_undefv :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
493
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
494
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
495
prop_Utils_select_undefv lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
496
  Utils.select undefined cndlist ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
497
498
499
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
          cndlist = flist ++ tlist ++ [undefined]
500

Iustin Pop's avatar
Iustin Pop committed
501
prop_Utils_parseUnit (NonNegative n) =
Iustin Pop's avatar
Iustin Pop committed
502
503
504
505
506
507
508
509
510
511
  Utils.parseUnit (show n) == Types.Ok n &&
  Utils.parseUnit (show n ++ "m") == Types.Ok n &&
  (case Utils.parseUnit (show n ++ "M") of
     Types.Ok m -> if n > 0
                     then m < n  -- for positive values, X MB is < than X MiB
                     else m == 0 -- but for 0, 0 MB == 0 MiB
     Types.Bad _ -> False) &&
  Utils.parseUnit (show n ++ "g") == Types.Ok (n*1024) &&
  Utils.parseUnit (show n ++ "t") == Types.Ok (n*1048576) &&
  Types.isBad (Utils.parseUnit (show n ++ "x")::Types.Result Int)
Iustin Pop's avatar
Iustin Pop committed
512
    where _types = n::Int
Iustin Pop's avatar
Iustin Pop committed
513

514
-- | Test list for the Utils module.
515
testSuite "Utils"
Iustin Pop's avatar
Iustin Pop committed
516
517
518
519
520
521
522
523
524
            [ 'prop_Utils_commaJoinSplit
            , 'prop_Utils_commaSplitJoin
            , 'prop_Utils_fromObjWithDefault
            , 'prop_Utils_if'if
            , 'prop_Utils_select
            , 'prop_Utils_select_undefd
            , 'prop_Utils_select_undefv
            , 'prop_Utils_parseUnit
            ]
525

526
527
528
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
529
prop_PeerMap_addIdempotent pmap key em =
Iustin Pop's avatar
Iustin Pop committed
530
  fn puniq ==? fn (fn puniq)
531
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
532
533
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
534
          puniq = PeerMap.accumArray const pmap
535

536
-- | Make sure remove is idempotent.
537
prop_PeerMap_removeIdempotent pmap key =
Iustin Pop's avatar
Iustin Pop committed
538
  fn puniq ==? fn (fn puniq)
539
540
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
541
542
          puniq = PeerMap.accumArray const pmap

543
-- | Make sure a missing item returns 0.
544
prop_PeerMap_findMissing pmap key =
Iustin Pop's avatar
Iustin Pop committed
545
  PeerMap.find key (PeerMap.remove key puniq) ==? 0
546
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
547
548
          puniq = PeerMap.accumArray const pmap

549
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
550
prop_PeerMap_addFind pmap key em =
Iustin Pop's avatar
Iustin Pop committed
551
  PeerMap.find key (PeerMap.add key em puniq) ==? em
552
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
553
                    key::PeerMap.Key, em::PeerMap.Elem)
554
          puniq = PeerMap.accumArray const pmap
555

556
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
557
prop_PeerMap_maxElem pmap =
Iustin Pop's avatar
Iustin Pop committed
558
  PeerMap.maxElem puniq ==? if null puniq then 0
Iustin Pop's avatar
Iustin Pop committed
559
                              else (maximum . snd . unzip) puniq
560
    where _types = pmap::PeerMap.PeerMap
561
562
          puniq = PeerMap.accumArray const pmap

563
-- | List of tests for the PeerMap module.
564
testSuite "PeerMap"
Iustin Pop's avatar
Iustin Pop committed
565
566
567
568
569
570
            [ 'prop_PeerMap_addIdempotent
            , 'prop_PeerMap_removeIdempotent
            , 'prop_PeerMap_maxElem
            , 'prop_PeerMap_addFind
            , 'prop_PeerMap_findMissing
            ]
571

572
-- ** Container tests
573

Iustin Pop's avatar
Iustin Pop committed
574
575
-- we silence the following due to hlint bug fixed in later versions
{-# ANN prop_Container_addTwo "HLint: ignore Avoid lambda" #-}
576
prop_Container_addTwo cdata i1 i2 =
Iustin Pop's avatar
Iustin Pop committed
577
578
  fn i1 i2 cont == fn i2 i1 cont &&
  fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
579
580
581
582
583
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

584
585
586
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
Iustin Pop's avatar
Iustin Pop committed
587
  in Container.nameOf nl (Node.idx fnode) ==? Node.name fnode
588

589
-- | We test that in a cluster, given a random node, we can find it by
590
-- its name and alias, as long as all names and aliases are unique,
591
-- and that we fail to find a non-existing name.
592
prop_Container_findByName node =
593
594
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
595
596
597
598
  forAll (genUniquesList (cnt * 2)) $ \ allnames ->
  forAll (arbitrary `suchThat` (`notElem` allnames)) $ \ othername ->
  let names = zip (take cnt allnames) (drop cnt allnames)
      nl = makeSmallCluster node cnt
599
600
601
602
603
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
604
      nl' = Container.fromList nodes'
605
606
607
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
Iustin Pop's avatar
Iustin Pop committed
608
     isNothing (Container.findByName nl' othername)
609

610
testSuite "Container"
Iustin Pop's avatar
Iustin Pop committed
611
612
613
614
            [ 'prop_Container_addTwo
            , 'prop_Container_nameOf
            , 'prop_Container_findByName
            ]
615

616
617
-- ** Instance tests

618
619
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
620
prop_Instance_creat inst =
Iustin Pop's avatar
Iustin Pop committed
621
  Instance.name inst ==? Instance.alias inst
Iustin Pop's avatar
Iustin Pop committed
622

623
prop_Instance_setIdx inst idx =
Iustin Pop's avatar
Iustin Pop committed
624
  Instance.idx (Instance.setIdx inst idx) ==? idx
625
626
627
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
628
629
  Instance.name newinst == name &&
  Instance.alias newinst == name
Iustin Pop's avatar
Iustin Pop committed
630
631
632
633
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
Iustin Pop's avatar
Iustin Pop committed
634
635
  Instance.name newinst == Instance.name inst &&
  Instance.alias newinst == name
636
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
637
          newinst = Instance.setAlias inst name
638
639

prop_Instance_setPri inst pdx =
Iustin Pop's avatar
Iustin Pop committed
640
  Instance.pNode (Instance.setPri inst pdx) ==? pdx
641
642
643
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
Iustin Pop's avatar
Iustin Pop committed
644
  Instance.sNode (Instance.setSec inst sdx) ==? sdx
645
646
647
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
Iustin Pop's avatar
Iustin Pop committed
648
  Instance.pNode si == pdx && Instance.sNode si == sdx
649
650
651
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
652
prop_Instance_shrinkMG inst =
Iustin Pop's avatar
Iustin Pop committed
653
654
655
656
  Instance.mem inst >= 2 * Types.unitMem ==>
    case Instance.shrinkByType inst Types.FailMem of
      Types.Ok inst' -> Instance.mem inst' == Instance.mem inst - Types.unitMem
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
657
658

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
659
  forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
Iustin Pop's avatar
Iustin Pop committed
660
661
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
662
663

prop_Instance_shrinkCG inst =
Iustin Pop's avatar
Iustin Pop committed
664
665
666
667
668
  Instance.vcpus inst >= 2 * Types.unitCpu ==>
    case Instance.shrinkByType inst Types.FailCPU of
      Types.Ok inst' ->
        Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
669
670

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
671
  forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
Iustin Pop's avatar
Iustin Pop committed
672
673
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
674
675

prop_Instance_shrinkDG inst =
Iustin Pop's avatar
Iustin Pop committed
676
677
678
679
680
  Instance.dsk inst >= 2 * Types.unitDsk ==>
    case Instance.shrinkByType inst Types.FailDisk of
      Types.Ok inst' ->
        Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
681
682

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
683
  forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
Iustin Pop's avatar
Iustin Pop committed
684
685
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
686
687

prop_Instance_setMovable inst m =
Iustin Pop's avatar
Iustin Pop committed
688
  Instance.movable inst' ==? m
689
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
690

691
testSuite "Instance"
Iustin Pop's avatar
Iustin Pop committed
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
            [ 'prop_Instance_creat
            , 'prop_Instance_setIdx
            , 'prop_Instance_setName
            , 'prop_Instance_setAlias
            , 'prop_Instance_setPri
            , 'prop_Instance_setSec
            , 'prop_Instance_setBoth
            , 'prop_Instance_shrinkMG
            , 'prop_Instance_shrinkMF
            , 'prop_Instance_shrinkCG
            , 'prop_Instance_shrinkCF
            , 'prop_Instance_shrinkDG
            , 'prop_Instance_shrinkDF
            , 'prop_Instance_setMovable
            ]
Iustin Pop's avatar
Iustin Pop committed
707

708
709
-- ** Text backend tests

Iustin Pop's avatar
Iustin Pop committed
710
711
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
712
713
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
714
                        (NonNegative pdx) (NonNegative sdx) autobal dt =
Iustin Pop's avatar
Iustin Pop committed
715
716
717
718
719
720
  pnode /= snode && pdx /= sdx ==>
  let vcpus_s = show vcpus
      dsk_s = show dsk
      mem_s = show mem
      status_s = Types.instanceStatusToRaw status
      ndx = if null snode
Iustin Pop's avatar
Iustin Pop committed
721
              then [(pnode, pdx)]
722
              else [(pnode, pdx), (snode, sdx)]
Iustin Pop's avatar
Iustin Pop committed
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
      nl = Data.Map.fromList ndx
      tags = ""
      sbal = if autobal then "Y" else "N"
      sdt = Types.diskTemplateToRaw dt
      inst = Text.loadInst nl
             [name, mem_s, dsk_s, vcpus_s, status_s,
              sbal, pnode, snode, sdt, tags]
      fail1 = Text.loadInst nl
              [name, mem_s, dsk_s, vcpus_s, status_s,
               sbal, pnode, pnode, tags]
      _types = ( name::String, mem::Int, dsk::Int
               , vcpus::Int, status::Types.InstanceStatus
               , snode::String
               , autobal::Bool)
  in case inst of
Iustin Pop's avatar
Iustin Pop committed
738
       Types.Bad msg -> failTest $ "Failed to load instance: " ++ msg
Iustin Pop's avatar
Iustin Pop committed
739
740
741
742
743
744
745
746
747
748
749
       Types.Ok (_, i) -> printTestCase "Mismatch in some field while\
                                        \ loading the instance" $
               Instance.name i == name &&
               Instance.vcpus i == vcpus &&
               Instance.mem i == mem &&
               Instance.pNode i == pdx &&
               Instance.sNode i == (if null snode
                                      then Node.noSecondary
                                      else sdx) &&
               Instance.autoBalance i == autobal &&
               Types.isBad fail1
Iustin Pop's avatar
Iustin Pop committed
750
751

prop_Text_Load_InstanceFail ktn fields =
Iustin Pop's avatar
Iustin Pop committed
752
  length fields /= 10 ==>
Iustin Pop's avatar
Iustin Pop committed
753
    case Text.loadInst nl fields of
Iustin Pop's avatar
Iustin Pop committed
754
      Types.Ok _ -> failTest "Managed to load instance from invalid data"
755
756
      Types.Bad msg -> printTestCase ("Unrecognised error message: " ++ msg) $
                       "Invalid/incomplete instance data: '" `isPrefixOf` msg
757
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
758
759

prop_Text_Load_Node name tm nm fm td fd tc fo =
Iustin Pop's avatar
Iustin Pop committed
760
761
762
763
764
765
766
767
768
769
  let conv v = if v < 0
                 then "?"
                 else show v
      tm_s = conv tm
      nm_s = conv nm
      fm_s = conv fm
      td_s = conv td
      fd_s = conv fd
      tc_s = conv tc
      fo_s = if fo
Iustin Pop's avatar
Iustin Pop committed
770
771
               then "Y"
               else "N"
Iustin Pop's avatar
Iustin Pop committed
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
      any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
      gid = Group.uuid defGroup
  in case Text.loadNode defGroupAssoc
       [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
       Nothing -> False
       Just (name', node) ->
         if fo || any_broken
           then Node.offline node
           else Node.name node == name' && name' == name &&
                Node.alias node == name &&
                Node.tMem node == fromIntegral tm &&
                Node.nMem node == nm &&
                Node.fMem node == fm &&
                Node.tDsk node == fromIntegral td &&
                Node.fDsk node == fd &&
                Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
788
789

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
790
  length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
791

792
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
793
794
795
  (Text.loadNode defGroupAssoc.
       Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
  Just (Node.name n, n)
796
    -- override failN1 to what loadNode returns by default
Iustin Pop's avatar
Iustin Pop committed
797
798
    where n = node { Node.failN1 = True, Node.offline = False
                   , Node.iPolicy = Types.defIPolicy }
799

800
801
802
prop_Text_ISpecIdempotent ispec =
  case Text.loadISpec "dummy" . Utils.sepSplit ',' .
       Text.serializeISpec $ ispec of
Iustin Pop's avatar
Iustin Pop committed
803
    Types.Bad msg -> failTest $ "Failed to load ispec: " ++ msg
804
805
806
807
808
    Types.Ok ispec' -> ispec ==? ispec'

prop_Text_IPolicyIdempotent ipol =
  case Text.loadIPolicy . Utils.sepSplit '|' $
       Text.serializeIPolicy owner ipol of
Iustin Pop's avatar
Iustin Pop committed
809
    Types.Bad msg -> failTest $ "Failed to load ispec: " ++ msg
810
811
812
    Types.Ok res -> (owner, ipol) ==? res
  where owner = "dummy"

813
814
815
816
817
818
819
820
821
822
823
824
825
-- | This property, while being in the text tests, does more than just
-- test end-to-end the serialisation and loading back workflow; it
-- also tests the Loader.mergeData and the actuall
-- Cluster.iterateAlloc (for well-behaving w.r.t. instance
-- allocations, not for the business logic). As such, it's a quite
-- complex and slow test, and that's the reason we restrict it to
-- small cluster sizes.
prop_Text_CreateSerialise =
  forAll genTags $ \ctags ->
  forAll (choose (1, 2)) $ \reqnodes ->
  forAll (choose (1, 20)) $ \maxiter ->
  forAll (choose (2, 10)) $ \count ->
  forAll genOnlineNode $ \node ->
826
827
  forAll (genInstanceSmallerThanNode node) $ \inst ->
  let inst' = Instance.setMovable inst (reqnodes == 2)
828
829
830
831
      nl = makeSmallCluster node count
  in case Cluster.genAllocNodes defGroupList nl reqnodes True >>= \allocn ->
     Cluster.iterateAlloc nl Container.empty (Just maxiter) inst' allocn [] []
     of
Iustin Pop's avatar
Iustin Pop committed
832
       Types.Bad msg -> failTest $ "Failed to allocate: " ++ msg
833
834
835
836
837
838
839
       Types.Ok (_, _, _, [], _) -> printTestCase
                                    "Failed to allocate: no allocations" False
       Types.Ok (_, nl', il', _, _) ->
         let cdata = Loader.ClusterData defGroupList nl' il' ctags
                     Types.defIPolicy
             saved = Text.serializeCluster cdata
         in case Text.parseData saved >>= Loader.mergeData [] [] [] [] of
Iustin Pop's avatar
Iustin Pop committed
840
              Types.Bad msg -> failTest $ "Failed to load/merge: " ++ msg
841
842
843
844
              Types.Ok (Loader.ClusterData gl2 nl2 il2 ctags2 cpol2) ->
                ctags ==? ctags2 .&&.
                Types.defIPolicy ==? cpol2 .&&.
                il' ==? il2 .&&.
845
846
                defGroupList ==? gl2 .&&.
                nl' ==? nl2
847

848
testSuite "Text"
Iustin Pop's avatar
Iustin Pop committed
849
850
851
852
853
            [ 'prop_Text_Load_Instance
            , 'prop_Text_Load_InstanceFail
            , 'prop_Text_Load_Node
            , 'prop_Text_Load_NodeFail
            , 'prop_Text_NodeLSIdempotent
854
855
            , 'prop_Text_ISpecIdempotent
            , 'prop_Text_IPolicyIdempotent
856
            , 'prop_Text_CreateSerialise
Iustin Pop's avatar
Iustin Pop committed
857
            ]
858

859
-- ** Node tests
860

Iustin Pop's avatar
Iustin Pop committed
861
prop_Node_setAlias node name =
Iustin Pop's avatar
Iustin Pop committed
862
863
  Node.name newnode == Node.name node &&
  Node.alias newnode == name
Iustin Pop's avatar
Iustin Pop committed
864
865
866
867
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
Iustin Pop's avatar
Iustin Pop committed
868
  Node.offline newnode ==? status
Iustin Pop's avatar
Iustin Pop committed
869
870
871
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
Iustin Pop's avatar
Iustin Pop committed
872
  Node.xMem newnode ==? xm
Iustin Pop's avatar
Iustin Pop committed
873
874
875
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
Iustin Pop's avatar
Iustin Pop committed
876
  Node.mCpu newnode ==? mc
Iustin Pop's avatar
Iustin Pop committed
877
878
    where newnode = Node.setMcpu node mc

879
880
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
prop_Node_addPriFM node inst =
  Instance.mem inst >= Node.fMem node && not (Node.failN1 node) &&
  not (Instance.instanceOffline inst) ==>
  case Node.addPri node inst'' of
    Types.OpFail Types.FailMem -> True
    _ -> False
  where _types = (node::Node.Node, inst::Instance.Instance)
        inst' = setInstanceSmallerThanNode node inst
        inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst =
  Instance.dsk inst >= Node.fDsk node && not (Node.failN1 node) ==>
    case Node.addPri node inst'' of
      Types.OpFail Types.FailDisk -> True
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
896
897
898
899
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

900
901
902
903
904
905
906
907
prop_Node_addPriFC (Positive extra) =
  forAll genOnlineNode $ \node ->
  forAll (arbitrary `suchThat` Instance.instanceNotOffline) $ \inst ->
  let inst' = setInstanceSmallerThanNode node inst
      inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
  in case Node.addPri node inst'' of
       Types.OpFail Types.FailCPU -> property True
       v -> failTest $ "Expected OpFail FailCPU, but got " ++ show v
908

909
910
-- | Check that an instance add with too high memory or disk will be
-- rejected.
911
prop_Node_addSec node inst pdx =
Iustin Pop's avatar
Iustin Pop committed
912
913
914
915
916
  ((Instance.mem inst >= (Node.fMem node - Node.rMem node) &&
    not (Instance.instanceOffline inst)) ||
   Instance.dsk inst >= Node.fDsk node) &&
  not (Node.failN1 node) ==>
      isFailure (Node.addSec node inst pdx)
917
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
918

919
920
-- | Check that an offline instance with reasonable disk size can always
-- be added.
921
922
prop_Node_addPriOffline =
  forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
923
924
925
926
927
928
  forAll (arbitrary `suchThat`
          (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                   Instance.instanceOffline x)) $ \inst ->
  case Node.addPri node inst of
    Types.OpGood _ -> True
    _ -> False
929

930
prop_Node_addSecOffline pdx =
931
  forAll genOnlineNode $ \node ->
Iustin Pop's avatar
Iustin Pop committed
932
  forAll (arbitrary `suchThat`
933
934
          (\ inst -> Instance.dsk inst  < Node.availDisk node)) $ \inst ->
  case Node.addSec node (inst { Instance.runSt = Types.AdminOffline }) pdx of
Iustin Pop's avatar
Iustin Pop committed
935
936
    Types.OpGood _ -> True
    _ -> False
937

938
-- | Checks for memory reservation changes.
939
prop_Node_rMem inst =
Iustin Pop's avatar
Iustin Pop committed
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
  not (Instance.instanceOffline inst) ==>
  forAll (arbitrary `suchThat` ((> Types.unitMem) . Node.fMem)) $ \node ->
  -- ab = auto_balance, nb = non-auto_balance
  -- we use -1 as the primary node of the instance
  let inst' = inst { Instance.pNode = -1, Instance.autoBalance = True }
      inst_ab = setInstanceSmallerThanNode node inst'
      inst_nb = inst_ab { Instance.autoBalance = False }
      -- now we have the two instances, identical except the
      -- autoBalance attribute
      orig_rmem = Node.rMem node
      inst_idx = Instance.idx inst_ab
      node_add_ab = Node.addSec node inst_ab (-1)
      node_add_nb = Node.addSec node inst_nb (-1)
      node_del_ab = liftM (`Node.removeSec` inst_ab) node_add_ab
      node_del_nb = liftM (`Node.removeSec` inst_nb) node_add_nb
  in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
       (Types.OpGood a_ab, Types.OpGood a_nb,
        Types.OpGood d_ab, Types.OpGood d_nb) ->
         printTestCase "Consistency checks failed" $
           Node.rMem a_ab >  orig_rmem &&
           Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
           Node.rMem a_nb == orig_rmem &&
           Node.rMem d_ab == orig_rmem &&
           Node.rMem d_nb == orig_rmem &&
           -- this is not related to rMem, but as good a place to
           -- test as any
           inst_idx `elem` Node.sList a_ab &&
Iustin Pop's avatar
Iustin Pop committed
967
           inst_idx `notElem` Node.sList d_ab
Iustin Pop's avatar
Iustin Pop committed
968
       x -> failTest $ "Failed to add/remove instances: " ++ show x
969

970
-- | Check mdsk setting.
Iustin Pop's avatar
Iustin Pop committed
971
prop_Node_setMdsk node mx =
Iustin Pop's avatar
Iustin Pop committed
972
973
974
975
976
977
  Node.loDsk node' >= 0 &&
  fromIntegral (Node.loDsk node') <= Node.tDsk node &&
  Node.availDisk node' >= 0 &&
  Node.availDisk node' <= Node.fDsk node' &&
  fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
  Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
978
979
980
981
982
983
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
Iustin Pop's avatar
Iustin Pop committed
984
  Node.delTags (Node.addTags m tags) tags ==? m
985
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
986
987

prop_Node_tagMaps_reject tags =
Iustin Pop's avatar
Iustin Pop committed
988
989
  not (null tags) ==>
  all (\t -> Node.rejectAddTags m [t]) tags
990
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
991

Iustin Pop's avatar
Iustin Pop committed
992
993
994
995
996
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

997
998
999
1000
1001
1002
prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
Iustin Pop's avatar
Iustin Pop committed
1003
     (null nodes || not (null ng))
1004

1005
testSuite "Node"
Iustin Pop's avatar
Iustin Pop committed
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
            [ 'prop_Node_setAlias
            , 'prop_Node_setOffline
            , 'prop_Node_setMcpu
            , 'prop_Node_setXmem
            , 'prop_Node_addPriFM
            , 'prop_Node_addPriFD
            , 'prop_Node_addPriFC
            , 'prop_Node_addSec
            , 'prop_Node_addPriOffline
            , 'prop_Node_addSecOffline
            , 'prop_Node_rMem
            , 'prop_Node_setMdsk
            , 'prop_Node_tagMaps_idempotent
            , 'prop_Node_tagMaps_reject
            , 'prop_Node_showField
            , 'prop_Node_computeGroups
            ]
1023

1024
-- ** Cluster tests
1025

1026
1027
-- | Check that the cluster score is close to zero for a homogeneous
-- cluster.
Iustin Pop's avatar
Iustin Pop committed
1028
prop_Score_Zero node =