QC.hs 43.6 KB
Newer Older
1
2
{-# LANGUAGE TemplateHaskell #-}

3
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
4
5
6
7
8

-}

{-

Iustin Pop's avatar
Iustin Pop committed
9
Copyright (C) 2009, 2010, 2011, 2012 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

28
module Ganeti.HTools.QC
Iustin Pop's avatar
Iustin Pop committed
29
30
31
32
33
34
35
36
37
38
39
40
  ( testUtils
  , testPeerMap
  , testContainer
  , testInstance
  , testNode
  , testText
  , testOpCodes
  , testJobs
  , testCluster
  , testLoader
  , testTypes
  ) where
41
42

import Test.QuickCheck
Iustin Pop's avatar
Iustin Pop committed
43
import Data.List (findIndex, intercalate, nub, isPrefixOf)
44
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
45
46
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
47
import qualified Data.Map
48
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
49
import qualified Ganeti.OpCodes as OpCodes
50
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
51
import qualified Ganeti.Luxi
52
53
54
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
55
import qualified Ganeti.HTools.ExtLoader
56
57
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
58
import qualified Ganeti.HTools.JSON as JSON
59
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
60
import qualified Ganeti.HTools.Luxi
61
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
62
import qualified Ganeti.HTools.Group as Group
63
import qualified Ganeti.HTools.PeerMap as PeerMap
64
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
65
import qualified Ganeti.HTools.Simu
66
67
68
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
69
import qualified Ganeti.HTools.Version
70
import qualified Ganeti.Constants as C
71

72
73
74
75
76
import qualified Ganeti.HTools.Program.Hail
import qualified Ganeti.HTools.Program.Hbal
import qualified Ganeti.HTools.Program.Hscan
import qualified Ganeti.HTools.Program.Hspace

77
import Ganeti.HTools.QCHelper (testSuite)
Iustin Pop's avatar
Iustin Pop committed
78

79
80
-- * Constants

81
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
82
83
84
maxMem :: Int
maxMem = 1024 * 1024

85
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
86
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
87
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
88

89
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
90
91
92
maxCpu :: Int
maxCpu = 1024

93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
-- | Null iPolicy, and by null we mean very liberal.
nullIPolicy = Types.IPolicy
  { Types.iPolicyMinSpec = Types.ISpec { Types.iSpecMemorySize = 0
                                       , Types.iSpecCpuCount   = 0
                                       , Types.iSpecDiskSize   = 0
                                       , Types.iSpecDiskCount  = 0
                                       , Types.iSpecNicCount   = 0
                                       }
  , Types.iPolicyMaxSpec = Types.ISpec { Types.iSpecMemorySize = maxBound
                                       , Types.iSpecCpuCount   = maxBound
                                       , Types.iSpecDiskSize   = maxBound
                                       , Types.iSpecDiskCount  = C.maxDisks
                                       , Types.iSpecNicCount   = C.maxNics
                                       }
  , Types.iPolicyStdSpec = Types.ISpec { Types.iSpecMemorySize = Types.unitMem
                                       , Types.iSpecCpuCount   = Types.unitCpu
                                       , Types.iSpecDiskSize   = Types.unitDsk
                                       , Types.iSpecDiskCount  = 1
                                       , Types.iSpecNicCount   = 1
                                       }
  , Types.iPolicyDiskTemplates = [Types.DTDrbd8, Types.DTPlain]
  }


Iustin Pop's avatar
Iustin Pop committed
117
118
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
Iustin Pop's avatar
Iustin Pop committed
119
             Group.create "default" Types.defaultGroupID Types.AllocPreferred
120
                  nullIPolicy
Iustin Pop's avatar
Iustin Pop committed
121
122

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
123
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
124
125
126
127

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

128
129
-- * Helper functions

130
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
131
132
133
134
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

Iustin Pop's avatar
Iustin Pop committed
135
136
137
138
139
140
141
-- | Checks for equality with proper annotation.
(==?) :: (Show a, Eq a) => a -> a -> Property
(==?) x y = printTestCase
            ("Expected equality, but '" ++
             show x ++ "' /= '" ++ show y ++ "'") (x == y)
infix 3 ==?

142
-- | Update an instance to be smaller than a node.
143
setInstanceSmallerThanNode node inst =
Iustin Pop's avatar
Iustin Pop committed
144
145
146
147
  inst { Instance.mem = Node.availMem node `div` 2
       , Instance.dsk = Node.availDisk node `div` 2
       , Instance.vcpus = Node.availCpu node `div` 2
       }
148

149
-- | Create an instance given its spec.
150
createInstance mem dsk vcpus =
Iustin Pop's avatar
Iustin Pop committed
151
152
  Instance.create "inst-unnamed" mem dsk vcpus Types.Running [] True (-1) (-1)
    Types.DTDrbd8
153

154
-- | Create a small cluster by repeating a node spec.
155
156
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
Iustin Pop's avatar
Iustin Pop committed
157
158
159
160
  let fn = Node.buildPeers node Container.empty
      namelst = map (\n -> (Node.name n, n)) (replicate count fn)
      (_, nlst) = Loader.assignIndices namelst
  in nlst
161

Iustin Pop's avatar
Iustin Pop committed
162
163
164
165
166
167
168
-- | Make a small cluster, both nodes and instances.
makeSmallEmptyCluster :: Node.Node -> Int -> Instance.Instance
                      -> (Node.List, Instance.List, Instance.Instance)
makeSmallEmptyCluster node count inst =
  (makeSmallCluster node count, Container.empty,
   setInstanceSmallerThanNode node inst)

169
-- | Checks if a node is "big" enough.
170
171
172
173
174
isNodeBig :: Node.Node -> Int -> Bool
isNodeBig node size = Node.availDisk node > size * Types.unitDsk
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

175
176
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
177

178
-- | Assigns a new fresh instance to a cluster; this is not
179
-- allocation, so no resource checks are done.
180
181
182
183
184
185
186
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
Iustin Pop's avatar
Iustin Pop committed
187
188
                  then 0
                  else fst (Container.findMax il) + 1
189
190
191
192
193
194
195
196
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

197
198
-- * Arbitrary instances

199
-- | Defines a DNS name.
200
newtype DNSChar = DNSChar { dnsGetChar::Char }
201

202
instance Arbitrary DNSChar where
Iustin Pop's avatar
Iustin Pop committed
203
204
205
  arbitrary = do
    x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
    return (DNSChar x)
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220

getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)

getFQDN :: Gen String
getFQDN = do
  felem <- getName
  ncomps <- choose (1, 4)
  frest <- vector ncomps::Gen [[DNSChar]]
  let frest' = map (map dnsGetChar) frest
  return (felem ++ "." ++ intercalate "." frest')

221
instance Arbitrary Types.InstanceStatus where
222
    arbitrary = elements [minBound..maxBound]
223

224
225
-- let's generate a random instance
instance Arbitrary Instance.Instance where
Iustin Pop's avatar
Iustin Pop committed
226
227
228
229
230
231
232
233
234
235
  arbitrary = do
    name <- getFQDN
    mem <- choose (0, maxMem)
    dsk <- choose (0, maxDsk)
    run_st <- arbitrary
    pn <- arbitrary
    sn <- arbitrary
    vcpus <- choose (0, maxCpu)
    return $ Instance.create name mem dsk vcpus run_st [] True pn sn
              Types.DTDrbd8
236

237
238
239
240
241
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
242
243
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
Iustin Pop's avatar
Iustin Pop committed
244
245
246
247
248
        case min_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (0, 0, 0)
249
      (top_mem, top_dsk, top_cpu)  =
Iustin Pop's avatar
Iustin Pop committed
250
251
252
253
254
        case max_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (maxMem, maxDsk, maxCpu)
255
256
257
258
259
260
261
262
263
264
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
Iustin Pop's avatar
Iustin Pop committed
265
266
      n' = Node.setPolicy nullIPolicy n
  return $ Node.buildPeers n' Container.empty
267

268
269
-- and a random node
instance Arbitrary Node.Node where
Iustin Pop's avatar
Iustin Pop committed
270
  arbitrary = genNode Nothing Nothing
271

Iustin Pop's avatar
Iustin Pop committed
272
273
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
274
  arbitrary = elements [minBound..maxBound]
Iustin Pop's avatar
Iustin Pop committed
275
276
277
278
279
280
281
282

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
Iustin Pop's avatar
Iustin Pop committed
283
284
285
286
287
288
289
290
291
292
293
294
295
    case op_id of
      "OP_TEST_DELAY" ->
        liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
      "OP_INSTANCE_REPLACE_DISKS" ->
        liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
          arbitrary arbitrary arbitrary
      "OP_INSTANCE_FAILOVER" ->
        liftM3 OpCodes.OpInstanceFailover arbitrary arbitrary
          arbitrary
      "OP_INSTANCE_MIGRATE" ->
        liftM5 OpCodes.OpInstanceMigrate arbitrary arbitrary
          arbitrary arbitrary arbitrary
      _ -> fail "Wrong opcode"
Iustin Pop's avatar
Iustin Pop committed
296

297
298
299
300
301
302
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

303
304
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
Iustin Pop's avatar
Iustin Pop committed
305
306
307
  arbitrary = do
    v <- choose (0, 1)
    return $ SmallRatio v
308

309
310
311
312
313
314
instance Arbitrary Types.AllocPolicy where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Types.DiskTemplate where
  arbitrary = elements [minBound..maxBound]

315
instance Arbitrary Types.FailMode where
Iustin Pop's avatar
Iustin Pop committed
316
  arbitrary = elements [minBound..maxBound]
317
318

instance Arbitrary a => Arbitrary (Types.OpResult a) where
Iustin Pop's avatar
Iustin Pop committed
319
  arbitrary = arbitrary >>= \c ->
Iustin Pop's avatar
Iustin Pop committed
320
321
322
              if c
                then liftM Types.OpGood arbitrary
                else liftM Types.OpFail arbitrary
323

324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
instance Arbitrary Types.ISpec where
  arbitrary = do
    mem <- arbitrary::Gen (NonNegative Int)
    dsk_c <- arbitrary::Gen (NonNegative Int)
    dsk_s <- arbitrary::Gen (NonNegative Int)
    cpu <- arbitrary::Gen (NonNegative Int)
    nic <- arbitrary::Gen (NonNegative Int)
    return Types.ISpec { Types.iSpecMemorySize = fromIntegral mem
                       , Types.iSpecCpuCount   = fromIntegral cpu
                       , Types.iSpecDiskSize   = fromIntegral dsk_s
                       , Types.iSpecDiskCount  = fromIntegral dsk_c
                       , Types.iSpecNicCount   = fromIntegral nic
                       }

-- | Helper function to check whether a spec is LTE than another
iSpecSmaller :: Types.ISpec -> Types.ISpec -> Bool
iSpecSmaller imin imax =
  Types.iSpecMemorySize imin <= Types.iSpecMemorySize imax &&
  Types.iSpecCpuCount imin   <= Types.iSpecCpuCount imax &&
  Types.iSpecDiskSize imin   <= Types.iSpecDiskSize imax &&
  Types.iSpecDiskCount imin  <= Types.iSpecDiskCount imax &&
  Types.iSpecNicCount imin   <= Types.iSpecNicCount imax

instance Arbitrary Types.IPolicy where
  arbitrary = do
    imin <- arbitrary
    istd <- arbitrary `suchThat` (iSpecSmaller imin)
    imax <- arbitrary `suchThat` (iSpecSmaller istd)
    dts  <- arbitrary
    return Types.IPolicy { Types.iPolicyMinSpec = imin
                         , Types.iPolicyStdSpec = istd
                         , Types.iPolicyMaxSpec = imax
                         , Types.iPolicyDiskTemplates = dts
                         }

359
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
360

361
362
363
364
-- ** Utils tests

-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
365
prop_Utils_commaJoinSplit =
Iustin Pop's avatar
Iustin Pop committed
366
  forAll (arbitrary `suchThat`
Iustin Pop's avatar
Iustin Pop committed
367
          (\l -> l /= [""] && all (notElem ',') l )) $ \lst ->
Iustin Pop's avatar
Iustin Pop committed
368
  Utils.sepSplit ',' (Utils.commaJoin lst) ==? lst
Iustin Pop's avatar
Iustin Pop committed
369

370
-- | Split and join should always be idempotent.
Iustin Pop's avatar
Iustin Pop committed
371
prop_Utils_commaSplitJoin s =
Iustin Pop's avatar
Iustin Pop committed
372
  Utils.commaJoin (Utils.sepSplit ',' s) ==? s
373

374
-- | fromObjWithDefault, we test using the Maybe monad and an integer
375
-- value.
376
prop_Utils_fromObjWithDefault def_value random_key =
Iustin Pop's avatar
Iustin Pop committed
377
  -- a missing key will be returned with the default
378
  JSON.fromObjWithDefault [] random_key def_value == Just def_value &&
Iustin Pop's avatar
Iustin Pop committed
379
  -- a found key will be returned as is, not with default
380
  JSON.fromObjWithDefault [(random_key, J.showJSON def_value)]
Iustin Pop's avatar
Iustin Pop committed
381
382
       random_key (def_value+1) == Just def_value
    where _types = def_value :: Integer
383

384
-- | Test that functional if' behaves like the syntactic sugar if.
Iustin Pop's avatar
Iustin Pop committed
385
386
prop_Utils_if'if :: Bool -> Int -> Int -> Gen Prop
prop_Utils_if'if cnd a b =
Iustin Pop's avatar
Iustin Pop committed
387
  Utils.if' cnd a b ==? if cnd then a else b
388

Guido Trotter's avatar
Guido Trotter committed
389
-- | Test basic select functionality
Iustin Pop's avatar
Iustin Pop committed
390
391
392
393
prop_Utils_select :: Int      -- ^ Default result
                  -> [Int]    -- ^ List of False values
                  -> [Int]    -- ^ List of True values
                  -> Gen Prop -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
394
prop_Utils_select def lst1 lst2 =
Iustin Pop's avatar
Iustin Pop committed
395
  Utils.select def (flist ++ tlist) ==? expectedresult
Iustin Pop's avatar
Iustin Pop committed
396
397
398
    where expectedresult = Utils.if' (null lst2) def (head lst2)
          flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
399
400

-- | Test basic select functionality with undefined default
Iustin Pop's avatar
Iustin Pop committed
401
prop_Utils_select_undefd :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
402
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
403
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
404
prop_Utils_select_undefd lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
405
  Utils.select undefined (flist ++ tlist) ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
406
407
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
408
409

-- | Test basic select functionality with undefined list values
Iustin Pop's avatar
Iustin Pop committed
410
prop_Utils_select_undefv :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
411
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
412
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
413
prop_Utils_select_undefv lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
414
  Utils.select undefined cndlist ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
415
416
417
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
          cndlist = flist ++ tlist ++ [undefined]
418

Iustin Pop's avatar
Iustin Pop committed
419
prop_Utils_parseUnit (NonNegative n) =
Iustin Pop's avatar
Iustin Pop committed
420
421
422
423
424
425
426
427
428
429
  Utils.parseUnit (show n) == Types.Ok n &&
  Utils.parseUnit (show n ++ "m") == Types.Ok n &&
  (case Utils.parseUnit (show n ++ "M") of
     Types.Ok m -> if n > 0
                     then m < n  -- for positive values, X MB is < than X MiB
                     else m == 0 -- but for 0, 0 MB == 0 MiB
     Types.Bad _ -> False) &&
  Utils.parseUnit (show n ++ "g") == Types.Ok (n*1024) &&
  Utils.parseUnit (show n ++ "t") == Types.Ok (n*1048576) &&
  Types.isBad (Utils.parseUnit (show n ++ "x")::Types.Result Int)
Iustin Pop's avatar
Iustin Pop committed
430
    where _types = n::Int
Iustin Pop's avatar
Iustin Pop committed
431

432
-- | Test list for the Utils module.
433
testSuite "Utils"
Iustin Pop's avatar
Iustin Pop committed
434
435
436
437
438
439
440
441
442
            [ 'prop_Utils_commaJoinSplit
            , 'prop_Utils_commaSplitJoin
            , 'prop_Utils_fromObjWithDefault
            , 'prop_Utils_if'if
            , 'prop_Utils_select
            , 'prop_Utils_select_undefd
            , 'prop_Utils_select_undefv
            , 'prop_Utils_parseUnit
            ]
443

444
445
446
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
447
prop_PeerMap_addIdempotent pmap key em =
Iustin Pop's avatar
Iustin Pop committed
448
  fn puniq ==? fn (fn puniq)
449
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
450
451
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
452
          puniq = PeerMap.accumArray const pmap
453

454
-- | Make sure remove is idempotent.
455
prop_PeerMap_removeIdempotent pmap key =
Iustin Pop's avatar
Iustin Pop committed
456
  fn puniq ==? fn (fn puniq)
457
458
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
459
460
          puniq = PeerMap.accumArray const pmap

461
-- | Make sure a missing item returns 0.
462
prop_PeerMap_findMissing pmap key =
Iustin Pop's avatar
Iustin Pop committed
463
  PeerMap.find key (PeerMap.remove key puniq) ==? 0
464
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
465
466
          puniq = PeerMap.accumArray const pmap

467
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
468
prop_PeerMap_addFind pmap key em =
Iustin Pop's avatar
Iustin Pop committed
469
  PeerMap.find key (PeerMap.add key em puniq) ==? em
470
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
471
                    key::PeerMap.Key, em::PeerMap.Elem)
472
          puniq = PeerMap.accumArray const pmap
473

474
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
475
prop_PeerMap_maxElem pmap =
Iustin Pop's avatar
Iustin Pop committed
476
  PeerMap.maxElem puniq ==? if null puniq then 0
Iustin Pop's avatar
Iustin Pop committed
477
                              else (maximum . snd . unzip) puniq
478
    where _types = pmap::PeerMap.PeerMap
479
480
          puniq = PeerMap.accumArray const pmap

481
-- | List of tests for the PeerMap module.
482
testSuite "PeerMap"
Iustin Pop's avatar
Iustin Pop committed
483
484
485
486
487
488
            [ 'prop_PeerMap_addIdempotent
            , 'prop_PeerMap_removeIdempotent
            , 'prop_PeerMap_maxElem
            , 'prop_PeerMap_addFind
            , 'prop_PeerMap_findMissing
            ]
489

490
-- ** Container tests
491

Iustin Pop's avatar
Iustin Pop committed
492
493
-- we silence the following due to hlint bug fixed in later versions
{-# ANN prop_Container_addTwo "HLint: ignore Avoid lambda" #-}
494
prop_Container_addTwo cdata i1 i2 =
Iustin Pop's avatar
Iustin Pop committed
495
496
  fn i1 i2 cont == fn i2 i1 cont &&
  fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
497
498
499
500
501
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

502
503
504
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
Iustin Pop's avatar
Iustin Pop committed
505
  in Container.nameOf nl (Node.idx fnode) ==? Node.name fnode
506

507
-- | We test that in a cluster, given a random node, we can find it by
508
-- its name and alias, as long as all names and aliases are unique,
509
-- and that we fail to find a non-existing name.
510
511
512
513
514
515
prop_Container_findByName node othername =
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
  forAll (vector cnt) $ \ names ->
  (length . nub) (map fst names ++ map snd names) ==
  length names * 2 &&
Iustin Pop's avatar
Iustin Pop committed
516
  othername `notElem` (map fst names ++ map snd names) ==>
517
518
519
520
521
522
  let nl = makeSmallCluster node cnt
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
523
      nl' = Container.fromList nodes'
524
525
526
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
Iustin Pop's avatar
Iustin Pop committed
527
     isNothing (Container.findByName nl' othername)
528

529
testSuite "Container"
Iustin Pop's avatar
Iustin Pop committed
530
531
532
533
            [ 'prop_Container_addTwo
            , 'prop_Container_nameOf
            , 'prop_Container_findByName
            ]
534

535
536
-- ** Instance tests

537
538
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
539
prop_Instance_creat inst =
Iustin Pop's avatar
Iustin Pop committed
540
  Instance.name inst ==? Instance.alias inst
Iustin Pop's avatar
Iustin Pop committed
541

542
prop_Instance_setIdx inst idx =
Iustin Pop's avatar
Iustin Pop committed
543
  Instance.idx (Instance.setIdx inst idx) ==? idx
544
545
546
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
547
548
  Instance.name newinst == name &&
  Instance.alias newinst == name
Iustin Pop's avatar
Iustin Pop committed
549
550
551
552
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
Iustin Pop's avatar
Iustin Pop committed
553
554
  Instance.name newinst == Instance.name inst &&
  Instance.alias newinst == name
555
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
556
          newinst = Instance.setAlias inst name
557
558

prop_Instance_setPri inst pdx =
Iustin Pop's avatar
Iustin Pop committed
559
  Instance.pNode (Instance.setPri inst pdx) ==? pdx
560
561
562
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
Iustin Pop's avatar
Iustin Pop committed
563
  Instance.sNode (Instance.setSec inst sdx) ==? sdx
564
565
566
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
Iustin Pop's avatar
Iustin Pop committed
567
  Instance.pNode si == pdx && Instance.sNode si == sdx
568
569
570
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
571
prop_Instance_shrinkMG inst =
Iustin Pop's avatar
Iustin Pop committed
572
573
574
575
  Instance.mem inst >= 2 * Types.unitMem ==>
    case Instance.shrinkByType inst Types.FailMem of
      Types.Ok inst' -> Instance.mem inst' == Instance.mem inst - Types.unitMem
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
576
577

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
578
  forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
Iustin Pop's avatar
Iustin Pop committed
579
580
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
581
582

prop_Instance_shrinkCG inst =
Iustin Pop's avatar
Iustin Pop committed
583
584
585
586
587
  Instance.vcpus inst >= 2 * Types.unitCpu ==>
    case Instance.shrinkByType inst Types.FailCPU of
      Types.Ok inst' ->
        Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
588
589

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
590
  forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
Iustin Pop's avatar
Iustin Pop committed
591
592
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
593
594

prop_Instance_shrinkDG inst =
Iustin Pop's avatar
Iustin Pop committed
595
596
597
598
599
  Instance.dsk inst >= 2 * Types.unitDsk ==>
    case Instance.shrinkByType inst Types.FailDisk of
      Types.Ok inst' ->
        Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
600
601

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
602
  forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
Iustin Pop's avatar
Iustin Pop committed
603
604
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
605
606

prop_Instance_setMovable inst m =
Iustin Pop's avatar
Iustin Pop committed
607
  Instance.movable inst' ==? m
608
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
609

610
testSuite "Instance"
Iustin Pop's avatar
Iustin Pop committed
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
            [ 'prop_Instance_creat
            , 'prop_Instance_setIdx
            , 'prop_Instance_setName
            , 'prop_Instance_setAlias
            , 'prop_Instance_setPri
            , 'prop_Instance_setSec
            , 'prop_Instance_setBoth
            , 'prop_Instance_shrinkMG
            , 'prop_Instance_shrinkMF
            , 'prop_Instance_shrinkCG
            , 'prop_Instance_shrinkCF
            , 'prop_Instance_shrinkDG
            , 'prop_Instance_shrinkDF
            , 'prop_Instance_setMovable
            ]
Iustin Pop's avatar
Iustin Pop committed
626

627
628
-- ** Text backend tests

Iustin Pop's avatar
Iustin Pop committed
629
630
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
631
632
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
633
                        (NonNegative pdx) (NonNegative sdx) autobal dt =
Iustin Pop's avatar
Iustin Pop committed
634
635
636
637
638
639
  pnode /= snode && pdx /= sdx ==>
  let vcpus_s = show vcpus
      dsk_s = show dsk
      mem_s = show mem
      status_s = Types.instanceStatusToRaw status
      ndx = if null snode
Iustin Pop's avatar
Iustin Pop committed
640
              then [(pnode, pdx)]
641
              else [(pnode, pdx), (snode, sdx)]
Iustin Pop's avatar
Iustin Pop committed
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
      nl = Data.Map.fromList ndx
      tags = ""
      sbal = if autobal then "Y" else "N"
      sdt = Types.diskTemplateToRaw dt
      inst = Text.loadInst nl
             [name, mem_s, dsk_s, vcpus_s, status_s,
              sbal, pnode, snode, sdt, tags]
      fail1 = Text.loadInst nl
              [name, mem_s, dsk_s, vcpus_s, status_s,
               sbal, pnode, pnode, tags]
      _types = ( name::String, mem::Int, dsk::Int
               , vcpus::Int, status::Types.InstanceStatus
               , snode::String
               , autobal::Bool)
  in case inst of
       Types.Bad msg -> printTestCase ("Failed to load instance: " ++ msg)
                        False
       Types.Ok (_, i) -> printTestCase "Mismatch in some field while\
                                        \ loading the instance" $
               Instance.name i == name &&
               Instance.vcpus i == vcpus &&
               Instance.mem i == mem &&
               Instance.pNode i == pdx &&
               Instance.sNode i == (if null snode
                                      then Node.noSecondary
                                      else sdx) &&
               Instance.autoBalance i == autobal &&
               Types.isBad fail1
Iustin Pop's avatar
Iustin Pop committed
670
671

prop_Text_Load_InstanceFail ktn fields =
Iustin Pop's avatar
Iustin Pop committed
672
  length fields /= 10 ==>
Iustin Pop's avatar
Iustin Pop committed
673
    case Text.loadInst nl fields of
674
675
676
677
      Types.Ok _ -> printTestCase "Managed to load instance from invalid\
                                  \ data" False
      Types.Bad msg -> printTestCase ("Unrecognised error message: " ++ msg) $
                       "Invalid/incomplete instance data: '" `isPrefixOf` msg
678
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
679
680

prop_Text_Load_Node name tm nm fm td fd tc fo =
Iustin Pop's avatar
Iustin Pop committed
681
682
683
684
685
686
687
688
689
690
  let conv v = if v < 0
                 then "?"
                 else show v
      tm_s = conv tm
      nm_s = conv nm
      fm_s = conv fm
      td_s = conv td
      fd_s = conv fd
      tc_s = conv tc
      fo_s = if fo
Iustin Pop's avatar
Iustin Pop committed
691
692
               then "Y"
               else "N"
Iustin Pop's avatar
Iustin Pop committed
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
      any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
      gid = Group.uuid defGroup
  in case Text.loadNode defGroupAssoc
       [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
       Nothing -> False
       Just (name', node) ->
         if fo || any_broken
           then Node.offline node
           else Node.name node == name' && name' == name &&
                Node.alias node == name &&
                Node.tMem node == fromIntegral tm &&
                Node.nMem node == nm &&
                Node.fMem node == fm &&
                Node.tDsk node == fromIntegral td &&
                Node.fDsk node == fd &&
                Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
709
710

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
711
  length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
712

713
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
714
715
716
  (Text.loadNode defGroupAssoc.
       Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
  Just (Node.name n, n)
717
    -- override failN1 to what loadNode returns by default
Iustin Pop's avatar
Iustin Pop committed
718
719
    where n = node { Node.failN1 = True, Node.offline = False
                   , Node.iPolicy = Types.defIPolicy }
720

721
testSuite "Text"
Iustin Pop's avatar
Iustin Pop committed
722
723
724
725
726
727
            [ 'prop_Text_Load_Instance
            , 'prop_Text_Load_InstanceFail
            , 'prop_Text_Load_Node
            , 'prop_Text_Load_NodeFail
            , 'prop_Text_NodeLSIdempotent
            ]
728

729
-- ** Node tests
730

Iustin Pop's avatar
Iustin Pop committed
731
prop_Node_setAlias node name =
Iustin Pop's avatar
Iustin Pop committed
732
733
  Node.name newnode == Node.name node &&
  Node.alias newnode == name
Iustin Pop's avatar
Iustin Pop committed
734
735
736
737
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
Iustin Pop's avatar
Iustin Pop committed
738
  Node.offline newnode ==? status
Iustin Pop's avatar
Iustin Pop committed
739
740
741
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
Iustin Pop's avatar
Iustin Pop committed
742
  Node.xMem newnode ==? xm
Iustin Pop's avatar
Iustin Pop committed
743
744
745
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
Iustin Pop's avatar
Iustin Pop committed
746
  Node.mCpu newnode ==? mc
Iustin Pop's avatar
Iustin Pop committed
747
748
    where newnode = Node.setMcpu node mc

749
750
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
prop_Node_addPriFM node inst =
  Instance.mem inst >= Node.fMem node && not (Node.failN1 node) &&
  not (Instance.instanceOffline inst) ==>
  case Node.addPri node inst'' of
    Types.OpFail Types.FailMem -> True
    _ -> False
  where _types = (node::Node.Node, inst::Instance.Instance)
        inst' = setInstanceSmallerThanNode node inst
        inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst =
  Instance.dsk inst >= Node.fDsk node && not (Node.failN1 node) ==>
    case Node.addPri node inst'' of
      Types.OpFail Types.FailDisk -> True
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
766
767
768
769
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

Iustin Pop's avatar
Iustin Pop committed
770
prop_Node_addPriFC node inst (Positive extra) =
Iustin Pop's avatar
Iustin Pop committed
771
772
773
774
  not (Node.failN1 node) && not (Instance.instanceOffline inst) ==>
      case Node.addPri node inst'' of
        Types.OpFail Types.FailCPU -> True
        _ -> False
Iustin Pop's avatar
Iustin Pop committed
775
776
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
Iustin Pop's avatar
Iustin Pop committed
777
          inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
778

779
780
-- | Check that an instance add with too high memory or disk will be
-- rejected.
781
prop_Node_addSec node inst pdx =
Iustin Pop's avatar
Iustin Pop committed
782
783
784
785
786
  ((Instance.mem inst >= (Node.fMem node - Node.rMem node) &&
    not (Instance.instanceOffline inst)) ||
   Instance.dsk inst >= Node.fDsk node) &&
  not (Node.failN1 node) ==>
      isFailure (Node.addSec node inst pdx)
787
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
788

789
790
-- | Check that an offline instance with reasonable disk size can always
-- be added.
791
792
prop_Node_addPriOffline =
  forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
793
794
795
796
797
798
  forAll (arbitrary `suchThat`
          (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                   Instance.instanceOffline x)) $ \inst ->
  case Node.addPri node inst of
    Types.OpGood _ -> True
    _ -> False
799

800
801
prop_Node_addSecOffline pdx =
  forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
802
803
804
805
806
807
  forAll (arbitrary `suchThat`
          (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                   Instance.instanceOffline x)) $ \inst ->
  case Node.addSec node inst pdx of
    Types.OpGood _ -> True
    _ -> False
808

809
-- | Checks for memory reservation changes.
810
prop_Node_rMem inst =
Iustin Pop's avatar
Iustin Pop committed
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
  not (Instance.instanceOffline inst) ==>
  forAll (arbitrary `suchThat` ((> Types.unitMem) . Node.fMem)) $ \node ->
  -- ab = auto_balance, nb = non-auto_balance
  -- we use -1 as the primary node of the instance
  let inst' = inst { Instance.pNode = -1, Instance.autoBalance = True }
      inst_ab = setInstanceSmallerThanNode node inst'
      inst_nb = inst_ab { Instance.autoBalance = False }
      -- now we have the two instances, identical except the
      -- autoBalance attribute
      orig_rmem = Node.rMem node
      inst_idx = Instance.idx inst_ab
      node_add_ab = Node.addSec node inst_ab (-1)
      node_add_nb = Node.addSec node inst_nb (-1)
      node_del_ab = liftM (`Node.removeSec` inst_ab) node_add_ab
      node_del_nb = liftM (`Node.removeSec` inst_nb) node_add_nb
  in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
       (Types.OpGood a_ab, Types.OpGood a_nb,
        Types.OpGood d_ab, Types.OpGood d_nb) ->
         printTestCase "Consistency checks failed" $
           Node.rMem a_ab >  orig_rmem &&
           Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
           Node.rMem a_nb == orig_rmem &&
           Node.rMem d_ab == orig_rmem &&
           Node.rMem d_nb == orig_rmem &&
           -- this is not related to rMem, but as good a place to
           -- test as any
           inst_idx `elem` Node.sList a_ab &&
Iustin Pop's avatar
Iustin Pop committed
838
           inst_idx `notElem` Node.sList d_ab
Iustin Pop's avatar
Iustin Pop committed
839
       x -> printTestCase ("Failed to add/remove instances: " ++ show x) False
840

841
-- | Check mdsk setting.
Iustin Pop's avatar
Iustin Pop committed
842
prop_Node_setMdsk node mx =
Iustin Pop's avatar
Iustin Pop committed
843
844
845
846
847
848
  Node.loDsk node' >= 0 &&
  fromIntegral (Node.loDsk node') <= Node.tDsk node &&
  Node.availDisk node' >= 0 &&
  Node.availDisk node' <= Node.fDsk node' &&
  fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
  Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
849
850
851
852
853
854
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
Iustin Pop's avatar
Iustin Pop committed
855
  Node.delTags (Node.addTags m tags) tags ==? m
856
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
857
858

prop_Node_tagMaps_reject tags =
Iustin Pop's avatar
Iustin Pop committed
859
860
  not (null tags) ==>
  all (\t -> Node.rejectAddTags m [t]) tags
861
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
862

Iustin Pop's avatar
Iustin Pop committed
863
864
865
866
867
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

868
869
870
871
872
873
prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
Iustin Pop's avatar
Iustin Pop committed
874
     (null nodes || not (null ng))
875

876
testSuite "Node"
Iustin Pop's avatar
Iustin Pop committed
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
            [ 'prop_Node_setAlias
            , 'prop_Node_setOffline
            , 'prop_Node_setMcpu
            , 'prop_Node_setXmem
            , 'prop_Node_addPriFM
            , 'prop_Node_addPriFD
            , 'prop_Node_addPriFC
            , 'prop_Node_addSec
            , 'prop_Node_addPriOffline
            , 'prop_Node_addSecOffline
            , 'prop_Node_rMem
            , 'prop_Node_setMdsk
            , 'prop_Node_tagMaps_idempotent
            , 'prop_Node_tagMaps_reject
            , 'prop_Node_showField
            , 'prop_Node_computeGroups
            ]
894

895
-- ** Cluster tests
896

897
898
-- | Check that the cluster score is close to zero for a homogeneous
-- cluster.
Iustin Pop's avatar
Iustin Pop committed
899
prop_Score_Zero node =
Iustin Pop's avatar
Iustin Pop committed
900
  forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
901
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
902
     (Node.tDsk node > 0) && (Node.tMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
903
904
905
906
907
908
  let fn = Node.buildPeers node Container.empty
      nlst = replicate count fn
      score = Cluster.compCVNodes nlst
  -- we can't say == 0 here as the floating point errors accumulate;
  -- this should be much lower than the default score in CLI.hs
  in score <= 1e-12
909

910
-- | Check that cluster stats are sane.
Iustin Pop's avatar
Iustin Pop committed
911
prop_CStats_sane node =
Iustin Pop's avatar
Iustin Pop committed
912
  forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
913
    (not (Node.offline node) && not (Node.failN1 node) &&
914
     (Node.availDisk node > 0) && (Node.availMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
915
916
917
918
919
920
  let fn = Node.buildPeers node Container.empty
      nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
      nl = Container.fromList nlst
      cstats = Cluster.totalResources nl
  in Cluster.csAdsk cstats >= 0 &&
     Cluster.csAdsk cstats <= Cluster.csFdsk cstats
Iustin Pop's avatar
Iustin Pop committed
921

922
-- | Check that one instance is allocated correctly, without
923
-- rebalances needed.
924
prop_ClusterAlloc_sane node inst =
Iustin Pop's avatar
Iustin Pop committed
925
926
927
928
929
930
  forAll (choose (5, 20)) $ \count ->
  not (Node.offline node)
        && not (Node.failN1 node)
        && Node.availDisk node > 0
        && Node.availMem node > 0
        ==>
Iustin Pop's avatar
Iustin Pop committed
931
  let (nl, il, inst') = makeSmallEmptyCluster node count inst
Iustin Pop's avatar
Iustin Pop committed
932
933
934
935
936
937
938
939
940
941
  in case Cluster.genAllocNodes defGroupList nl 2 True >>=
     Cluster.tryAlloc nl il inst' of
       Types.Bad _ -> False
       Types.Ok as ->
         case Cluster.asSolution as of
           Nothing -> False
           Just (xnl, xi, _, cv) ->
             let il' = Container.add (Instance.idx xi) xi il
                 tbl = Cluster.Table xnl il' cv []
             in not (canBalance tbl True True False)
942
943
944

-- | Checks that on a 2-5 node cluster, we can allocate a random
-- instance spec via tiered allocation (whatever the original instance
945
-- spec), on either one or two nodes.
946
prop_ClusterCanTieredAlloc node inst =
Iustin Pop's avatar
Iustin Pop committed
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
  forAll (choose (2, 5)) $ \count ->
  forAll (choose (1, 2)) $ \rqnodes ->
  not (Node.offline node)
        && not (Node.failN1 node)
        && isNodeBig node 4
        ==>
  let nl = makeSmallCluster node count
      il = Container.empty
      allocnodes = Cluster.genAllocNodes defGroupList nl rqnodes True
  in case allocnodes >>= \allocnodes' ->
    Cluster.tieredAlloc nl il (Just 1) inst allocnodes' [] [] of
       Types.Bad _ -> False
       Types.Ok (_, _, il', ixes, cstats) -> not (null ixes) &&
                                             IntMap.size il' == length ixes &&
                                             length ixes == length cstats
962
963

-- | Checks that on a 4-8 node cluster, once we allocate an instance,
964
-- we can also evacuate it.
965
prop_ClusterAllocEvac node inst =
Iustin Pop's avatar
Iustin Pop committed
966
967
968
969
970
  forAll (choose (4, 8)) $ \count ->
  not (Node.offline node)
        && not (Node.failN1 node)
        && isNodeBig node 4
        ==>
Iustin Pop's avatar
Iustin Pop committed
971
  let (nl, il, inst') = makeSmallEmptyCluster node count inst
Iustin Pop's avatar
Iustin Pop committed
972
973
974
975
976
977
978
979
980
981
982
983
984
  in case Cluster.genAllocNodes defGroupList nl 2 True >>=
     Cluster.tryAlloc nl il inst' of
       Types.Bad _ -> False
       Types.Ok as ->
         case Cluster.asSolution as of
           Nothing -> False
           Just (xnl, xi, _, _) ->
             let sdx = Instance.sNode xi
                 il' = Container.add (Instance.idx xi) xi il
             in case IAlloc.processRelocate defGroupList xnl il'
                  (Instance.idx xi) 1 [sdx] of
                  Types.Ok _ -> True
                  _ -> False
985
986

-- | Check that allocating multiple instances on a cluster, then
987
-- adding an empty node, results in a valid rebalance.
988
prop_ClusterAllocBalance =
Iustin Pop's avatar
Iustin Pop committed
989
990
991
992
993
994
995
996
997
998
  forAll (genNode (Just 5) (Just 128)) $ \node ->
  forAll (choose (3, 5)) $ \count ->
  not (Node.offline node) && not (Node.failN1 node) ==>
  let nl = makeSmallCluster node count
      (hnode, nl') = IntMap.deleteFindMax nl
      il = Container.empty
      allocnodes = Cluster.genAllocNodes defGroupList nl' 2 True
      i_templ = createInstance Types.unitMem Types.unitDsk Types.unitCpu
  in case allocnodes >>= \allocnodes' ->
    Cluster.iterateAlloc nl' il (Just 5) i_templ allocnodes' [] [] of
999
1000
       Types.Bad _ -> printTestCase "Failed to allocate" False
       Types.Ok (_, _, _, [], _) -> printTestCase "Failed to allocate" False
Iustin Pop's avatar
Iustin Pop committed
1001
1002
1003
1004
       Types.Ok (_, xnl, il', _, _) ->
         let ynl = Container.add (Node.idx hnode) hnode xnl
             cv = Cluster.compCV ynl
             tbl = Cluster.Table ynl il' cv []
1005
1006
         in printTestCase "Failed to rebalance" $
            canBalance tbl True True False
1007

1008
-- | Checks consistency.
1009
1010
1011
prop_ClusterCheckConsistency node inst =
  let nl = makeSmallCluster node 3
      [node1, node2, node3] = Container.elems nl
Iustin Pop's avatar
Iustin Pop committed
1012
      node3' = node3 { Node.group = 1 }
1013
1014
1015
1016
      nl' = Container.add (Node.idx node3') node3' nl
      inst1 = Instance.setBoth inst (Node.idx node1) (Node.idx node2)
      inst2 = Instance.setBoth inst (Node.idx node1) Node.noSecondary
      inst3 = Instance.setBoth inst (Node.idx node1) (Node.idx node3)
Iustin Pop's avatar
Iustin Pop committed
1017
      ccheck = Cluster.findSplitInstances nl' . Container.fromList
1018
1019
1020
1021
  in null (ccheck [(0, inst1)]) &&
     null (ccheck [(0, inst2)]) &&
     (not . null $ ccheck [(0, inst3)])

1022
-- | For now, we only test that we don't lose instances during the split.
1023
1024
1025
1026
1027
1028
1029
1030
1031
prop_ClusterSplitCluster node inst =