QC.hs 55.6 KB
Newer Older
1
2
{-# LANGUAGE TemplateHaskell #-}

3
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
4
5
6
7
8

-}

{-

Iustin Pop's avatar
Iustin Pop committed
9
Copyright (C) 2009, 2010, 2011, 2012 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

28
module Ganeti.HTools.QC
Iustin Pop's avatar
Iustin Pop committed
29
30
31
32
33
34
  ( testUtils
  , testPeerMap
  , testContainer
  , testInstance
  , testNode
  , testText
35
  , testSimu
Iustin Pop's avatar
Iustin Pop committed
36
37
38
39
40
  , testOpCodes
  , testJobs
  , testCluster
  , testLoader
  , testTypes
41
  , testCLI
Iustin Pop's avatar
Iustin Pop committed
42
  ) where
43
44

import Test.QuickCheck
45
import Text.Printf (printf)
Iustin Pop's avatar
Iustin Pop committed
46
import Data.List (findIndex, intercalate, nub, isPrefixOf)
47
import qualified Data.Set as Set
48
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
49
50
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
51
import qualified Data.Map
52
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
53
import qualified Ganeti.OpCodes as OpCodes
54
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
55
import qualified Ganeti.Luxi
56
57
58
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
59
import qualified Ganeti.HTools.ExtLoader
60
61
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
62
import qualified Ganeti.HTools.JSON as JSON
63
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
64
import qualified Ganeti.HTools.Luxi
65
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
66
import qualified Ganeti.HTools.Group as Group
67
import qualified Ganeti.HTools.PeerMap as PeerMap
68
import qualified Ganeti.HTools.Rapi
69
import qualified Ganeti.HTools.Simu as Simu
70
71
72
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
73
import qualified Ganeti.HTools.Version
74
import qualified Ganeti.Constants as C
75

76
77
78
79
80
import qualified Ganeti.HTools.Program.Hail
import qualified Ganeti.HTools.Program.Hbal
import qualified Ganeti.HTools.Program.Hscan
import qualified Ganeti.HTools.Program.Hspace

81
import Ganeti.HTools.QCHelper (testSuite)
Iustin Pop's avatar
Iustin Pop committed
82

83
84
-- * Constants

85
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
86
87
88
maxMem :: Int
maxMem = 1024 * 1024

89
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
90
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
91
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
92

93
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
94
95
96
maxCpu :: Int
maxCpu = 1024

97
98
99
100
-- | All disk templates (used later)
allDiskTemplates :: [Types.DiskTemplate]
allDiskTemplates = [minBound..maxBound]

101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
-- | Null iPolicy, and by null we mean very liberal.
nullIPolicy = Types.IPolicy
  { Types.iPolicyMinSpec = Types.ISpec { Types.iSpecMemorySize = 0
                                       , Types.iSpecCpuCount   = 0
                                       , Types.iSpecDiskSize   = 0
                                       , Types.iSpecDiskCount  = 0
                                       , Types.iSpecNicCount   = 0
                                       }
  , Types.iPolicyMaxSpec = Types.ISpec { Types.iSpecMemorySize = maxBound
                                       , Types.iSpecCpuCount   = maxBound
                                       , Types.iSpecDiskSize   = maxBound
                                       , Types.iSpecDiskCount  = C.maxDisks
                                       , Types.iSpecNicCount   = C.maxNics
                                       }
  , Types.iPolicyStdSpec = Types.ISpec { Types.iSpecMemorySize = Types.unitMem
                                       , Types.iSpecCpuCount   = Types.unitCpu
                                       , Types.iSpecDiskSize   = Types.unitDsk
                                       , Types.iSpecDiskCount  = 1
                                       , Types.iSpecNicCount   = 1
                                       }
  , Types.iPolicyDiskTemplates = [Types.DTDrbd8, Types.DTPlain]
  }


Iustin Pop's avatar
Iustin Pop committed
125
126
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
Iustin Pop's avatar
Iustin Pop committed
127
             Group.create "default" Types.defaultGroupID Types.AllocPreferred
128
                  nullIPolicy
Iustin Pop's avatar
Iustin Pop committed
129
130

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
131
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
132
133
134
135

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

136
137
-- * Helper functions

138
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
139
140
141
142
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

Iustin Pop's avatar
Iustin Pop committed
143
144
145
146
147
148
149
-- | Checks for equality with proper annotation.
(==?) :: (Show a, Eq a) => a -> a -> Property
(==?) x y = printTestCase
            ("Expected equality, but '" ++
             show x ++ "' /= '" ++ show y ++ "'") (x == y)
infix 3 ==?

Iustin Pop's avatar
Iustin Pop committed
150
151
152
153
-- | Show a message and fail the test.
failTest :: String -> Property
failTest msg = printTestCase msg False

154
-- | Update an instance to be smaller than a node.
155
setInstanceSmallerThanNode node inst =
Iustin Pop's avatar
Iustin Pop committed
156
157
158
159
  inst { Instance.mem = Node.availMem node `div` 2
       , Instance.dsk = Node.availDisk node `div` 2
       , Instance.vcpus = Node.availCpu node `div` 2
       }
160

161
-- | Create an instance given its spec.
162
createInstance mem dsk vcpus =
Iustin Pop's avatar
Iustin Pop committed
163
164
  Instance.create "inst-unnamed" mem dsk vcpus Types.Running [] True (-1) (-1)
    Types.DTDrbd8
165

166
-- | Create a small cluster by repeating a node spec.
167
168
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
169
170
171
172
173
174
175
  let origname = Node.name node
      origalias = Node.alias node
      nodes = map (\idx -> node { Node.name = origname ++ "-" ++ show idx
                                , Node.alias = origalias ++ "-" ++ show idx })
              [1..count]
      fn = flip Node.buildPeers Container.empty
      namelst = map (\n -> (Node.name n, fn n)) nodes
Iustin Pop's avatar
Iustin Pop committed
176
177
      (_, nlst) = Loader.assignIndices namelst
  in nlst
178

Iustin Pop's avatar
Iustin Pop committed
179
180
181
182
183
184
185
-- | Make a small cluster, both nodes and instances.
makeSmallEmptyCluster :: Node.Node -> Int -> Instance.Instance
                      -> (Node.List, Instance.List, Instance.Instance)
makeSmallEmptyCluster node count inst =
  (makeSmallCluster node count, Container.empty,
   setInstanceSmallerThanNode node inst)

186
-- | Checks if a node is "big" enough.
187
188
isNodeBig :: Int -> Node.Node -> Bool
isNodeBig size node = Node.availDisk node > size * Types.unitDsk
189
190
191
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

192
193
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
194

195
-- | Assigns a new fresh instance to a cluster; this is not
196
-- allocation, so no resource checks are done.
197
198
199
200
201
202
203
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
Iustin Pop's avatar
Iustin Pop committed
204
205
                  then 0
                  else fst (Container.findMax il) + 1
206
207
208
209
210
211
212
213
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

214
215
216
217
218
219
220
-- | Generates a list of a given size with non-duplicate elements.
genUniquesList :: (Eq a, Arbitrary a) => Int -> Gen [a]
genUniquesList cnt =
  foldM (\lst _ -> do
           newelem <- arbitrary `suchThat` (`notElem` lst)
           return (newelem:lst)) [] [1..cnt]

221
222
-- * Arbitrary instances

223
-- | Defines a DNS name.
224
newtype DNSChar = DNSChar { dnsGetChar::Char }
225

226
instance Arbitrary DNSChar where
Iustin Pop's avatar
Iustin Pop committed
227
228
229
  arbitrary = do
    x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
    return (DNSChar x)
230

231
-- | Generates a single name component.
232
233
234
235
236
237
getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)

238
-- | Generates an entire FQDN.
239
240
241
getFQDN :: Gen String
getFQDN = do
  ncomps <- choose (1, 4)
242
243
  names <- mapM (const getName) [1..ncomps::Int]
  return $ intercalate "." names
244

245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
-- | Defines a tag type.
newtype TagChar = TagChar { tagGetChar :: Char }

-- | All valid tag chars. This doesn't need to match _exactly_
-- Ganeti's own tag regex, just enough for it to be close.
tagChar :: [Char]
tagChar = ['a'..'z'] ++ ['A'..'Z'] ++ ['0'..'9'] ++ ".+*/:@-"

instance Arbitrary TagChar where
  arbitrary = do
    c <- elements tagChar
    return (TagChar c)

-- | Generates a tag
genTag :: Gen [TagChar]
genTag = do
  -- the correct value would be C.maxTagLen, but that's way too
  -- verbose in unittests, and at the moment I don't see any possible
  -- bugs with longer tags and the way we use tags in htools
  n <- choose (1, 10)
  vector n

-- | Generates a list of tags (correctly upper bounded).
genTags :: Gen [String]
genTags = do
  -- the correct value would be C.maxTagsPerObj, but per the comment
  -- in genTag, we don't use tags enough in htools to warrant testing
  -- such big values
  n <- choose (0, 10::Int)
  tags <- mapM (const genTag) [1..n]
  return $ map (map tagGetChar) tags

277
instance Arbitrary Types.InstanceStatus where
278
    arbitrary = elements [minBound..maxBound]
279

280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
-- | Generates a random instance with maximum disk/mem/cpu values.
genInstanceSmallerThan :: Int -> Int -> Int -> Gen Instance.Instance
genInstanceSmallerThan lim_mem lim_dsk lim_cpu = do
  name <- getFQDN
  mem <- choose (0, lim_mem)
  dsk <- choose (0, lim_dsk)
  run_st <- arbitrary
  pn <- arbitrary
  sn <- arbitrary
  vcpus <- choose (0, lim_cpu)
  return $ Instance.create name mem dsk vcpus run_st [] True pn sn
         Types.DTDrbd8

-- | Generates an instance smaller than a node.
genInstanceSmallerThanNode :: Node.Node -> Gen Instance.Instance
genInstanceSmallerThanNode node =
  genInstanceSmallerThan (Node.availMem node `div` 2)
                         (Node.availDisk node `div` 2)
                         (Node.availCpu node `div` 2)

300
301
-- let's generate a random instance
instance Arbitrary Instance.Instance where
302
  arbitrary = genInstanceSmallerThan maxMem maxDsk maxCpu
303

304
305
306
307
308
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
309
310
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
Iustin Pop's avatar
Iustin Pop committed
311
312
313
314
315
        case min_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (0, 0, 0)
316
      (top_mem, top_dsk, top_cpu)  =
Iustin Pop's avatar
Iustin Pop committed
317
318
319
320
321
        case max_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (maxMem, maxDsk, maxCpu)
322
323
324
325
326
327
328
329
330
331
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
Iustin Pop's avatar
Iustin Pop committed
332
333
      n' = Node.setPolicy nullIPolicy n
  return $ Node.buildPeers n' Container.empty
334

335
336
337
338
339
340
341
342
343
-- | Helper function to generate a sane node.
genOnlineNode :: Gen Node.Node
genOnlineNode = do
  arbitrary `suchThat` (\n -> not (Node.offline n) &&
                              not (Node.failN1 n) &&
                              Node.availDisk n > 0 &&
                              Node.availMem n > 0 &&
                              Node.availCpu n > 0)

344
345
-- and a random node
instance Arbitrary Node.Node where
Iustin Pop's avatar
Iustin Pop committed
346
  arbitrary = genNode Nothing Nothing
347

Iustin Pop's avatar
Iustin Pop committed
348
349
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
350
  arbitrary = elements [minBound..maxBound]
Iustin Pop's avatar
Iustin Pop committed
351
352
353
354
355
356
357
358

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
Iustin Pop's avatar
Iustin Pop committed
359
360
361
362
363
364
365
366
367
368
369
370
371
    case op_id of
      "OP_TEST_DELAY" ->
        liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
      "OP_INSTANCE_REPLACE_DISKS" ->
        liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
          arbitrary arbitrary arbitrary
      "OP_INSTANCE_FAILOVER" ->
        liftM3 OpCodes.OpInstanceFailover arbitrary arbitrary
          arbitrary
      "OP_INSTANCE_MIGRATE" ->
        liftM5 OpCodes.OpInstanceMigrate arbitrary arbitrary
          arbitrary arbitrary arbitrary
      _ -> fail "Wrong opcode"
Iustin Pop's avatar
Iustin Pop committed
372

373
374
375
376
377
378
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

379
380
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
Iustin Pop's avatar
Iustin Pop committed
381
382
383
  arbitrary = do
    v <- choose (0, 1)
    return $ SmallRatio v
384

385
386
387
388
389
390
instance Arbitrary Types.AllocPolicy where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Types.DiskTemplate where
  arbitrary = elements [minBound..maxBound]

391
instance Arbitrary Types.FailMode where
Iustin Pop's avatar
Iustin Pop committed
392
  arbitrary = elements [minBound..maxBound]
393

394
395
396
instance Arbitrary Types.EvacMode where
  arbitrary = elements [minBound..maxBound]

397
instance Arbitrary a => Arbitrary (Types.OpResult a) where
Iustin Pop's avatar
Iustin Pop committed
398
  arbitrary = arbitrary >>= \c ->
Iustin Pop's avatar
Iustin Pop committed
399
400
401
              if c
                then liftM Types.OpGood arbitrary
                else liftM Types.OpFail arbitrary
402

403
404
instance Arbitrary Types.ISpec where
  arbitrary = do
405
    mem_s <- arbitrary::Gen (NonNegative Int)
406
407
    dsk_c <- arbitrary::Gen (NonNegative Int)
    dsk_s <- arbitrary::Gen (NonNegative Int)
408
409
410
411
    cpu_c <- arbitrary::Gen (NonNegative Int)
    nic_c <- arbitrary::Gen (NonNegative Int)
    return Types.ISpec { Types.iSpecMemorySize = fromIntegral mem_s
                       , Types.iSpecCpuCount   = fromIntegral cpu_c
412
413
                       , Types.iSpecDiskSize   = fromIntegral dsk_s
                       , Types.iSpecDiskCount  = fromIntegral dsk_c
414
                       , Types.iSpecNicCount   = fromIntegral nic_c
415
416
                       }

417
418
419
420
421
422
423
424
425
426
427
428
429
430
-- | Generates an ispec bigger than the given one.
genBiggerISpec :: Types.ISpec -> Gen Types.ISpec
genBiggerISpec imin = do
  mem_s <- choose (Types.iSpecMemorySize imin, maxBound)
  dsk_c <- choose (Types.iSpecDiskCount imin, maxBound)
  dsk_s <- choose (Types.iSpecDiskSize imin, maxBound)
  cpu_c <- choose (Types.iSpecCpuCount imin, maxBound)
  nic_c <- choose (Types.iSpecNicCount imin, maxBound)
  return Types.ISpec { Types.iSpecMemorySize = fromIntegral mem_s
                     , Types.iSpecCpuCount   = fromIntegral cpu_c
                     , Types.iSpecDiskSize   = fromIntegral dsk_s
                     , Types.iSpecDiskCount  = fromIntegral dsk_c
                     , Types.iSpecNicCount   = fromIntegral nic_c
                     }
431
432
433
434

instance Arbitrary Types.IPolicy where
  arbitrary = do
    imin <- arbitrary
435
436
437
438
    istd <- genBiggerISpec imin
    imax <- genBiggerISpec istd
    num_tmpl <- choose (0, length allDiskTemplates)
    dts  <- genUniquesList num_tmpl
439
440
441
442
443
444
    return Types.IPolicy { Types.iPolicyMinSpec = imin
                         , Types.iPolicyStdSpec = istd
                         , Types.iPolicyMaxSpec = imax
                         , Types.iPolicyDiskTemplates = dts
                         }

445
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
446

447
448
449
450
-- ** Utils tests

-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
451
prop_Utils_commaJoinSplit =
Iustin Pop's avatar
Iustin Pop committed
452
  forAll (arbitrary `suchThat`
Iustin Pop's avatar
Iustin Pop committed
453
          (\l -> l /= [""] && all (notElem ',') l )) $ \lst ->
Iustin Pop's avatar
Iustin Pop committed
454
  Utils.sepSplit ',' (Utils.commaJoin lst) ==? lst
Iustin Pop's avatar
Iustin Pop committed
455

456
-- | Split and join should always be idempotent.
Iustin Pop's avatar
Iustin Pop committed
457
prop_Utils_commaSplitJoin s =
Iustin Pop's avatar
Iustin Pop committed
458
  Utils.commaJoin (Utils.sepSplit ',' s) ==? s
459

460
-- | fromObjWithDefault, we test using the Maybe monad and an integer
461
-- value.
462
prop_Utils_fromObjWithDefault def_value random_key =
Iustin Pop's avatar
Iustin Pop committed
463
  -- a missing key will be returned with the default
464
  JSON.fromObjWithDefault [] random_key def_value == Just def_value &&
Iustin Pop's avatar
Iustin Pop committed
465
  -- a found key will be returned as is, not with default
466
  JSON.fromObjWithDefault [(random_key, J.showJSON def_value)]
Iustin Pop's avatar
Iustin Pop committed
467
468
       random_key (def_value+1) == Just def_value
    where _types = def_value :: Integer
469

470
-- | Test that functional if' behaves like the syntactic sugar if.
Iustin Pop's avatar
Iustin Pop committed
471
472
prop_Utils_if'if :: Bool -> Int -> Int -> Gen Prop
prop_Utils_if'if cnd a b =
Iustin Pop's avatar
Iustin Pop committed
473
  Utils.if' cnd a b ==? if cnd then a else b
474

Guido Trotter's avatar
Guido Trotter committed
475
-- | Test basic select functionality
Iustin Pop's avatar
Iustin Pop committed
476
477
478
479
prop_Utils_select :: Int      -- ^ Default result
                  -> [Int]    -- ^ List of False values
                  -> [Int]    -- ^ List of True values
                  -> Gen Prop -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
480
prop_Utils_select def lst1 lst2 =
Iustin Pop's avatar
Iustin Pop committed
481
  Utils.select def (flist ++ tlist) ==? expectedresult
Iustin Pop's avatar
Iustin Pop committed
482
483
484
    where expectedresult = Utils.if' (null lst2) def (head lst2)
          flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
485
486

-- | Test basic select functionality with undefined default
Iustin Pop's avatar
Iustin Pop committed
487
prop_Utils_select_undefd :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
488
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
489
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
490
prop_Utils_select_undefd lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
491
  Utils.select undefined (flist ++ tlist) ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
492
493
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
494
495

-- | Test basic select functionality with undefined list values
Iustin Pop's avatar
Iustin Pop committed
496
prop_Utils_select_undefv :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
497
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
498
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
499
prop_Utils_select_undefv lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
500
  Utils.select undefined cndlist ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
501
502
503
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
          cndlist = flist ++ tlist ++ [undefined]
504

Iustin Pop's avatar
Iustin Pop committed
505
prop_Utils_parseUnit (NonNegative n) =
Iustin Pop's avatar
Iustin Pop committed
506
507
508
509
510
511
512
513
514
515
  Utils.parseUnit (show n) == Types.Ok n &&
  Utils.parseUnit (show n ++ "m") == Types.Ok n &&
  (case Utils.parseUnit (show n ++ "M") of
     Types.Ok m -> if n > 0
                     then m < n  -- for positive values, X MB is < than X MiB
                     else m == 0 -- but for 0, 0 MB == 0 MiB
     Types.Bad _ -> False) &&
  Utils.parseUnit (show n ++ "g") == Types.Ok (n*1024) &&
  Utils.parseUnit (show n ++ "t") == Types.Ok (n*1048576) &&
  Types.isBad (Utils.parseUnit (show n ++ "x")::Types.Result Int)
Iustin Pop's avatar
Iustin Pop committed
516
    where _types = n::Int
Iustin Pop's avatar
Iustin Pop committed
517

518
-- | Test list for the Utils module.
519
testSuite "Utils"
Iustin Pop's avatar
Iustin Pop committed
520
521
522
523
524
525
526
527
528
            [ 'prop_Utils_commaJoinSplit
            , 'prop_Utils_commaSplitJoin
            , 'prop_Utils_fromObjWithDefault
            , 'prop_Utils_if'if
            , 'prop_Utils_select
            , 'prop_Utils_select_undefd
            , 'prop_Utils_select_undefv
            , 'prop_Utils_parseUnit
            ]
529

530
531
532
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
533
prop_PeerMap_addIdempotent pmap key em =
Iustin Pop's avatar
Iustin Pop committed
534
  fn puniq ==? fn (fn puniq)
535
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
536
537
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
538
          puniq = PeerMap.accumArray const pmap
539

540
-- | Make sure remove is idempotent.
541
prop_PeerMap_removeIdempotent pmap key =
Iustin Pop's avatar
Iustin Pop committed
542
  fn puniq ==? fn (fn puniq)
543
544
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
545
546
          puniq = PeerMap.accumArray const pmap

547
-- | Make sure a missing item returns 0.
548
prop_PeerMap_findMissing pmap key =
Iustin Pop's avatar
Iustin Pop committed
549
  PeerMap.find key (PeerMap.remove key puniq) ==? 0
550
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
551
552
          puniq = PeerMap.accumArray const pmap

553
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
554
prop_PeerMap_addFind pmap key em =
Iustin Pop's avatar
Iustin Pop committed
555
  PeerMap.find key (PeerMap.add key em puniq) ==? em
556
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
557
                    key::PeerMap.Key, em::PeerMap.Elem)
558
          puniq = PeerMap.accumArray const pmap
559

560
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
561
prop_PeerMap_maxElem pmap =
Iustin Pop's avatar
Iustin Pop committed
562
  PeerMap.maxElem puniq ==? if null puniq then 0
Iustin Pop's avatar
Iustin Pop committed
563
                              else (maximum . snd . unzip) puniq
564
    where _types = pmap::PeerMap.PeerMap
565
566
          puniq = PeerMap.accumArray const pmap

567
-- | List of tests for the PeerMap module.
568
testSuite "PeerMap"
Iustin Pop's avatar
Iustin Pop committed
569
570
571
572
573
574
            [ 'prop_PeerMap_addIdempotent
            , 'prop_PeerMap_removeIdempotent
            , 'prop_PeerMap_maxElem
            , 'prop_PeerMap_addFind
            , 'prop_PeerMap_findMissing
            ]
575

576
-- ** Container tests
577

Iustin Pop's avatar
Iustin Pop committed
578
579
-- we silence the following due to hlint bug fixed in later versions
{-# ANN prop_Container_addTwo "HLint: ignore Avoid lambda" #-}
580
prop_Container_addTwo cdata i1 i2 =
Iustin Pop's avatar
Iustin Pop committed
581
582
  fn i1 i2 cont == fn i2 i1 cont &&
  fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
583
584
585
586
587
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

588
589
590
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
Iustin Pop's avatar
Iustin Pop committed
591
  in Container.nameOf nl (Node.idx fnode) ==? Node.name fnode
592

593
-- | We test that in a cluster, given a random node, we can find it by
594
-- its name and alias, as long as all names and aliases are unique,
595
-- and that we fail to find a non-existing name.
596
prop_Container_findByName node =
597
598
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
599
600
601
602
  forAll (genUniquesList (cnt * 2)) $ \ allnames ->
  forAll (arbitrary `suchThat` (`notElem` allnames)) $ \ othername ->
  let names = zip (take cnt allnames) (drop cnt allnames)
      nl = makeSmallCluster node cnt
603
604
605
606
607
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
608
      nl' = Container.fromList nodes'
609
610
611
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
Iustin Pop's avatar
Iustin Pop committed
612
     isNothing (Container.findByName nl' othername)
613

614
testSuite "Container"
Iustin Pop's avatar
Iustin Pop committed
615
616
617
618
            [ 'prop_Container_addTwo
            , 'prop_Container_nameOf
            , 'prop_Container_findByName
            ]
619

620
621
-- ** Instance tests

622
623
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
624
prop_Instance_creat inst =
Iustin Pop's avatar
Iustin Pop committed
625
  Instance.name inst ==? Instance.alias inst
Iustin Pop's avatar
Iustin Pop committed
626

627
prop_Instance_setIdx inst idx =
Iustin Pop's avatar
Iustin Pop committed
628
  Instance.idx (Instance.setIdx inst idx) ==? idx
629
630
631
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
632
633
  Instance.name newinst == name &&
  Instance.alias newinst == name
Iustin Pop's avatar
Iustin Pop committed
634
635
636
637
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
Iustin Pop's avatar
Iustin Pop committed
638
639
  Instance.name newinst == Instance.name inst &&
  Instance.alias newinst == name
640
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
641
          newinst = Instance.setAlias inst name
642
643

prop_Instance_setPri inst pdx =
Iustin Pop's avatar
Iustin Pop committed
644
  Instance.pNode (Instance.setPri inst pdx) ==? pdx
645
646
647
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
Iustin Pop's avatar
Iustin Pop committed
648
  Instance.sNode (Instance.setSec inst sdx) ==? sdx
649
650
651
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
Iustin Pop's avatar
Iustin Pop committed
652
  Instance.pNode si == pdx && Instance.sNode si == sdx
653
654
655
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
656
prop_Instance_shrinkMG inst =
Iustin Pop's avatar
Iustin Pop committed
657
658
659
660
  Instance.mem inst >= 2 * Types.unitMem ==>
    case Instance.shrinkByType inst Types.FailMem of
      Types.Ok inst' -> Instance.mem inst' == Instance.mem inst - Types.unitMem
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
661
662

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
663
  forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
Iustin Pop's avatar
Iustin Pop committed
664
665
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
666
667

prop_Instance_shrinkCG inst =
Iustin Pop's avatar
Iustin Pop committed
668
669
670
671
672
  Instance.vcpus inst >= 2 * Types.unitCpu ==>
    case Instance.shrinkByType inst Types.FailCPU of
      Types.Ok inst' ->
        Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
673
674

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
675
  forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
Iustin Pop's avatar
Iustin Pop committed
676
677
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
678
679

prop_Instance_shrinkDG inst =
Iustin Pop's avatar
Iustin Pop committed
680
681
682
683
684
  Instance.dsk inst >= 2 * Types.unitDsk ==>
    case Instance.shrinkByType inst Types.FailDisk of
      Types.Ok inst' ->
        Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
685
686

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
687
  forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
Iustin Pop's avatar
Iustin Pop committed
688
689
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
690
691

prop_Instance_setMovable inst m =
Iustin Pop's avatar
Iustin Pop committed
692
  Instance.movable inst' ==? m
693
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
694

695
testSuite "Instance"
Iustin Pop's avatar
Iustin Pop committed
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
            [ 'prop_Instance_creat
            , 'prop_Instance_setIdx
            , 'prop_Instance_setName
            , 'prop_Instance_setAlias
            , 'prop_Instance_setPri
            , 'prop_Instance_setSec
            , 'prop_Instance_setBoth
            , 'prop_Instance_shrinkMG
            , 'prop_Instance_shrinkMF
            , 'prop_Instance_shrinkCG
            , 'prop_Instance_shrinkCF
            , 'prop_Instance_shrinkDG
            , 'prop_Instance_shrinkDF
            , 'prop_Instance_setMovable
            ]
Iustin Pop's avatar
Iustin Pop committed
711

712
713
714
-- ** Backends

-- *** Text backend tests
715

Iustin Pop's avatar
Iustin Pop committed
716
717
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
718
719
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
720
                        (NonNegative pdx) (NonNegative sdx) autobal dt =
Iustin Pop's avatar
Iustin Pop committed
721
722
723
724
725
726
  pnode /= snode && pdx /= sdx ==>
  let vcpus_s = show vcpus
      dsk_s = show dsk
      mem_s = show mem
      status_s = Types.instanceStatusToRaw status
      ndx = if null snode
Iustin Pop's avatar
Iustin Pop committed
727
              then [(pnode, pdx)]
728
              else [(pnode, pdx), (snode, sdx)]
Iustin Pop's avatar
Iustin Pop committed
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
      nl = Data.Map.fromList ndx
      tags = ""
      sbal = if autobal then "Y" else "N"
      sdt = Types.diskTemplateToRaw dt
      inst = Text.loadInst nl
             [name, mem_s, dsk_s, vcpus_s, status_s,
              sbal, pnode, snode, sdt, tags]
      fail1 = Text.loadInst nl
              [name, mem_s, dsk_s, vcpus_s, status_s,
               sbal, pnode, pnode, tags]
      _types = ( name::String, mem::Int, dsk::Int
               , vcpus::Int, status::Types.InstanceStatus
               , snode::String
               , autobal::Bool)
  in case inst of
Iustin Pop's avatar
Iustin Pop committed
744
       Types.Bad msg -> failTest $ "Failed to load instance: " ++ msg
Iustin Pop's avatar
Iustin Pop committed
745
746
747
748
749
750
751
752
753
754
755
       Types.Ok (_, i) -> printTestCase "Mismatch in some field while\
                                        \ loading the instance" $
               Instance.name i == name &&
               Instance.vcpus i == vcpus &&
               Instance.mem i == mem &&
               Instance.pNode i == pdx &&
               Instance.sNode i == (if null snode
                                      then Node.noSecondary
                                      else sdx) &&
               Instance.autoBalance i == autobal &&
               Types.isBad fail1
Iustin Pop's avatar
Iustin Pop committed
756
757

prop_Text_Load_InstanceFail ktn fields =
Iustin Pop's avatar
Iustin Pop committed
758
  length fields /= 10 ==>
Iustin Pop's avatar
Iustin Pop committed
759
    case Text.loadInst nl fields of
Iustin Pop's avatar
Iustin Pop committed
760
      Types.Ok _ -> failTest "Managed to load instance from invalid data"
761
762
      Types.Bad msg -> printTestCase ("Unrecognised error message: " ++ msg) $
                       "Invalid/incomplete instance data: '" `isPrefixOf` msg
763
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
764
765

prop_Text_Load_Node name tm nm fm td fd tc fo =
Iustin Pop's avatar
Iustin Pop committed
766
767
768
769
770
771
772
773
774
775
  let conv v = if v < 0
                 then "?"
                 else show v
      tm_s = conv tm
      nm_s = conv nm
      fm_s = conv fm
      td_s = conv td
      fd_s = conv fd
      tc_s = conv tc
      fo_s = if fo
Iustin Pop's avatar
Iustin Pop committed
776
777
               then "Y"
               else "N"
Iustin Pop's avatar
Iustin Pop committed
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
      any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
      gid = Group.uuid defGroup
  in case Text.loadNode defGroupAssoc
       [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
       Nothing -> False
       Just (name', node) ->
         if fo || any_broken
           then Node.offline node
           else Node.name node == name' && name' == name &&
                Node.alias node == name &&
                Node.tMem node == fromIntegral tm &&
                Node.nMem node == nm &&
                Node.fMem node == fm &&
                Node.tDsk node == fromIntegral td &&
                Node.fDsk node == fd &&
                Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
794
795

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
796
  length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
797

798
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
799
800
801
  (Text.loadNode defGroupAssoc.
       Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
  Just (Node.name n, n)
802
    -- override failN1 to what loadNode returns by default
Iustin Pop's avatar
Iustin Pop committed
803
804
    where n = node { Node.failN1 = True, Node.offline = False
                   , Node.iPolicy = Types.defIPolicy }
805

806
807
808
prop_Text_ISpecIdempotent ispec =
  case Text.loadISpec "dummy" . Utils.sepSplit ',' .
       Text.serializeISpec $ ispec of
Iustin Pop's avatar
Iustin Pop committed
809
    Types.Bad msg -> failTest $ "Failed to load ispec: " ++ msg
810
811
812
813
814
    Types.Ok ispec' -> ispec ==? ispec'

prop_Text_IPolicyIdempotent ipol =
  case Text.loadIPolicy . Utils.sepSplit '|' $
       Text.serializeIPolicy owner ipol of
Iustin Pop's avatar
Iustin Pop committed
815
    Types.Bad msg -> failTest $ "Failed to load ispec: " ++ msg
816
817
818
    Types.Ok res -> (owner, ipol) ==? res
  where owner = "dummy"

819
820
821
822
823
824
825
826
827
828
829
830
831
-- | This property, while being in the text tests, does more than just
-- test end-to-end the serialisation and loading back workflow; it
-- also tests the Loader.mergeData and the actuall
-- Cluster.iterateAlloc (for well-behaving w.r.t. instance
-- allocations, not for the business logic). As such, it's a quite
-- complex and slow test, and that's the reason we restrict it to
-- small cluster sizes.
prop_Text_CreateSerialise =
  forAll genTags $ \ctags ->
  forAll (choose (1, 2)) $ \reqnodes ->
  forAll (choose (1, 20)) $ \maxiter ->
  forAll (choose (2, 10)) $ \count ->
  forAll genOnlineNode $ \node ->
832
833
  forAll (genInstanceSmallerThanNode node) $ \inst ->
  let inst' = Instance.setMovable inst (reqnodes == 2)
834
835
836
837
      nl = makeSmallCluster node count
  in case Cluster.genAllocNodes defGroupList nl reqnodes True >>= \allocn ->
     Cluster.iterateAlloc nl Container.empty (Just maxiter) inst' allocn [] []
     of
Iustin Pop's avatar
Iustin Pop committed
838
       Types.Bad msg -> failTest $ "Failed to allocate: " ++ msg
839
840
841
842
843
844
845
       Types.Ok (_, _, _, [], _) -> printTestCase
                                    "Failed to allocate: no allocations" False
       Types.Ok (_, nl', il', _, _) ->
         let cdata = Loader.ClusterData defGroupList nl' il' ctags
                     Types.defIPolicy
             saved = Text.serializeCluster cdata
         in case Text.parseData saved >>= Loader.mergeData [] [] [] [] of
Iustin Pop's avatar
Iustin Pop committed
846
              Types.Bad msg -> failTest $ "Failed to load/merge: " ++ msg
847
848
849
850
              Types.Ok (Loader.ClusterData gl2 nl2 il2 ctags2 cpol2) ->
                ctags ==? ctags2 .&&.
                Types.defIPolicy ==? cpol2 .&&.
                il' ==? il2 .&&.
851
852
                defGroupList ==? gl2 .&&.
                nl' ==? nl2
853

854
testSuite "Text"
Iustin Pop's avatar
Iustin Pop committed
855
856
857
858
859
            [ 'prop_Text_Load_Instance
            , 'prop_Text_Load_InstanceFail
            , 'prop_Text_Load_Node
            , 'prop_Text_Load_NodeFail
            , 'prop_Text_NodeLSIdempotent
860
861
            , 'prop_Text_ISpecIdempotent
            , 'prop_Text_IPolicyIdempotent
862
            , 'prop_Text_CreateSerialise
Iustin Pop's avatar
Iustin Pop committed
863
            ]
864

865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
-- *** Simu backend

-- | Generates a tuple of specs for simulation.
genSimuSpec :: Gen (String, Int, Int, Int, Int)
genSimuSpec = do
  pol <- elements [C.allocPolicyPreferred,
                   C.allocPolicyLastResort, C.allocPolicyUnallocable,
                  "p", "a", "u"]
 -- should be reasonable (nodes/group), bigger values only complicate
 -- the display of failed tests, and we don't care (in this particular
 -- test) about big node groups
  nodes <- choose (0, 20)
  dsk <- choose (0, maxDsk)
  mem <- choose (0, maxMem)
  cpu <- choose (0, maxCpu)
  return (pol, nodes, dsk, mem, cpu)

-- | Checks that given a set of corrects specs, we can load them
-- successfully, and that at high-level the values look right.
prop_SimuLoad =
  forAll (choose (0, 10)) $ \ngroups ->
  forAll (replicateM ngroups genSimuSpec) $ \specs ->
  let strspecs = map (\(p, n, d, m, c) -> printf "%s,%d,%d,%d,%d"
                                          p n d m c::String) specs
      totnodes = sum $ map (\(_, n, _, _, _) -> n) specs
      mdc_in = concatMap (\(_, n, d, m, c) ->
                            replicate n (fromIntegral m, fromIntegral d,
                                         fromIntegral c,
                                         fromIntegral m, fromIntegral d)) specs
  in case Simu.parseData strspecs of
       Types.Bad msg -> failTest $ "Failed to load specs: " ++ msg
       Types.Ok (Loader.ClusterData gl nl il tags ipol) ->
         let nodes = map snd $ IntMap.toAscList nl
             nidx = map Node.idx nodes
             mdc_out = map (\n -> (Node.tMem n, Node.tDsk n, Node.tCpu n,
                                   Node.fMem n, Node.fDsk n)) nodes
         in
         Container.size gl ==? ngroups .&&.
         Container.size nl ==? totnodes .&&.
         Container.size il ==? 0 .&&.
         length tags ==? 0 .&&.
         ipol ==? Types.defIPolicy .&&.
         nidx ==? [1..totnodes] .&&.
         mdc_in ==? mdc_out .&&.
         map Group.iPolicy (Container.elems gl) ==?
             replicate ngroups Types.defIPolicy

testSuite "Simu"
            [ 'prop_SimuLoad
            ]

916
-- ** Node tests
917

Iustin Pop's avatar
Iustin Pop committed
918
prop_Node_setAlias node name =
Iustin Pop's avatar
Iustin Pop committed
919
920
  Node.name newnode == Node.name node &&
  Node.alias newnode == name
Iustin Pop's avatar
Iustin Pop committed
921
922
923
924
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
Iustin Pop's avatar
Iustin Pop committed
925
  Node.offline newnode ==? status
Iustin Pop's avatar
Iustin Pop committed
926
927
928
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
Iustin Pop's avatar
Iustin Pop committed
929
  Node.xMem newnode ==? xm
Iustin Pop's avatar
Iustin Pop committed
930
931
932
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
Iustin Pop's avatar
Iustin Pop committed
933
  Node.mCpu newnode ==? mc
Iustin Pop's avatar
Iustin Pop committed
934
935
    where newnode = Node.setMcpu node mc

936
937
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
prop_Node_addPriFM node inst =
  Instance.mem inst >= Node.fMem node && not (Node.failN1 node) &&
  not (Instance.instanceOffline inst) ==>
  case Node.addPri node inst'' of
    Types.OpFail Types.FailMem -> True
    _ -> False
  where _types = (node::Node.Node, inst::Instance.Instance)
        inst' = setInstanceSmallerThanNode node inst
        inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst =
  Instance.dsk inst >= Node.fDsk node && not (Node.failN1 node) ==>
    case Node.addPri node inst'' of
      Types.OpFail Types.FailDisk -> True
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
953
954
955
956
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

957
958
959
960
961
962
963
964
prop_Node_addPriFC (Positive extra) =
  forAll genOnlineNode $ \node ->
  forAll (arbitrary `suchThat` Instance.instanceNotOffline) $ \inst ->
  let inst' = setInstanceSmallerThanNode node inst
      inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
  in case Node.addPri node inst'' of
       Types.OpFail Types.FailCPU -> property True
       v -> failTest $ "Expected OpFail FailCPU, but got " ++ show v
965

966
967
-- | Check that an instance add with too high memory or disk will be
-- rejected.
968
prop_Node_addSec node inst pdx =
Iustin Pop's avatar
Iustin Pop committed
969
970
971
972
973
  ((Instance.mem inst >= (Node.fMem node - Node.rMem node) &&
    not (Instance.instanceOffline inst)) ||
   Instance.dsk inst >= Node.fDsk node) &&
  not (Node.failN1 node) ==>
      isFailure (Node.addSec node inst pdx)
974
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
975

976
977
-- | Check that an offline instance with reasonable disk size can always
-- be added.
978
979
prop_Node_addPriOffline =
  forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
980
981
982
983
984
985
  forAll (arbitrary `suchThat`
          (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                   Instance.instanceOffline x)) $ \inst ->
  case Node.addPri node inst of
    Types.OpGood _ -> True
    _ -> False
986

987
prop_Node_addSecOffline pdx =
988
  forAll genOnlineNode $ \node ->
Iustin Pop's avatar
Iustin Pop committed
989
  forAll (arbitrary `suchThat`
990
991
          (\ inst -> Instance.dsk inst  < Node.availDisk node)) $ \inst ->
  case Node.addSec node (inst { Instance.runSt = Types.AdminOffline }) pdx of
Iustin Pop's avatar
Iustin Pop committed
992
993
    Types.OpGood _ -> True
    _ -> False
994

995
-- | Checks for memory reservation changes.
996
prop_Node_rMem inst =
Iustin Pop's avatar
Iustin Pop committed
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
  not (Instance.instanceOffline inst) ==>
  forAll (arbitrary `suchThat` ((> Types.unitMem) . Node.fMem)) $ \node ->
  -- ab = auto_balance, nb = non-auto_balance
  -- we use -1 as the primary node of the instance
  let inst' = inst { Instance.pNode = -1, Instance.autoBalance = True }
      inst_ab = setInstanceSmallerThanNode node inst'
      inst_nb = inst_ab { Instance.autoBalance = False }
      -- now we have the two instances, identical except the
      -- autoBalance attribute
      orig_rmem = Node.rMem node
      inst_idx = Instance.idx inst_ab
      node_add_ab = Node.addSec node inst_ab (-1)
      node_add_nb = Node.addSec node inst_nb (-1)
      node_del_ab = liftM (`Node.removeSec` inst_ab) node_add_ab
      node_del_nb = liftM (`Node.removeSec` inst_nb) node_add_nb
  in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
       (Types.OpGood a_ab, Types.OpGood a_nb,
        Types.OpGood d_ab, Types.OpGood d_nb) ->
         printTestCase "Consistency checks failed" $
           Node.rMem a_ab >  orig_rmem &&
           Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
           Node.rMem a_nb == orig_rmem &&
           Node.rMem d_ab == orig_rmem &&
           Node.rMem d_nb == orig_rmem &&
           -- this is not related to rMem, but as good a place to
           -- test as any
           inst_idx `elem` Node.sList a_ab &&
Iustin Pop's avatar
Iustin Pop committed
1024
           inst_idx `notElem` Node.sList d_ab
Iustin Pop's avatar
Iustin Pop committed
1025
       x -> failTest $ "Failed to add/remove instances: " ++ show x
1026

1027
-- | Check mdsk setting.
Iustin Pop's avatar
Iustin Pop committed
1028
prop_Node_setMdsk node mx =
Iustin Pop's avatar
Iustin Pop committed
1029
1030
1031
1032
1033
1034
  Node.loDsk node' >= 0 &&
  fromIntegral (Node.loDsk node') <= Node.tDsk node &&
  Node.availDisk node' >= 0 &&
  Node.availDisk node' <= Node.fDsk node' &&
  fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
  Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
1035
1036
1037
1038
1039
1040
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
Iustin Pop's avatar
Iustin Pop committed
1041
  Node.delTags (Node.addTags m tags) tags ==? m
1042
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
1043
1044

prop_Node_tagMaps_reject tags =