QC.hs 39.3 KB
Newer Older
1
2
{-# LANGUAGE TemplateHaskell #-}

3
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
4
5
6
7
8

-}

{-

9
Copyright (C) 2009, 2010, 2011 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

28
module Ganeti.HTools.QC
Iustin Pop's avatar
Iustin Pop committed
29
30
31
32
33
34
35
36
37
38
39
40
  ( testUtils
  , testPeerMap
  , testContainer
  , testInstance
  , testNode
  , testText
  , testOpCodes
  , testJobs
  , testCluster
  , testLoader
  , testTypes
  ) where
41
42

import Test.QuickCheck
Iustin Pop's avatar
Iustin Pop committed
43
import Data.List (findIndex, intercalate, nub, isPrefixOf)
44
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
45
46
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
47
import qualified Data.Map
48
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
49
import qualified Ganeti.OpCodes as OpCodes
50
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
51
import qualified Ganeti.Luxi
52
53
54
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
55
import qualified Ganeti.HTools.ExtLoader
56
57
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
58
import qualified Ganeti.HTools.JSON as JSON
59
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
60
import qualified Ganeti.HTools.Luxi
61
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
62
import qualified Ganeti.HTools.Group as Group
63
import qualified Ganeti.HTools.PeerMap as PeerMap
64
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
65
import qualified Ganeti.HTools.Simu
66
67
68
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
69
import qualified Ganeti.HTools.Version
70
import qualified Ganeti.Constants as C
71

72
73
74
75
76
import qualified Ganeti.HTools.Program.Hail
import qualified Ganeti.HTools.Program.Hbal
import qualified Ganeti.HTools.Program.Hscan
import qualified Ganeti.HTools.Program.Hspace

77
import Ganeti.HTools.QCHelper (testSuite)
Iustin Pop's avatar
Iustin Pop committed
78

79
80
-- * Constants

81
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
82
83
84
maxMem :: Int
maxMem = 1024 * 1024

85
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
86
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
87
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
88

89
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
90
91
92
maxCpu :: Int
maxCpu = 1024

Iustin Pop's avatar
Iustin Pop committed
93
94
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
Iustin Pop's avatar
Iustin Pop committed
95
             Group.create "default" Types.defaultGroupID Types.AllocPreferred
Iustin Pop's avatar
Iustin Pop committed
96
97

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
98
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
99
100
101
102

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

103
104
-- * Helper functions

105
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
106
107
108
109
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

Iustin Pop's avatar
Iustin Pop committed
110
111
112
113
114
115
116
-- | Checks for equality with proper annotation.
(==?) :: (Show a, Eq a) => a -> a -> Property
(==?) x y = printTestCase
            ("Expected equality, but '" ++
             show x ++ "' /= '" ++ show y ++ "'") (x == y)
infix 3 ==?

117
-- | Update an instance to be smaller than a node.
118
setInstanceSmallerThanNode node inst =
Iustin Pop's avatar
Iustin Pop committed
119
120
121
122
  inst { Instance.mem = Node.availMem node `div` 2
       , Instance.dsk = Node.availDisk node `div` 2
       , Instance.vcpus = Node.availCpu node `div` 2
       }
123

124
-- | Create an instance given its spec.
125
createInstance mem dsk vcpus =
Iustin Pop's avatar
Iustin Pop committed
126
127
  Instance.create "inst-unnamed" mem dsk vcpus Types.Running [] True (-1) (-1)
    Types.DTDrbd8
128

129
-- | Create a small cluster by repeating a node spec.
130
131
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
Iustin Pop's avatar
Iustin Pop committed
132
133
134
135
  let fn = Node.buildPeers node Container.empty
      namelst = map (\n -> (Node.name n, n)) (replicate count fn)
      (_, nlst) = Loader.assignIndices namelst
  in nlst
136

Iustin Pop's avatar
Iustin Pop committed
137
138
139
140
141
142
143
-- | Make a small cluster, both nodes and instances.
makeSmallEmptyCluster :: Node.Node -> Int -> Instance.Instance
                      -> (Node.List, Instance.List, Instance.Instance)
makeSmallEmptyCluster node count inst =
  (makeSmallCluster node count, Container.empty,
   setInstanceSmallerThanNode node inst)

144
-- | Checks if a node is "big" enough.
145
146
147
148
149
isNodeBig :: Node.Node -> Int -> Bool
isNodeBig node size = Node.availDisk node > size * Types.unitDsk
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

150
151
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
152

153
-- | Assigns a new fresh instance to a cluster; this is not
154
-- allocation, so no resource checks are done.
155
156
157
158
159
160
161
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
Iustin Pop's avatar
Iustin Pop committed
162
163
                  then 0
                  else fst (Container.findMax il) + 1
164
165
166
167
168
169
170
171
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

172
173
-- * Arbitrary instances

174
-- | Defines a DNS name.
175
newtype DNSChar = DNSChar { dnsGetChar::Char }
176

177
instance Arbitrary DNSChar where
Iustin Pop's avatar
Iustin Pop committed
178
179
180
  arbitrary = do
    x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
    return (DNSChar x)
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195

getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)

getFQDN :: Gen String
getFQDN = do
  felem <- getName
  ncomps <- choose (1, 4)
  frest <- vector ncomps::Gen [[DNSChar]]
  let frest' = map (map dnsGetChar) frest
  return (felem ++ "." ++ intercalate "." frest')

196
instance Arbitrary Types.InstanceStatus where
197
    arbitrary = elements [minBound..maxBound]
198

199
200
-- let's generate a random instance
instance Arbitrary Instance.Instance where
Iustin Pop's avatar
Iustin Pop committed
201
202
203
204
205
206
207
208
209
210
  arbitrary = do
    name <- getFQDN
    mem <- choose (0, maxMem)
    dsk <- choose (0, maxDsk)
    run_st <- arbitrary
    pn <- arbitrary
    sn <- arbitrary
    vcpus <- choose (0, maxCpu)
    return $ Instance.create name mem dsk vcpus run_st [] True pn sn
              Types.DTDrbd8
211

212
213
214
215
216
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
217
218
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
Iustin Pop's avatar
Iustin Pop committed
219
220
221
222
223
        case min_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (0, 0, 0)
224
      (top_mem, top_dsk, top_cpu)  =
Iustin Pop's avatar
Iustin Pop committed
225
226
227
228
229
        case max_multiplier of
          Just mm -> (mm * Types.unitMem,
                      mm * Types.unitDsk,
                      mm * Types.unitCpu)
          Nothing -> (maxMem, maxDsk, maxCpu)
230
231
232
233
234
235
236
237
238
239
240
241
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
  return $ Node.buildPeers n Container.empty

242
243
-- and a random node
instance Arbitrary Node.Node where
Iustin Pop's avatar
Iustin Pop committed
244
  arbitrary = genNode Nothing Nothing
245

Iustin Pop's avatar
Iustin Pop committed
246
247
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
248
  arbitrary = elements [minBound..maxBound]
Iustin Pop's avatar
Iustin Pop committed
249
250
251
252
253
254
255
256

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
Iustin Pop's avatar
Iustin Pop committed
257
258
259
260
261
262
263
264
265
266
267
268
269
    case op_id of
      "OP_TEST_DELAY" ->
        liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
      "OP_INSTANCE_REPLACE_DISKS" ->
        liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
          arbitrary arbitrary arbitrary
      "OP_INSTANCE_FAILOVER" ->
        liftM3 OpCodes.OpInstanceFailover arbitrary arbitrary
          arbitrary
      "OP_INSTANCE_MIGRATE" ->
        liftM5 OpCodes.OpInstanceMigrate arbitrary arbitrary
          arbitrary arbitrary arbitrary
      _ -> fail "Wrong opcode"
Iustin Pop's avatar
Iustin Pop committed
270

271
272
273
274
275
276
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

277
278
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
Iustin Pop's avatar
Iustin Pop committed
279
280
281
  arbitrary = do
    v <- choose (0, 1)
    return $ SmallRatio v
282

283
284
285
286
287
288
instance Arbitrary Types.AllocPolicy where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Types.DiskTemplate where
  arbitrary = elements [minBound..maxBound]

289
instance Arbitrary Types.FailMode where
Iustin Pop's avatar
Iustin Pop committed
290
  arbitrary = elements [minBound..maxBound]
291
292

instance Arbitrary a => Arbitrary (Types.OpResult a) where
Iustin Pop's avatar
Iustin Pop committed
293
  arbitrary = arbitrary >>= \c ->
Iustin Pop's avatar
Iustin Pop committed
294
295
296
              if c
                then liftM Types.OpGood arbitrary
                else liftM Types.OpFail arbitrary
297

298
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
299

300
301
302
303
-- ** Utils tests

-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
304
prop_Utils_commaJoinSplit =
Iustin Pop's avatar
Iustin Pop committed
305
  forAll (arbitrary `suchThat`
Iustin Pop's avatar
Iustin Pop committed
306
          (\l -> l /= [""] && all (notElem ',') l )) $ \lst ->
Iustin Pop's avatar
Iustin Pop committed
307
  Utils.sepSplit ',' (Utils.commaJoin lst) ==? lst
Iustin Pop's avatar
Iustin Pop committed
308

309
-- | Split and join should always be idempotent.
Iustin Pop's avatar
Iustin Pop committed
310
prop_Utils_commaSplitJoin s =
Iustin Pop's avatar
Iustin Pop committed
311
  Utils.commaJoin (Utils.sepSplit ',' s) ==? s
312

313
-- | fromObjWithDefault, we test using the Maybe monad and an integer
314
-- value.
315
prop_Utils_fromObjWithDefault def_value random_key =
Iustin Pop's avatar
Iustin Pop committed
316
  -- a missing key will be returned with the default
317
  JSON.fromObjWithDefault [] random_key def_value == Just def_value &&
Iustin Pop's avatar
Iustin Pop committed
318
  -- a found key will be returned as is, not with default
319
  JSON.fromObjWithDefault [(random_key, J.showJSON def_value)]
Iustin Pop's avatar
Iustin Pop committed
320
321
       random_key (def_value+1) == Just def_value
    where _types = def_value :: Integer
322

323
-- | Test that functional if' behaves like the syntactic sugar if.
Iustin Pop's avatar
Iustin Pop committed
324
325
prop_Utils_if'if :: Bool -> Int -> Int -> Gen Prop
prop_Utils_if'if cnd a b =
Iustin Pop's avatar
Iustin Pop committed
326
  Utils.if' cnd a b ==? if cnd then a else b
327

Guido Trotter's avatar
Guido Trotter committed
328
-- | Test basic select functionality
Iustin Pop's avatar
Iustin Pop committed
329
330
331
332
prop_Utils_select :: Int      -- ^ Default result
                  -> [Int]    -- ^ List of False values
                  -> [Int]    -- ^ List of True values
                  -> Gen Prop -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
333
prop_Utils_select def lst1 lst2 =
Iustin Pop's avatar
Iustin Pop committed
334
  Utils.select def (flist ++ tlist) ==? expectedresult
Iustin Pop's avatar
Iustin Pop committed
335
336
337
    where expectedresult = Utils.if' (null lst2) def (head lst2)
          flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
338
339

-- | Test basic select functionality with undefined default
Iustin Pop's avatar
Iustin Pop committed
340
prop_Utils_select_undefd :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
341
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
342
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
343
prop_Utils_select_undefd lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
344
  Utils.select undefined (flist ++ tlist) ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
345
346
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
Guido Trotter's avatar
Guido Trotter committed
347
348

-- | Test basic select functionality with undefined list values
Iustin Pop's avatar
Iustin Pop committed
349
prop_Utils_select_undefv :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
350
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
351
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
352
prop_Utils_select_undefv lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
353
  Utils.select undefined cndlist ==? head lst2
Iustin Pop's avatar
Iustin Pop committed
354
355
356
    where flist = zip (repeat False) lst1
          tlist = zip (repeat True)  lst2
          cndlist = flist ++ tlist ++ [undefined]
357

Iustin Pop's avatar
Iustin Pop committed
358
prop_Utils_parseUnit (NonNegative n) =
Iustin Pop's avatar
Iustin Pop committed
359
360
361
362
363
364
365
366
367
368
  Utils.parseUnit (show n) == Types.Ok n &&
  Utils.parseUnit (show n ++ "m") == Types.Ok n &&
  (case Utils.parseUnit (show n ++ "M") of
     Types.Ok m -> if n > 0
                     then m < n  -- for positive values, X MB is < than X MiB
                     else m == 0 -- but for 0, 0 MB == 0 MiB
     Types.Bad _ -> False) &&
  Utils.parseUnit (show n ++ "g") == Types.Ok (n*1024) &&
  Utils.parseUnit (show n ++ "t") == Types.Ok (n*1048576) &&
  Types.isBad (Utils.parseUnit (show n ++ "x")::Types.Result Int)
Iustin Pop's avatar
Iustin Pop committed
369
    where _types = n::Int
Iustin Pop's avatar
Iustin Pop committed
370

371
-- | Test list for the Utils module.
372
testSuite "Utils"
Iustin Pop's avatar
Iustin Pop committed
373
374
375
376
377
378
379
380
381
            [ 'prop_Utils_commaJoinSplit
            , 'prop_Utils_commaSplitJoin
            , 'prop_Utils_fromObjWithDefault
            , 'prop_Utils_if'if
            , 'prop_Utils_select
            , 'prop_Utils_select_undefd
            , 'prop_Utils_select_undefv
            , 'prop_Utils_parseUnit
            ]
382

383
384
385
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
386
prop_PeerMap_addIdempotent pmap key em =
Iustin Pop's avatar
Iustin Pop committed
387
  fn puniq ==? fn (fn puniq)
388
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
389
390
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
391
          puniq = PeerMap.accumArray const pmap
392

393
-- | Make sure remove is idempotent.
394
prop_PeerMap_removeIdempotent pmap key =
Iustin Pop's avatar
Iustin Pop committed
395
  fn puniq ==? fn (fn puniq)
396
397
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
398
399
          puniq = PeerMap.accumArray const pmap

400
-- | Make sure a missing item returns 0.
401
prop_PeerMap_findMissing pmap key =
Iustin Pop's avatar
Iustin Pop committed
402
  PeerMap.find key (PeerMap.remove key puniq) ==? 0
403
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
404
405
          puniq = PeerMap.accumArray const pmap

406
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
407
prop_PeerMap_addFind pmap key em =
Iustin Pop's avatar
Iustin Pop committed
408
  PeerMap.find key (PeerMap.add key em puniq) ==? em
409
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
410
                    key::PeerMap.Key, em::PeerMap.Elem)
411
          puniq = PeerMap.accumArray const pmap
412

413
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
414
prop_PeerMap_maxElem pmap =
Iustin Pop's avatar
Iustin Pop committed
415
  PeerMap.maxElem puniq ==? if null puniq then 0
Iustin Pop's avatar
Iustin Pop committed
416
                              else (maximum . snd . unzip) puniq
417
    where _types = pmap::PeerMap.PeerMap
418
419
          puniq = PeerMap.accumArray const pmap

420
-- | List of tests for the PeerMap module.
421
testSuite "PeerMap"
Iustin Pop's avatar
Iustin Pop committed
422
423
424
425
426
427
            [ 'prop_PeerMap_addIdempotent
            , 'prop_PeerMap_removeIdempotent
            , 'prop_PeerMap_maxElem
            , 'prop_PeerMap_addFind
            , 'prop_PeerMap_findMissing
            ]
428

429
-- ** Container tests
430

Iustin Pop's avatar
Iustin Pop committed
431
432
-- we silence the following due to hlint bug fixed in later versions
{-# ANN prop_Container_addTwo "HLint: ignore Avoid lambda" #-}
433
prop_Container_addTwo cdata i1 i2 =
Iustin Pop's avatar
Iustin Pop committed
434
435
  fn i1 i2 cont == fn i2 i1 cont &&
  fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
436
437
438
439
440
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

441
442
443
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
Iustin Pop's avatar
Iustin Pop committed
444
  in Container.nameOf nl (Node.idx fnode) ==? Node.name fnode
445

446
-- | We test that in a cluster, given a random node, we can find it by
447
-- its name and alias, as long as all names and aliases are unique,
448
-- and that we fail to find a non-existing name.
449
450
451
452
453
454
prop_Container_findByName node othername =
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
  forAll (vector cnt) $ \ names ->
  (length . nub) (map fst names ++ map snd names) ==
  length names * 2 &&
Iustin Pop's avatar
Iustin Pop committed
455
  othername `notElem` (map fst names ++ map snd names) ==>
456
457
458
459
460
461
  let nl = makeSmallCluster node cnt
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
462
      nl' = Container.fromList nodes'
463
464
465
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
Iustin Pop's avatar
Iustin Pop committed
466
     isNothing (Container.findByName nl' othername)
467

468
testSuite "Container"
Iustin Pop's avatar
Iustin Pop committed
469
470
471
472
            [ 'prop_Container_addTwo
            , 'prop_Container_nameOf
            , 'prop_Container_findByName
            ]
473

474
475
-- ** Instance tests

476
477
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
478
prop_Instance_creat inst =
Iustin Pop's avatar
Iustin Pop committed
479
  Instance.name inst ==? Instance.alias inst
Iustin Pop's avatar
Iustin Pop committed
480

481
prop_Instance_setIdx inst idx =
Iustin Pop's avatar
Iustin Pop committed
482
  Instance.idx (Instance.setIdx inst idx) ==? idx
483
484
485
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
486
487
  Instance.name newinst == name &&
  Instance.alias newinst == name
Iustin Pop's avatar
Iustin Pop committed
488
489
490
491
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
Iustin Pop's avatar
Iustin Pop committed
492
493
  Instance.name newinst == Instance.name inst &&
  Instance.alias newinst == name
494
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
495
          newinst = Instance.setAlias inst name
496
497

prop_Instance_setPri inst pdx =
Iustin Pop's avatar
Iustin Pop committed
498
  Instance.pNode (Instance.setPri inst pdx) ==? pdx
499
500
501
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
Iustin Pop's avatar
Iustin Pop committed
502
  Instance.sNode (Instance.setSec inst sdx) ==? sdx
503
504
505
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
Iustin Pop's avatar
Iustin Pop committed
506
  Instance.pNode si == pdx && Instance.sNode si == sdx
507
508
509
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
510
prop_Instance_shrinkMG inst =
Iustin Pop's avatar
Iustin Pop committed
511
512
513
514
  Instance.mem inst >= 2 * Types.unitMem ==>
    case Instance.shrinkByType inst Types.FailMem of
      Types.Ok inst' -> Instance.mem inst' == Instance.mem inst - Types.unitMem
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
515
516

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
517
  forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
Iustin Pop's avatar
Iustin Pop committed
518
519
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
520
521

prop_Instance_shrinkCG inst =
Iustin Pop's avatar
Iustin Pop committed
522
523
524
525
526
  Instance.vcpus inst >= 2 * Types.unitCpu ==>
    case Instance.shrinkByType inst Types.FailCPU of
      Types.Ok inst' ->
        Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
527
528

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
529
  forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
Iustin Pop's avatar
Iustin Pop committed
530
531
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
532
533

prop_Instance_shrinkDG inst =
Iustin Pop's avatar
Iustin Pop committed
534
535
536
537
538
  Instance.dsk inst >= 2 * Types.unitDsk ==>
    case Instance.shrinkByType inst Types.FailDisk of
      Types.Ok inst' ->
        Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
539
540

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
541
  forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
Iustin Pop's avatar
Iustin Pop committed
542
543
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
544
545

prop_Instance_setMovable inst m =
Iustin Pop's avatar
Iustin Pop committed
546
  Instance.movable inst' ==? m
547
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
548

549
testSuite "Instance"
Iustin Pop's avatar
Iustin Pop committed
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
            [ 'prop_Instance_creat
            , 'prop_Instance_setIdx
            , 'prop_Instance_setName
            , 'prop_Instance_setAlias
            , 'prop_Instance_setPri
            , 'prop_Instance_setSec
            , 'prop_Instance_setBoth
            , 'prop_Instance_shrinkMG
            , 'prop_Instance_shrinkMF
            , 'prop_Instance_shrinkCG
            , 'prop_Instance_shrinkCF
            , 'prop_Instance_shrinkDG
            , 'prop_Instance_shrinkDF
            , 'prop_Instance_setMovable
            ]
Iustin Pop's avatar
Iustin Pop committed
565

566
567
-- ** Text backend tests

Iustin Pop's avatar
Iustin Pop committed
568
569
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
570
571
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
572
                        (NonNegative pdx) (NonNegative sdx) autobal dt =
Iustin Pop's avatar
Iustin Pop committed
573
574
575
576
577
578
  pnode /= snode && pdx /= sdx ==>
  let vcpus_s = show vcpus
      dsk_s = show dsk
      mem_s = show mem
      status_s = Types.instanceStatusToRaw status
      ndx = if null snode
Iustin Pop's avatar
Iustin Pop committed
579
              then [(pnode, pdx)]
580
              else [(pnode, pdx), (snode, sdx)]
Iustin Pop's avatar
Iustin Pop committed
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
      nl = Data.Map.fromList ndx
      tags = ""
      sbal = if autobal then "Y" else "N"
      sdt = Types.diskTemplateToRaw dt
      inst = Text.loadInst nl
             [name, mem_s, dsk_s, vcpus_s, status_s,
              sbal, pnode, snode, sdt, tags]
      fail1 = Text.loadInst nl
              [name, mem_s, dsk_s, vcpus_s, status_s,
               sbal, pnode, pnode, tags]
      _types = ( name::String, mem::Int, dsk::Int
               , vcpus::Int, status::Types.InstanceStatus
               , snode::String
               , autobal::Bool)
  in case inst of
       Types.Bad msg -> printTestCase ("Failed to load instance: " ++ msg)
                        False
       Types.Ok (_, i) -> printTestCase "Mismatch in some field while\
                                        \ loading the instance" $
               Instance.name i == name &&
               Instance.vcpus i == vcpus &&
               Instance.mem i == mem &&
               Instance.pNode i == pdx &&
               Instance.sNode i == (if null snode
                                      then Node.noSecondary
                                      else sdx) &&
               Instance.autoBalance i == autobal &&
               Types.isBad fail1
Iustin Pop's avatar
Iustin Pop committed
609
610

prop_Text_Load_InstanceFail ktn fields =
Iustin Pop's avatar
Iustin Pop committed
611
  length fields /= 10 ==>
Iustin Pop's avatar
Iustin Pop committed
612
    case Text.loadInst nl fields of
613
614
615
616
      Types.Ok _ -> printTestCase "Managed to load instance from invalid\
                                  \ data" False
      Types.Bad msg -> printTestCase ("Unrecognised error message: " ++ msg) $
                       "Invalid/incomplete instance data: '" `isPrefixOf` msg
617
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
618
619

prop_Text_Load_Node name tm nm fm td fd tc fo =
Iustin Pop's avatar
Iustin Pop committed
620
621
622
623
624
625
626
627
628
629
  let conv v = if v < 0
                 then "?"
                 else show v
      tm_s = conv tm
      nm_s = conv nm
      fm_s = conv fm
      td_s = conv td
      fd_s = conv fd
      tc_s = conv tc
      fo_s = if fo
Iustin Pop's avatar
Iustin Pop committed
630
631
               then "Y"
               else "N"
Iustin Pop's avatar
Iustin Pop committed
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
      any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
      gid = Group.uuid defGroup
  in case Text.loadNode defGroupAssoc
       [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
       Nothing -> False
       Just (name', node) ->
         if fo || any_broken
           then Node.offline node
           else Node.name node == name' && name' == name &&
                Node.alias node == name &&
                Node.tMem node == fromIntegral tm &&
                Node.nMem node == nm &&
                Node.fMem node == fm &&
                Node.tDsk node == fromIntegral td &&
                Node.fDsk node == fd &&
                Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
648
649

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
650
  length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
651

652
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
653
654
655
  (Text.loadNode defGroupAssoc.
       Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
  Just (Node.name n, n)
656
657
658
    -- override failN1 to what loadNode returns by default
    where n = node { Node.failN1 = True, Node.offline = False }

659
testSuite "Text"
Iustin Pop's avatar
Iustin Pop committed
660
661
662
663
664
665
            [ 'prop_Text_Load_Instance
            , 'prop_Text_Load_InstanceFail
            , 'prop_Text_Load_Node
            , 'prop_Text_Load_NodeFail
            , 'prop_Text_NodeLSIdempotent
            ]
666

667
-- ** Node tests
668

Iustin Pop's avatar
Iustin Pop committed
669
prop_Node_setAlias node name =
Iustin Pop's avatar
Iustin Pop committed
670
671
  Node.name newnode == Node.name node &&
  Node.alias newnode == name
Iustin Pop's avatar
Iustin Pop committed
672
673
674
675
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
Iustin Pop's avatar
Iustin Pop committed
676
  Node.offline newnode ==? status
Iustin Pop's avatar
Iustin Pop committed
677
678
679
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
Iustin Pop's avatar
Iustin Pop committed
680
  Node.xMem newnode ==? xm
Iustin Pop's avatar
Iustin Pop committed
681
682
683
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
Iustin Pop's avatar
Iustin Pop committed
684
  Node.mCpu newnode ==? mc
Iustin Pop's avatar
Iustin Pop committed
685
686
    where newnode = Node.setMcpu node mc

687
688
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
prop_Node_addPriFM node inst =
  Instance.mem inst >= Node.fMem node && not (Node.failN1 node) &&
  not (Instance.instanceOffline inst) ==>
  case Node.addPri node inst'' of
    Types.OpFail Types.FailMem -> True
    _ -> False
  where _types = (node::Node.Node, inst::Instance.Instance)
        inst' = setInstanceSmallerThanNode node inst
        inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst =
  Instance.dsk inst >= Node.fDsk node && not (Node.failN1 node) ==>
    case Node.addPri node inst'' of
      Types.OpFail Types.FailDisk -> True
      _ -> False
Iustin Pop's avatar
Iustin Pop committed
704
705
706
707
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

Iustin Pop's avatar
Iustin Pop committed
708
prop_Node_addPriFC node inst (Positive extra) =
Iustin Pop's avatar
Iustin Pop committed
709
710
711
712
  not (Node.failN1 node) && not (Instance.instanceOffline inst) ==>
      case Node.addPri node inst'' of
        Types.OpFail Types.FailCPU -> True
        _ -> False
Iustin Pop's avatar
Iustin Pop committed
713
714
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
Iustin Pop's avatar
Iustin Pop committed
715
          inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
716

717
718
-- | Check that an instance add with too high memory or disk will be
-- rejected.
719
prop_Node_addSec node inst pdx =
Iustin Pop's avatar
Iustin Pop committed
720
721
722
723
724
  ((Instance.mem inst >= (Node.fMem node - Node.rMem node) &&
    not (Instance.instanceOffline inst)) ||
   Instance.dsk inst >= Node.fDsk node) &&
  not (Node.failN1 node) ==>
      isFailure (Node.addSec node inst pdx)
725
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
726

727
728
-- | Check that an offline instance with reasonable disk size can always
-- be added.
729
730
prop_Node_addPriOffline =
  forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
731
732
733
734
735
736
  forAll (arbitrary `suchThat`
          (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                   Instance.instanceOffline x)) $ \inst ->
  case Node.addPri node inst of
    Types.OpGood _ -> True
    _ -> False
737

738
739
prop_Node_addSecOffline pdx =
  forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
Iustin Pop's avatar
Iustin Pop committed
740
741
742
743
744
745
  forAll (arbitrary `suchThat`
          (\ x ->  (Instance.dsk x  < Node.fDsk node) &&
                   Instance.instanceOffline x)) $ \inst ->
  case Node.addSec node inst pdx of
    Types.OpGood _ -> True
    _ -> False
746

747
-- | Checks for memory reservation changes.
748
prop_Node_rMem inst =
Iustin Pop's avatar
Iustin Pop committed
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
  not (Instance.instanceOffline inst) ==>
  forAll (arbitrary `suchThat` ((> Types.unitMem) . Node.fMem)) $ \node ->
  -- ab = auto_balance, nb = non-auto_balance
  -- we use -1 as the primary node of the instance
  let inst' = inst { Instance.pNode = -1, Instance.autoBalance = True }
      inst_ab = setInstanceSmallerThanNode node inst'
      inst_nb = inst_ab { Instance.autoBalance = False }
      -- now we have the two instances, identical except the
      -- autoBalance attribute
      orig_rmem = Node.rMem node
      inst_idx = Instance.idx inst_ab
      node_add_ab = Node.addSec node inst_ab (-1)
      node_add_nb = Node.addSec node inst_nb (-1)
      node_del_ab = liftM (`Node.removeSec` inst_ab) node_add_ab
      node_del_nb = liftM (`Node.removeSec` inst_nb) node_add_nb
  in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
       (Types.OpGood a_ab, Types.OpGood a_nb,
        Types.OpGood d_ab, Types.OpGood d_nb) ->
         printTestCase "Consistency checks failed" $
           Node.rMem a_ab >  orig_rmem &&
           Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
           Node.rMem a_nb == orig_rmem &&
           Node.rMem d_ab == orig_rmem &&
           Node.rMem d_nb == orig_rmem &&
           -- this is not related to rMem, but as good a place to
           -- test as any
           inst_idx `elem` Node.sList a_ab &&
Iustin Pop's avatar
Iustin Pop committed
776
           inst_idx `notElem` Node.sList d_ab
Iustin Pop's avatar
Iustin Pop committed
777
       x -> printTestCase ("Failed to add/remove instances: " ++ show x) False
778

779
-- | Check mdsk setting.
Iustin Pop's avatar
Iustin Pop committed
780
prop_Node_setMdsk node mx =
Iustin Pop's avatar
Iustin Pop committed
781
782
783
784
785
786
  Node.loDsk node' >= 0 &&
  fromIntegral (Node.loDsk node') <= Node.tDsk node &&
  Node.availDisk node' >= 0 &&
  Node.availDisk node' <= Node.fDsk node' &&
  fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
  Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
787
788
789
790
791
792
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
Iustin Pop's avatar
Iustin Pop committed
793
  Node.delTags (Node.addTags m tags) tags ==? m
794
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
795
796

prop_Node_tagMaps_reject tags =
Iustin Pop's avatar
Iustin Pop committed
797
798
  not (null tags) ==>
  all (\t -> Node.rejectAddTags m [t]) tags
799
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
800

Iustin Pop's avatar
Iustin Pop committed
801
802
803
804
805
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

806
807
808
809
810
811
prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
Iustin Pop's avatar
Iustin Pop committed
812
     (null nodes || not (null ng))
813

814
testSuite "Node"
Iustin Pop's avatar
Iustin Pop committed
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
            [ 'prop_Node_setAlias
            , 'prop_Node_setOffline
            , 'prop_Node_setMcpu
            , 'prop_Node_setXmem
            , 'prop_Node_addPriFM
            , 'prop_Node_addPriFD
            , 'prop_Node_addPriFC
            , 'prop_Node_addSec
            , 'prop_Node_addPriOffline
            , 'prop_Node_addSecOffline
            , 'prop_Node_rMem
            , 'prop_Node_setMdsk
            , 'prop_Node_tagMaps_idempotent
            , 'prop_Node_tagMaps_reject
            , 'prop_Node_showField
            , 'prop_Node_computeGroups
            ]
832

833
-- ** Cluster tests
834

835
836
-- | Check that the cluster score is close to zero for a homogeneous
-- cluster.
Iustin Pop's avatar
Iustin Pop committed
837
prop_Score_Zero node =
Iustin Pop's avatar
Iustin Pop committed
838
  forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
839
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
840
     (Node.tDsk node > 0) && (Node.tMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
841
842
843
844
845
846
  let fn = Node.buildPeers node Container.empty
      nlst = replicate count fn
      score = Cluster.compCVNodes nlst
  -- we can't say == 0 here as the floating point errors accumulate;
  -- this should be much lower than the default score in CLI.hs
  in score <= 1e-12
847

848
-- | Check that cluster stats are sane.
Iustin Pop's avatar
Iustin Pop committed
849
prop_CStats_sane node =
Iustin Pop's avatar
Iustin Pop committed
850
  forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
851
    (not (Node.offline node) && not (Node.failN1 node) &&
852
     (Node.availDisk node > 0) && (Node.availMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
853
854
855
856
857
858
  let fn = Node.buildPeers node Container.empty
      nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
      nl = Container.fromList nlst
      cstats = Cluster.totalResources nl
  in Cluster.csAdsk cstats >= 0 &&
     Cluster.csAdsk cstats <= Cluster.csFdsk cstats
Iustin Pop's avatar
Iustin Pop committed
859

860
-- | Check that one instance is allocated correctly, without
861
-- rebalances needed.
862
prop_ClusterAlloc_sane node inst =
Iustin Pop's avatar
Iustin Pop committed
863
864
865
866
867
868
  forAll (choose (5, 20)) $ \count ->
  not (Node.offline node)
        && not (Node.failN1 node)
        && Node.availDisk node > 0
        && Node.availMem node > 0
        ==>
Iustin Pop's avatar
Iustin Pop committed
869
  let (nl, il, inst') = makeSmallEmptyCluster node count inst
Iustin Pop's avatar
Iustin Pop committed
870
871
872
873
874
875
876
877
878
879
  in case Cluster.genAllocNodes defGroupList nl 2 True >>=
     Cluster.tryAlloc nl il inst' of
       Types.Bad _ -> False
       Types.Ok as ->
         case Cluster.asSolution as of
           Nothing -> False
           Just (xnl, xi, _, cv) ->
             let il' = Container.add (Instance.idx xi) xi il
                 tbl = Cluster.Table xnl il' cv []
             in not (canBalance tbl True True False)
880
881
882

-- | Checks that on a 2-5 node cluster, we can allocate a random
-- instance spec via tiered allocation (whatever the original instance
883
-- spec), on either one or two nodes.
884
prop_ClusterCanTieredAlloc node inst =
Iustin Pop's avatar
Iustin Pop committed
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
  forAll (choose (2, 5)) $ \count ->
  forAll (choose (1, 2)) $ \rqnodes ->
  not (Node.offline node)
        && not (Node.failN1 node)
        && isNodeBig node 4
        ==>
  let nl = makeSmallCluster node count
      il = Container.empty
      allocnodes = Cluster.genAllocNodes defGroupList nl rqnodes True
  in case allocnodes >>= \allocnodes' ->
    Cluster.tieredAlloc nl il (Just 1) inst allocnodes' [] [] of
       Types.Bad _ -> False
       Types.Ok (_, _, il', ixes, cstats) -> not (null ixes) &&
                                             IntMap.size il' == length ixes &&
                                             length ixes == length cstats
900
901

-- | Checks that on a 4-8 node cluster, once we allocate an instance,
902
-- we can also evacuate it.
903
prop_ClusterAllocEvac node inst =
Iustin Pop's avatar
Iustin Pop committed
904
905
906
907
908
  forAll (choose (4, 8)) $ \count ->
  not (Node.offline node)
        && not (Node.failN1 node)
        && isNodeBig node 4
        ==>
Iustin Pop's avatar
Iustin Pop committed
909
  let (nl, il, inst') = makeSmallEmptyCluster node count inst
Iustin Pop's avatar
Iustin Pop committed
910
911
912
913
914
915
916
917
918
919
920
921
922
  in case Cluster.genAllocNodes defGroupList nl 2 True >>=
     Cluster.tryAlloc nl il inst' of
       Types.Bad _ -> False
       Types.Ok as ->
         case Cluster.asSolution as of
           Nothing -> False
           Just (xnl, xi, _, _) ->
             let sdx = Instance.sNode xi
                 il' = Container.add (Instance.idx xi) xi il
             in case IAlloc.processRelocate defGroupList xnl il'
                  (Instance.idx xi) 1 [sdx] of
                  Types.Ok _ -> True
                  _ -> False
923
924

-- | Check that allocating multiple instances on a cluster, then
925
-- adding an empty node, results in a valid rebalance.
926
prop_ClusterAllocBalance =
Iustin Pop's avatar
Iustin Pop committed
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
  forAll (genNode (Just 5) (Just 128)) $ \node ->
  forAll (choose (3, 5)) $ \count ->
  not (Node.offline node) && not (Node.failN1 node) ==>
  let nl = makeSmallCluster node count
      (hnode, nl') = IntMap.deleteFindMax nl
      il = Container.empty
      allocnodes = Cluster.genAllocNodes defGroupList nl' 2 True
      i_templ = createInstance Types.unitMem Types.unitDsk Types.unitCpu
  in case allocnodes >>= \allocnodes' ->
    Cluster.iterateAlloc nl' il (Just 5) i_templ allocnodes' [] [] of
       Types.Bad _ -> False
       Types.Ok (_, xnl, il', _, _) ->
         let ynl = Container.add (Node.idx hnode) hnode xnl
             cv = Cluster.compCV ynl
             tbl = Cluster.Table ynl il' cv []
         in canBalance tbl True True False
943

944
-- | Checks consistency.
945
946
947
prop_ClusterCheckConsistency node inst =
  let nl = makeSmallCluster node 3
      [node1, node2, node3] = Container.elems nl
Iustin Pop's avatar
Iustin Pop committed
948
      node3' = node3 { Node.group = 1 }
949
950
951
952
      nl' = Container.add (Node.idx node3') node3' nl
      inst1 = Instance.setBoth inst (Node.idx node1) (Node.idx node2)
      inst2 = Instance.setBoth inst (Node.idx node1) Node.noSecondary
      inst3 = Instance.setBoth inst (Node.idx node1) (Node.idx node3)
Iustin Pop's avatar
Iustin Pop committed
953
      ccheck = Cluster.findSplitInstances nl' . Container.fromList
954
955
956
957
  in null (ccheck [(0, inst1)]) &&
     null (ccheck [(0, inst2)]) &&
     (not . null $ ccheck [(0, inst3)])

958
-- | For now, we only test that we don't lose instances during the split.
959
960
961
962
963
964
965
966
967
prop_ClusterSplitCluster node inst =
  forAll (choose (0, 100)) $ \icnt ->
  let nl = makeSmallCluster node 2
      (nl', il') = foldl (\(ns, is) _ -> assignInstance ns is inst 0 1)
                   (nl, Container.empty) [1..icnt]
      gni = Cluster.splitCluster nl' il'
  in sum (map (Container.size . snd . snd) gni) == icnt &&
     all (\(guuid, (nl'', _)) -> all ((== guuid) . Node.group)
                                 (Container.elems nl'')) gni
968

969
testSuite "Cluster"
Iustin Pop's avatar
Iustin Pop committed
970
971
972
973
974
975
976
977
978
            [ 'prop_Score_Zero
            , 'prop_CStats_sane
            , 'prop_ClusterAlloc_sane
            , 'prop_ClusterCanTieredAlloc
            , 'prop_ClusterAllocEvac
            , 'prop_ClusterAllocBalance
            , 'prop_ClusterCheckConsistency
            , 'prop_ClusterSplitCluster
            ]
Iustin Pop's avatar
Iustin Pop committed
979

980
-- ** OpCodes tests
Iustin Pop's avatar
Iustin Pop committed
981

982
-- | Check that opcode serialization is idempotent.
Iustin Pop's avatar
Iustin Pop committed
983
984
prop_OpCodes_serialization op =
  case J.readJSON (J.showJSON op) of
Iustin Pop's avatar
Iustin Pop committed
985
986
    J.Error e -> printTestCase ("Cannot deserialise: " ++ e) False
    J.Ok op' -> op ==? op'
987
  where _types = op::OpCodes.OpCode
Iustin Pop's avatar
Iustin Pop committed
988

989
testSuite "OpCodes"
Iustin Pop's avatar
Iustin Pop committed
990
            [ 'prop_OpCodes_serialization ]
Iustin Pop's avatar
Iustin Pop committed
991

992
993
994
-- ** Jobs tests

-- | Check that (queued) job\/opcode status serialization is idempotent.
995
996
prop_OpStatus_serialization os =
  case J.readJSON (J.showJSON os) of
Iustin Pop's avatar
Iustin Pop committed
997
998
    J.Error e -> printTestCase ("Cannot deserialise: " ++ e) False
    J.Ok os' -> os ==? os'
999
1000
1001
1002
  where _types = os::Jobs.OpStatus

prop_JobStatus_serialization js =
  case J.readJSON (J.showJSON js) of