QC.hs 40 KB
Newer Older
1
2
{-# LANGUAGE TemplateHaskell #-}

3
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
4
5
6
7
8

-}

{-

9
Copyright (C) 2009, 2010, 2011 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

28
module Ganeti.HTools.QC
29
30
    ( testUtils
    , testPeerMap
31
32
33
34
    , testContainer
    , testInstance
    , testNode
    , testText
Iustin Pop's avatar
Iustin Pop committed
35
    , testOpCodes
36
    , testJobs
37
    , testCluster
Iustin Pop's avatar
Iustin Pop committed
38
    , testLoader
39
    , testTypes
40
    ) where
41
42

import Test.QuickCheck
Iustin Pop's avatar
Iustin Pop committed
43
import Data.List (findIndex, intercalate, nub, isPrefixOf)
44
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
45
46
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
47
import qualified Data.Map
48
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
49
import qualified Ganeti.OpCodes as OpCodes
50
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
51
import qualified Ganeti.Luxi
52
53
54
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
55
import qualified Ganeti.HTools.ExtLoader
56
57
58
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
59
import qualified Ganeti.HTools.Luxi
60
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
61
import qualified Ganeti.HTools.Group as Group
62
import qualified Ganeti.HTools.PeerMap as PeerMap
63
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
64
import qualified Ganeti.HTools.Simu
65
66
67
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
68
import qualified Ganeti.HTools.Version
69
import qualified Ganeti.Constants as C
70

71
72
73
74
75
import qualified Ganeti.HTools.Program.Hail
import qualified Ganeti.HTools.Program.Hbal
import qualified Ganeti.HTools.Program.Hscan
import qualified Ganeti.HTools.Program.Hspace

76
import Ganeti.HTools.QCHelper (testSuite)
Iustin Pop's avatar
Iustin Pop committed
77

78
79
-- * Constants

80
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
81
82
83
maxMem :: Int
maxMem = 1024 * 1024

84
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
85
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
86
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
87

88
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
89
90
91
maxCpu :: Int
maxCpu = 1024

Iustin Pop's avatar
Iustin Pop committed
92
93
94
95
96
97
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
               Group.create "default" Utils.defaultGroupID
                    Types.AllocPreferred

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
98
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
99
100
101
102

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

103
104
-- * Helper functions

105
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
106
107
108
109
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

Iustin Pop's avatar
Iustin Pop committed
110
111
112
113
114
115
116
-- | Checks for equality with proper annotation.
(==?) :: (Show a, Eq a) => a -> a -> Property
(==?) x y = printTestCase
            ("Expected equality, but '" ++
             show x ++ "' /= '" ++ show y ++ "'") (x == y)
infix 3 ==?

117
-- | Update an instance to be smaller than a node.
118
setInstanceSmallerThanNode node inst =
119
120
121
    inst { Instance.mem = Node.availMem node `div` 2
         , Instance.dsk = Node.availDisk node `div` 2
         , Instance.vcpus = Node.availCpu node `div` 2
122
123
         }

124
-- | Create an instance given its spec.
125
createInstance mem dsk vcpus =
126
    Instance.create "inst-unnamed" mem dsk vcpus "running" [] True (-1) (-1)
127
                    Types.DTDrbd8
128

129
-- | Create a small cluster by repeating a node spec.
130
131
132
133
134
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
    let fn = Node.buildPeers node Container.empty
        namelst = map (\n -> (Node.name n, n)) (replicate count fn)
        (_, nlst) = Loader.assignIndices namelst
135
    in nlst
136

137
-- | Checks if a node is "big" enough.
138
139
140
141
142
isNodeBig :: Node.Node -> Int -> Bool
isNodeBig node size = Node.availDisk node > size * Types.unitDsk
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

143
144
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
145

146
-- | Assigns a new fresh instance to a cluster; this is not
147
-- allocation, so no resource checks are done.
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
                then 0
                else fst (Container.findMax il) + 1
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

165
166
-- * Arbitrary instances

167
-- | Defines a DNS name.
168
newtype DNSChar = DNSChar { dnsGetChar::Char }
169

170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
instance Arbitrary DNSChar where
    arbitrary = do
      x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
      return (DNSChar x)

getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)


getFQDN :: Gen String
getFQDN = do
  felem <- getName
  ncomps <- choose (1, 4)
  frest <- vector ncomps::Gen [[DNSChar]]
  let frest' = map (map dnsGetChar) frest
  return (felem ++ "." ++ intercalate "." frest')

190
191
192
-- let's generate a random instance
instance Arbitrary Instance.Instance where
    arbitrary = do
193
      name <- getFQDN
Iustin Pop's avatar
Iustin Pop committed
194
195
      mem <- choose (0, maxMem)
      dsk <- choose (0, maxDsk)
196
197
198
199
200
201
202
203
      run_st <- elements [ C.inststErrorup
                         , C.inststErrordown
                         , C.inststAdmindown
                         , C.inststNodedown
                         , C.inststNodeoffline
                         , C.inststRunning
                         , "no_such_status1"
                         , "no_such_status2"]
204
205
      pn <- arbitrary
      sn <- arbitrary
Iustin Pop's avatar
Iustin Pop committed
206
      vcpus <- choose (0, maxCpu)
207
      return $ Instance.create name mem dsk vcpus run_st [] True pn sn
208
                               Types.DTDrbd8
209

210
211
212
213
214
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
          case min_multiplier of
            Just mm -> (mm * Types.unitMem,
                        mm * Types.unitDsk,
                        mm * Types.unitCpu)
            Nothing -> (0, 0, 0)
      (top_mem, top_dsk, top_cpu)  =
          case max_multiplier of
            Just mm -> (mm * Types.unitMem,
                        mm * Types.unitDsk,
                        mm * Types.unitCpu)
            Nothing -> (maxMem, maxDsk, maxCpu)
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
  return $ Node.buildPeers n Container.empty

240
241
-- and a random node
instance Arbitrary Node.Node where
242
    arbitrary = genNode Nothing Nothing
243

Iustin Pop's avatar
Iustin Pop committed
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
  arbitrary = elements [ OpCodes.ReplaceOnPrimary
                       , OpCodes.ReplaceOnSecondary
                       , OpCodes.ReplaceNewSecondary
                       , OpCodes.ReplaceAuto
                       ]

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
    (case op_id of
        "OP_TEST_DELAY" ->
          liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
        "OP_INSTANCE_REPLACE_DISKS" ->
263
          liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
Iustin Pop's avatar
Iustin Pop committed
264
265
          arbitrary arbitrary arbitrary
        "OP_INSTANCE_FAILOVER" ->
266
267
          liftM3 OpCodes.OpInstanceFailover arbitrary arbitrary
                 arbitrary
Iustin Pop's avatar
Iustin Pop committed
268
        "OP_INSTANCE_MIGRATE" ->
269
270
          liftM5 OpCodes.OpInstanceMigrate arbitrary arbitrary
                 arbitrary arbitrary
271
          arbitrary
Iustin Pop's avatar
Iustin Pop committed
272
273
        _ -> fail "Wrong opcode")

274
275
276
277
278
279
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

280
281
282
283
284
285
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
    arbitrary = do
      v <- choose (0, 1)
      return $ SmallRatio v

286
287
288
289
290
291
instance Arbitrary Types.AllocPolicy where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Types.DiskTemplate where
  arbitrary = elements [minBound..maxBound]

292
293
294
295
296
297
298
299
300
instance Arbitrary Types.FailMode where
    arbitrary = elements [minBound..maxBound]

instance Arbitrary a => Arbitrary (Types.OpResult a) where
    arbitrary = arbitrary >>= \c ->
                case c of
                  False -> liftM Types.OpFail arbitrary
                  True -> liftM Types.OpGood arbitrary

301
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
302

303
304
305
306
-- ** Utils tests

-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
307
308
309
prop_Utils_commaJoinSplit =
    forAll (arbitrary `suchThat`
            (\l -> l /= [""] && all (not . elem ',') l )) $ \lst ->
Iustin Pop's avatar
Iustin Pop committed
310
    Utils.sepSplit ',' (Utils.commaJoin lst) ==? lst
Iustin Pop's avatar
Iustin Pop committed
311

312
-- | Split and join should always be idempotent.
Iustin Pop's avatar
Iustin Pop committed
313
314
prop_Utils_commaSplitJoin s =
    Utils.commaJoin (Utils.sepSplit ',' s) ==? s
315

316
-- | fromObjWithDefault, we test using the Maybe monad and an integer
317
-- value.
318
319
320
321
322
323
prop_Utils_fromObjWithDefault def_value random_key =
    -- a missing key will be returned with the default
    Utils.fromObjWithDefault [] random_key def_value == Just def_value &&
    -- a found key will be returned as is, not with default
    Utils.fromObjWithDefault [(random_key, J.showJSON def_value)]
         random_key (def_value+1) == Just def_value
Iustin Pop's avatar
Iustin Pop committed
324
        where _types = def_value :: Integer
325

326
-- | Test that functional if' behaves like the syntactic sugar if.
Iustin Pop's avatar
Iustin Pop committed
327
328
329
prop_Utils_if'if :: Bool -> Int -> Int -> Gen Prop
prop_Utils_if'if cnd a b =
    Utils.if' cnd a b ==? if cnd then a else b
330

Guido Trotter's avatar
Guido Trotter committed
331
-- | Test basic select functionality
Iustin Pop's avatar
Iustin Pop committed
332
333
334
335
prop_Utils_select :: Int      -- ^ Default result
                  -> [Int]    -- ^ List of False values
                  -> [Int]    -- ^ List of True values
                  -> Gen Prop -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
336
prop_Utils_select def lst1 lst2 =
Iustin Pop's avatar
Iustin Pop committed
337
  Utils.select def cndlist ==? expectedresult
Guido Trotter's avatar
Guido Trotter committed
338
  where expectedresult = Utils.if' (null lst2) def (head lst2)
339
340
        flist = map (\e -> (False, e)) lst1
        tlist = map (\e -> (True, e)) lst2
Guido Trotter's avatar
Guido Trotter committed
341
342
343
        cndlist = flist ++ tlist

-- | Test basic select functionality with undefined default
Iustin Pop's avatar
Iustin Pop committed
344
prop_Utils_select_undefd :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
345
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
346
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
347
prop_Utils_select_undefd lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
348
  Utils.select undefined cndlist ==? head lst2
Guido Trotter's avatar
Guido Trotter committed
349
350
351
352
353
  where flist = map (\e -> (False, e)) lst1
        tlist = map (\e -> (True, e)) lst2
        cndlist = flist ++ tlist

-- | Test basic select functionality with undefined list values
Iustin Pop's avatar
Iustin Pop committed
354
prop_Utils_select_undefv :: [Int]            -- ^ List of False values
Guido Trotter's avatar
Guido Trotter committed
355
                         -> NonEmptyList Int -- ^ List of True values
Iustin Pop's avatar
Iustin Pop committed
356
                         -> Gen Prop         -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
357
prop_Utils_select_undefv lst1 (NonEmpty lst2) =
Iustin Pop's avatar
Iustin Pop committed
358
  Utils.select undefined cndlist ==? head lst2
Guido Trotter's avatar
Guido Trotter committed
359
360
361
  where flist = map (\e -> (False, e)) lst1
        tlist = map (\e -> (True, e)) lst2
        cndlist = flist ++ tlist ++ [undefined]
362

Iustin Pop's avatar
Iustin Pop committed
363
364
365
366
367
368
369
370
371
372
373
prop_Utils_parseUnit (NonNegative n) =
    Utils.parseUnit (show n) == Types.Ok n &&
    Utils.parseUnit (show n ++ "m") == Types.Ok n &&
    (case Utils.parseUnit (show n ++ "M") of
      Types.Ok m -> if n > 0
                    then m < n  -- for positive values, X MB is less than X MiB
                    else m == 0 -- but for 0, 0 MB == 0 MiB
      Types.Bad _ -> False) &&
    Utils.parseUnit (show n ++ "g") == Types.Ok (n*1024) &&
    Utils.parseUnit (show n ++ "t") == Types.Ok (n*1048576) &&
    Types.isBad (Utils.parseUnit (show n ++ "x")::Types.Result Int)
Iustin Pop's avatar
Iustin Pop committed
374
    where _types = n::Int
Iustin Pop's avatar
Iustin Pop committed
375

376
-- | Test list for the Utils module.
377
378
379
380
381
382
383
384
385
386
testSuite "Utils"
              [ 'prop_Utils_commaJoinSplit
              , 'prop_Utils_commaSplitJoin
              , 'prop_Utils_fromObjWithDefault
              , 'prop_Utils_if'if
              , 'prop_Utils_select
              , 'prop_Utils_select_undefd
              , 'prop_Utils_select_undefv
              , 'prop_Utils_parseUnit
              ]
387

388
389
390
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
391
prop_PeerMap_addIdempotent pmap key em =
Iustin Pop's avatar
Iustin Pop committed
392
    fn puniq ==? fn (fn puniq)
393
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
394
395
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
396
          puniq = PeerMap.accumArray const pmap
397

398
-- | Make sure remove is idempotent.
399
prop_PeerMap_removeIdempotent pmap key =
Iustin Pop's avatar
Iustin Pop committed
400
    fn puniq ==? fn (fn puniq)
401
402
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
403
404
          puniq = PeerMap.accumArray const pmap

405
-- | Make sure a missing item returns 0.
406
prop_PeerMap_findMissing pmap key =
Iustin Pop's avatar
Iustin Pop committed
407
    PeerMap.find key (PeerMap.remove key puniq) ==? 0
408
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
409
410
          puniq = PeerMap.accumArray const pmap

411
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
412
prop_PeerMap_addFind pmap key em =
Iustin Pop's avatar
Iustin Pop committed
413
    PeerMap.find key (PeerMap.add key em puniq) ==? em
414
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
415
                    key::PeerMap.Key, em::PeerMap.Elem)
416
          puniq = PeerMap.accumArray const pmap
417

418
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
419
prop_PeerMap_maxElem pmap =
Iustin Pop's avatar
Iustin Pop committed
420
421
    PeerMap.maxElem puniq ==? if null puniq then 0
                              else (maximum . snd . unzip) puniq
422
    where _types = pmap::PeerMap.PeerMap
423
424
          puniq = PeerMap.accumArray const pmap

425
-- | List of tests for the PeerMap module.
426
427
428
429
430
431
432
testSuite "PeerMap"
              [ 'prop_PeerMap_addIdempotent
              , 'prop_PeerMap_removeIdempotent
              , 'prop_PeerMap_maxElem
              , 'prop_PeerMap_addFind
              , 'prop_PeerMap_findMissing
              ]
433

434
-- ** Container tests
435
436
437
438
439
440
441
442
443

prop_Container_addTwo cdata i1 i2 =
    fn i1 i2 cont == fn i2 i1 cont &&
       fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

444
445
446
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
Iustin Pop's avatar
Iustin Pop committed
447
  in Container.nameOf nl (Node.idx fnode) ==? Node.name fnode
448

449
-- | We test that in a cluster, given a random node, we can find it by
450
-- its name and alias, as long as all names and aliases are unique,
451
-- and that we fail to find a non-existing name.
452
453
454
455
456
457
458
459
460
461
462
463
464
prop_Container_findByName node othername =
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
  forAll (vector cnt) $ \ names ->
  (length . nub) (map fst names ++ map snd names) ==
  length names * 2 &&
  not (othername `elem` (map fst names ++ map snd names)) ==>
  let nl = makeSmallCluster node cnt
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
465
      nl' = Container.fromList nodes'
466
467
468
469
470
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
     Container.findByName nl' othername == Nothing

471
472
473
474
475
testSuite "Container"
              [ 'prop_Container_addTwo
              , 'prop_Container_nameOf
              , 'prop_Container_findByName
              ]
476

477
478
-- ** Instance tests

479
480
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
481
prop_Instance_creat inst =
Iustin Pop's avatar
Iustin Pop committed
482
    Instance.name inst ==? Instance.alias inst
Iustin Pop's avatar
Iustin Pop committed
483

484
prop_Instance_setIdx inst idx =
Iustin Pop's avatar
Iustin Pop committed
485
    Instance.idx (Instance.setIdx inst idx) ==? idx
486
487
488
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
489
490
491
492
493
494
495
496
    Instance.name newinst == name &&
    Instance.alias newinst == name
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
    Instance.name newinst == Instance.name inst &&
    Instance.alias newinst == name
497
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
498
          newinst = Instance.setAlias inst name
499
500

prop_Instance_setPri inst pdx =
Iustin Pop's avatar
Iustin Pop committed
501
    Instance.pNode (Instance.setPri inst pdx) ==? pdx
502
503
504
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
Iustin Pop's avatar
Iustin Pop committed
505
    Instance.sNode (Instance.setSec inst sdx) ==? sdx
506
507
508
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
509
    Instance.pNode si == pdx && Instance.sNode si == sdx
510
511
512
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
513
514
515
516
prop_Instance_runStatus_True =
    forAll (arbitrary `suchThat`
            ((`elem` Instance.runningStates) . Instance.runSt))
    Instance.running
Iustin Pop's avatar
Iustin Pop committed
517
518
519

prop_Instance_runStatus_False inst =
    let run_st = Instance.running inst
520
        run_tx = Instance.runSt inst
Iustin Pop's avatar
Iustin Pop committed
521
    in
522
      run_tx `notElem` Instance.runningStates ==> not run_st
Iustin Pop's avatar
Iustin Pop committed
523

Iustin Pop's avatar
Iustin Pop committed
524
525
526
527
528
529
530
531
prop_Instance_shrinkMG inst =
    Instance.mem inst >= 2 * Types.unitMem ==>
        case Instance.shrinkByType inst Types.FailMem of
          Types.Ok inst' ->
              Instance.mem inst' == Instance.mem inst - Types.unitMem
          _ -> False

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
532
533
534
    forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
535
536
537
538
539
540
541
542
543

prop_Instance_shrinkCG inst =
    Instance.vcpus inst >= 2 * Types.unitCpu ==>
        case Instance.shrinkByType inst Types.FailCPU of
          Types.Ok inst' ->
              Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
          _ -> False

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
544
545
546
    forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
547
548
549
550
551
552
553
554
555

prop_Instance_shrinkDG inst =
    Instance.dsk inst >= 2 * Types.unitDsk ==>
        case Instance.shrinkByType inst Types.FailDisk of
          Types.Ok inst' ->
              Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
          _ -> False

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
556
557
558
    forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
559
560

prop_Instance_setMovable inst m =
Iustin Pop's avatar
Iustin Pop committed
561
    Instance.movable inst' ==? m
562
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
563

564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
testSuite "Instance"
              [ 'prop_Instance_creat
              , 'prop_Instance_setIdx
              , 'prop_Instance_setName
              , 'prop_Instance_setAlias
              , 'prop_Instance_setPri
              , 'prop_Instance_setSec
              , 'prop_Instance_setBoth
              , 'prop_Instance_runStatus_True
              , 'prop_Instance_runStatus_False
              , 'prop_Instance_shrinkMG
              , 'prop_Instance_shrinkMF
              , 'prop_Instance_shrinkCG
              , 'prop_Instance_shrinkCF
              , 'prop_Instance_shrinkDG
              , 'prop_Instance_shrinkDF
              , 'prop_Instance_setMovable
              ]
Iustin Pop's avatar
Iustin Pop committed
582

583
584
-- ** Text backend tests

Iustin Pop's avatar
Iustin Pop committed
585
586
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
587
588
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
589
                        (NonNegative pdx) (NonNegative sdx) autobal dt =
590
    pnode /= snode && pdx /= sdx ==>
Iustin Pop's avatar
Iustin Pop committed
591
592
593
    let vcpus_s = show vcpus
        dsk_s = show dsk
        mem_s = show mem
Iustin Pop's avatar
Iustin Pop committed
594
595
        ndx = if null snode
              then [(pnode, pdx)]
596
              else [(pnode, pdx), (snode, sdx)]
597
        nl = Data.Map.fromList ndx
598
        tags = ""
Iustin Pop's avatar
Iustin Pop committed
599
        sbal = if autobal then "Y" else "N"
600
        sdt = Types.diskTemplateToRaw dt
601
        inst = Text.loadInst nl
Iustin Pop's avatar
Iustin Pop committed
602
               [name, mem_s, dsk_s, vcpus_s, status,
603
                sbal, pnode, snode, sdt, tags]
604
        fail1 = Text.loadInst nl
Iustin Pop's avatar
Iustin Pop committed
605
               [name, mem_s, dsk_s, vcpus_s, status,
606
                sbal, pnode, pnode, tags]
Iustin Pop's avatar
Iustin Pop committed
607
608
        _types = ( name::String, mem::Int, dsk::Int
                 , vcpus::Int, status::String
Iustin Pop's avatar
Iustin Pop committed
609
                 , snode::String
Iustin Pop's avatar
Iustin Pop committed
610
                 , autobal::Bool)
Iustin Pop's avatar
Iustin Pop committed
611
612
    in
      case inst of
613
614
        Types.Bad msg -> printTestCase ("Failed to load instance: " ++ msg)
                         False
Iustin Pop's avatar
Iustin Pop committed
615
616
        Types.Ok (_, i) -> printTestCase "Mismatch in some field while\
                                         \ loading the instance" $
Iustin Pop's avatar
Iustin Pop committed
617
618
619
620
621
622
            Instance.name i == name &&
            Instance.vcpus i == vcpus &&
            Instance.mem i == mem &&
            Instance.pNode i == pdx &&
            Instance.sNode i == (if null snode
                                 then Node.noSecondary
623
                                 else sdx) &&
624
            Instance.autoBalance i == autobal &&
625
            Types.isBad fail1
Iustin Pop's avatar
Iustin Pop committed
626
627

prop_Text_Load_InstanceFail ktn fields =
628
    length fields /= 10 ==>
Iustin Pop's avatar
Iustin Pop committed
629
    case Text.loadInst nl fields of
630
631
632
633
      Types.Ok _ -> printTestCase "Managed to load instance from invalid\
                                  \ data" False
      Types.Bad msg -> printTestCase ("Unrecognised error message: " ++ msg) $
                       "Invalid/incomplete instance data: '" `isPrefixOf` msg
634
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649

prop_Text_Load_Node name tm nm fm td fd tc fo =
    let conv v = if v < 0
                    then "?"
                    else show v
        tm_s = conv tm
        nm_s = conv nm
        fm_s = conv fm
        td_s = conv td
        fd_s = conv fd
        tc_s = conv tc
        fo_s = if fo
               then "Y"
               else "N"
        any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
Iustin Pop's avatar
Iustin Pop committed
650
651
652
        gid = Group.uuid defGroup
    in case Text.loadNode defGroupAssoc
           [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
Iustin Pop's avatar
Iustin Pop committed
653
654
655
656
         Nothing -> False
         Just (name', node) ->
             if fo || any_broken
             then Node.offline node
657
658
659
660
661
662
663
664
             else Node.name node == name' && name' == name &&
                  Node.alias node == name &&
                  Node.tMem node == fromIntegral tm &&
                  Node.nMem node == nm &&
                  Node.fMem node == fm &&
                  Node.tDsk node == fromIntegral td &&
                  Node.fDsk node == fd &&
                  Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
665
666

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
667
    length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
668

669
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
670
671
    (Text.loadNode defGroupAssoc.
         Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
672
673
674
675
    Just (Node.name n, n)
    -- override failN1 to what loadNode returns by default
    where n = node { Node.failN1 = True, Node.offline = False }

676
677
678
679
680
681
682
testSuite "Text"
              [ 'prop_Text_Load_Instance
              , 'prop_Text_Load_InstanceFail
              , 'prop_Text_Load_Node
              , 'prop_Text_Load_NodeFail
              , 'prop_Text_NodeLSIdempotent
              ]
683

684
-- ** Node tests
685

Iustin Pop's avatar
Iustin Pop committed
686
687
688
689
690
691
692
prop_Node_setAlias node name =
    Node.name newnode == Node.name node &&
    Node.alias newnode == name
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
Iustin Pop's avatar
Iustin Pop committed
693
    Node.offline newnode ==? status
Iustin Pop's avatar
Iustin Pop committed
694
695
696
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
Iustin Pop's avatar
Iustin Pop committed
697
    Node.xMem newnode ==? xm
Iustin Pop's avatar
Iustin Pop committed
698
699
700
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
Iustin Pop's avatar
Iustin Pop committed
701
    Node.mCpu newnode ==? mc
Iustin Pop's avatar
Iustin Pop committed
702
703
    where newnode = Node.setMcpu node mc

704
705
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
706
707
708
709
710
711
prop_Node_addPriFM node inst = Instance.mem inst >= Node.fMem node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailMem -> True
                                 _ -> False
712
    where _types = (node::Node.Node, inst::Instance.Instance)
Iustin Pop's avatar
Iustin Pop committed
713
714
715
716
717
718
719
720
721
722
723
724
725
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst = Instance.dsk inst >= Node.fDsk node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailDisk -> True
                                 _ -> False
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

Iustin Pop's avatar
Iustin Pop committed
726
727
728
729
730
prop_Node_addPriFC node inst (Positive extra) =
    not (Node.failN1 node) ==>
        case Node.addPri node inst'' of
          Types.OpFail Types.FailCPU -> True
          _ -> False
Iustin Pop's avatar
Iustin Pop committed
731
732
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
Iustin Pop's avatar
Iustin Pop committed
733
          inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
734

735
736
-- | Check that an instance add with too high memory or disk will be
-- rejected.
737
prop_Node_addSec node inst pdx =
738
739
    (Instance.mem inst >= (Node.fMem node - Node.rMem node) ||
     Instance.dsk inst >= Node.fDsk node) &&
Iustin Pop's avatar
Iustin Pop committed
740
    not (Node.failN1 node)
Iustin Pop's avatar
Iustin Pop committed
741
    ==> isFailure (Node.addSec node inst pdx)
742
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
743

744
-- | Checks for memory reservation changes.
745
prop_Node_rMem inst =
746
    forAll (arbitrary `suchThat` ((> Types.unitMem) . Node.fMem)) $ \node ->
747
748
    -- ab = auto_balance, nb = non-auto_balance
    -- we use -1 as the primary node of the instance
749
    let inst' = inst { Instance.pNode = -1, Instance.autoBalance = True }
750
        inst_ab = setInstanceSmallerThanNode node inst'
751
        inst_nb = inst_ab { Instance.autoBalance = False }
752
        -- now we have the two instances, identical except the
753
        -- autoBalance attribute
754
755
756
757
        orig_rmem = Node.rMem node
        inst_idx = Instance.idx inst_ab
        node_add_ab = Node.addSec node inst_ab (-1)
        node_add_nb = Node.addSec node inst_nb (-1)
Iustin Pop's avatar
Iustin Pop committed
758
759
        node_del_ab = liftM (`Node.removeSec` inst_ab) node_add_ab
        node_del_nb = liftM (`Node.removeSec` inst_nb) node_add_nb
760
761
762
    in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
         (Types.OpGood a_ab, Types.OpGood a_nb,
          Types.OpGood d_ab, Types.OpGood d_nb) ->
763
             printTestCase "Consistency checks failed" $
764
765
766
767
768
769
770
771
772
             Node.rMem a_ab >  orig_rmem &&
             Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
             Node.rMem a_nb == orig_rmem &&
             Node.rMem d_ab == orig_rmem &&
             Node.rMem d_nb == orig_rmem &&
             -- this is not related to rMem, but as good a place to
             -- test as any
             inst_idx `elem` Node.sList a_ab &&
             not (inst_idx `elem` Node.sList d_ab)
773
774
         x -> printTestCase ("Failed to add/remove instances: " ++ show x)
              False
775

776
-- | Check mdsk setting.
Iustin Pop's avatar
Iustin Pop committed
777
778
779
780
781
prop_Node_setMdsk node mx =
    Node.loDsk node' >= 0 &&
    fromIntegral (Node.loDsk node') <= Node.tDsk node &&
    Node.availDisk node' >= 0 &&
    Node.availDisk node' <= Node.fDsk node' &&
Iustin Pop's avatar
Iustin Pop committed
782
783
    fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
    Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
784
785
786
787
788
789
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
Iustin Pop's avatar
Iustin Pop committed
790
    Node.delTags (Node.addTags m tags) tags ==? m
791
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
792
793
794

prop_Node_tagMaps_reject tags =
    not (null tags) ==>
Iustin Pop's avatar
Iustin Pop committed
795
    all (\t -> Node.rejectAddTags m [t]) tags
796
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
797

Iustin Pop's avatar
Iustin Pop committed
798
799
800
801
802
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

803
804
805
806
807
808
prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
Iustin Pop's avatar
Iustin Pop committed
809
     (null nodes || not (null ng))
810

811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
testSuite "Node"
              [ 'prop_Node_setAlias
              , 'prop_Node_setOffline
              , 'prop_Node_setMcpu
              , 'prop_Node_setXmem
              , 'prop_Node_addPriFM
              , 'prop_Node_addPriFD
              , 'prop_Node_addPriFC
              , 'prop_Node_addSec
              , 'prop_Node_rMem
              , 'prop_Node_setMdsk
              , 'prop_Node_tagMaps_idempotent
              , 'prop_Node_tagMaps_reject
              , 'prop_Node_showField
              , 'prop_Node_computeGroups
              ]
827

828
-- ** Cluster tests
829

830
831
-- | Check that the cluster score is close to zero for a homogeneous
-- cluster.
Iustin Pop's avatar
Iustin Pop committed
832
833
prop_Score_Zero node =
    forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
834
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
835
     (Node.tDsk node > 0) && (Node.tMem node > 0)) ==>
836
    let fn = Node.buildPeers node Container.empty
837
838
        nlst = replicate count fn
        score = Cluster.compCVNodes nlst
839
840
    -- we can't say == 0 here as the floating point errors accumulate;
    -- this should be much lower than the default score in CLI.hs
Iustin Pop's avatar
Iustin Pop committed
841
    in score <= 1e-12
842

843
-- | Check that cluster stats are sane.
Iustin Pop's avatar
Iustin Pop committed
844
845
846
prop_CStats_sane node =
    forAll (choose (1, 1024)) $ \count ->
    (not (Node.offline node) && not (Node.failN1 node) &&
847
     (Node.availDisk node > 0) && (Node.availMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
848
849
    let fn = Node.buildPeers node Container.empty
        nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
Iustin Pop's avatar
Iustin Pop committed
850
        nl = Container.fromList nlst
Iustin Pop's avatar
Iustin Pop committed
851
852
853
854
        cstats = Cluster.totalResources nl
    in Cluster.csAdsk cstats >= 0 &&
       Cluster.csAdsk cstats <= Cluster.csFdsk cstats

855
-- | Check that one instance is allocated correctly, without
856
-- rebalances needed.
857
858
859
860
861
862
863
864
865
866
prop_ClusterAlloc_sane node inst =
    forAll (choose (5, 20)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && Node.availDisk node > 0
            && Node.availMem node > 0
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
867
868
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
869
         Types.Bad _ -> False
870
         Types.Ok as ->
871
872
873
             case Cluster.asSolution as of
               Nothing -> False
               Just (xnl, xi, _, cv) ->
874
                   let il' = Container.add (Instance.idx xi) xi il
875
                       tbl = Cluster.Table xnl il' cv []
876
                   in not (canBalance tbl True True False)
877
878
879

-- | Checks that on a 2-5 node cluster, we can allocate a random
-- instance spec via tiered allocation (whatever the original instance
880
-- spec), on either one or two nodes.
881
882
883
884
885
886
887
888
889
prop_ClusterCanTieredAlloc node inst =
    forAll (choose (2, 5)) $ \count ->
    forAll (choose (1, 2)) $ \rqnodes ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
890
        allocnodes = Cluster.genAllocNodes defGroupList nl rqnodes True
Iustin Pop's avatar
Iustin Pop committed
891
    in case allocnodes >>= \allocnodes' ->
892
        Cluster.tieredAlloc nl il (Just 1) inst allocnodes' [] [] of
893
         Types.Bad _ -> False
894
895
896
         Types.Ok (_, _, il', ixes, cstats) -> not (null ixes) &&
                                      IntMap.size il' == length ixes &&
                                      length ixes == length cstats
897
898

-- | Checks that on a 4-8 node cluster, once we allocate an instance,
899
-- we can also evacuate it.
900
901
902
903
904
905
906
907
908
prop_ClusterAllocEvac node inst =
    forAll (choose (4, 8)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
909
910
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
911
         Types.Bad _ -> False
912
         Types.Ok as ->
913
914
915
             case Cluster.asSolution as of
               Nothing -> False
               Just (xnl, xi, _, _) ->
916
917
                   let sdx = Instance.sNode xi
                       il' = Container.add (Instance.idx xi) xi il
Iustin Pop's avatar
Iustin Pop committed
918
919
920
                   in case IAlloc.processRelocate defGroupList xnl il'
                          (Instance.idx xi) 1 [sdx] of
                        Types.Ok _ -> True
921
922
923
                        _ -> False

-- | Check that allocating multiple instances on a cluster, then
924
-- adding an empty node, results in a valid rebalance.
925
926
prop_ClusterAllocBalance =
    forAll (genNode (Just 5) (Just 128)) $ \node ->
927
    forAll (choose (3, 5)) $ \count ->
928
    not (Node.offline node) && not (Node.failN1 node) ==>
929
930
931
    let nl = makeSmallCluster node count
        (hnode, nl') = IntMap.deleteFindMax nl
        il = Container.empty
932
        allocnodes = Cluster.genAllocNodes defGroupList nl' 2 True
933
        i_templ = createInstance Types.unitMem Types.unitDsk Types.unitCpu
Iustin Pop's avatar
Iustin Pop committed
934
    in case allocnodes >>= \allocnodes' ->
935
        Cluster.iterateAlloc nl' il (Just 5) i_templ allocnodes' [] [] of
936
         Types.Bad _ -> False
937
         Types.Ok (_, xnl, il', _, _) ->
938
939
940
                   let ynl = Container.add (Node.idx hnode) hnode xnl
                       cv = Cluster.compCV ynl
                       tbl = Cluster.Table ynl il' cv []
941
                   in canBalance tbl True True False
942

943
-- | Checks consistency.
944
945
946
prop_ClusterCheckConsistency node inst =
  let nl = makeSmallCluster node 3
      [node1, node2, node3] = Container.elems nl
Iustin Pop's avatar
Iustin Pop committed
947
      node3' = node3 { Node.group = 1 }
948
949
950
951
      nl' = Container.add (Node.idx node3') node3' nl
      inst1 = Instance.setBoth inst (Node.idx node1) (Node.idx node2)
      inst2 = Instance.setBoth inst (Node.idx node1) Node.noSecondary
      inst3 = Instance.setBoth inst (Node.idx node1) (Node.idx node3)
Iustin Pop's avatar
Iustin Pop committed
952
      ccheck = Cluster.findSplitInstances nl' . Container.fromList
953
954
955
956
  in null (ccheck [(0, inst1)]) &&
     null (ccheck [(0, inst2)]) &&
     (not . null $ ccheck [(0, inst3)])

957
-- | For now, we only test that we don't lose instances during the split.
958
959
960
961
962
963
964
965
966
prop_ClusterSplitCluster node inst =
  forAll (choose (0, 100)) $ \icnt ->
  let nl = makeSmallCluster node 2
      (nl', il') = foldl (\(ns, is) _ -> assignInstance ns is inst 0 1)
                   (nl, Container.empty) [1..icnt]
      gni = Cluster.splitCluster nl' il'
  in sum (map (Container.size . snd . snd) gni) == icnt &&
     all (\(guuid, (nl'', _)) -> all ((== guuid) . Node.group)
                                 (Container.elems nl'')) gni
967

968
969
970
971
972
973
974
975
976
977
testSuite "Cluster"
              [ 'prop_Score_Zero
              , 'prop_CStats_sane
              , 'prop_ClusterAlloc_sane
              , 'prop_ClusterCanTieredAlloc
              , 'prop_ClusterAllocEvac
              , 'prop_ClusterAllocBalance
              , 'prop_ClusterCheckConsistency
              , 'prop_ClusterSplitCluster
              ]
Iustin Pop's avatar
Iustin Pop committed
978

979
-- ** OpCodes tests
Iustin Pop's avatar
Iustin Pop committed
980

981
-- | Check that opcode serialization is idempotent.
Iustin Pop's avatar
Iustin Pop committed
982
983
prop_OpCodes_serialization op =
  case J.readJSON (J.showJSON op) of
Iustin Pop's avatar
Iustin Pop committed
984
985
    J.Error e -> printTestCase ("Cannot deserialise: " ++ e) False
    J.Ok op' -> op ==? op'
986
  where _types = op::OpCodes.OpCode
Iustin Pop's avatar
Iustin Pop committed
987