QC.hs 37.1 KB
Newer Older
1
{-| Unittests for ganeti-htools.
Iustin Pop's avatar
Iustin Pop committed
2
3
4
5
6

-}

{-

7
Copyright (C) 2009, 2010, 2011 Google Inc.
Iustin Pop's avatar
Iustin Pop committed
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301, USA.

-}

26
module Ganeti.HTools.QC
27
28
    ( testUtils
    , testPeerMap
29
30
31
32
    , testContainer
    , testInstance
    , testNode
    , testText
Iustin Pop's avatar
Iustin Pop committed
33
    , testOpCodes
34
    , testJobs
35
    , testCluster
Iustin Pop's avatar
Iustin Pop committed
36
    , testLoader
37
    , testTypes
38
    ) where
39
40

import Test.QuickCheck
Iustin Pop's avatar
Iustin Pop committed
41
import Data.List (findIndex, intercalate, nub, isPrefixOf)
42
import Data.Maybe
Iustin Pop's avatar
Iustin Pop committed
43
44
import Control.Monad
import qualified Text.JSON as J
Iustin Pop's avatar
Iustin Pop committed
45
import qualified Data.Map
46
import qualified Data.IntMap as IntMap
Iustin Pop's avatar
Iustin Pop committed
47
import qualified Ganeti.OpCodes as OpCodes
48
import qualified Ganeti.Jobs as Jobs
Iustin Pop's avatar
Iustin Pop committed
49
import qualified Ganeti.Luxi
50
51
52
import qualified Ganeti.HTools.CLI as CLI
import qualified Ganeti.HTools.Cluster as Cluster
import qualified Ganeti.HTools.Container as Container
Iustin Pop's avatar
Iustin Pop committed
53
import qualified Ganeti.HTools.ExtLoader
54
55
56
import qualified Ganeti.HTools.IAlloc as IAlloc
import qualified Ganeti.HTools.Instance as Instance
import qualified Ganeti.HTools.Loader as Loader
Iustin Pop's avatar
Iustin Pop committed
57
import qualified Ganeti.HTools.Luxi
58
import qualified Ganeti.HTools.Node as Node
Iustin Pop's avatar
Iustin Pop committed
59
import qualified Ganeti.HTools.Group as Group
60
import qualified Ganeti.HTools.PeerMap as PeerMap
61
import qualified Ganeti.HTools.Rapi
Iustin Pop's avatar
Iustin Pop committed
62
import qualified Ganeti.HTools.Simu
63
64
65
import qualified Ganeti.HTools.Text as Text
import qualified Ganeti.HTools.Types as Types
import qualified Ganeti.HTools.Utils as Utils
Iustin Pop's avatar
Iustin Pop committed
66
import qualified Ganeti.HTools.Version
67
import qualified Ganeti.Constants as C
68

Iustin Pop's avatar
Iustin Pop committed
69
70
71
run :: Testable prop => prop -> Args -> IO Result
run = flip quickCheckWithResult

72
73
-- * Constants

74
-- | Maximum memory (1TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
75
76
77
maxMem :: Int
maxMem = 1024 * 1024

78
-- | Maximum disk (8TiB, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
79
maxDsk :: Int
Iustin Pop's avatar
Iustin Pop committed
80
maxDsk = 1024 * 1024 * 8
Iustin Pop's avatar
Iustin Pop committed
81

82
-- | Max CPUs (1024, somewhat random value).
Iustin Pop's avatar
Iustin Pop committed
83
84
85
maxCpu :: Int
maxCpu = 1024

Iustin Pop's avatar
Iustin Pop committed
86
87
88
89
90
91
defGroup :: Group.Group
defGroup = flip Group.setIdx 0 $
               Group.create "default" Utils.defaultGroupID
                    Types.AllocPreferred

defGroupList :: Group.List
Iustin Pop's avatar
Iustin Pop committed
92
defGroupList = Container.fromList [(Group.idx defGroup, defGroup)]
Iustin Pop's avatar
Iustin Pop committed
93
94
95
96

defGroupAssoc :: Data.Map.Map String Types.Gdx
defGroupAssoc = Data.Map.singleton (Group.uuid defGroup) (Group.idx defGroup)

97
98
-- * Helper functions

99
-- | Simple checker for whether OpResult is fail or pass.
Iustin Pop's avatar
Iustin Pop committed
100
101
102
103
isFailure :: Types.OpResult a -> Bool
isFailure (Types.OpFail _) = True
isFailure _ = False

104
-- | Update an instance to be smaller than a node.
105
setInstanceSmallerThanNode node inst =
106
107
108
    inst { Instance.mem = Node.availMem node `div` 2
         , Instance.dsk = Node.availDisk node `div` 2
         , Instance.vcpus = Node.availCpu node `div` 2
109
110
         }

111
-- | Create an instance given its spec.
112
createInstance mem dsk vcpus =
113
    Instance.create "inst-unnamed" mem dsk vcpus "running" [] True (-1) (-1)
114
                    Types.DTDrbd8
115

116
-- | Create a small cluster by repeating a node spec.
117
118
119
120
121
makeSmallCluster :: Node.Node -> Int -> Node.List
makeSmallCluster node count =
    let fn = Node.buildPeers node Container.empty
        namelst = map (\n -> (Node.name n, n)) (replicate count fn)
        (_, nlst) = Loader.assignIndices namelst
122
    in nlst
123

124
-- | Checks if a node is "big" enough.
125
126
127
128
129
isNodeBig :: Node.Node -> Int -> Bool
isNodeBig node size = Node.availDisk node > size * Types.unitDsk
                      && Node.availMem node > size * Types.unitMem
                      && Node.availCpu node > size * Types.unitCpu

130
131
canBalance :: Cluster.Table -> Bool -> Bool -> Bool -> Bool
canBalance tbl dm im evac = isJust $ Cluster.tryBalance tbl dm im evac 0 0
132

133
-- | Assigns a new fresh instance to a cluster; this is not
134
-- allocation, so no resource checks are done.
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
assignInstance :: Node.List -> Instance.List -> Instance.Instance ->
                  Types.Idx -> Types.Idx ->
                  (Node.List, Instance.List)
assignInstance nl il inst pdx sdx =
  let pnode = Container.find pdx nl
      snode = Container.find sdx nl
      maxiidx = if Container.null il
                then 0
                else fst (Container.findMax il) + 1
      inst' = inst { Instance.idx = maxiidx,
                     Instance.pNode = pdx, Instance.sNode = sdx }
      pnode' = Node.setPri pnode inst'
      snode' = Node.setSec snode inst'
      nl' = Container.addTwo pdx pnode' sdx snode' nl
      il' = Container.add maxiidx inst' il
  in (nl', il')

152
153
-- * Arbitrary instances

154
-- | Defines a DNS name.
155
newtype DNSChar = DNSChar { dnsGetChar::Char }
156

157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
instance Arbitrary DNSChar where
    arbitrary = do
      x <- elements (['a'..'z'] ++ ['0'..'9'] ++ "_-")
      return (DNSChar x)

getName :: Gen String
getName = do
  n <- choose (1, 64)
  dn <- vector n::Gen [DNSChar]
  return (map dnsGetChar dn)


getFQDN :: Gen String
getFQDN = do
  felem <- getName
  ncomps <- choose (1, 4)
  frest <- vector ncomps::Gen [[DNSChar]]
  let frest' = map (map dnsGetChar) frest
  return (felem ++ "." ++ intercalate "." frest')

177
178
179
-- let's generate a random instance
instance Arbitrary Instance.Instance where
    arbitrary = do
180
      name <- getFQDN
Iustin Pop's avatar
Iustin Pop committed
181
182
      mem <- choose (0, maxMem)
      dsk <- choose (0, maxDsk)
183
184
185
186
187
188
189
190
      run_st <- elements [ C.inststErrorup
                         , C.inststErrordown
                         , C.inststAdmindown
                         , C.inststNodedown
                         , C.inststNodeoffline
                         , C.inststRunning
                         , "no_such_status1"
                         , "no_such_status2"]
191
192
      pn <- arbitrary
      sn <- arbitrary
Iustin Pop's avatar
Iustin Pop committed
193
      vcpus <- choose (0, maxCpu)
194
      return $ Instance.create name mem dsk vcpus run_st [] True pn sn
195
                               Types.DTDrbd8
196

197
198
199
200
201
-- | Generas an arbitrary node based on sizing information.
genNode :: Maybe Int -- ^ Minimum node size in terms of units
        -> Maybe Int -- ^ Maximum node size (when Nothing, bounded
                     -- just by the max... constants)
        -> Gen Node.Node
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
genNode min_multiplier max_multiplier = do
  let (base_mem, base_dsk, base_cpu) =
          case min_multiplier of
            Just mm -> (mm * Types.unitMem,
                        mm * Types.unitDsk,
                        mm * Types.unitCpu)
            Nothing -> (0, 0, 0)
      (top_mem, top_dsk, top_cpu)  =
          case max_multiplier of
            Just mm -> (mm * Types.unitMem,
                        mm * Types.unitDsk,
                        mm * Types.unitCpu)
            Nothing -> (maxMem, maxDsk, maxCpu)
  name  <- getFQDN
  mem_t <- choose (base_mem, top_mem)
  mem_f <- choose (base_mem, mem_t)
  mem_n <- choose (0, mem_t - mem_f)
  dsk_t <- choose (base_dsk, top_dsk)
  dsk_f <- choose (base_dsk, dsk_t)
  cpu_t <- choose (base_cpu, top_cpu)
  offl  <- arbitrary
  let n = Node.create name (fromIntegral mem_t) mem_n mem_f
          (fromIntegral dsk_t) dsk_f (fromIntegral cpu_t) offl 0
  return $ Node.buildPeers n Container.empty

227
228
-- and a random node
instance Arbitrary Node.Node where
229
    arbitrary = genNode Nothing Nothing
230

Iustin Pop's avatar
Iustin Pop committed
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
-- replace disks
instance Arbitrary OpCodes.ReplaceDisksMode where
  arbitrary = elements [ OpCodes.ReplaceOnPrimary
                       , OpCodes.ReplaceOnSecondary
                       , OpCodes.ReplaceNewSecondary
                       , OpCodes.ReplaceAuto
                       ]

instance Arbitrary OpCodes.OpCode where
  arbitrary = do
    op_id <- elements [ "OP_TEST_DELAY"
                      , "OP_INSTANCE_REPLACE_DISKS"
                      , "OP_INSTANCE_FAILOVER"
                      , "OP_INSTANCE_MIGRATE"
                      ]
    (case op_id of
        "OP_TEST_DELAY" ->
          liftM3 OpCodes.OpTestDelay arbitrary arbitrary arbitrary
        "OP_INSTANCE_REPLACE_DISKS" ->
250
          liftM5 OpCodes.OpInstanceReplaceDisks arbitrary arbitrary
Iustin Pop's avatar
Iustin Pop committed
251
252
          arbitrary arbitrary arbitrary
        "OP_INSTANCE_FAILOVER" ->
253
          liftM2 OpCodes.OpInstanceFailover arbitrary arbitrary
Iustin Pop's avatar
Iustin Pop committed
254
        "OP_INSTANCE_MIGRATE" ->
255
          liftM4 OpCodes.OpInstanceMigrate arbitrary arbitrary arbitrary
256
          arbitrary
Iustin Pop's avatar
Iustin Pop committed
257
258
        _ -> fail "Wrong opcode")

259
260
261
262
263
264
instance Arbitrary Jobs.OpStatus where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Jobs.JobStatus where
  arbitrary = elements [minBound..maxBound]

265
266
267
268
269
270
newtype SmallRatio = SmallRatio Double deriving Show
instance Arbitrary SmallRatio where
    arbitrary = do
      v <- choose (0, 1)
      return $ SmallRatio v

271
272
273
274
275
276
instance Arbitrary Types.AllocPolicy where
  arbitrary = elements [minBound..maxBound]

instance Arbitrary Types.DiskTemplate where
  arbitrary = elements [minBound..maxBound]

277
-- * Actual tests
Iustin Pop's avatar
Iustin Pop committed
278

279
280
281
282
-- ** Utils tests

-- | If the list is not just an empty element, and if the elements do
-- not contain commas, then join+split should be idempotent.
Iustin Pop's avatar
Iustin Pop committed
283
284
285
286
287
prop_Utils_commaJoinSplit =
    forAll (arbitrary `suchThat`
            (\l -> l /= [""] && all (not . elem ',') l )) $ \lst ->
    Utils.sepSplit ',' (Utils.commaJoin lst) == lst

288
-- | Split and join should always be idempotent.
289
290
prop_Utils_commaSplitJoin s = Utils.commaJoin (Utils.sepSplit ',' s) == s

291
-- | fromObjWithDefault, we test using the Maybe monad and an integer
292
-- value.
293
294
295
296
297
298
prop_Utils_fromObjWithDefault def_value random_key =
    -- a missing key will be returned with the default
    Utils.fromObjWithDefault [] random_key def_value == Just def_value &&
    -- a found key will be returned as is, not with default
    Utils.fromObjWithDefault [(random_key, J.showJSON def_value)]
         random_key (def_value+1) == Just def_value
Iustin Pop's avatar
Iustin Pop committed
299
        where _types = def_value :: Integer
300

301
302
303
304
-- | Test that functional if' behaves like the syntactic sugar if.
prop_Utils_if'if :: Bool -> Int -> Int -> Bool
prop_Utils_if'if cnd a b = Utils.if' cnd a b == if cnd then a else b

Guido Trotter's avatar
Guido Trotter committed
305
-- | Test basic select functionality
306
307
308
309
prop_Utils_select :: Int   -- ^ Default result
                  -> [Int] -- ^ List of False values
                  -> [Int] -- ^ List of True values
                  -> Bool  -- ^ Test result
Guido Trotter's avatar
Guido Trotter committed
310
prop_Utils_select def lst1 lst2 =
311
  Utils.select def cndlist == expectedresult
Guido Trotter's avatar
Guido Trotter committed
312
  where expectedresult = Utils.if' (null lst2) def (head lst2)
313
314
        flist = map (\e -> (False, e)) lst1
        tlist = map (\e -> (True, e)) lst2
Guido Trotter's avatar
Guido Trotter committed
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
        cndlist = flist ++ tlist

-- | Test basic select functionality with undefined default
prop_Utils_select_undefd :: [Int] -- ^ List of False values
                         -> NonEmptyList Int -- ^ List of True values
                         -> Bool  -- ^ Test result
prop_Utils_select_undefd lst1 (NonEmpty lst2) =
  Utils.select undefined cndlist == head lst2
  where flist = map (\e -> (False, e)) lst1
        tlist = map (\e -> (True, e)) lst2
        cndlist = flist ++ tlist

-- | Test basic select functionality with undefined list values
prop_Utils_select_undefv :: [Int] -- ^ List of False values
                         -> NonEmptyList Int -- ^ List of True values
                         -> Bool  -- ^ Test result
prop_Utils_select_undefv lst1 (NonEmpty lst2) =
  Utils.select undefined cndlist == head lst2
  where flist = map (\e -> (False, e)) lst1
        tlist = map (\e -> (True, e)) lst2
        cndlist = flist ++ tlist ++ [undefined]
336

337
-- | Test list for the Utils module.
338
339
340
testUtils =
  [ run prop_Utils_commaJoinSplit
  , run prop_Utils_commaSplitJoin
341
  , run prop_Utils_fromObjWithDefault
342
343
  , run prop_Utils_if'if
  , run prop_Utils_select
Guido Trotter's avatar
Guido Trotter committed
344
345
  , run prop_Utils_select_undefd
  , run prop_Utils_select_undefv
346
347
  ]

348
349
350
-- ** PeerMap tests

-- | Make sure add is idempotent.
Iustin Pop's avatar
Iustin Pop committed
351
prop_PeerMap_addIdempotent pmap key em =
352
    fn puniq == fn (fn puniq)
353
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
354
355
                    key::PeerMap.Key, em::PeerMap.Elem)
          fn = PeerMap.add key em
356
          puniq = PeerMap.accumArray const pmap
357

358
-- | Make sure remove is idempotent.
359
360
prop_PeerMap_removeIdempotent pmap key =
    fn puniq == fn (fn puniq)
361
362
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
          fn = PeerMap.remove key
363
364
          puniq = PeerMap.accumArray const pmap

365
-- | Make sure a missing item returns 0.
366
367
prop_PeerMap_findMissing pmap key =
    PeerMap.find key (PeerMap.remove key puniq) == 0
368
    where _types = (pmap::PeerMap.PeerMap, key::PeerMap.Key)
369
370
          puniq = PeerMap.accumArray const pmap

371
-- | Make sure an added item is found.
Iustin Pop's avatar
Iustin Pop committed
372
373
prop_PeerMap_addFind pmap key em =
    PeerMap.find key (PeerMap.add key em puniq) == em
374
    where _types = (pmap::PeerMap.PeerMap,
Iustin Pop's avatar
Iustin Pop committed
375
                    key::PeerMap.Key, em::PeerMap.Elem)
376
          puniq = PeerMap.accumArray const pmap
377

378
-- | Manual check that maxElem returns the maximum indeed, or 0 for null.
379
380
381
prop_PeerMap_maxElem pmap =
    PeerMap.maxElem puniq == if null puniq then 0
                             else (maximum . snd . unzip) puniq
382
    where _types = pmap::PeerMap.PeerMap
383
384
          puniq = PeerMap.accumArray const pmap

385
-- | List of tests for the PeerMap module.
386
testPeerMap =
387
388
389
390
391
392
393
    [ run prop_PeerMap_addIdempotent
    , run prop_PeerMap_removeIdempotent
    , run prop_PeerMap_maxElem
    , run prop_PeerMap_addFind
    , run prop_PeerMap_findMissing
    ]

394
-- ** Container tests
395
396
397
398
399
400
401
402
403

prop_Container_addTwo cdata i1 i2 =
    fn i1 i2 cont == fn i2 i1 cont &&
       fn i1 i2 cont == fn i1 i2 (fn i1 i2 cont)
    where _types = (cdata::[Int],
                    i1::Int, i2::Int)
          cont = foldl (\c x -> Container.add x x c) Container.empty cdata
          fn x1 x2 = Container.addTwo x1 x1 x2 x2

404
405
406
407
408
prop_Container_nameOf node =
  let nl = makeSmallCluster node 1
      fnode = head (Container.elems nl)
  in Container.nameOf nl (Node.idx fnode) == Node.name fnode

409
-- | We test that in a cluster, given a random node, we can find it by
410
-- its name and alias, as long as all names and aliases are unique,
411
-- and that we fail to find a non-existing name.
412
413
414
415
416
417
418
419
420
421
422
423
424
prop_Container_findByName node othername =
  forAll (choose (1, 20)) $ \ cnt ->
  forAll (choose (0, cnt - 1)) $ \ fidx ->
  forAll (vector cnt) $ \ names ->
  (length . nub) (map fst names ++ map snd names) ==
  length names * 2 &&
  not (othername `elem` (map fst names ++ map snd names)) ==>
  let nl = makeSmallCluster node cnt
      nodes = Container.elems nl
      nodes' = map (\((name, alias), nn) -> (Node.idx nn,
                                             nn { Node.name = name,
                                                  Node.alias = alias }))
               $ zip names nodes
Iustin Pop's avatar
Iustin Pop committed
425
      nl' = Container.fromList nodes'
426
427
428
429
430
      target = snd (nodes' !! fidx)
  in Container.findByName nl' (Node.name target) == Just target &&
     Container.findByName nl' (Node.alias target) == Just target &&
     Container.findByName nl' othername == Nothing

431
testContainer =
432
433
434
435
    [ run prop_Container_addTwo
    , run prop_Container_nameOf
    , run prop_Container_findByName
    ]
436

437
438
-- ** Instance tests

439
440
-- Simple instance tests, we only have setter/getters

Iustin Pop's avatar
Iustin Pop committed
441
442
443
prop_Instance_creat inst =
    Instance.name inst == Instance.alias inst

444
445
446
447
448
prop_Instance_setIdx inst idx =
    Instance.idx (Instance.setIdx inst idx) == idx
    where _types = (inst::Instance.Instance, idx::Types.Idx)

prop_Instance_setName inst name =
Iustin Pop's avatar
Iustin Pop committed
449
450
451
452
453
454
455
456
    Instance.name newinst == name &&
    Instance.alias newinst == name
    where _types = (inst::Instance.Instance, name::String)
          newinst = Instance.setName inst name

prop_Instance_setAlias inst name =
    Instance.name newinst == Instance.name inst &&
    Instance.alias newinst == name
457
    where _types = (inst::Instance.Instance, name::String)
Iustin Pop's avatar
Iustin Pop committed
458
          newinst = Instance.setAlias inst name
459
460

prop_Instance_setPri inst pdx =
461
    Instance.pNode (Instance.setPri inst pdx) == pdx
462
463
464
    where _types = (inst::Instance.Instance, pdx::Types.Ndx)

prop_Instance_setSec inst sdx =
465
    Instance.sNode (Instance.setSec inst sdx) == sdx
466
467
468
    where _types = (inst::Instance.Instance, sdx::Types.Ndx)

prop_Instance_setBoth inst pdx sdx =
469
    Instance.pNode si == pdx && Instance.sNode si == sdx
470
471
472
    where _types = (inst::Instance.Instance, pdx::Types.Ndx, sdx::Types.Ndx)
          si = Instance.setBoth inst pdx sdx

Iustin Pop's avatar
Iustin Pop committed
473
474
475
476
prop_Instance_runStatus_True =
    forAll (arbitrary `suchThat`
            ((`elem` Instance.runningStates) . Instance.runSt))
    Instance.running
Iustin Pop's avatar
Iustin Pop committed
477
478
479

prop_Instance_runStatus_False inst =
    let run_st = Instance.running inst
480
        run_tx = Instance.runSt inst
Iustin Pop's avatar
Iustin Pop committed
481
    in
482
      run_tx `notElem` Instance.runningStates ==> not run_st
Iustin Pop's avatar
Iustin Pop committed
483

Iustin Pop's avatar
Iustin Pop committed
484
485
486
487
488
489
490
491
prop_Instance_shrinkMG inst =
    Instance.mem inst >= 2 * Types.unitMem ==>
        case Instance.shrinkByType inst Types.FailMem of
          Types.Ok inst' ->
              Instance.mem inst' == Instance.mem inst - Types.unitMem
          _ -> False

prop_Instance_shrinkMF inst =
Iustin Pop's avatar
Iustin Pop committed
492
493
494
    forAll (choose (0, 2 * Types.unitMem - 1)) $ \mem ->
    let inst' = inst { Instance.mem = mem}
    in Types.isBad $ Instance.shrinkByType inst' Types.FailMem
Iustin Pop's avatar
Iustin Pop committed
495
496
497
498
499
500
501
502
503

prop_Instance_shrinkCG inst =
    Instance.vcpus inst >= 2 * Types.unitCpu ==>
        case Instance.shrinkByType inst Types.FailCPU of
          Types.Ok inst' ->
              Instance.vcpus inst' == Instance.vcpus inst - Types.unitCpu
          _ -> False

prop_Instance_shrinkCF inst =
Iustin Pop's avatar
Iustin Pop committed
504
505
506
    forAll (choose (0, 2 * Types.unitCpu - 1)) $ \vcpus ->
    let inst' = inst { Instance.vcpus = vcpus }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailCPU
Iustin Pop's avatar
Iustin Pop committed
507
508
509
510
511
512
513
514
515

prop_Instance_shrinkDG inst =
    Instance.dsk inst >= 2 * Types.unitDsk ==>
        case Instance.shrinkByType inst Types.FailDisk of
          Types.Ok inst' ->
              Instance.dsk inst' == Instance.dsk inst - Types.unitDsk
          _ -> False

prop_Instance_shrinkDF inst =
Iustin Pop's avatar
Iustin Pop committed
516
517
518
    forAll (choose (0, 2 * Types.unitDsk - 1)) $ \dsk ->
    let inst' = inst { Instance.dsk = dsk }
    in Types.isBad $ Instance.shrinkByType inst' Types.FailDisk
Iustin Pop's avatar
Iustin Pop committed
519
520
521

prop_Instance_setMovable inst m =
    Instance.movable inst' == m
522
    where inst' = Instance.setMovable inst m
Iustin Pop's avatar
Iustin Pop committed
523

524
testInstance =
Iustin Pop's avatar
Iustin Pop committed
525
526
    [ run prop_Instance_creat
    , run prop_Instance_setIdx
527
    , run prop_Instance_setName
Iustin Pop's avatar
Iustin Pop committed
528
    , run prop_Instance_setAlias
529
530
531
    , run prop_Instance_setPri
    , run prop_Instance_setSec
    , run prop_Instance_setBoth
Iustin Pop's avatar
Iustin Pop committed
532
533
    , run prop_Instance_runStatus_True
    , run prop_Instance_runStatus_False
Iustin Pop's avatar
Iustin Pop committed
534
535
536
537
538
539
540
    , run prop_Instance_shrinkMG
    , run prop_Instance_shrinkMF
    , run prop_Instance_shrinkCG
    , run prop_Instance_shrinkCF
    , run prop_Instance_shrinkDG
    , run prop_Instance_shrinkDF
    , run prop_Instance_setMovable
Iustin Pop's avatar
Iustin Pop committed
541
542
    ]

543
544
-- ** Text backend tests

Iustin Pop's avatar
Iustin Pop committed
545
546
-- Instance text loader tests

Iustin Pop's avatar
Iustin Pop committed
547
548
prop_Text_Load_Instance name mem dsk vcpus status
                        (NonEmpty pnode) snode
549
                        (NonNegative pdx) (NonNegative sdx) autobal dt =
550
    pnode /= snode && pdx /= sdx ==>
Iustin Pop's avatar
Iustin Pop committed
551
552
553
    let vcpus_s = show vcpus
        dsk_s = show dsk
        mem_s = show mem
Iustin Pop's avatar
Iustin Pop committed
554
555
        ndx = if null snode
              then [(pnode, pdx)]
556
              else [(pnode, pdx), (snode, sdx)]
557
        nl = Data.Map.fromList ndx
558
        tags = ""
Iustin Pop's avatar
Iustin Pop committed
559
        sbal = if autobal then "Y" else "N"
560
        sdt = Types.dtToString dt
561
        inst = Text.loadInst nl
Iustin Pop's avatar
Iustin Pop committed
562
               [name, mem_s, dsk_s, vcpus_s, status,
563
                sbal, pnode, snode, sdt, tags]
564
        fail1 = Text.loadInst nl
Iustin Pop's avatar
Iustin Pop committed
565
               [name, mem_s, dsk_s, vcpus_s, status,
566
                sbal, pnode, pnode, tags]
Iustin Pop's avatar
Iustin Pop committed
567
568
        _types = ( name::String, mem::Int, dsk::Int
                 , vcpus::Int, status::String
Iustin Pop's avatar
Iustin Pop committed
569
                 , snode::String
Iustin Pop's avatar
Iustin Pop committed
570
                 , autobal::Bool)
Iustin Pop's avatar
Iustin Pop committed
571
572
    in
      case inst of
573
574
575
576
        Types.Bad msg -> printTestCase ("Failed to load instance: " ++ msg)
                         False
        Types.Ok (_, i) -> printTestCase ("Mismatch in some field while\
                                          \ loading the instance") $
Iustin Pop's avatar
Iustin Pop committed
577
578
579
580
581
582
            Instance.name i == name &&
            Instance.vcpus i == vcpus &&
            Instance.mem i == mem &&
            Instance.pNode i == pdx &&
            Instance.sNode i == (if null snode
                                 then Node.noSecondary
583
                                 else sdx) &&
584
            Instance.autoBalance i == autobal &&
585
            Types.isBad fail1
Iustin Pop's avatar
Iustin Pop committed
586
587

prop_Text_Load_InstanceFail ktn fields =
588
    length fields /= 10 ==>
Iustin Pop's avatar
Iustin Pop committed
589
    case Text.loadInst nl fields of
590
591
592
593
      Types.Ok _ -> printTestCase "Managed to load instance from invalid\
                                  \ data" False
      Types.Bad msg -> printTestCase ("Unrecognised error message: " ++ msg) $
                       "Invalid/incomplete instance data: '" `isPrefixOf` msg
594
    where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609

prop_Text_Load_Node name tm nm fm td fd tc fo =
    let conv v = if v < 0
                    then "?"
                    else show v
        tm_s = conv tm
        nm_s = conv nm
        fm_s = conv fm
        td_s = conv td
        fd_s = conv fd
        tc_s = conv tc
        fo_s = if fo
               then "Y"
               else "N"
        any_broken = any (< 0) [tm, nm, fm, td, fd, tc]
Iustin Pop's avatar
Iustin Pop committed
610
611
612
        gid = Group.uuid defGroup
    in case Text.loadNode defGroupAssoc
           [name, tm_s, nm_s, fm_s, td_s, fd_s, tc_s, fo_s, gid] of
Iustin Pop's avatar
Iustin Pop committed
613
614
615
616
         Nothing -> False
         Just (name', node) ->
             if fo || any_broken
             then Node.offline node
617
618
619
620
621
622
623
624
             else Node.name node == name' && name' == name &&
                  Node.alias node == name &&
                  Node.tMem node == fromIntegral tm &&
                  Node.nMem node == nm &&
                  Node.fMem node == fm &&
                  Node.tDsk node == fromIntegral td &&
                  Node.fDsk node == fd &&
                  Node.tCpu node == fromIntegral tc
Iustin Pop's avatar
Iustin Pop committed
625
626

prop_Text_Load_NodeFail fields =
Iustin Pop's avatar
Iustin Pop committed
627
    length fields /= 8 ==> isNothing $ Text.loadNode Data.Map.empty fields
Iustin Pop's avatar
Iustin Pop committed
628

629
prop_Text_NodeLSIdempotent node =
Iustin Pop's avatar
Iustin Pop committed
630
631
    (Text.loadNode defGroupAssoc.
         Utils.sepSplit '|' . Text.serializeNode defGroupList) n ==
632
633
634
635
    Just (Node.name n, n)
    -- override failN1 to what loadNode returns by default
    where n = node { Node.failN1 = True, Node.offline = False }

636
testText =
Iustin Pop's avatar
Iustin Pop committed
637
    [ run prop_Text_Load_Instance
Iustin Pop's avatar
Iustin Pop committed
638
639
640
    , run prop_Text_Load_InstanceFail
    , run prop_Text_Load_Node
    , run prop_Text_Load_NodeFail
641
    , run prop_Text_NodeLSIdempotent
642
643
    ]

644
-- ** Node tests
645

Iustin Pop's avatar
Iustin Pop committed
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
prop_Node_setAlias node name =
    Node.name newnode == Node.name node &&
    Node.alias newnode == name
    where _types = (node::Node.Node, name::String)
          newnode = Node.setAlias node name

prop_Node_setOffline node status =
    Node.offline newnode == status
    where newnode = Node.setOffline node status

prop_Node_setXmem node xm =
    Node.xMem newnode == xm
    where newnode = Node.setXmem node xm

prop_Node_setMcpu node mc =
    Node.mCpu newnode == mc
    where newnode = Node.setMcpu node mc

664
665
-- | Check that an instance add with too high memory or disk will be
-- rejected.
Iustin Pop's avatar
Iustin Pop committed
666
667
668
669
670
671
prop_Node_addPriFM node inst = Instance.mem inst >= Node.fMem node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailMem -> True
                                 _ -> False
672
    where _types = (node::Node.Node, inst::Instance.Instance)
Iustin Pop's avatar
Iustin Pop committed
673
674
675
676
677
678
679
680
681
682
683
684
685
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.mem = Instance.mem inst }

prop_Node_addPriFD node inst = Instance.dsk inst >= Node.fDsk node &&
                               not (Node.failN1 node)
                               ==>
                               case Node.addPri node inst'' of
                                 Types.OpFail Types.FailDisk -> True
                                 _ -> False
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
          inst'' = inst' { Instance.dsk = Instance.dsk inst }

Iustin Pop's avatar
Iustin Pop committed
686
687
688
689
690
prop_Node_addPriFC node inst (Positive extra) =
    not (Node.failN1 node) ==>
        case Node.addPri node inst'' of
          Types.OpFail Types.FailCPU -> True
          _ -> False
Iustin Pop's avatar
Iustin Pop committed
691
692
    where _types = (node::Node.Node, inst::Instance.Instance)
          inst' = setInstanceSmallerThanNode node inst
Iustin Pop's avatar
Iustin Pop committed
693
          inst'' = inst' { Instance.vcpus = Node.availCpu node + extra }
694

695
696
-- | Check that an instance add with too high memory or disk will be
-- rejected.
697
prop_Node_addSec node inst pdx =
698
699
    (Instance.mem inst >= (Node.fMem node - Node.rMem node) ||
     Instance.dsk inst >= Node.fDsk node) &&
Iustin Pop's avatar
Iustin Pop committed
700
    not (Node.failN1 node)
Iustin Pop's avatar
Iustin Pop committed
701
    ==> isFailure (Node.addSec node inst pdx)
702
        where _types = (node::Node.Node, inst::Instance.Instance, pdx::Int)
703

704
-- | Checks for memory reservation changes.
705
706
prop_Node_rMem inst =
    forAll (arbitrary `suchThat` ((> 0) . Node.fMem)) $ \node ->
707
708
    -- ab = auto_balance, nb = non-auto_balance
    -- we use -1 as the primary node of the instance
709
    let inst' = inst { Instance.pNode = -1, Instance.autoBalance = True }
710
        inst_ab = setInstanceSmallerThanNode node inst'
711
        inst_nb = inst_ab { Instance.autoBalance = False }
712
        -- now we have the two instances, identical except the
713
        -- autoBalance attribute
714
715
716
717
718
719
720
721
722
        orig_rmem = Node.rMem node
        inst_idx = Instance.idx inst_ab
        node_add_ab = Node.addSec node inst_ab (-1)
        node_add_nb = Node.addSec node inst_nb (-1)
        node_del_ab = liftM (flip Node.removeSec inst_ab) node_add_ab
        node_del_nb = liftM (flip Node.removeSec inst_nb) node_add_nb
    in case (node_add_ab, node_add_nb, node_del_ab, node_del_nb) of
         (Types.OpGood a_ab, Types.OpGood a_nb,
          Types.OpGood d_ab, Types.OpGood d_nb) ->
723
             printTestCase "Consistency checks failed" $
724
725
726
727
728
729
730
731
732
             Node.rMem a_ab >  orig_rmem &&
             Node.rMem a_ab - orig_rmem == Instance.mem inst_ab &&
             Node.rMem a_nb == orig_rmem &&
             Node.rMem d_ab == orig_rmem &&
             Node.rMem d_nb == orig_rmem &&
             -- this is not related to rMem, but as good a place to
             -- test as any
             inst_idx `elem` Node.sList a_ab &&
             not (inst_idx `elem` Node.sList d_ab)
733
734
         x -> printTestCase ("Failed to add/remove instances: " ++ show x)
              False
735

736
-- | Check mdsk setting.
Iustin Pop's avatar
Iustin Pop committed
737
738
739
740
741
prop_Node_setMdsk node mx =
    Node.loDsk node' >= 0 &&
    fromIntegral (Node.loDsk node') <= Node.tDsk node &&
    Node.availDisk node' >= 0 &&
    Node.availDisk node' <= Node.fDsk node' &&
Iustin Pop's avatar
Iustin Pop committed
742
743
    fromIntegral (Node.availDisk node') <= Node.tDsk node' &&
    Node.mDsk node' == mx'
Iustin Pop's avatar
Iustin Pop committed
744
745
746
747
748
749
750
    where _types = (node::Node.Node, mx::SmallRatio)
          node' = Node.setMdsk node mx'
          SmallRatio mx' = mx

-- Check tag maps
prop_Node_tagMaps_idempotent tags =
    Node.delTags (Node.addTags m tags) tags == m
751
    where m = Data.Map.empty
Iustin Pop's avatar
Iustin Pop committed
752
753
754
755

prop_Node_tagMaps_reject tags =
    not (null tags) ==>
    any (\t -> Node.rejectAddTags m [t]) tags
756
    where m = Node.addTags Data.Map.empty tags
Iustin Pop's avatar
Iustin Pop committed
757

Iustin Pop's avatar
Iustin Pop committed
758
759
760
761
762
prop_Node_showField node =
  forAll (elements Node.defaultFields) $ \ field ->
  fst (Node.showHeader field) /= Types.unknownField &&
  Node.showField node field /= Types.unknownField

763
764
765
766
767
768
769

prop_Node_computeGroups nodes =
  let ng = Node.computeGroups nodes
      onlyuuid = map fst ng
  in length nodes == sum (map (length . snd) ng) &&
     all (\(guuid, ns) -> all ((== guuid) . Node.group) ns) ng &&
     length (nub onlyuuid) == length onlyuuid &&
Iustin Pop's avatar
Iustin Pop committed
770
     (null nodes || not (null ng))
771

772
testNode =
Iustin Pop's avatar
Iustin Pop committed
773
774
775
776
777
    [ run prop_Node_setAlias
    , run prop_Node_setOffline
    , run prop_Node_setMcpu
    , run prop_Node_setXmem
    , run prop_Node_addPriFM
Iustin Pop's avatar
Iustin Pop committed
778
779
    , run prop_Node_addPriFD
    , run prop_Node_addPriFC
780
    , run prop_Node_addSec
781
    , run prop_Node_rMem
Iustin Pop's avatar
Iustin Pop committed
782
783
784
    , run prop_Node_setMdsk
    , run prop_Node_tagMaps_idempotent
    , run prop_Node_tagMaps_reject
Iustin Pop's avatar
Iustin Pop committed
785
    , run prop_Node_showField
786
    , run prop_Node_computeGroups
787
    ]
788
789


790
-- ** Cluster tests
791

792
793
-- | Check that the cluster score is close to zero for a homogeneous
-- cluster.
Iustin Pop's avatar
Iustin Pop committed
794
795
prop_Score_Zero node =
    forAll (choose (1, 1024)) $ \count ->
Iustin Pop's avatar
Iustin Pop committed
796
    (not (Node.offline node) && not (Node.failN1 node) && (count > 0) &&
797
     (Node.tDsk node > 0) && (Node.tMem node > 0)) ==>
798
    let fn = Node.buildPeers node Container.empty
Iustin Pop's avatar
Iustin Pop committed
799
        nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
Iustin Pop's avatar
Iustin Pop committed
800
        nl = Container.fromList nlst
801
802
803
        score = Cluster.compCV nl
    -- we can't say == 0 here as the floating point errors accumulate;
    -- this should be much lower than the default score in CLI.hs
Iustin Pop's avatar
Iustin Pop committed
804
    in score <= 1e-12
805

806
-- | Check that cluster stats are sane.
Iustin Pop's avatar
Iustin Pop committed
807
808
809
prop_CStats_sane node =
    forAll (choose (1, 1024)) $ \count ->
    (not (Node.offline node) && not (Node.failN1 node) &&
810
     (Node.availDisk node > 0) && (Node.availMem node > 0)) ==>
Iustin Pop's avatar
Iustin Pop committed
811
812
    let fn = Node.buildPeers node Container.empty
        nlst = zip [1..] $ replicate count fn::[(Types.Ndx, Node.Node)]
Iustin Pop's avatar
Iustin Pop committed
813
        nl = Container.fromList nlst
Iustin Pop's avatar
Iustin Pop committed
814
815
816
817
        cstats = Cluster.totalResources nl
    in Cluster.csAdsk cstats >= 0 &&
       Cluster.csAdsk cstats <= Cluster.csFdsk cstats

818
-- | Check that one instance is allocated correctly, without
819
-- rebalances needed.
820
821
822
823
824
825
826
827
828
829
prop_ClusterAlloc_sane node inst =
    forAll (choose (5, 20)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && Node.availDisk node > 0
            && Node.availMem node > 0
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
830
831
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
832
         Types.Bad _ -> False
833
834
         Types.Ok as ->
             case Cluster.asSolutions as of
835
               [] -> False
836
               (xnl, xi, _, cv):[] ->
837
                   let il' = Container.add (Instance.idx xi) xi il
838
                       tbl = Cluster.Table xnl il' cv []
839
                   in not (canBalance tbl True True False)
840
841
842
843
               _ -> False

-- | Checks that on a 2-5 node cluster, we can allocate a random
-- instance spec via tiered allocation (whatever the original instance
844
-- spec), on either one or two nodes.
845
846
847
848
849
850
851
852
853
prop_ClusterCanTieredAlloc node inst =
    forAll (choose (2, 5)) $ \count ->
    forAll (choose (1, 2)) $ \rqnodes ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
854
        allocnodes = Cluster.genAllocNodes defGroupList nl rqnodes True
Iustin Pop's avatar
Iustin Pop committed
855
856
    in case allocnodes >>= \allocnodes' ->
        Cluster.tieredAlloc nl il inst allocnodes' [] [] of
857
         Types.Bad _ -> False
858
859
860
         Types.Ok (_, _, il', ixes, cstats) -> not (null ixes) &&
                                      IntMap.size il' == length ixes &&
                                      length ixes == length cstats
861
862

-- | Checks that on a 4-8 node cluster, once we allocate an instance,
863
-- we can also evacuate it.
864
865
866
867
868
869
870
871
872
prop_ClusterAllocEvac node inst =
    forAll (choose (4, 8)) $ \count ->
    not (Node.offline node)
            && not (Node.failN1 node)
            && isNodeBig node 4
            ==>
    let nl = makeSmallCluster node count
        il = Container.empty
        inst' = setInstanceSmallerThanNode node inst
873
874
    in case Cluster.genAllocNodes defGroupList nl 2 True >>=
       Cluster.tryAlloc nl il inst' of
875
         Types.Bad _ -> False
876
877
         Types.Ok as ->
             case Cluster.asSolutions as of
878
               [] -> False
879
               (xnl, xi, _, _):[] ->
880
881
                   let sdx = Instance.sNode xi
                       il' = Container.add (Instance.idx xi) xi il
882
                   in case Cluster.tryEvac xnl il' [Instance.idx xi] [sdx] of
883
884
885
886
887
                        Just _ -> True
                        _ -> False
               _ -> False

-- | Check that allocating multiple instances on a cluster, then
888
-- adding an empty node, results in a valid rebalance.
889
890
prop_ClusterAllocBalance =
    forAll (genNode (Just 5) (Just 128)) $ \node ->
891
    forAll (choose (3, 5)) $ \count ->
892
    not (Node.offline node) && not (Node.failN1 node) ==>
893
894
895
    let nl = makeSmallCluster node count
        (hnode, nl') = IntMap.deleteFindMax nl
        il = Container.empty
896
        allocnodes = Cluster.genAllocNodes defGroupList nl' 2 True
897
        i_templ = createInstance Types.unitMem Types.unitDsk Types.unitCpu
Iustin Pop's avatar
Iustin Pop committed
898
899
    in case allocnodes >>= \allocnodes' ->
        Cluster.iterateAlloc nl' il i_templ allocnodes' [] [] of
900
         Types.Bad _ -> False
901
         Types.Ok (_, xnl, il', _, _) ->
902
903
904
                   let ynl = Container.add (Node.idx hnode) hnode xnl
                       cv = Cluster.compCV ynl
                       tbl = Cluster.Table ynl il' cv []
905
                   in canBalance tbl True True False
906

907
-- | Checks consistency.
908
909
910
prop_ClusterCheckConsistency node inst =
  let nl = makeSmallCluster node 3
      [node1, node2, node3] = Container.elems nl
Iustin Pop's avatar
Iustin Pop committed
911
      node3' = node3 { Node.group = 1 }
912
913
914
915
      nl' = Container.add (Node.idx node3') node3' nl
      inst1 = Instance.setBoth inst (Node.idx node1) (Node.idx node2)
      inst2 = Instance.setBoth inst (Node.idx node1) Node.noSecondary
      inst3 = Instance.setBoth inst (Node.idx node1) (Node.idx node3)
Iustin Pop's avatar
Iustin Pop committed
916
      ccheck = Cluster.findSplitInstances nl' . Container.fromList
917
918
919
920
  in null (ccheck [(0, inst1)]) &&
     null (ccheck [(0, inst2)]) &&
     (not . null $ ccheck [(0, inst3)])

921
-- | For now, we only test that we don't lose instances during the split.
922
923
924
925
926
927
928
929
930
prop_ClusterSplitCluster node inst =
  forAll (choose (0, 100)) $ \icnt ->
  let nl = makeSmallCluster node 2
      (nl', il') = foldl (\(ns, is) _ -> assignInstance ns is inst 0 1)
                   (nl, Container.empty) [1..icnt]
      gni = Cluster.splitCluster nl' il'
  in sum (map (Container.size . snd . snd) gni) == icnt &&
     all (\(guuid, (nl'', _)) -> all ((== guuid) . Node.group)
                                 (Container.elems nl'')) gni
931

932
testCluster =
933
    [ run prop_Score_Zero
Iustin Pop's avatar
Iustin Pop committed
934
    , run prop_CStats_sane
935
936
937
938
    , run prop_ClusterAlloc_sane
    , run prop_ClusterCanTieredAlloc
    , run prop_ClusterAllocEvac
    , run prop_ClusterAllocBalance
939
    , run prop_ClusterCheckConsistency
940
    , run prop_ClusterSplitCluster
941
    ]
Iustin Pop's avatar
Iustin Pop committed
942

943
-- ** OpCodes tests
Iustin Pop's avatar
Iustin Pop committed
944

945
-- | Check that opcode serialization is idempotent.
Iustin Pop's avatar
Iustin Pop committed
946
947
948
949
prop_OpCodes_serialization op =
  case J.readJSON (J.showJSON op) of
    J.Error _ -> False
    J.Ok op' -> op == op'
950
  where _types = op::OpCodes.OpCode
Iustin Pop's avatar
Iustin Pop committed
951
952
953
954

testOpCodes =
  [ run prop_OpCodes_serialization
  ]
Iustin Pop's avatar
Iustin Pop committed
955

956
957
958
-- ** Jobs tests

-- | Check that (queued) job\/opcode status serialization is idempotent.
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
prop_OpStatus_serialization os =
  case J.readJSON (J.showJSON os) of
    J.Error _ -> False
    J.Ok os' -> os == os'
  where _types = os::Jobs.OpStatus

prop_JobStatus_serialization js =
  case J.readJSON (J.showJSON js) of
    J.Error _ -> False
    J.Ok js' -> js == js'
  where _types = js::Jobs.JobStatus

testJobs =
  [ run prop_OpStatus_serialization
  , run prop_JobStatus_serialization
  ]

976
-- ** Loader tests
Iustin Pop's avatar
Iustin Pop committed
977
978

prop_Loader_lookupNode ktn inst node =
979
980
  Loader.lookupNode nl inst node == Data.Map.lookup node nl
  where nl = Data.Map.fromList ktn
Iustin Pop's avatar
Iustin Pop committed
981
982

prop_Loader_lookupInstance kti inst =
983
984
985
986
987
988
989
990
  Loader.lookupInstance il inst == Data.Map.lookup inst il
  where il = Data.Map.fromList kti

prop_Loader_assignIndices nodes =
  Data.Map.size nassoc == length nodes &&
  Container.size kt == length nodes &&
  (if not (null nodes)
   then maximum (IntMap.keys kt) == length nodes - 1
Iustin Pop's avatar
Iustin Pop committed
991
   else True)
992
  where (nassoc, kt) = Loader.assignIndices (map (\n -> (Node.name n, n)) nodes)
Iustin Pop's avatar
Iustin Pop committed
993
994

-- | Checks that the number of primary instances recorded on the nodes
995
-- is zero.
Iustin Pop's avatar
Iustin Pop committed
996
prop_Loader_mergeData ns =
Iustin Pop's avatar
Iustin Pop committed
997
  let na = Container.fromList $ map (\n -> (Node.idx n, n)) ns
998
  in case Loader.mergeData [] [] [] []
999
         (Loader.emptyCluster {Loader.cdNodes = na}) of
Iustin Pop's avatar
Iustin Pop committed
1000
    Types.Bad _ -> False
1001
    Types.Ok (Loader.ClusterData _ nl il _) ->
Iustin Pop's avatar