check-python-code 1.44 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
#!/bin/bash
#

# Copyright (C) 2009 Google Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
# General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
# 02110-1301, USA.

let problems=0

for script; do
24
  if grep -n -H -F $'\t' "$script"; then
25
26
27
    let ++problems
    echo "Found tabs in $script" >&2
  fi
28

29
  if grep -n -H -E '[[:space:]]$' "$script"; then
30
31
32
33
    let ++problems
    echo "Found end-of-line-whitespace in $script" >&2
  fi

34
35
36
37
38
39
  # FIXME: This will also match "foo.xrange(...)"
  if grep -n -H -E '^[^#]*\<xrange\>' "$script"; then
    let ++problems
    echo "Forbidden function 'xrange' used in $script" >&2
  fi

40
41
42
43
44
45
46
  if [[ "$(wc --max-line-length < "$script")" -gt 80 ]]; then
    let ++problems
    echo "Longest line in $script is longer than 80 characters" >&2
  fi
done

if [[ "$problems" -gt 0 ]]; then
47
  echo "Found $problems problem(s) while checking code." >&2
48
49
  exit 1
fi