mcpu.py 20.1 KB
Newer Older
Iustin Pop's avatar
Iustin Pop committed
1
#
Iustin Pop's avatar
Iustin Pop committed
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
#

# Copyright (C) 2006, 2007 Google Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
# General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
# 02110-1301, USA.


"""Module implementing the logic behind the cluster operations

This module implements the logic for doing operations in the cluster. There
are two kinds of classes defined:
  - logical units, which know how to deal with their specific opcode only
  - the processor, which dispatches the opcodes to their logical units

"""

31
import logging
32
33
import random
import time
Iustin Pop's avatar
Iustin Pop committed
34
35
36
37
38
39

from ganeti import opcodes
from ganeti import constants
from ganeti import errors
from ganeti import rpc
from ganeti import cmdlib
40
from ganeti import locking
Iustin Pop's avatar
Iustin Pop committed
41

42

43
44
45
46
47
48
class _LockAcquireTimeout(Exception):
  """Internal exception to report timeouts on acquiring locks.

  """


49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
def _CalculateLockAttemptTimeouts():
  """Calculate timeouts for lock attempts.

  """
  result = [1.0]

  # Wait for a total of at least 150s before doing a blocking acquire
  while sum(result) < 150.0:
    timeout = (result[-1] * 1.05) ** 1.25

    # Cap timeout at 10 seconds. This gives other jobs a chance to run
    # even if we're still trying to get our locks, before finally moving
    # to a blocking acquire.
    if timeout > 10.0:
      timeout = 10.0

    elif timeout < 0.1:
      # Lower boundary for safety
      timeout = 0.1

    result.append(timeout)

  return result


class _LockAttemptTimeoutStrategy(object):
75
76
77
78
  """Class with lock acquire timeout strategy.

  """
  __slots__ = [
79
    "_attempt",
80
81
    "_random_fn",
    "_start_time",
82
    "_time_fn",
83
    "_running_timeout",
84
85
    ]

86
  _TIMEOUT_PER_ATTEMPT = _CalculateLockAttemptTimeouts()
87

88
  def __init__(self, attempt=0, _time_fn=time.time, _random_fn=random.random):
89
90
    """Initializes this class.

91
92
93
    @type attempt: int
    @param attempt: Current attempt number
    @param _time_fn: Time function for unittests
94
95
96
97
98
    @param _random_fn: Random number generator for unittests

    """
    object.__init__(self)

99
100
    if attempt < 0:
      raise ValueError("Attempt must be zero or positive")
101

102
103
104
105
    self._attempt = attempt
    self._time_fn = _time_fn
    self._random_fn = _random_fn

106
107
108
109
110
111
112
113
    try:
      timeout = self._TIMEOUT_PER_ATTEMPT[attempt]
    except IndexError:
      # No more timeouts, do blocking acquire
      timeout = None

    self._running_timeout = locking.RunningTimeout(timeout, False,
                                                   _time_fn=_time_fn)
114
115

  def NextAttempt(self):
116
    """Returns the strategy for the next attempt.
117
118

    """
119
120
121
    return _LockAttemptTimeoutStrategy(attempt=self._attempt + 1,
                                       _time_fn=self._time_fn,
                                       _random_fn=self._random_fn)
122
123
124
125
126

  def CalcRemainingTimeout(self):
    """Returns the remaining timeout.

    """
127
    timeout = self._running_timeout.Remaining()
128

129
130
131
132
133
134
    if timeout is not None:
      # Add a small variation (-/+ 5%) to timeout. This helps in situations
      # where two or more jobs are fighting for the same lock(s).
      variation_range = timeout * 0.1
      timeout += ((self._random_fn() * variation_range) -
                  (variation_range * 0.5))
135

136
    return timeout
137
138


139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
class OpExecCbBase:
  """Base class for OpCode execution callbacks.

  """
  def NotifyStart(self):
    """Called when we are about to execute the LU.

    This function is called when we're about to start the lu's Exec() method,
    that is, after we have acquired all locks.

    """

  def Feedback(self, *args):
    """Sends feedback from the LU code to the end-user.

    """

156
157
158
159
160
  def ReportLocks(self, msg):
    """Report lock operations.

    """

161

Iustin Pop's avatar
Iustin Pop committed
162
163
164
165
class Processor(object):
  """Object which runs OpCodes"""
  DISPATCH_TABLE = {
    # Cluster
166
    opcodes.OpPostInitCluster: cmdlib.LUPostInitCluster,
Iustin Pop's avatar
Iustin Pop committed
167
168
169
    opcodes.OpDestroyCluster: cmdlib.LUDestroyCluster,
    opcodes.OpQueryClusterInfo: cmdlib.LUQueryClusterInfo,
    opcodes.OpVerifyCluster: cmdlib.LUVerifyCluster,
170
    opcodes.OpQueryConfigValues: cmdlib.LUQueryConfigValues,
171
    opcodes.OpRenameCluster: cmdlib.LURenameCluster,
172
    opcodes.OpVerifyDisks: cmdlib.LUVerifyDisks,
173
    opcodes.OpSetClusterParams: cmdlib.LUSetClusterParams,
174
    opcodes.OpRedistributeConfig: cmdlib.LURedistributeConfig,
175
    opcodes.OpRepairDiskSizes: cmdlib.LURepairDiskSizes,
Iustin Pop's avatar
Iustin Pop committed
176
177
178
    # node lu
    opcodes.OpAddNode: cmdlib.LUAddNode,
    opcodes.OpQueryNodes: cmdlib.LUQueryNodes,
179
    opcodes.OpQueryNodeVolumes: cmdlib.LUQueryNodeVolumes,
180
    opcodes.OpQueryNodeStorage: cmdlib.LUQueryNodeStorage,
181
    opcodes.OpModifyNodeStorage: cmdlib.LUModifyNodeStorage,
182
    opcodes.OpRepairNodeStorage: cmdlib.LURepairNodeStorage,
Iustin Pop's avatar
Iustin Pop committed
183
    opcodes.OpRemoveNode: cmdlib.LURemoveNode,
Iustin Pop's avatar
Iustin Pop committed
184
    opcodes.OpSetNodeParams: cmdlib.LUSetNodeParams,
Iustin Pop's avatar
Iustin Pop committed
185
    opcodes.OpPowercycleNode: cmdlib.LUPowercycleNode,
186
    opcodes.OpEvacuateNode: cmdlib.LUEvacuateNode,
187
    opcodes.OpMigrateNode: cmdlib.LUMigrateNode,
Iustin Pop's avatar
Iustin Pop committed
188
189
    # instance lu
    opcodes.OpCreateInstance: cmdlib.LUCreateInstance,
190
    opcodes.OpReinstallInstance: cmdlib.LUReinstallInstance,
Iustin Pop's avatar
Iustin Pop committed
191
    opcodes.OpRemoveInstance: cmdlib.LURemoveInstance,
192
    opcodes.OpRenameInstance: cmdlib.LURenameInstance,
Iustin Pop's avatar
Iustin Pop committed
193
194
195
    opcodes.OpActivateInstanceDisks: cmdlib.LUActivateInstanceDisks,
    opcodes.OpShutdownInstance: cmdlib.LUShutdownInstance,
    opcodes.OpStartupInstance: cmdlib.LUStartupInstance,
196
    opcodes.OpRebootInstance: cmdlib.LURebootInstance,
Iustin Pop's avatar
Iustin Pop committed
197
198
    opcodes.OpDeactivateInstanceDisks: cmdlib.LUDeactivateInstanceDisks,
    opcodes.OpReplaceDisks: cmdlib.LUReplaceDisks,
Iustin Pop's avatar
Iustin Pop committed
199
    opcodes.OpRecreateInstanceDisks: cmdlib.LURecreateInstanceDisks,
Iustin Pop's avatar
Iustin Pop committed
200
    opcodes.OpFailoverInstance: cmdlib.LUFailoverInstance,
201
    opcodes.OpMigrateInstance: cmdlib.LUMigrateInstance,
202
    opcodes.OpMoveInstance: cmdlib.LUMoveInstance,
Iustin Pop's avatar
Iustin Pop committed
203
204
205
    opcodes.OpConnectConsole: cmdlib.LUConnectConsole,
    opcodes.OpQueryInstances: cmdlib.LUQueryInstances,
    opcodes.OpQueryInstanceData: cmdlib.LUQueryInstanceData,
206
    opcodes.OpSetInstanceParams: cmdlib.LUSetInstanceParams,
Iustin Pop's avatar
Iustin Pop committed
207
    opcodes.OpGrowDisk: cmdlib.LUGrowDisk,
Iustin Pop's avatar
Iustin Pop committed
208
209
210
211
212
    # os lu
    opcodes.OpDiagnoseOS: cmdlib.LUDiagnoseOS,
    # exports lu
    opcodes.OpQueryExports: cmdlib.LUQueryExports,
    opcodes.OpExportInstance: cmdlib.LUExportInstance,
213
    opcodes.OpRemoveExport: cmdlib.LURemoveExport,
214
215
    # tags lu
    opcodes.OpGetTags: cmdlib.LUGetTags,
Iustin Pop's avatar
Iustin Pop committed
216
    opcodes.OpSearchTags: cmdlib.LUSearchTags,
217
218
    opcodes.OpAddTags: cmdlib.LUAddTags,
    opcodes.OpDelTags: cmdlib.LUDelTags,
219
220
    # test lu
    opcodes.OpTestDelay: cmdlib.LUTestDelay,
221
    opcodes.OpTestAllocator: cmdlib.LUTestAllocator,
Iustin Pop's avatar
Iustin Pop committed
222
223
    }

224
  def __init__(self, context, ec_id):
Iustin Pop's avatar
Iustin Pop committed
225
226
    """Constructor for Processor

227
228
229
230
231
    @type context: GanetiContext
    @param context: global Ganeti context
    @type ec_id: string
    @param ec_id: execution context identifier

Iustin Pop's avatar
Iustin Pop committed
232
    """
233
    self.context = context
234
    self._ec_id = ec_id
235
    self._cbs = None
Iustin Pop's avatar
Iustin Pop committed
236
    self.rpc = rpc.RpcRunner(context.cfg)
237
    self.hmclass = HooksMaster
Iustin Pop's avatar
Iustin Pop committed
238

239
  def _ReportLocks(self, level, names, shared, timeout, acquired, result):
240
241
242
243
244
245
246
    """Reports lock operations.

    @type level: int
    @param level: Lock level
    @type names: list or string
    @param names: Lock names
    @type shared: bool
247
248
249
    @param shared: Whether the locks should be acquired in shared mode
    @type timeout: None or float
    @param timeout: Timeout for acquiring the locks
250
    @type acquired: bool
251
252
253
    @param acquired: Whether the locks have already been acquired
    @type result: None or set
    @param result: Result from L{locking.GanetiLockManager.acquire}
254
255
256
257
258
259

    """
    parts = []

    # Build message
    if acquired:
260
261
262
263
      if result is None:
        parts.append("timeout")
      else:
        parts.append("acquired")
264
265
    else:
      parts.append("waiting")
266
267
268
269
      if timeout is None:
        parts.append("blocking")
      else:
        parts.append("timeout=%0.6fs" % timeout)
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291

    parts.append(locking.LEVEL_NAMES[level])

    if names == locking.ALL_SET:
      parts.append("ALL")
    elif isinstance(names, basestring):
      parts.append(names)
    else:
      parts.append(",".join(names))

    if shared:
      parts.append("shared")
    else:
      parts.append("exclusive")

    msg = "/".join(parts)

    logging.debug("LU locks %s", msg)

    if self._cbs:
      self._cbs.ReportLocks(msg)

292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
  def _AcquireLocks(self, level, names, shared, timeout):
    """Acquires locks via the Ganeti lock manager.

    @type level: int
    @param level: Lock level
    @type names: list or string
    @param names: Lock names
    @type shared: bool
    @param shared: Whether the locks should be acquired in shared mode
    @type timeout: None or float
    @param timeout: Timeout for acquiring the locks

    """
    self._ReportLocks(level, names, shared, timeout, False, None)

    acquired = self.context.glm.acquire(level, names, shared=shared,
                                        timeout=timeout)

    self._ReportLocks(level, names, shared, timeout, True, acquired)

    return acquired

314
315
316
317
318
319
  def _ExecLU(self, lu):
    """Logical Unit execution sequence.

    """
    write_count = self.context.cfg.write_count
    lu.CheckPrereq()
320
    hm = HooksMaster(self.rpc.call_hooks_runner, lu)
321
322
    h_results = hm.RunPhase(constants.HOOKS_PHASE_PRE)
    lu.HooksCallBack(constants.HOOKS_PHASE_PRE, h_results,
323
                     self._Feedback, None)
324
325
326
327
328
329
330
331
332

    if getattr(lu.op, "dry_run", False):
      # in this mode, no post-hooks are run, and the config is not
      # written (as it might have been modified by another LU, and we
      # shouldn't do writeout on behalf of other threads
      self.LogInfo("dry-run mode requested, not actually executing"
                   " the operation")
      return lu.dry_run_result

333
    try:
334
      result = lu.Exec(self._Feedback)
335
336
      h_results = hm.RunPhase(constants.HOOKS_PHASE_POST)
      result = lu.HooksCallBack(constants.HOOKS_PHASE_POST, h_results,
337
                                self._Feedback, result)
338
339
340
341
342
343
344
    finally:
      # FIXME: This needs locks if not lu_class.REQ_BGL
      if write_count != self.context.cfg.write_count:
        hm.RunConfigUpdate()

    return result

345
  def _LockAndExecLU(self, lu, level, calc_timeout):
346
347
348
349
350
351
352
    """Execute a Logical Unit, with the needed locks.

    This is a recursive function that starts locking the given level, and
    proceeds up, till there are no more locks to acquire. Then it executes the
    given LU and its opcodes.

    """
353
354
    adding_locks = level in lu.add_locks
    acquiring_locks = level in lu.needed_locks
355
    if level not in locking.LEVELS:
356
357
358
      if self._cbs:
        self._cbs.NotifyStart()

359
      result = self._ExecLU(lu)
360

361
362
363
    elif adding_locks and acquiring_locks:
      # We could both acquire and add locks at the same level, but for now we
      # don't need this, so we'll avoid the complicated code needed.
364
365
366
      raise NotImplementedError("Can't declare locks to acquire when adding"
                                " others")

367
    elif adding_locks or acquiring_locks:
Guido Trotter's avatar
Guido Trotter committed
368
      lu.DeclareLocks(level)
Guido Trotter's avatar
Guido Trotter committed
369
      share = lu.share_locks[level]
370

371
      try:
372
373
374
375
376
377
378
        assert adding_locks ^ acquiring_locks, \
          "Locks must be either added or acquired"

        if acquiring_locks:
          # Acquiring locks
          needed_locks = lu.needed_locks[level]

379
380
          acquired = self._AcquireLocks(level, needed_locks, share,
                                        calc_timeout())
381
382
383
384
385
386
387
388
389
390
391
392
393
394

          if acquired is None:
            raise _LockAcquireTimeout()

        else:
          # Adding locks
          add_locks = lu.add_locks[level]
          lu.remove_locks[level] = add_locks

          try:
            self.context.glm.add(level, add_locks, acquired=1, shared=share)
          except errors.LockError:
            raise errors.OpPrereqError(
              "Couldn't add locks (%s), probably because of a race condition"
395
396
              " with another job, who added them first" % add_locks,
              errors.ECODE_FAULT)
397

398
399
          acquired = add_locks

400
        try:
401
402
          lu.acquired_locks[level] = acquired

403
          result = self._LockAndExecLU(lu, level + 1, calc_timeout)
404
405
406
        finally:
          if level in lu.remove_locks:
            self.context.glm.remove(level, lu.remove_locks[level])
407
      finally:
408
        if self.context.glm.is_owned(level):
409
          self.context.glm.release(level)
410

411
    else:
412
      result = self._LockAndExecLU(lu, level + 1, calc_timeout)
413
414
415

    return result

416
  def ExecOpCode(self, op, cbs):
Iustin Pop's avatar
Iustin Pop committed
417
418
    """Execute an opcode.

Iustin Pop's avatar
Iustin Pop committed
419
420
    @type op: an OpCode instance
    @param op: the opcode to be executed
421
422
    @type cbs: L{OpExecCbBase}
    @param cbs: Runtime callbacks
Iustin Pop's avatar
Iustin Pop committed
423
424
425

    """
    if not isinstance(op, opcodes.OpCode):
426
427
      raise errors.ProgrammerError("Non-opcode instance passed"
                                   " to ExecOpcode")
Iustin Pop's avatar
Iustin Pop committed
428

429
    self._cbs = cbs
430
    try:
431
432
433
434
      lu_class = self.DISPATCH_TABLE.get(op.__class__, None)
      if lu_class is None:
        raise errors.OpCodeUnknown("Unknown opcode")

435
      timeout_strategy = _LockAttemptTimeoutStrategy()
436
437
438

      while True:
        try:
439
440
          acquire_timeout = timeout_strategy.CalcRemainingTimeout()

441
442
443
444
          # Acquire the Big Ganeti Lock exclusively if this LU requires it,
          # and in a shared fashion otherwise (to prevent concurrent run with
          # an exclusive LU.
          if self._AcquireLocks(locking.LEVEL_CLUSTER, locking.BGL,
445
                                not lu_class.REQ_BGL, acquire_timeout) is None:
446
447
448
449
450
451
452
            raise _LockAcquireTimeout()

          try:
            lu = lu_class(self, op, self.context, self.rpc)
            lu.ExpandNames()
            assert lu.needed_locks is not None, "needed_locks not set by LU"

Guido Trotter's avatar
Guido Trotter committed
453
454
455
456
457
458
459
            try:
              return self._LockAndExecLU(lu, locking.LEVEL_INSTANCE,
                                         timeout_strategy.CalcRemainingTimeout)
            finally:
              if self._ec_id:
                self.context.cfg.DropECReservations(self._ec_id)

460
461
462
463
464
465
466
          finally:
            self.context.glm.release(locking.LEVEL_CLUSTER)

        except _LockAcquireTimeout:
          # Timeout while waiting for lock, try again
          pass

467
        timeout_strategy = timeout_strategy.NextAttempt()
468

469
    finally:
470
      self._cbs = None
471

472
473
474
475
476
477
478
  def _Feedback(self, *args):
    """Forward call to feedback callback function.

    """
    if self._cbs:
      self._cbs.Feedback(*args)

479
480
481
482
  def LogStep(self, current, total, message):
    """Log a change in LU execution progress.

    """
483
    logging.debug("Step %d/%d %s", current, total, message)
484
    self._Feedback("STEP %d/%d %s" % (current, total, message))
485

486
  def LogWarning(self, message, *args, **kwargs):
487
488
    """Log a warning to the logs and the user.

489
490
491
492
    The optional keyword argument is 'hint' and can be used to show a
    hint to the user (presumably related to the warning). If the
    message is empty, it will not be printed at all, allowing one to
    show only a hint.
493

494
495
496
497
498
499
500
    """
    assert not kwargs or (len(kwargs) == 1 and "hint" in kwargs), \
           "Invalid keyword arguments for LogWarning (%s)" % str(kwargs)
    if args:
      message = message % tuple(args)
    if message:
      logging.warning(message)
501
      self._Feedback(" - WARNING: %s" % message)
502
    if "hint" in kwargs:
503
      self._Feedback("      Hint: %s" % kwargs["hint"])
504
505

  def LogInfo(self, message, *args):
506
507
508
    """Log an informational message to the logs and the user.

    """
509
510
    if args:
      message = message % tuple(args)
511
    logging.info(message)
512
    self._Feedback(" - INFO: %s" % message)
513

514
515
516
517
518
  def GetECId(self):
    if not self._ec_id:
      errors.ProgrammerError("Tried to use execution context id when not set")
    return self._ec_id

Iustin Pop's avatar
Iustin Pop committed
519
520
521
522
523
524
525
526
527
528
529
530
531

class HooksMaster(object):
  """Hooks master.

  This class distributes the run commands to the nodes based on the
  specific LU class.

  In order to remove the direct dependency on the rpc module, the
  constructor needs a function which actually does the remote
  call. This will usually be rpc.call_hooks_runner, but any function
  which behaves the same works.

  """
532
  def __init__(self, callfn, lu):
Iustin Pop's avatar
Iustin Pop committed
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
    self.callfn = callfn
    self.lu = lu
    self.op = lu.op
    self.env, node_list_pre, node_list_post = self._BuildEnv()
    self.node_list = {constants.HOOKS_PHASE_PRE: node_list_pre,
                      constants.HOOKS_PHASE_POST: node_list_post}

  def _BuildEnv(self):
    """Compute the environment and the target nodes.

    Based on the opcode and the current node list, this builds the
    environment for the hooks and the target node list for the run.

    """
    env = {
      "PATH": "/sbin:/bin:/usr/sbin:/usr/bin",
      "GANETI_HOOKS_VERSION": constants.HOOKS_VERSION,
      "GANETI_OP_CODE": self.op.OP_ID,
      "GANETI_OBJECT_TYPE": self.lu.HTYPE,
552
      "GANETI_DATA_DIR": constants.DATA_DIR,
Iustin Pop's avatar
Iustin Pop committed
553
554
      }

555
556
557
558
559
560
561
    if self.lu.HPATH is not None:
      lu_env, lu_nodes_pre, lu_nodes_post = self.lu.BuildHooksEnv()
      if lu_env:
        for key in lu_env:
          env["GANETI_" + key] = lu_env[key]
    else:
      lu_nodes_pre = lu_nodes_post = []
Iustin Pop's avatar
Iustin Pop committed
562

563
564
565
566
567
568
569
570
571
572
573
    return env, frozenset(lu_nodes_pre), frozenset(lu_nodes_post)

  def _RunWrapper(self, node_list, hpath, phase):
    """Simple wrapper over self.callfn.

    This method fixes the environment before doing the rpc call.

    """
    env = self.env.copy()
    env["GANETI_HOOKS_PHASE"] = phase
    env["GANETI_HOOKS_PATH"] = hpath
Michael Hanselmann's avatar
Michael Hanselmann committed
574
575
576
    if self.lu.cfg is not None:
      env["GANETI_CLUSTER"] = self.lu.cfg.GetClusterName()
      env["GANETI_MASTER"] = self.lu.cfg.GetMasterNode()
Iustin Pop's avatar
Iustin Pop committed
577

578
    env = dict([(str(key), str(val)) for key, val in env.iteritems()])
Iustin Pop's avatar
Iustin Pop committed
579

580
    return self.callfn(node_list, hpath, phase, env)
Iustin Pop's avatar
Iustin Pop committed
581

582
  def RunPhase(self, phase, nodes=None):
Iustin Pop's avatar
Iustin Pop committed
583
584
585
586
    """Run all the scripts for a phase.

    This is the main function of the HookMaster.

Iustin Pop's avatar
Iustin Pop committed
587
588
    @param phase: one of L{constants.HOOKS_PHASE_POST} or
        L{constants.HOOKS_PHASE_PRE}; it denotes the hooks phase
589
    @param nodes: overrides the predefined list of nodes for the given phase
Iustin Pop's avatar
Iustin Pop committed
590
591
    @return: the processed results of the hooks multi-node rpc call
    @raise errors.HooksFailure: on communication failure to the nodes
592
    @raise errors.HooksAbort: on failure of one of the hooks
593

Iustin Pop's avatar
Iustin Pop committed
594
    """
595
    if not self.node_list[phase] and not nodes:
596
597
598
      # empty node list, we should not attempt to run this as either
      # we're in the cluster init phase and the rpc client part can't
      # even attempt to run, or this LU doesn't do hooks at all
Iustin Pop's avatar
Iustin Pop committed
599
      return
600
    hpath = self.lu.HPATH
601
602
603
604
    if nodes is not None:
      results = self._RunWrapper(nodes, hpath, phase)
    else:
      results = self._RunWrapper(self.node_list[phase], hpath, phase)
605
606
607
608
609
610
611
    errs = []
    if not results:
      msg = "Communication Failure"
      if phase == constants.HOOKS_PHASE_PRE:
        raise errors.HooksFailure(msg)
      else:
        self.lu.LogWarning(msg)
612
        return results
613
614
615
616
    for node_name in results:
      res = results[node_name]
      if res.offline:
        continue
617
      msg = res.fail_msg
618
619
620
621
622
623
624
      if msg:
        self.lu.LogWarning("Communication failure to node %s: %s",
                           node_name, msg)
        continue
      for script, hkr, output in res.payload:
        if hkr == constants.HKR_FAIL:
          if phase == constants.HOOKS_PHASE_PRE:
Iustin Pop's avatar
Iustin Pop committed
625
            errs.append((node_name, script, output))
626
627
          else:
            if not output:
628
              output = "(no output)"
629
630
631
632
            self.lu.LogWarning("On %s script %s failed, output: %s" %
                               (node_name, script, output))
    if errs and phase == constants.HOOKS_PHASE_PRE:
      raise errors.HooksAbort(errs)
633
    return results
634
635
636
637
638
639
640
641
642
643

  def RunConfigUpdate(self):
    """Run the special configuration update hook

    This is a special hook that runs only on the master after each
    top-level LI if the configuration has been updated.

    """
    phase = constants.HOOKS_PHASE_POST
    hpath = constants.HOOKS_NAME_CFGUPDATE
Michael Hanselmann's avatar
Michael Hanselmann committed
644
    nodes = [self.lu.cfg.GetMasterNode()]
Iustin Pop's avatar
Iustin Pop committed
645
    self._RunWrapper(nodes, hpath, phase)