bootstrap.py 22.3 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
#
#

# Copyright (C) 2006, 2007, 2008 Google Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
# General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
# 02110-1301, USA.


"""Functions to bootstrap a new cluster.

"""

import os
import os.path
import re
29
import logging
30
import tempfile
31
import time
32 33 34 35 36 37 38

from ganeti import rpc
from ganeti import ssh
from ganeti import utils
from ganeti import errors
from ganeti import config
from ganeti import constants
39
from ganeti import objects
40
from ganeti import ssconf
41
from ganeti import serializer
42
from ganeti import hypervisor
43

44

45
def _InitSSHSetup():
46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65
  """Setup the SSH configuration for the cluster.

  This generates a dsa keypair for root, adds the pub key to the
  permitted hosts and adds the hostkey to its own known hosts.

  """
  priv_key, pub_key, auth_keys = ssh.GetUserFiles(constants.GANETI_RUNAS)

  for name in priv_key, pub_key:
    if os.path.exists(name):
      utils.CreateBackup(name)
    utils.RemoveFile(name)

  result = utils.RunCmd(["ssh-keygen", "-t", "dsa",
                         "-f", priv_key,
                         "-q", "-N", ""])
  if result.failed:
    raise errors.OpExecError("Could not generate ssh keypair, error %s" %
                             result.output)

66
  utils.AddAuthorizedKey(auth_keys, utils.ReadFile(pub_key))
67 68


69
def GenerateSelfSignedSslCert(file_name, validity=(365 * 5)):
70
  """Generates a self-signed SSL certificate.
71

72 73 74 75
  @type file_name: str
  @param file_name: Path to output file
  @type validity: int
  @param validity: Validity for certificate in days
76 77

  """
78 79
  (fd, tmp_file_name) = tempfile.mkstemp(dir=os.path.dirname(file_name))
  try:
80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98
    try:
      # Set permissions before writing key
      os.chmod(tmp_file_name, 0600)

      result = utils.RunCmd(["openssl", "req", "-new", "-newkey", "rsa:1024",
                             "-days", str(validity), "-nodes", "-x509",
                             "-keyout", tmp_file_name, "-out", tmp_file_name,
                             "-batch"])
      if result.failed:
        raise errors.OpExecError("Could not generate SSL certificate, command"
                                 " %s had exitcode %s and error message %s" %
                                 (result.cmd, result.exit_code, result.output))

      # Make read-only
      os.chmod(tmp_file_name, 0400)

      os.rename(tmp_file_name, file_name)
    finally:
      utils.RemoveFile(tmp_file_name)
99
  finally:
100
    os.close(fd)
101 102


103 104 105 106 107 108 109
def GenerateHmacKey(file_name):
  """Writes a new HMAC key.

  @type file_name: str
  @param file_name: Path to output file

  """
110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158
  utils.WriteFile(file_name, data="%s\n" % utils.GenerateSecret(), mode=0400,
                  backup=True)


def GenerateClusterCrypto(new_cluster_cert, new_rapi_cert, new_hmac_key,
                          rapi_cert_pem=None):
  """Updates the cluster certificates, keys and secrets.

  @type new_cluster_cert: bool
  @param new_cluster_cert: Whether to generate a new cluster certificate
  @type new_rapi_cert: bool
  @param new_rapi_cert: Whether to generate a new RAPI certificate
  @type new_hmac_key: bool
  @param new_hmac_key: Whether to generate a new HMAC key
  @type rapi_cert_pem: string
  @param rapi_cert_pem: New RAPI certificate in PEM format

  """
  # SSL certificate
  cluster_cert_exists = os.path.exists(constants.SSL_CERT_FILE)
  if new_cluster_cert or not cluster_cert_exists:
    if cluster_cert_exists:
      utils.CreateBackup(constants.SSL_CERT_FILE)

    logging.debug("Generating new cluster certificate at %s",
                  constants.SSL_CERT_FILE)
    GenerateSelfSignedSslCert(constants.SSL_CERT_FILE)

  # HMAC key
  if new_hmac_key or not os.path.exists(constants.HMAC_CLUSTER_KEY):
    logging.debug("Writing new HMAC key to %s", constants.HMAC_CLUSTER_KEY)
    GenerateHmacKey(constants.HMAC_CLUSTER_KEY)

  # RAPI
  rapi_cert_exists = os.path.exists(constants.RAPI_CERT_FILE)

  if rapi_cert_pem:
    # Assume rapi_pem contains a valid PEM-formatted certificate and key
    logging.debug("Writing RAPI certificate at %s",
                  constants.RAPI_CERT_FILE)
    utils.WriteFile(constants.RAPI_CERT_FILE, data=rapi_cert_pem, backup=True)

  elif new_rapi_cert or not rapi_cert_exists:
    if rapi_cert_exists:
      utils.CreateBackup(constants.RAPI_CERT_FILE)

    logging.debug("Generating new RAPI certificate at %s",
                  constants.RAPI_CERT_FILE)
    GenerateSelfSignedSslCert(constants.RAPI_CERT_FILE)
159 160


161
def _InitGanetiServerSetup(master_name):
162 163 164 165 166 167
  """Setup the necessary configuration for the initial node daemon.

  This creates the nodepass file containing the shared password for
  the cluster and also generates the SSL certificate.

  """
168 169
  # Generate cluster secrets
  GenerateClusterCrypto(True, False, False)
170

171
  result = utils.RunCmd([constants.DAEMON_UTIL, "start", constants.NODED])
172 173 174 175 176
  if result.failed:
    raise errors.OpExecError("Could not start the node daemon, command %s"
                             " had exitcode %s and error %s" %
                             (result.cmd, result.exit_code, result.output))

177 178 179 180 181 182 183
  _WaitForNodeDaemon(master_name)


def _WaitForNodeDaemon(node_name):
  """Wait for node daemon to become responsive.

  """
184
  def _CheckNodeDaemon():
185
    result = rpc.RpcRunner.call_version([node_name])[node_name]
186 187
    if result.fail_msg:
      raise utils.RetryAgain()
188

189 190 191
  try:
    utils.Retry(_CheckNodeDaemon, 1.0, 10.0)
  except utils.RetryTimeout:
192 193 194
    raise errors.OpExecError("Node daemon on %s didn't answer queries within"
                             " 10 seconds" % node_name)

195

196
def InitCluster(cluster_name, mac_prefix,
197
                master_netdev, file_storage_dir, candidate_pool_size,
198 199
                secondary_ip=None, vg_name=None, beparams=None,
                nicparams=None, hvparams=None, enabled_hypervisors=None,
200
                modify_etc_hosts=True, modify_ssh_setup=True):
201 202
  """Initialise the cluster.

203 204 205
  @type candidate_pool_size: int
  @param candidate_pool_size: master candidate pool size

206
  """
207
  # TODO: complete the docstring
208
  if config.ConfigWriter.IsCluster():
209 210
    raise errors.OpPrereqError("Cluster is already initialised",
                               errors.ECODE_STATE)
211

212 213
  if not enabled_hypervisors:
    raise errors.OpPrereqError("Enabled hypervisors list must contain at"
214
                               " least one member", errors.ECODE_INVAL)
215 216 217
  invalid_hvs = set(enabled_hypervisors) - constants.HYPER_TYPES
  if invalid_hvs:
    raise errors.OpPrereqError("Enabled hypervisors contains invalid"
218 219
                               " entries: %s" % invalid_hvs,
                               errors.ECODE_INVAL)
220

221
  hostname = utils.GetHostInfo()
222 223 224 225

  if hostname.ip.startswith("127."):
    raise errors.OpPrereqError("This host's IP resolves to the private"
                               " range (%s). Please fix DNS or %s." %
226 227
                               (hostname.ip, constants.ETC_HOSTS),
                               errors.ECODE_ENVIRON)
228

229
  if not utils.OwnIpAddress(hostname.ip):
230 231
    raise errors.OpPrereqError("Inconsistency: this host's name resolves"
                               " to %s,\nbut this ip address does not"
232 233
                               " belong to this host. Aborting." %
                               hostname.ip, errors.ECODE_ENVIRON)
234

235
  clustername = utils.GetHostInfo(utils.HostInfo.NormalizeName(cluster_name))
236 237 238

  if utils.TcpPing(clustername.ip, constants.DEFAULT_NODED_PORT,
                   timeout=5):
239 240
    raise errors.OpPrereqError("Cluster IP already active. Aborting.",
                               errors.ECODE_NOTUNIQUE)
241 242 243

  if secondary_ip:
    if not utils.IsValidIP(secondary_ip):
244 245
      raise errors.OpPrereqError("Invalid secondary ip given",
                                 errors.ECODE_INVAL)
246
    if (secondary_ip != hostname.ip and
247
        not utils.OwnIpAddress(secondary_ip)):
248 249
      raise errors.OpPrereqError("You gave %s as secondary IP,"
                                 " but it does not belong to this host." %
250
                                 secondary_ip, errors.ECODE_ENVIRON)
251 252
  else:
    secondary_ip = hostname.ip
253 254 255 256 257 258 259

  if vg_name is not None:
    # Check if volume group is valid
    vgstatus = utils.CheckVolumeGroupSize(utils.ListVolumeGroups(), vg_name,
                                          constants.MIN_VG_SIZE)
    if vgstatus:
      raise errors.OpPrereqError("Error: %s\nspecify --no-lvm-storage if"
260 261
                                 " you are not using lvm" % vgstatus,
                                 errors.ECODE_INVAL)
262 263 264 265 266

  file_storage_dir = os.path.normpath(file_storage_dir)

  if not os.path.isabs(file_storage_dir):
    raise errors.OpPrereqError("The file storage directory you passed is"
267
                               " not an absolute path.", errors.ECODE_INVAL)
268 269 270 271 272 273

  if not os.path.exists(file_storage_dir):
    try:
      os.makedirs(file_storage_dir, 0750)
    except OSError, err:
      raise errors.OpPrereqError("Cannot create file storage directory"
274 275
                                 " '%s': %s" % (file_storage_dir, err),
                                 errors.ECODE_ENVIRON)
276 277 278

  if not os.path.isdir(file_storage_dir):
    raise errors.OpPrereqError("The file storage directory '%s' is not"
279 280
                               " a directory." % file_storage_dir,
                               errors.ECODE_ENVIRON)
281 282

  if not re.match("^[0-9a-z]{2}:[0-9a-z]{2}:[0-9a-z]{2}$", mac_prefix):
283 284
    raise errors.OpPrereqError("Invalid mac prefix given '%s'" % mac_prefix,
                               errors.ECODE_INVAL)
285 286 287 288 289

  result = utils.RunCmd(["ip", "link", "show", "dev", master_netdev])
  if result.failed:
    raise errors.OpPrereqError("Invalid master netdev given (%s): '%s'" %
                               (master_netdev,
290
                                result.output.strip()), errors.ECODE_INVAL)
291

292 293 294
  dirs = [(constants.RUN_GANETI_DIR, constants.RUN_DIRS_MODE)]
  utils.EnsureDirs(dirs)

295
  utils.ForceDictType(beparams, constants.BES_PARAMETER_TYPES)
296 297 298
  utils.ForceDictType(nicparams, constants.NICS_PARAMETER_TYPES)
  objects.NIC.CheckParameterSyntax(nicparams)

299 300 301 302 303
  # hvparams is a mapping of hypervisor->hvparams dict
  for hv_name, hv_params in hvparams.iteritems():
    utils.ForceDictType(hv_params, constants.HVS_PARAMETER_TYPES)
    hv_class = hypervisor.GetHypervisor(hv_name)
    hv_class.CheckParameterSyntax(hv_params)
304

305
  # set up the inter-node password and certificate
306
  _InitGanetiServerSetup(hostname.name)
307 308

  # set up ssh config and /etc/hosts
309
  sshline = utils.ReadFile(constants.SSH_HOST_RSA_PUB)
310 311
  sshkey = sshline.split(" ")[1]

312 313 314
  if modify_etc_hosts:
    utils.AddHostToEtcHosts(hostname.name)

315 316
  if modify_ssh_setup:
    _InitSSHSetup()
317

318 319
  now = time.time()

320
  # init of cluster config file
321 322 323 324 325 326 327
  cluster_config = objects.Cluster(
    serial_no=1,
    rsahostkeypub=sshkey,
    highest_used_port=(constants.FIRST_DRBD_PORT - 1),
    mac_prefix=mac_prefix,
    volume_group_name=vg_name,
    tcpudp_port_pool=set(),
328 329 330 331 332
    master_node=hostname.name,
    master_ip=clustername.ip,
    master_netdev=master_netdev,
    cluster_name=clustername.name,
    file_storage_dir=file_storage_dir,
333
    enabled_hypervisors=enabled_hypervisors,
334
    beparams={constants.PP_DEFAULT: beparams},
335
    nicparams={constants.PP_DEFAULT: nicparams},
336
    hvparams=hvparams,
337
    candidate_pool_size=candidate_pool_size,
Guido Trotter's avatar
Guido Trotter committed
338
    modify_etc_hosts=modify_etc_hosts,
339
    modify_ssh_setup=modify_ssh_setup,
340 341 342
    ctime=now,
    mtime=now,
    uuid=utils.NewUUID(),
343 344 345
    )
  master_node_config = objects.Node(name=hostname.name,
                                    primary_ip=hostname.ip,
346
                                    secondary_ip=secondary_ip,
347 348
                                    serial_no=1,
                                    master_candidate=True,
349
                                    offline=False, drained=False,
350
                                    )
351
  InitConfig(constants.CONFIG_VERSION, cluster_config, master_node_config)
352
  cfg = config.ConfigWriter()
353
  ssh.WriteKnownHostsFile(cfg, constants.SSH_KNOWN_HOSTS_FILE)
354
  cfg.Update(cfg.GetClusterInfo(), logging.error)
355

Iustin Pop's avatar
Iustin Pop committed
356 357
  # start the master ip
  # TODO: Review rpc call from bootstrap
358
  # TODO: Warn on failed start master
359
  rpc.RpcRunner.call_node_start_master(hostname.name, True, False)
Iustin Pop's avatar
Iustin Pop committed
360

361

Oleksiy Mishchenko's avatar
Oleksiy Mishchenko committed
362 363
def InitConfig(version, cluster_config, master_node_config,
               cfg_file=constants.CLUSTER_CONF_FILE):
Iustin Pop's avatar
Iustin Pop committed
364 365 366 367 368 369
  """Create the initial cluster configuration.

  It will contain the current node, which will also be the master
  node, and no instances.

  @type version: int
Iustin Pop's avatar
Iustin Pop committed
370 371 372 373 374 375 376 377
  @param version: configuration version
  @type cluster_config: L{objects.Cluster}
  @param cluster_config: cluster configuration
  @type master_node_config: L{objects.Node}
  @param master_node_config: master node configuration
  @type cfg_file: string
  @param cfg_file: configuration file path

Iustin Pop's avatar
Iustin Pop committed
378 379 380 381 382
  """
  nodes = {
    master_node_config.name: master_node_config,
    }

383
  now = time.time()
Iustin Pop's avatar
Iustin Pop committed
384 385 386 387
  config_data = objects.ConfigData(version=version,
                                   cluster=cluster_config,
                                   nodes=nodes,
                                   instances={},
388 389
                                   serial_no=1,
                                   ctime=now, mtime=now)
390 391 392
  utils.WriteFile(cfg_file,
                  data=serializer.Dump(config_data.ToDict()),
                  mode=0600)
Oleksiy Mishchenko's avatar
Oleksiy Mishchenko committed
393 394


Iustin Pop's avatar
Iustin Pop committed
395 396 397 398 399 400 401
def FinalizeClusterDestroy(master):
  """Execute the last steps of cluster destroy

  This function shuts down all the daemons, completing the destroy
  begun in cmdlib.LUDestroyOpcode.

  """
402 403
  cfg = config.ConfigWriter()
  modify_ssh_setup = cfg.GetClusterInfo().modify_ssh_setup
404
  result = rpc.RpcRunner.call_node_stop_master(master, True)
405
  msg = result.fail_msg
406
  if msg:
407
    logging.warning("Could not disable the master role: %s", msg)
408
  result = rpc.RpcRunner.call_node_leave_cluster(master, modify_ssh_setup)
409
  msg = result.fail_msg
410 411 412
  if msg:
    logging.warning("Could not shutdown the node daemon and cleanup"
                    " the node: %s", msg)
Iustin Pop's avatar
Iustin Pop committed
413 414


Iustin Pop's avatar
Iustin Pop committed
415
def SetupNodeDaemon(cluster_name, node, ssh_key_check):
416 417
  """Add a node to the cluster.

418 419 420
  This function must be called before the actual opcode, and will ssh
  to the remote node, copy the needed files, and start ganeti-noded,
  allowing the master to do the rest via normal rpc calls.
421

Iustin Pop's avatar
Iustin Pop committed
422 423 424
  @param cluster_name: the cluster name
  @param node: the name of the new node
  @param ssh_key_check: whether to do a strict key check
425 426

  """
Iustin Pop's avatar
Iustin Pop committed
427
  sshrunner = ssh.SshRunner(cluster_name)
428 429

  noded_cert = utils.ReadFile(constants.SSL_CERT_FILE)
430
  rapi_cert = utils.ReadFile(constants.RAPI_CERT_FILE)
431
  hmac_key = utils.ReadFile(constants.HMAC_CLUSTER_KEY)
432

433 434 435
  # in the base64 pem encoding, neither '!' nor '.' are valid chars,
  # so we use this to detect an invalid certificate; as long as the
  # cert doesn't contain this, the here-document will be correctly
436 437 438 439 440
  # parsed by the shell sequence below. HMAC keys are hexadecimal strings,
  # so the same restrictions apply.
  for content in (noded_cert, rapi_cert, hmac_key):
    if re.search('^!EOF\.', content, re.MULTILINE):
      raise errors.OpExecError("invalid SSL certificate or HMAC key")
441 442 443

  if not noded_cert.endswith("\n"):
    noded_cert += "\n"
444 445
  if not rapi_cert.endswith("\n"):
    rapi_cert += "\n"
446 447
  if not hmac_key.endswith("\n"):
    hmac_key += "\n"
448 449 450 451 452 453 454

  # set up inter-node password and certificate and restarts the node daemon
  # and then connect with ssh to set password and start ganeti-noded
  # note that all the below variables are sanitized at this point,
  # either by being constants or by the checks above
  mycommand = ("umask 077 && "
               "cat > '%s' << '!EOF.' && \n"
455 456 457
               "%s!EOF.\n"
               "cat > '%s' << '!EOF.' && \n"
               "%s!EOF.\n"
458 459 460
               "cat > '%s' << '!EOF.' && \n"
               "%s!EOF.\n"
               "chmod 0400 %s %s %s && "
461
               "%s start %s" %
462
               (constants.SSL_CERT_FILE, noded_cert,
463
                constants.RAPI_CERT_FILE, rapi_cert,
464
                constants.HMAC_CLUSTER_KEY, hmac_key,
465
                constants.SSL_CERT_FILE, constants.RAPI_CERT_FILE,
466
                constants.HMAC_CLUSTER_KEY,
467
                constants.DAEMON_UTIL, constants.NODED))
468

469 470 471 472
  result = sshrunner.Run(node, 'root', mycommand, batch=False,
                         ask_key=ssh_key_check,
                         use_cluster_key=False,
                         strict_host_check=ssh_key_check)
473 474 475 476 477
  if result.failed:
    raise errors.OpExecError("Remote command on node %s, error: %s,"
                             " output: %s" %
                             (node, result.fail_reason, result.output))

478 479
  _WaitForNodeDaemon(node)

480

481
def MasterFailover(no_voting=False):
482 483 484 485 486 487
  """Failover the master node.

  This checks that we are not already the master, and will cause the
  current master to cease being master, and the non-master to become
  new master.

488 489 490 491
  @type no_voting: boolean
  @param no_voting: force the operation without remote nodes agreement
                      (dangerous)

492
  """
493
  sstore = ssconf.SimpleStore()
494

495 496 497
  old_master, new_master = ssconf.GetMasterAndMyself(sstore)
  node_list = sstore.GetNodeList()
  mc_list = sstore.GetMasterCandidates()
498 499 500 501 502

  if old_master == new_master:
    raise errors.OpPrereqError("This commands must be run on the node"
                               " where you want the new master to be."
                               " %s is already the master" %
503
                               old_master, errors.ECODE_INVAL)
504

505 506 507 508 509 510
  if new_master not in mc_list:
    mc_no_master = [name for name in mc_list if name != old_master]
    raise errors.OpPrereqError("This node is not among the nodes marked"
                               " as master candidates. Only these nodes"
                               " can become masters. Current list of"
                               " master candidates is:\n"
511 512
                               "%s" % ('\n'.join(mc_no_master)),
                               errors.ECODE_STATE)
513

514 515 516 517 518 519 520
  if not no_voting:
    vote_list = GatherMasterVotes(node_list)

    if vote_list:
      voted_master = vote_list[0][0]
      if voted_master is None:
        raise errors.OpPrereqError("Cluster is inconsistent, most nodes did"
521
                                   " not respond.", errors.ECODE_ENVIRON)
522 523 524 525 526
      elif voted_master != old_master:
        raise errors.OpPrereqError("I have a wrong configuration, I believe"
                                   " the master is %s but the other nodes"
                                   " voted %s. Please resync the configuration"
                                   " of this node." %
527 528
                                   (old_master, voted_master),
                                   errors.ECODE_STATE)
529 530 531 532
  # end checks

  rcode = 0

533
  logging.info("Setting master to %s, old master: %s", new_master, old_master)
534

535
  result = rpc.RpcRunner.call_node_stop_master(old_master, True)
536
  msg = result.fail_msg
537
  if msg:
538
    logging.error("Could not disable the master role on the old master"
539
                 " %s, please disable manually: %s", old_master, msg)
540

Michael Hanselmann's avatar
Michael Hanselmann committed
541
  # Here we have a phase where no master should be running
542

Iustin Pop's avatar
Iustin Pop committed
543 544 545
  # instantiate a real config writer, as we now know we have the
  # configuration data
  cfg = config.ConfigWriter()
546

Iustin Pop's avatar
Iustin Pop committed
547 548 549 550
  cluster_info = cfg.GetClusterInfo()
  cluster_info.master_node = new_master
  # this will also regenerate the ssconf files, since we updated the
  # cluster info
551
  cfg.Update(cluster_info, logging.error)
552

553
  result = rpc.RpcRunner.call_node_start_master(new_master, True, no_voting)
554
  msg = result.fail_msg
555
  if msg:
556
    logging.error("Could not start the master role on the new master"
557
                  " %s, please check: %s", new_master, msg)
558 559 560
    rcode = 1

  return rcode
561 562


563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578
def GetMaster():
  """Returns the current master node.

  This is a separate function in bootstrap since it's needed by
  gnt-cluster, and instead of importing directly ssconf, it's better
  to abstract it in bootstrap, where we do use ssconf in other
  functions too.

  """
  sstore = ssconf.SimpleStore()

  old_master, _ = ssconf.GetMasterAndMyself(sstore)

  return old_master


579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594
def GatherMasterVotes(node_list):
  """Check the agreement on who is the master.

  This function will return a list of (node, number of votes), ordered
  by the number of votes. Errors will be denoted by the key 'None'.

  Note that the sum of votes is the number of nodes this machine
  knows, whereas the number of entries in the list could be different
  (if some nodes vote for another master).

  We remove ourselves from the list since we know that (bugs aside)
  since we use the same source for configuration information for both
  backend and boostrap, we'll always vote for ourselves.

  @type node_list: list
  @param node_list: the list of nodes to query for master info; the current
Michael Hanselmann's avatar
Michael Hanselmann committed
595
      node will be removed if it is in the list
596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614
  @rtype: list
  @return: list of (node, votes)

  """
  myself = utils.HostInfo().name
  try:
    node_list.remove(myself)
  except ValueError:
    pass
  if not node_list:
    # no nodes left (eventually after removing myself)
    return []
  results = rpc.RpcRunner.call_master_info(node_list)
  if not isinstance(results, dict):
    # this should not happen (unless internal error in rpc)
    logging.critical("Can't complete rpc call, aborting master startup")
    return [(None, len(node_list))]
  votes = {}
  for node in results:
615
    nres = results[node]
616
    data = nres.payload
617
    msg = nres.fail_msg
618 619 620 621 622 623 624 625
    fail = False
    if msg:
      logging.warning("Error contacting node %s: %s", node, msg)
      fail = True
    elif not isinstance(data, (tuple, list)) or len(data) < 3:
      logging.warning("Invalid data received from node %s: %s", node, data)
      fail = True
    if fail:
626 627 628 629
      if None not in votes:
        votes[None] = 0
      votes[None] += 1
      continue
630
    master_node = data[2]
631 632 633 634 635 636 637 638 639 640 641
    if master_node not in votes:
      votes[master_node] = 0
    votes[master_node] += 1

  vote_list = [v for v in votes.items()]
  # sort first on number of votes then on name, since we want None
  # sorted later if we have the half of the nodes not responding, and
  # half voting all for the same master
  vote_list.sort(key=lambda x: (x[1], x[0]), reverse=True)

  return vote_list